[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:39 + +static constexpr StringLiteral AllStdExts = "mafdqlcbjtpvn"; + craig.topper wrote: > 'b' shouldn't be in this list anymore? I would prefer to keep that for sync with ISA manual,

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff13189c5d0d: [RISCV] Unify the arch string parsing logic to to RISCVISAInfo. (authored by Kito Cheng ). Changed prior to com

[clang] ff13189 - [RISCV] Unify the arch string parsing logic to to RISCVISAInfo.

Author: Kito Cheng Date: 2021-10-17T16:25:23+08:00 New Revision: ff13189c5d0d96d0f955e9b1e951cf0ddc9e1d92 URL: https://github.com/llvm/llvm-project/commit/ff13189c5d0d96d0f955e9b1e951cf0ddc9e1d92 DIFF: https://github.com/llvm/llvm-project/commit/ff13189c5d0d96d0f955e9b1e951cf0ddc9e1d92.diff LO

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added a comment. Committed with one minor update for version of zba/zbb/zbc/zbs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 ___ cfe-commits mail

[clang] 8efa651 - [RISCV][NFC] Fix build error

Author: Kito Cheng Date: 2021-10-17T16:38:53+08:00 New Revision: 8efa6512e0662b813ab783ed937768cef28e5a8b URL: https://github.com/llvm/llvm-project/commit/8efa6512e0662b813ab783ed937768cef28e5a8b DIFF: https://github.com/llvm/llvm-project/commit/8efa6512e0662b813ab783ed937768cef28e5a8b.diff LO

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Now that we have the tests on the D111551 side, I think this patch LGTM. Do you think it's worth adding something to the release notes? "-mtune now actually works for AArch64". But, umm, perhaps better written than that. CHANGES SINC

[clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

Author: Aaron Ballman Date: 2021-10-17T07:54:48-04:00 New Revision: 2edb89c746848c52964537268bf03e7906bf2542 URL: https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03e7906bf2542 DIFF: https://github.com/llvm/llvm-project/commit/2edb89c746848c52964537268bf03e7906bf2542.diff

[clang] c8be774 - Bump the value of __STDC_VERSION__ in -std=c2x mode

Author: Aaron Ballman Date: 2021-10-17T09:23:43-04:00 New Revision: c8be7743acc7e8ea32ba9985c1d57c38f0eab010 URL: https://github.com/llvm/llvm-project/commit/c8be7743acc7e8ea32ba9985c1d57c38f0eab010 DIFF: https://github.com/llvm/llvm-project/commit/c8be7743acc7e8ea32ba9985c1d57c38f0eab010.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:39 + +static constexpr StringLiteral AllStdExts = "mafdqlcbjtpvn"; + kito-cheng wrote: > craig.topper wrote: > > 'b' shouldn't be in this list anymore? > I would prefer to keep that f

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 380110. gandhi21299 added a comment. added -target option in the test amdgpu-alias-undef-symbols.cu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 Files: clang

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. @thakis can you please check if this solution is sufficient? Thanks for bringing it up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

MaskRay added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-alias-undef-symbols.cu:3 + +// RUN: %clang -target x86_64-unknown-linux-gnu --offload-arch=gfx906 --cuda-device-only -nogpulib -nogpuinc -x hip -emit-llvm -S -o - %s \ +// RUN: -fgpu-rdc -O3 -mllvm -amdgp

[PATCH] D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ca4b3ef19fe: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune, committed by hyeongyukim). Reposito

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-alias-undef-symbols.cu:3 + +// RUN: %clang -target x86_64-unknown-linux-gnu --offload-arch=gfx906 --cuda-device-only -nogpulib -nogpuinc -x hip -emit-llvm -S -o - %s \ +// RUN: -fgpu-rdc -O3 -mllvm -a

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

fcambus added a comment. Any update on this? For info, we started shipping libraries in the OpenBSD base system using this naming scheme for architectures on which we build Clang. CHANGES SINCE LAST ACTION htt

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. LG. Could be changed to the assert in the future…. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/ https://reviews.llvm.org/D10734

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

brad added a comment. I'm not a Perl guy but I'm wondering about simplifying what it is doing there to just `uname -s` eq 'OpenBSD'? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 __

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus updated this revision to Diff 380263. fcambus added a comment. Avoid using regexps and use the 'eq' operator for doing string comparison. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111797/new/ https://reviews.llvm.org/D111797 Files: clang/tools/scan-build/libexec/ccc-analy

[PATCH] D111797: [clang][scan-build] Use uname -s to detect the operating system.

fcambus added a comment. In D111797#3069103 , @brad wrote: > I'm not a Perl guy but I'm wondering about simplifying what it is doing there > to just `uname -s` eq 'OpenBSD'? Yes, I think it makes sense. Just sent an updated revision. CHANGES SINCE LAS

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. I've bisected a crash in generated code down to this commit. The code that crashes is clean when run in ubsan. The misbehaviour happens across 4 tested architectures (i686, x86_64, armv7, aarch64). The misbehaviour occurs in this preprocessed source, https://martin.st

[clang] d245f2e - [clang] Use llvm::erase_if (NFC)

Author: Kazu Hirata Date: 2021-10-17T13:50:29-07:00 New Revision: d245f2e8597bfb52c34810a328d42b990e4af1a4 URL: https://github.com/llvm/llvm-project/commit/d245f2e8597bfb52c34810a328d42b990e4af1a4 DIFF: https://github.com/llvm/llvm-project/commit/d245f2e8597bfb52c34810a328d42b990e4af1a4.diff L

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. I can see that `@ff_seek_frame_binary` is the only affected function. It introduces `llvm.assume` as well as `!nonnull` at a few places and folds null pointer checks. Still investigating.. F19677416: before.ll F19677415: after.ll

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. It seems the original code has a use of an uninitialized variable. Line 4420 at seek-preproc.c (function `ff_seek_frame_binary`): int64_t pos_min=pos_min, pos_max=pos_max, pos, pos_limit; // pos_min and pos_max are self-assigned. ... if (sti->index_entries) {

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Now that consteval and constinit are possible values, 1 bit is no longer enough.

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

nridge added a comment. Not sure if clangd is the best place to test this. I'm open to other suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971 ___ c

[PATCH] D110127: [Clang] Support typedef with btf_decl_tag attributes

yonghong-song updated this revision to Diff 380275. yonghong-song retitled this revision from "[Clang] Support typedef with btf_tag attributes" to "[Clang] Support typedef with btf_decl_tag attributes". yonghong-song edited the summary of this revision. yonghong-song added a comment. - rebase bas

[PATCH] D110129: [DebugInfo] Support typedef with btf_decl_tag attributes

yonghong-song updated this revision to Diff 380276. yonghong-song retitled this revision from "[DebugInfo] Support typedef with btf_tag attributes" to "[DebugInfo] Support typedef with btf_decl_tag attributes". yonghong-song edited the summary of this revision. yonghong-song added a comment. - u

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames accepted this revision. lhames added a comment. This looks good to me, but we should get a libunwind contributor to weigh in too. I've been trying to think of a good way to test this, but it's awkward. The best strategy that I've come up with, at least for testing within libunwind itsel

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

tlively added a comment. This is looking good! I'll take a more thorough pass through tomorrow so we can get this landed. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1455 + const SDValue &Base, +

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We still need access to various things in the ASTContext when printing stats. Repository: rG LLVM Github Monor

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Could you check some of the stats output is valid/expected, not just corrupt/garbage? "just doesn't crash" isn't a great criteria for a test. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380282. kateinoigakukun retitled this revision from " [WebAssembly] Emit PCH __clang_ast in custom section" to "[WebAssembly] Emit clangast in custom section aligned by 4 bytes". kateinoigakukun edited the summary of this revision. kateinoigakukun add

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380283. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74531/new/ https://reviews.llvm.org/D74531 Files: clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp clang/test/PCH/pch-wasm.c llvm/lib/MC/