[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Meinersbur updated this revision to Diff 377099. Meinersbur added a comment. Re-sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Bas

[PATCH] D110614: [clang-tidy] Fix false positives in cppcoreguidelines-virtual-class-destructor

carlosgalvezp updated this revision to Diff 377100. carlosgalvezp added a comment. Added test where an alias to the class template is created. @whisperity let me know if that's what you meant! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110614/new/ https://reviews.llvm.org/D110614 F

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. This will fail in the presence of macro line concatination if (x) return true; else return false; #define RETURN(x) \ if (x) \ return true;\ else \ return false; it will remove the trailing \ if (x) { return tru

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: zzheng, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clang

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall added inline comments. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 +#include "llvm/ADT/DenseMap.h" #include kbobyrev wrote: > sammccall wrote: > > you only need DenseMapInfo here > I think I do need utility because I'm using `std:

Re: [PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

Ahh, sorry, I thought you meant the other one :( Apologies for confusion On Tue, Oct 5, 2021 at 9:58 AM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added inline comments. > > > > Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:17 > > +#in

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

sammccall added a comment. In D110925#3041807 , @kbobyrev wrote: > Ahh, sorry, I thought you meant the other one :( Apologies for confusion All good. Instead of relying on us to spot this stuff, we should probably build some tooling to tell us which inc

[PATCH] D106044: [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.

frasercrmck accepted this revision. frasercrmck added a comment. LGTM in principle but `aliases.s` is apparently failing with something that looks relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106044/new/ https://reviews.llvm.org/D106044

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 updated this revision to Diff 377111. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/new/ https://reviews.llvm.org/D111039 Files: clang-to

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377112. kbobyrev added a comment. Rebase on top of landed patches. Ping, @sammccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-tools-extra/clang

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:1397 + OverriddenBy.Subjects.insert(ID); getOverriddenMethods(CMD, OverriddenMeth

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added a comment. Sorry, I thought i'd sent these comments... Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:158 + +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, Why are we passing around Inclusions by value?

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 updated this revision to Diff 377114. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/new/ https://reviews.llvm.org/D111039 Files: clang-to

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1397 + OverriddenBy.Subjects.insert(ID); getOverriddenMethods(CMD, OverriddenMethods); } kadircet

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added a comment. In D108482#3041127 , @ricejasonf wrote: > I rebased onto `main` and made one small style fix. I don't think the rebase > changes anything. > > I do not understand why random things are failing in the CI. Even on my own > build m

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

tambre added inline comments. Comment at: clang/test/CodeGenCXX/pr45964-decomp-transform.cpp:1 +// RUN: %clang_cc1 -std=c++1z -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s + I'd prefer `-std=c++17` since the standard and flag have been finalized.

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1148 + std::set ParamNamesSeen; +}; // SignatureHelpCollector + change the ending comment (well, I'd actually drop it completely) Comment at: clang-tools-ext

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377125. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang-

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

bader added a comment. In D109144#3032865 , @Anastasia wrote: > It would be good to get closure on this asap. > > @bader We had related discussions on the other reviews about the approach in > this patch. If you have any concerns/suggestions can you plea

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos added a comment. To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano The cryptographic extensions will **//NOT//** be enabled by default on Armv9-A and on Armv9-A ARM CPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] e463b69 - [Support] Change fatal_error_handler_t to take a const char* instead of std::string

Author: Simon Pilgrim Date: 2021-10-05T10:55:40+01:00 New Revision: e463b69736da8b0a950ecd937cf990401bdfcdeb URL: https://github.com/llvm/llvm-project/commit/e463b69736da8b0a950ecd937cf990401bdfcdeb DIFF: https://github.com/llvm/llvm-project/commit/e463b69736da8b0a950ecd937cf990401bdfcdeb.diff

[PATCH] D111049: [Support] Change fatal_error_handler_t to take a const char* instead of std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rGe463b69736da: [Support] Change fatal_error_handler_t to take a const char* instead of std… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D111049?vs=376870&id=377135#toc Repos

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

balazske updated this revision to Diff 377143. balazske added a comment. Adding `&&` and new asserts to use `AttrImporter` only once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110810/new/ https://reviews.llvm.org/D110810 Files: clang/lib/AST

[PATCH] D110810: [clang][ASTImporter] Simplify code of attribute import [NFC].

steakhal accepted this revision. steakhal added a comment. I think it looks great. Thank you for addressing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110810/new/ https://reviews.llvm.org/D110810 __

[clang] bcefea8 - [clang][ASTImporter] Add import of thread safety attributes.

Author: Balázs Kéri Date: 2021-10-05T13:08:31+02:00 New Revision: bcefea80a40ead1e1fbec2e6fa001dd4816ca5c2 URL: https://github.com/llvm/llvm-project/commit/bcefea80a40ead1e1fbec2e6fa001dd4816ca5c2 DIFF: https://github.com/llvm/llvm-project/commit/bcefea80a40ead1e1fbec2e6fa001dd4816ca5c2.diff L

[PATCH] D110528: [clang][ASTImporter] Add import of thread safety attributes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcefea80a40e: [clang][ASTImporter] Add import of thread safety attributes. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in bader

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

Anastasia added a comment. In D109144#3042014 , @bader wrote: > In D109144#3032865 , @Anastasia > wrote: > >> It would be good to get closure on this asap. >> >> @bader We had related discussions on the other rev

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

bader added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:59 +// translation). This mapping is enabled when the language mode is HIP. +1, // cuda_device +// cuda_constant pointer can be casted to default/"flat" pointer, but in Anastasia

[clang] 424733c - Implement if consteval (P1938)

Author: Corentin Jabot Date: 2021-10-05T08:04:14-04:00 New Revision: 424733c12aacc227a28114deba72061153f8dff2 URL: https://github.com/llvm/llvm-project/commit/424733c12aacc227a28114deba72061153f8dff2 DIFF: https://github.com/llvm/llvm-project/commit/424733c12aacc227a28114deba72061153f8dff2.diff

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

kristof.beyls created this revision. kristof.beyls added reviewers: psmith, miyuki, srhines. Herald added subscribers: s.egerton, simoncook. kristof.beyls requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D110482: [clang] Implement if consteval (P1938)

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 424733c12aacc227a28114deba72061153f8dff2 , thank you for the new functionality! Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377158. kbobyrev added a comment. Refactor FileID -> IncludeStructure::HeaderID into a separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: cl

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110670/new/ https://reviews.llvm.org/D110670 _

[clang] aa4f4d1 - consteval if is now fully supported

Author: Aaron Ballman Date: 2021-10-05T08:21:29-04:00 New Revision: aa4f4d18e85d65f796ee9a9549ead1c0cd56ac1d URL: https://github.com/llvm/llvm-project/commit/aa4f4d18e85d65f796ee9a9549ead1c0cd56ac1d DIFF: https://github.com/llvm/llvm-project/commit/aa4f4d18e85d65f796ee9a9549ead1c0cd56ac1d.diff

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8445-8463 +const ValueDecl *VD = Cap.getCapturedVar()->getCanonicalDecl(); +const auto *RD = VD->getType() + .getCanonicalType() + .getNonRefer

[PATCH] D108822: [python bindings] Add missing cursor kind in Clang Python's bindings.

ColinChargy added a comment. Hi @teerytko, It's my first PR, so I don't know how to get this PR reviewed. I sent an e-mail to @rsmith without luck. Should I send another e-mail to the mailing list IYHO ? Regards, Colin Chargy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:159 +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, + const IncludeStructure &Structure, EntryPoint is unused Comment at: clang-too

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 ___

[PATCH] D107141: [Inline-asm] Add structure type handling when they are tied in input and output constraints

pengfei updated this revision to Diff 377168. pengfei added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/Sema/SemaStmtAsm.cpp clan

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24/new/ https://reviews.llvm.org/D24 ___

[clang] 8737c74 - [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

Author: Kamau Bridgeman Date: 2021-10-05T07:59:32-05:00 New Revision: 8737c74fab3aee833d85b7d235d2c47ebb4eed2e URL: https://github.com/llvm/llvm-project/commit/8737c74fab3aee833d85b7d235d2c47ebb4eed2e DIFF: https://github.com/llvm/llvm-project/commit/8737c74fab3aee833d85b7d235d2c47ebb4eed2e.dif

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

This revision was automatically updated to reflect the committed changes. Closed by commit rG8737c74fab3a: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units (authored by kamaub). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

kamaub marked an inline comment as done. kamaub added a comment. Updated an existing test for the backend with pwr8 and pwr9 be/le targets during commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109599/new/ https://reviews.llvm.org/D109599 __

[clang] f4f9ad0 - Reland "[clang-repl] Allow loading of plugins in clang-repl."

Author: Vassil Vassilev Date: 2021-10-05T13:04:01Z New Revision: f4f9ad0f5d8e8994c677c3712dff7585bf8bd963 URL: https://github.com/llvm/llvm-project/commit/f4f9ad0f5d8e8994c677c3712dff7585bf8bd963 DIFF: https://github.com/llvm/llvm-project/commit/f4f9ad0f5d8e8994c677c3712dff7585bf8bd963.diff LO

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:158 + +std::vector +getUnused(IncludeStructure::HeaderID EntryPoint, sammccall wrote: > sammccall wrote: > > Why are we passing around Inclusions by value? > Sorry, should ha

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377197. kbobyrev marked 10 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/D108194 Files: clang

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a reviewer: mstorsjo. mstorsjo added a subscriber: cfe-commits. mstorsjo added a comment. (I’ll have a look and comment on the patch later.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___

[PATCH] D110455: DebugInfo: Use clang's preferred names for integer types

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Seems like a good simplification. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110455/new/ https://reviews.llvm.org/D110455 __

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: hubert.reinterpretcast wrote: > Confirming that this case matches GCC on AIX: > ``` > ld 4,8(3) > ld 3,0(3)

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

aaron.ballman added a comment. In D110656#3034971 , @beanz wrote: > In D110656#3034083 , @xbolva00 > wrote: > >> Why just no special case "= {0};" pattern and do not warn in that case? > > This case did show up,

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

crayroud added a comment. Thank you for your inputs. I will work on the changes and update the patch once it is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110833/new/ https://reviews.llvm.org/D110833

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

daltenty added a comment. > Making a change to whether a platform has __int128 affects the ABI of > libc++'s std::chrono::file_clock. We should make sure the mitigation patch is > posted and accepted. Good point, but the std::chrono::file_clock interface hasn't shipped yet on the platform libc

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3042913 , @daltenty wrote: > Good point, but the std::chrono::file_clock interface hasn't shipped yet on > the platform libc++, since it's currently still at a bit of a backlevel, so I > don't think tha

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.h:65 SrcMgr::CharacteristicKind FileKind = SrcMgr::C_User; + unsigned ID = std::numeric_limits::max(); // Correspon

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

kbobyrev updated this revision to Diff 377264. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Thank you for the review! Looks much better now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.llvm.org/

[clang-tools-extra] 6831c1d - [clangd] Include refs of base method in refs for derived method.

Author: Utkarsh Saxena Date: 2021-10-05T17:39:49+02:00 New Revision: 6831c1d8689bebe745aac1fdd7354c2e2f692c1a URL: https://github.com/llvm/llvm-project/commit/6831c1d8689bebe745aac1fdd7354c2e2f692c1a DIFF: https://github.com/llvm/llvm-project/commit/6831c1d8689bebe745aac1fdd7354c2e2f692c1a.diff

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6831c1d8689b: [clangd] Include refs of base method in refs for derived method. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/

[PATCH] D111062: [RISCV] Rename some assembler mnemonic and intrinsic functions for RVV 1.0.

frasercrmck added a comment. LGTM in general. My comments are all about comments. I know the old names are kept as aliases but I still think it's better to reference the "real" instructions where we can. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2468

[clang] 9503ad3 - [clang] FatalErrorHandler.cpp - add explicit include

Author: Simon Pilgrim Date: 2021-10-05T17:03:17+01:00 New Revision: 9503ad3b533cb84b51cfc80c51d262da50435013 URL: https://github.com/llvm/llvm-project/commit/9503ad3b533cb84b51cfc80c51d262da50435013 DIFF: https://github.com/llvm/llvm-project/commit/9503ad3b533cb84b51cfc80c51d262da50435013.diff

[clang-tools-extra] ebfcd06 - [clangd] IncludeCleaner: Mark used headers

Author: Kirill Bobyrev Date: 2021-10-05T18:08:24+02:00 New Revision: ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb URL: https://github.com/llvm/llvm-project/commit/ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb DIFF: https://github.com/llvm/llvm-project/commit/ebfcd06d422286dcdd0e9a8c57e207a46c8fb8fb.diff

[PATCH] D108194: [clangd] IncludeCleaner: Mark used headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGebfcd06d4222: [clangd] IncludeCleaner: Mark used headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108194/new/ https://reviews.l

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

kbobyrev added a comment. Sure! I'm just using the credentials from the arc, mostly, i.e. `arc patch --nobranch D110600 && git push`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600 _

[clang-tools-extra] 32ab79e - [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

Author: Matt Beardsley Date: 2021-10-05T18:09:53+02:00 New Revision: 32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 URL: https://github.com/llvm/llvm-project/commit/32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1 DIFF: https://github.com/llvm/llvm-project/commit/32ab79ebc496d73cb0eb3ad3b54d32b00fc49ba1.diff

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32ab79ebc496: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column… (authored by mattbeardsley, committed by kbobyrev). Re

[PATCH] D110910: [analyzer][solver] Fix CmpOpTable handling bug

ASDenysPetrov added a comment. Thanks for mentioning me. I'll make a review of this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110910/new/ https://reviews.llvm.org/D110910 ___ cfe-commits ma

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley added a comment. Works for me! 🙂 I didn't realize you can pull the info automatically from arc. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600 _

[PATCH] D111134: Add basic aarch64-none-elf bare metal driver.

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM thanks for the update. This looks like it follows the same format as the other -none-elf toolchains, and AArch64 can benefit from the bare-metal driver for easier access to LLD.

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver &

Re: [PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

You're welcome :) Yeah, I think there's even `arc land` that's _intended_ for this but I'm just using the patch option. And it pulls from Phabricator (name, email etc). On Tue, Oct 5, 2021 at 6:17 PM Matt Beardsley via Phabricator < revi...@reviews.llvm.org> wrote: > mattbeardsley added a comment

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 377283. jsji added a comment. Herald added a subscriber: kbarton. Address comments -- adding AIX triples to more existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D

[clang-tools-extra] 0c14e27 - [clangd] Revert unwanted change from D108194

Author: Kirill Bobyrev Date: 2021-10-05T18:44:43+02:00 New Revision: 0c14e279c7294cb354e803ba5f2557425fee7c59 URL: https://github.com/llvm/llvm-project/commit/0c14e279c7294cb354e803ba5f2557425fee7c59 DIFF: https://github.com/llvm/llvm-project/commit/0c14e279c7294cb354e803ba5f2557425fee7c59.diff

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers planned changes to this revision. vabridgers added a comment. I'm refactoring the code change a bit. I'll push another update soon. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 updated this revision to Diff 377288. jyu2 added a comment. Thanks Alexey's review. This patch is address Alexe's comments by adding new field LambdasMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15/new/ https://reviews.llvm.org/D11

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8451-8454 + ArrayRef MapModifiers; + ArrayRef MotionModifiers; + return getMapTypeBits( + I->getSecond(), MapModifiers, MotionModifiers, false, No need to cre

[clang] c7104e5 - [Sema] Allow comparisons between different ms ptr size address space types.

Author: Amy Huang Date: 2021-10-05T10:56:29-07:00 New Revision: c7104e506619b551ee7ab888a040114f260e8cb5 URL: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5 DIFF: https://github.com/llvm/llvm-project/commit/c7104e506619b551ee7ab888a040114f260e8cb5.diff LOG

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7104e506619: [Sema] Allow comparisons between different ms ptr size address space types. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, emaste. Jake-Egan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377303. v.g.vassilev added a comment. Upload the newest version of this patch. It has several improvements that came from various bot failures. We just need to outline the `llvm::consumeError` to be able to call it from exceptions land and fix the last

[PATCH] D110436: Add %n format specifier warning

Jaysonyan added a comment. Since no discussion came out of the RFC I'll leave the warning under the `-Wformat-n-specifier` flag under `-Wformat` unless there's other ideas brought up. Would appreciate any reviews at this points! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

Jake-Egan updated this revision to Diff 377306. Jake-Egan added a comment. Updated to preserve blank lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69/new/ https://reviews.llvm.org/D69 Files: clang/test/ClangScanDeps/modules-full-b

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 377307. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/examples/CMakeLists.txt clang/exa

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:102 + } catch (...) { +printf("Unknown exception\n"); + } karies wrote: > How is that provoking a test failure? What about `exit(1)` or

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 377309. vabridgers added a comment. This revision is now accepted and ready to land. Refactor compare a little bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625

[PATCH] D110781: [CUDA] Make sure is included with original __THROW defined.

tra added a comment. @jdoerfert: Ping. I think you're the best match for reviewing the code related to interaction between CUDA and the system include files, even if this particular header does not have much to do with OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 377316. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fix up c++ version in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files:

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae updated this revision to Diff 377323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/annotations-global.c clang/test/CodeGenC

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937 +// Extract map information. +for (const auto *C : Dir.getClausesOfKind()) { + if (C->getMapType() != OMPC_MAP_to) +continue; + for (auto L : C->component_lists()) {

[PATCH] D110436: Add %n format specifier warning

aaron.ballman added a comment. The trouble with this diagnostic is that it throws the baby out with the bathwater. It is possible to securely use `%n`, so we can't have this warning be on by default because it will have too high of a false positive rate. However, we typically don't introduce ne

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin created this revision. Herald added a subscriber: jeroen.dobbelaere. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement P2360R0 in C++23 mode and as an extension in older languages mode. Repository: rG LLVM Gith

[PATCH] D110436: Add %n format specifier warning

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning< FWIW, I

[PATCH] D111115: [OPENMP] Fix assert of "Unable to find base lambda address" from adjustMemberOfForLambdaCaptures.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8923-8937 +// Extract map information. +for (const auto *C : Dir.getClausesOfKind()) { + if (C->getMapType() != OMPC_MAP_to) +continue; + for (auto L : C->component_lists())

[PATCH] D110436: Add %n format specifier warning

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9230 +def warn_printf_n_specifier : Warning< + "usage of '%%n' can lead to unsafe writing to memory">, InGroup; def warn_printf_data_arg_not_used : Warning< Quuxp

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems like a good place to start with experimentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://reviews.llvm.org/D1

[PATCH] D109557: Adds a BreakBeforeClosingParen option

gracicot added a comment. In D109557#3021667 , @HazardyKnusperkeks wrote: > In D109557#3021312 , > @MyDeveloperDay wrote: > >> FYI, this is a very aggressive change, I highly recommend you run this over >> a la

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

dblaikie requested changes to this revision. dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. This revision now requires changes to proceed. Oh, looking at this ab it further I do have some things to discuss. Comment at: clang/include/clang/Driver/Options.t

[PATCH] D111178: Fix clang postMerge logic based on System V ABI Standard

vsoch created this revision. vsoch added reviewers: LLVM, llvm.org. vsoch created this object with edit policy "Only User: vsoch (Vanessasaurus)". vsoch added a project: LLVM. Herald added a subscriber: pengfei. vsoch requested review of this revision. Herald added a project: clang. Herald added a

  1   2   >