[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2992702 , @wenlei wrote: > The change makes sense given instr PGO also happens for O0. But practically, > if a file is being built with O0, do we care about its profile given we're > not really optimizing it anyways? Func

[PATCH] D106674: Runtime for Interop directive

RaviNarayanaswamy added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, + noalias_dep_list); + }

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei created this revision. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fallback-style is a frequently used flag in clang_format, however, it was not supported by clang-format-diff.py script. This change adds this flag. Repo

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', +

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371737. jhuber6 added a comment. Addressing Comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td cl

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371740. jhuber6 added a comment. Forgot to format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield added a comment. I'm seeing crashes in this area when running OvO, e.g. 0. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_float_complex_float.cpp 1. $HOME/OvO/test_src/cpp/mathematical_function/cpp11-complex/pow_complex_float_complex_flo

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei updated this revision to Diff 371749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109550/new/ https://reviews.llvm.org/D109550 Files: clang/tools/clang-format/clang-format-diff.py Index: clang/tools/clang-format/clang-format-diff.py ===

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

haowei marked an inline comment as done. haowei added inline comments. Comment at: clang/tools/clang-format/clang-format-diff.py:62 + parser.add_argument('-fallback-style', + dest='fallback_style', + help='The name of the predefined styl

[clang] 38a5bd4 - [clang_format] Add fallback-style flag to clang-format-diff.py

Author: Haowei Wu Date: 2021-09-09T16:36:39-07:00 New Revision: 38a5bd4115afbe022a99334c7880f30a8ffd7c4a URL: https://github.com/llvm/llvm-project/commit/38a5bd4115afbe022a99334c7880f30a8ffd7c4a DIFF: https://github.com/llvm/llvm-project/commit/38a5bd4115afbe022a99334c7880f30a8ffd7c4a.diff LOG

[PATCH] D109550: [clang_format] Add fallback_style flag to clang-format-diff.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. haowei marked an inline comment as done. Closed by commit rG38a5bd4115af: [clang_format] Add fallback-style flag to clang-format-diff.py (authored by haowei). Reposito

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. @MyDeveloperDay is it all good? I'm sorry for all the misunderstanding, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 ___ cfe-com

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern created this revision. csmulhern added a reviewer: MyDeveloperDay. csmulhern requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This style can be used to control the alignment of closing brackets. For prior work on a similar feature

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin abandoned this revision. peixin added a comment. Abandon this PR since this is not right fix. Continuing discussion will be on openmp-dev mail list. This bug should be fixed if `ordered simd` is processed correctly in frontend and vectorization pass. Repository: rG LLVM Github Monorep

[PATCH] D109544: [OpenMP] Add flag for setting debug in the offloading device

jhuber6 updated this revision to Diff 371772. jhuber6 added a comment. Adding global regex to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109544/new/ https://reviews.llvm.org/D109544 Files: clang/include/clang/Basic/DiagnosticDriverKinds

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

ChuanqiXu added a comment. In D108905#2975806 , @rjmccall wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions can

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. But please wait to see whether @aprantl has any comments. Thanks. Comment at: clang/test/Modules/ExtDebugInfo.cpp:27 +#line 50 using DebugCXX::Struct; A

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

wmi added a comment. In D109531#2992721 , @hoy wrote: > In D109531#2992702 , @wenlei wrote: > >> The change makes sense given instr PGO also happens for O0. But practically, >> if a file is being built with O0, d

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. In D36850#2990907 , @tejohnson wrote: > In D36850#2990847 , @modimo wrote: > >> In D36850#2990771 , @tejohnson >> wrote: >> >>> In D36850#2968536

[PATCH] D109531: [CSSPGO] Enable pseudo probe instrumentation in O0 mode.

hoy added a comment. In D109531#2993394 , @wmi wrote: > In D109531#2992721 , @hoy wrote: > >> In D109531#2992702 , @wenlei wrote: >> >>> The change makes sense given instr

<    1   2