[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro accepted this revision. evandro added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 _

[PATCH] D108886: Add RISC-V sifive-s51 cpu

jrtc27 added a comment. In D108886#2977873 , @apivovarov wrote: > In D108886#2977733 , @jrtc27 wrote: > >> You don't need to tag people as well as adding them as reviewers, it's just >> annoying. Also, it's only

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert added a subscriber: Meinersbur. jdoerfert added a comment. In D109057#2977859 , @JonChesterfield wrote: > Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to > Windows. I can't run anything on Windows locally, and tri

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov updated this revision to Diff 370072. apivovarov added a comment. Added a note to Release Notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 Files: clang/docs/ReleaseNotes.rst clang/test

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. I don't think that such a minor change makes sense to be added to the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 _

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. Evandro, similar notes have been made in the past for Release Notes 12.x and 11.x for Arm and RISC-V processors: https://github.com/llvm/llvm-project/blob/release/12.x/clang/docs/ReleaseNotes.rst#modified-compiler-flags https://github.com/llvm/llvm-project/blob/release

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.h:40 + static constexpr int DefaultSmallMaxSize = 16; + int SmallMaxSize = Options.get("SmallMaxSize", DefaultSmallMaxSize); + jmarrec wrote: > https://re

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. In D108886#2978038 , @apivovarov wrote: > Evandro, similar notes have been made in the past for Release Notes 12.x and > 11.x for Arm and RISC-V processors: > https://github.com/llvm/llvm-project/blob/release/12.x/clang/docs/Rel

[PATCH] D108794: Fully qualify template template parameters when printing

dblaikie updated this revision to Diff 370086. dblaikie added a comment. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang-tools-extra. Fix the clang-tools-extra caller, and update the TemplateName::print doc comment Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370087. JonChesterfield added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[PATCH] D108794: Fully qualify template template parameters when printing

dblaikie marked an inline comment as done. dblaikie added a comment. Ping In D108794#2976063 , @rtrieu wrote: > It looks like a strict improvement on printing and most callers using the > default args won't need to be updated. > > There's one more funct

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield requested review of this revision. JonChesterfield added a comment. Sending back to review now that the test updates are included and LIBRARY_PATH removed from the test setup entirely Comment at: clang/test/Driver/openmp-offload-gpu.c:151 /// Check that the

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. Add Cortex-A78C Support for Clang and LLVM is similar to this patch. As we can see `cortex-a78c` support was included to the ReleaseNotes 12.x

[PATCH] D108886: Add RISC-V sifive-s51 cpu

evandro added a comment. In D108886#2978169 , @apivovarov wrote: > Add Cortex-A78C Support for Clang and LLVM > > is similar to this patch. As we can see `cortex-a7

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos added a comment. LG. One possible suggestion is that you leave the double dash (`--`) variant in some tests so that we can make sure both variants (e.g. both `openmp-amdgcn-amd-amdhsa--gfx906` and `openmp-amdgcn-amd-amdhsa-gfx906`) are correctly parsed. Repository: rG LLVM Github Mon

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

rjmccall closed this revision. rjmccall added a comment. I agree. This isn't the right approach. The patch in question is currently reverted; if you'd like to argue to not restore it, that conversation should be part of that review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, Jim, atanasyan, jrtc27, fedor.sergeev, sdardis, dylanmckay, emaste. thakis requested review of this revision. Herald added a project: LLVM. Now prints the list of known archs. This requires plumbing

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

rjmccall added a comment. How does `stripPointerCasts` "see through" an attribute on the underlying call instruction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 _

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

jroelofs added a comment. In D105671#2978248 , @rjmccall wrote: > How does `stripPointerCasts` "see through" an attribute on the underlying > call instruction? https://github.com/llvm/llvm-project/blob/bf77b11277411f6725cf09a66feb36d2c14bc8a7/llvm/lib/I

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

rjmccall added a comment. Whoa. That does not seem like it's in the contract for `stripPointerCasts()` generically. At best that should be enabled by the strip kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1671 unsigned KeyLen = key.Filename.size() + 1 + 8 + 8; - unsigned DataLen = 1 + 2 + 4 + 4; + unsigned DataLen = 1 + 4 + 4 + 4; + for (auto ModuleIncluder : Data.HFI.ModuleInclu

[PATCH] D104344: [modules] Track how headers are included by different modules.

vsapsai updated this revision to Diff 370117. vsapsai added a comment. Clarify some comments; rebase for a fresh pre-commit testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://reviews.llvm.org/D104344 Files: clang/include/

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64ebf313a7e4: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 64ebf31 - [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

Author: Volodymyr Sapsai Date: 2021-09-01T17:07:35-07:00 New Revision: 64ebf313a7e485e1a90da9cd69c412e06615a9bc URL: https://github.com/llvm/llvm-project/commit/64ebf313a7e485e1a90da9cd69c412e06615a9bc DIFF: https://github.com/llvm/llvm-project/commit/64ebf313a7e485e1a90da9cd69c412e06615a9bc.di

[PATCH] D104344: [modules] Track how headers are included by different submodules.

rsmith added a comment. I wonder if perhaps we're tracking this state in the wrong way. The "has been included" information for `#pragma once` / `#import` should behave exactly like macro definition visibility: it should be reset whenever we enter a new "clean slate" state and should be saved a

[PATCH] D109105: [clang-cl] Emit nicer warning on unknown /arch: arguments

thakis updated this revision to Diff 370128. thakis added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109105/new/ https://reviews.llvm.org/D109105 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Dri

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. I checked EmitAutoVarAlloca(). It emits the llvm.stacksave() due to // If the type is variably-modified, emit all the VLA sizes for it. if (Ty->isVariablyModifiedType()) EmitVariablyModifiedType(Ty); Here, in order not to generate llvm.stacksave(), we need

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In order to tackle the issues, I think we can do it this way: put the clang default lib ahead of `LIBRARY_PATH`. This can make sure `clang` always uses the bitcode library that comes with it, and if it is not there, it also has the ability to find a potential one

[clang] 6eda66b - PR50294: Fix a performance regression from 2c9dbcd.

Author: Richard Smith Date: 2021-09-01T18:00:07-07:00 New Revision: 6eda66b0a9f793c65852aa94430ae9bd891bcf63 URL: https://github.com/llvm/llvm-project/commit/6eda66b0a9f793c65852aa94430ae9bd891bcf63 DIFF: https://github.com/llvm/llvm-project/commit/6eda66b0a9f793c65852aa94430ae9bd891bcf63.diff

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @rjmccall @lxfind @junparser hi, do you feel comfortable with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. In D106343#2967089 , @haonanya wrote: > Hi, svenvh. > Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to > guard the functions using atomic_double type? > Thanks very much. > > #if defined(__opencl

[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai added a comment. That's a good point. Let me check how we track macros, I haven't thought about that approach. And I haven't considered using `Preprocessor::SubmoduleState`, was too excited `HeaderSearch::ShouldEnterIncludeFile` works correctly with the updated data.

[PATCH] D104344: [modules] Track how headers are included by different submodules.

vsapsai planned changes to this revision. vsapsai added a comment. Investigate less heavy-weight approaches similar to those used for tracking macros from different submodules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104344/new/ https://revi

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds Big-Endian checks for the existing MMA test cases. Repository: rG LLVM Github Mon

[PATCH] D109127: Use python 3 in add_new_check.py and rename_check.py

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. As of this commit: https://github.com/llvm/llvm-project/commit/307b1fdd If either o

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

oToToT added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108756/new/ https://reviews.llvm.org/D108756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is a follow up to 0be9ca7c0f9a733f846bb6bc4e8e3

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 370155. keith added a comment. Some of the other checks were invalid given the current tests, these seem to be enough to solve this issue without breaking existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE Seems just adding `%clang_cc1

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___

<    1   2