nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107002/new/
https://reviews.llvm.org/D107002
__
0x8000- added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136
+CheckFactories.registerCheck(
+"readability-variable-length");
}
aaron.ballman wrote:
> 0x8000- wrote:
> > aaron.ballman wro
bnbarham added inline comments.
Comment at: clang/test/VFS/umbrella-mismatch.m:4
-
-// RUN: %clang_cc1 -Werror -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -ivfsoverlay %t.yaml -F %S/Inputs -fsyntax-only %s
-Wno-atimport-in-framework-header -verify
-// RUN: %clang_c
bnbarham updated this revision to Diff 365619.
bnbarham added a comment.
Removed the now unused UsesFoo.framework in the tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107690/new/
https://reviews.llvm.org/D107690
Files:
clang/lib/Serializat
0x8000- updated this revision to Diff 365622.
0x8000- added a comment.
Rebased on main and renamed from readability-variable-length to
readability-identifier-length.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97753/new/
https://reviews.llvm.org/D97753
Files:
clang-tools-e
nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Sema/SemaChecking.cpp:7329
+// and false if it is not valid.
+auto IsValidType = [ArgType, ExpectedType]() {
+ if (Expect
cjdb added a comment.
Ping @aaron.ballman
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107294/new/
https://reviews.llvm.org/D107294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
cjdb added a comment.
Ping @aaron.ballman
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107292/new/
https://reviews.llvm.org/D107292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
cjdb created this revision.
cjdb added a reviewer: aaron.ballman.
Herald added subscribers: xazax.hun, mgorny.
cjdb requested review of this revision.
Herald added projects: LLVM, clang-tools-extra.
Herald added subscribers: cfe-commits, llvm-commits.
Checks ``const``-qualified parameters to deter
cjdb added a comment.
Work left to do in this patch: add user options. Figured getting a non-config
version up for review first would be a good idea.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107873/new/
https://reviews.llvm.org/D107873
_
cjdb added a comment.
Those CI failures are kinda embarrassing. Is there any way to leverage
clang-format in a case like this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107873/new/
https://reviews.llvm.org/D107873
nemanjai added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15962
if (Depth > 0) {
+SDValue FrameAddr =
Please add a comment:
```
// The link register (return address) is saved in the caller's frame
// not the callee's stack f
phosek updated this revision to Diff 365635.
phosek retitled this revision from "[InstrProfiling] Generate runtime hook for
ELF platforms" to "[InstrProfiling] Generate runtime hook for Fuchsia".
phosek edited the summary of this revision.
phosek added a comment.
I have reworked the change and re
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
Thanks Craig. I haven't find time to work on it. I think this is a good start.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107843/new/
hoy created this revision.
Herald added subscribers: modimo, wenlei.
hoy requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Previoulsy debug-info-for-profiling and pseudo-probe-for-profiling are mutual
exclusive because they
Jim added a comment.
Hi @jrtc27, any further feedback? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95588/new/
https://reviews.llvm.org/D95588
___
cfe-commits mailing list
cfe-commits@lists.llvm
jrtc27 added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCV.td:186-188
+ [FeatureExtZpsfoperand,
+FeatureExtZpn,
+FeatureExtZprvsfextra]>;
Jim wrote:
> jrtc27 wrote:
> > These aren't
cjdb updated this revision to Diff 365648.
cjdb added a comment.
uploading solely for a fast visual inspection on the diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107528/new/
https://reviews.llvm.org/D107528
Files:
clang-tools-extra/clang-
Author: Christopher Di Bella
Date: 2021-08-11T02:48:53Z
New Revision: c874dd53628db8170d4c5ba3878817abc385a695
URL:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695
DIFF:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif
Author: Christopher Di Bella
Date: 2021-08-11T02:48:53Z
New Revision: c874dd53628db8170d4c5ba3878817abc385a695
URL:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695
DIFF:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
cjdb marked 3 inline comments as done.
Closed by commit rGc874dd53628d: [llvm][clang][NFC] updates inline licence info
(authored by cjdb).
Changed prior to commit:
h
kstoimenov updated this revision to Diff 365650.
kstoimenov added a comment.
Fixed the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107850/new/
https://reviews.llvm.org/D107850
Files:
clang/test/CodeGen/asan-use-callbacks.cpp
llvm/inclu
0x8000- updated this revision to Diff 365651.
0x8000- added a comment.
Clean diff against origin/main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97753/new/
https://reviews.llvm.org/D97753
Files:
clang-tools-extra/clang-tidy/readability/CMakeLists.txt
clang-tools-extra/cl
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107668/new/
https://reviews.llvm.org/D107668
___
wenlei added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3896
- // These two forms of profiling info can't be used together.
- if (const Arg *A1 =
Args.getLastArg(options::OPT_fpseudo_probe_for_profiling))
-if (const Arg *A2 =
Args.getLastArg(option
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:57
+namespace {
+bool isSharedPtr(const QualType &T) {
+ if (auto R = T->getAsCXXRecordDecl())
Please use `static`, not anonymous namespace f
Author: Petr Hosek
Date: 2021-08-10T23:21:15-07:00
New Revision: 389dc94d4be7a75c243528981a25260c1c7a6103
URL:
https://github.com/llvm/llvm-project/commit/389dc94d4be7a75c243528981a25260c1c7a6103
DIFF:
https://github.com/llvm/llvm-project/commit/389dc94d4be7a75c243528981a25260c1c7a6103.diff
LO
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG389dc94d4be7: [InstrProfiling] Generate runtime hook for
Fuchsia (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D98061?vs
yonghong-song created this revision.
yonghong-song added a reviewer: rsmith.
Herald added a subscriber: dexonsmith.
yonghong-song requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Paul Chaignon reported a bpf verifier failur
101 - 129 of 129 matches
Mail list logo
