[PATCH] D105462: [X86] Add CRC32 feature.

tianqing added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. craig.topper wrote: > This does

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. @rnk could you please have a review of IMAGE_COMDAT_SELECT_XXX modification? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commi

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

paulwalker-arm added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8677 + return Ty->getKind() == BuiltinType::SveBool + ? Context.getLangOpts().ArmSveVectorBits / Context.getCharWidth() + : Context.getLangOpts().ArmSveVectorBits;

[clang] 724f0e2 - [OpenCL] Add cl_khr_extended_bit_ops

Author: Sven van Haastregt Date: 2021-07-21T10:01:19+01:00 New Revision: 724f0e2abb0ce327d2e82af5a61be25e2d2014ec URL: https://github.com/llvm/llvm-project/commit/724f0e2abb0ce327d2e82af5a61be25e2d2014ec DIFF: https://github.com/llvm/llvm-project/commit/724f0e2abb0ce327d2e82af5a61be25e2d2014ec.

[PATCH] D106267: [OpenCL] Add cl_khr_extended_bit_ops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG724f0e2abb0c: [OpenCL] Add cl_khr_extended_bit_ops (authored by svenvh). Herald added subscribers: cfe-commits, ldrumm. Repository: rG LLVM Github

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added a comment. This broke https://lab.llvm.org/buildbot/#/builders/105/builds/12584. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits ma

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D106203: [clangd] Propagate header-guarded flag from preamble to main AST

sammccall added a comment. Sorry, forgot to address the style comments. Will send a followup patch. Comment at: clang-tools-extra/clangd/Preamble.cpp:87 + +const SourceManager &SM = CI.getSourceManager(); +const FileEntry *MainFE = SM.getFileEntryForID(SM.getMainFileID(

[clang-tools-extra] 91670f5 - [clangd] Remove big PreambleData constructor. NFC

Author: Sam McCall Date: 2021-07-21T11:31:52+02:00 New Revision: 91670f5f20daa00b83520b76bcb54a5d373242f3 URL: https://github.com/llvm/llvm-project/commit/91670f5f20daa00b83520b76bcb54a5d373242f3 DIFF: https://github.com/llvm/llvm-project/commit/91670f5f20daa00b83520b76bcb54a5d373242f3.diff LO

[clang] 21401a7 - [clang] Introduce SourceLocation::[U]IntTy typedefs.

Author: Simon Tatham Date: 2021-07-21T10:45:46+01:00 New Revision: 21401a72629cc591bab7ec6816f03e6c550f3fb3 URL: https://github.com/llvm/llvm-project/commit/21401a72629cc591bab7ec6816f03e6c550f3fb3 DIFF: https://github.com/llvm/llvm-project/commit/21401a72629cc591bab7ec6816f03e6c550f3fb3.diff

[PATCH] D105492: [clang] Introduce SourceLocation::[U]IntTy typedefs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21401a72629c: [clang] Introduce SourceLocation::[U]IntTy typedefs. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

sammccall added a comment. Please before sending any more patches, let's resolve the design questions here (or via mail). It's clear that it's possible to write a clang-tidy check whose behavior on the main file cannot be preserved without traversing the whole AST. Silly example: the main file

[clang] 732a8a9 - [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes

Author: Gabor Marton Date: 2021-07-21T11:59:56+02:00 New Revision: 732a8a9dfb3ed96a0d3c9b4507b1d1a40dfa198a URL: https://github.com/llvm/llvm-project/commit/732a8a9dfb3ed96a0d3c9b4507b1d1a40dfa198a DIFF: https://github.com/llvm/llvm-project/commit/732a8a9dfb3ed96a0d3c9b4507b1d1a40dfa198a.diff

[PATCH] D106370: [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG732a8a9dfb3e: [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes (authored by martong). Changed prior to commit: https://revie

[PATCH] D106370: [Analyzer][solver][NFC] Add explanatory comments to trivial eq classes

martong added a comment. In D106370#2892390 , @NoQ wrote: > I understood this comment! Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106370/new/ https://reviews.llvm.org/D106370 __

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

vsavchenko added a comment. Can we please land the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106296/new/ https://reviews.llvm.org/D106296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8677 + return Ty->getKind() == BuiltinType::SveBool + ? Context.getLangOpts().ArmSveVectorBits / Context.getCharWidth() + : Context.getLangOpts().ArmSveVectorBits;

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8673 +/// getSVETypeSize - Return SVE vector or perdicate register size. +static uint64_t getSVETypeSize(ASTContext &Context, const BuiltinType *Ty) { s/perdicate/predicate =

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

sammccall added a comment. This is pretty interesting from a tooling perspective! Some prior art here are the include-what-you-use "pragmas" (magic comments). Clangd supports `// IWYU pragma: "private

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

Sockke created this revision. Sockke added reviewers: aaron.ballman, MTC, steven.zhang. Herald added subscribers: shchenz, kbarton, xazax.hun, nemanjai. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. In C++, the enumerat

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

whisperity added a comment. Is this the right decision to make, conceptually? It will leave the variable uninitialised still, and reading such an uninit variable is still an issue, even if it is an enum. Could we consider the alternative of warning the user about the uninitialized variable, jus

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

steven.zhang added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-init-variables.cpp:103 + // Expect no warning given here. + Color color; + // Expect no warning given here. Technical speaking, we should warn about s

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

MTC added a comment. In D106431#2892859 , @whisperity wrote: > Is this the right decision to make, conceptually? It will leave the variable > uninitialised still, and reading such an uninit variable is still an issue, > even if it is an enum. Yeah, th

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-init-variables.cpp:103 + // Expect no warning given here. + Color color; + // Expect no warning given here. steven.zhang wrote: > Technical speaking, we should

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables with enum judgement

steven.zhang added a comment. In D106431#2892866 , @MTC wrote: > In D106431#2892859 , @whisperity > wrote: > >> Is this the right decision to make, conceptually? It will leave the variable >> uninitialised still

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

sammccall added a comment. Thanks. AFAIK this is now waiting on you David with Kadir to review impl. In D105904#2881329 , @dgoldman wrote: > I think the difficulty is when you "figure out the mark container for a > symbol" since we implicitly scope the

[PATCH] D106432: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Due to the LLVM's J

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. tianqing wrote: > craig.topper

[PATCH] D106432: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106432/new/ https://reviews.llvm.org/D106432 __

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360408. quinnp added a comment. Rebasing to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Basic/T

[clang-tools-extra] 907efdf - [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

Author: Kirill Bobyrev Date: 2021-07-21T14:51:16+02:00 New Revision: 907efdf95da567c314e2c9b9df67187756eed5ca URL: https://github.com/llvm/llvm-project/commit/907efdf95da567c314e2c9b9df67187756eed5ca DIFF: https://github.com/llvm/llvm-project/commit/907efdf95da567c314e2c9b9df67187756eed5ca.diff

[PATCH] D106432: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG907efdf95da5: [clangd] Cleanup FuzzyFindRequest serialization and dex benchmark (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANG

[clang] 80068ca - [analyzer] Fix for faulty namespace test in SmartPtrModelling

Author: Deep Majumder Date: 2021-07-21T18:23:35+05:30 New Revision: 80068ca6232b32e3ab79eb2ed72fd73558179ad5 URL: https://github.com/llvm/llvm-project/commit/80068ca6232b32e3ab79eb2ed72fd73558179ad5 DIFF: https://github.com/llvm/llvm-project/commit/80068ca6232b32e3ab79eb2ed72fd73558179ad5.diff

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80068ca6232b: [analyzer] Fix for faulty namespace test in SmartPtrModelling (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106296: [analyzer] Fix for faulty namespace test in SmartPtrModelling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:291 // we can try this function - if (Call.getNumArgs() == 2 && - Call.getDecl()->getDeclContext()->isStdNamespace()) -if (smartptr::isStdSmartPtr(Call.getArgExpr(0)) |

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:375-378 +def warn_changed_error_warning_attr_text : Warning< + "duplicate attribute changes text from %0 to %1">, + InGroup; + FWIW, elsewhere we typically use `

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added a comment. Thanks @jroelofs for moving the test cases! Those cases were added in https://reviews.llvm.org/D105946 and I have notified the author. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

NeHuang added subscribers: jroelofs, NeHuang. NeHuang added a comment. @jroelofs committed `f6769b663a0d4432b5e00e0c03904a5dfba7b077` to move the backend test cases from `CodeGen` -> `CodeGen/PowerPC` so they don't fail when the PPC backend isn't built. Repository: rG LLVM Github Monorepo C

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

svenvh created this revision. svenvh added reviewers: Anastasia, stuart. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins defined by Section 42 "Integer dot product" in the Op

[clang] e002d25 - [PowerPC] Floating Point Builtins for XL Compat.

Author: Quinn Pham Date: 2021-07-21T08:33:39-05:00 New Revision: e002d251dd34fc1855e3a17feafd358d55d92ed8 URL: https://github.com/llvm/llvm-project/commit/e002d251dd34fc1855e3a17feafd358d55d92ed8 DIFF: https://github.com/llvm/llvm-project/commit/e002d251dd34fc1855e3a17feafd358d55d92ed8.diff LO

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe002d251dd34: [PowerPC] Floating Point Builtins for XL Compat. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D106435: Fix tests

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106435 Files: clang/test/Lexer/char-escapes-delimited.c Index: clang/test/Lexer/c

Re: [clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

On Tue, Jul 20, 2021 at 8:27 PM David Blaikie wrote: > Any chance some of this series of patches could have test coverage > included? (like small clang test cases that exercise only a narrow part of > the codegen & works with force-opaque-pointers due to these changes?) > I think we're still pre

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 360435. whisperity edited the summary of this revision. whisperity added a comment. **NFC** Fix bad phrasing in comments (e.g. still mentioning //core type// and having a misleading negated sentence.) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

estewart08 added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif jdoerfert wrote: > JonChesterfield wrote: > > jdoerfert wrote: > > > estewart08 wrote: > > > > JonChesterfi

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

jdoerfert added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D106442: [clang-tidy] Improve "common type" diagnostic output in 'bugprone-easily-swappable-parameters'

whisperity created this revision. whisperity added a reviewer: aaron.ballman. whisperity added a project: clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk updated this revision to Diff 360443. anjankgk added a comment. Added braces for else-block. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106371/new/ https://reviews.llvm.org/D106371 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/mcmodel.c Index: clang/t

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk added a comment. In D106371#2892186 , @hubert.reinterpretcast wrote: > LGTM with minor nit; thanks. Done. @hubert.reinterpretcast Hubert, could you pls help me commit this? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106371

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

anjankgk added a comment. @cebowleratibm @Whitney Could either of you pls commit this? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106074/new/ https://reviews.llvm.org/D106074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Here's an interesting test case: > > > ``` >

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

DavidSpickett added a comment. You missed a REQUIRES for the llvm test, I added one in: https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5 So if you see Arm-AArch64 quick bot failures, that was the reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield updated this revision to Diff 360447. JonChesterfield added a comment. - rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 Files: clang/lib/Driver/ToolChains/Clang.cpp cla

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

Szelethus added inline comments. Herald added a subscriber: manas. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:156-157 // the bug is reported. -virtual std::string describe(ProgramStateRef State, +virtual std::string describe(Descrit

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

xgupta added a comment. @anjankgk You need to provide your identity for commit in "your name " form. see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your behal

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp added a comment. In D103986#2893177 , @DavidSpickett wrote: > You missed a REQUIRES for the llvm test, I added one in: > https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5 > > So if you see Arm-AArch64 quick bot failures, that wa

[PATCH] D106434: [OpenCL] Add cl_khr_integer_dot_product

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106434/new/ https://reviews.llvm.org/D106434 _

[clang] 968899a - [OpenMP][AMDGCN] Initial math headers support

Author: Pushpinder Singh Date: 2021-07-21T16:15:39+01:00 New Revision: 968899ad9cf17579f9867dafb35c4d97bad0863f URL: https://github.com/llvm/llvm-project/commit/968899ad9cf17579f9867dafb35c4d97bad0863f DIFF: https://github.com/llvm/llvm-project/commit/968899ad9cf17579f9867dafb35c4d97bad0863f.di

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG968899ad9cf1: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal, committed by JonChesterfield). Repository: rG LLVM Github Mono

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

bmahjour added a comment. Thanks for this patch @ZarkoCA. We have six of these functions in altivec: `vec_ctd, vec_ctf, vec_cts, vec_ctsl, vec_ctu, vec_ctul`. They are all defined as macros in altivec.h and not all of them map to the builtins checked in this patch (eg `vec_ctul`). I realize th

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. Landed on @pdhaliwal's behalf. My expectation is that this patch mostly works and the rough edges can be cleaned up once ocml is linked in and we can more easily run more applications through it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

ldionne added a comment. This is quite interesting, I'd love to be able to use this in libc++ (and suggest that my peers use this in Apple's libc)! In D106394#2892832 , @sammccall wrote: > Eventually this seems like a reasonable thing to want for user c

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

tlively updated this revision to Diff 360485. tlively added a comment. - Add aligment tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106400/new/ https://reviews.llvm.org/D106400 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def cla

[PATCH] D106400: [WebAssembly] Codegen for v128.load{32,64}_zero

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a57ee1276ed: [WebAssembly] Codegen for v128.load{32,64}_zero (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 1a57ee1 - [WebAssembly] Codegen for v128.load{32,64}_zero

Author: Thomas Lively Date: 2021-07-21T09:02:12-07:00 New Revision: 1a57ee1276edd90d13ca0d7e617c647bfe28377f URL: https://github.com/llvm/llvm-project/commit/1a57ee1276edd90d13ca0d7e617c647bfe28377f DIFF: https://github.com/llvm/llvm-project/commit/1a57ee1276edd90d13ca0d7e617c647bfe28377f.diff

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

nemanjai added a comment. My preference would be to just truncate the value with `& 0x1F`. It won't produce any code in the binary and will work as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.org/D10640

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

hliao added a comment. My local build failed due to regression failures. clang/test/Headers/openmp_device_math_isnan.cpp failed with the following errors on undeclared `fabs`. 1950 /home/michliao/working/llvm/llvm-project/clang/test/Headers/Inputs/include/cstdlib:29:31: error: use of undeclar

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2892832 , @sammccall wrote: > This is pretty interesting from a tooling perspective! > > Some prior art here are the include-what-you-use "pragmas" >

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

thakis added a comment. This breaks tests: http://45.33.8.238/linux/51733/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904

[PATCH] D106361: [clang-tidy] Fix crash and handle AttributedTypes in 'bugprone-easily-swappable-parameters'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:476-477 + +QualType NewCoreType = CoreType; +NewCoreType.add

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

dim added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:5 +set(LLVM_ABI_REVISION 0) + # Building libclang-cpp.so fails if LLVM_ENABLE_PIC=Off Is this actually needed? This CMakeLists.txt calls `add_clang_library()` in `clang/cmake/modules/

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

simon_tatham added a subscriber: lattner. simon_tatham added a comment. In D105491#2891860 , @dexonsmith wrote: > although it'd be good to get someone more involved in lib/CodeGen to take a > quick look / sign off (ideally someone that knows the use cas

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. Thanks! Will take a look. Feel free to revert, I'll do so shortly if noone beats me to it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904

[clang] d71062f - Revert "[OpenMP][AMDGCN] Initial math headers support"

Author: Jon Chesterfield Date: 2021-07-21T17:35:40+01:00 New Revision: d71062fbdab26fcc1c7e25ccdae410e1c61ed7f9 URL: https://github.com/llvm/llvm-project/commit/d71062fbdab26fcc1c7e25ccdae410e1c61ed7f9 DIFF: https://github.com/llvm/llvm-project/commit/d71062fbdab26fcc1c7e25ccdae410e1c61ed7f9.di

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

anjankgk added a comment. In D106074#2893249 , @xgupta wrote: > @anjankgk You need to provide your identity for commit in "your name email>" form. > see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > >> Prior to obtaining commit acc

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

bmahjour added a comment. In D106409#2893592 , @nemanjai wrote: > My preference would be to just truncate the value with `& 0x1F`. It won't > produce any code in the binary and will work as expected. That's fine with me too. Repository: rG LLVM Gith

[PATCH] D106349: [clang-format] respect AfterEnum for enums

MyDeveloperDay added a comment. This feels like there is some overlap with D93938: [clang-format] Fixed AfterEnum handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349

[PATCH] D105462: [X86] Add CRC32 feature.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. hjl.tools wrote: > tianqing

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

Quuxplusone added a comment. > Hmm... I like prior art. That clangd supports it suggests that there's a > section of code I can look at for inspiration if we were to replace this > pragma with the IWYU comment-pragma (I wonder why they didn't just go with > `#pragma IWYU ...`?). Is it reasonabl

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

cebowleratibm added a comment. The decision was made to make -mlong-double-128 an error on AIX: https://reviews.llvm.org/D106074 [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX. So I think your patch is ready to land. LGTM. Repository: rG LLVM Github

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103872/new/ https://reviews.llvm.org/D103872 ___

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 ___

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 ___

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103871/new/ https://reviews.llvm.org/D103871 ___

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 ___

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. The newly added test case clang/test/Index/preamble-reparse-changed-module.m is failing on the patch that I'm trying to commit, https://reviews.llvm.org/D93769 Actually the result of the test is a bit flaky, when I build the Debug version on Linux, running ninja check-c

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. craig.topper wrote: > hjl.tool

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:857 +if (BR.isInteresting(ArgSVal)) + OS << Msg; + })); Szelethus wrote: > steakhal wrote: > > Ah, there is a slight issue. >

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 360514. ychen marked an inline comment as done. ychen added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Sema/S

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added inline comments. Comment at: clang/test/Sema/i-c-e.c:77-78 + // expected-warning {{expression result unused}} +int comma3[(1, 2)]; // expected-warning {{variable length array folded to constant array as an extension}} \ + /

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360517. tstellar marked 3 inline comments as done. tstellar added a comment. Address some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: c

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} MaskRay wrote: > What does this do? > > A hard-coded list cannot catch up with the real

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. cstdlib test header contains // amdgcn already provides definition of fabs #ifndef __AMDGCN__ float fabs(float __x) { return __builtin_fabs(__x); } #endif If I delete or invert the ifndef > $HOME/llvm-build/llvm/lib/clang/13.0.0/include/__clang_hip_cmath

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 360519. cjdb added a comment. - renames files - makes it possible for `#pragma GCC system_header` to come after includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} tstellar wrote: > MaskRay wrote: > > What does this do? > > > > A hard-coded list cannot

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} MaskRay wrote: > tstellar wrote: > > MaskRay wrote: > > > What does this do? > > > > > >

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360524. SaurabhJha added a comment. Updated docs to address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/MatrixTypes.rst Index: c

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: aaron.ballman. mibintc added a comment. @aaron.ballman suggested I may have made a mistake adding the new option, I'll look there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 360535. ZarkoCA added a comment. - Fix comment to also describe what happens in 32bit mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ cfe-commits mailing lis

  1   2   >