[PATCH] D105926: [PowerPC] Extra test case for LDARX

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:1 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +;

[PATCH] D105926: [PowerPC] Extra test case for LDARX

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-check-ldarx-opt.ll:149 + +attributes #0 = { noinline nounwind optnone uwtable "frame-pointer"="all" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "tar

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

kito-cheng updated this revision to Diff 358494. kito-cheng added a comment. Changes: - Update testcase again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105091/new/ https://reviews.llvm.org/D105091 Files: clang/lib/Driver/ToolChains/RISCVTo

[clang] 40ce58d - Revert "[clang] Refactor AST printing tests to share more infrastructure"

Author: David Green Date: 2021-07-14T04:40:47+01:00 New Revision: 40ce58d0ca10a1195da82895749b67f30f000243 URL: https://github.com/llvm/llvm-project/commit/40ce58d0ca10a1195da82895749b67f30f000243 DIFF: https://github.com/llvm/llvm-project/commit/40ce58d0ca10a1195da82895749b67f30f000243.diff L

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

jdoerfert updated this revision to Diff 358502. jdoerfert added a comment. Fix lifetime problem, update one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105937/new/ https://reviews.llvm.org/D105937 Files: clang/include/clang/Sema/Sema

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2288 +} + } morehouse wrote: > This is for Objective C? I don't think we care about Objective C. I will remove this. Comment at: clang/lib/CodeGen/CodeGenModu

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

necipfazil updated this revision to Diff 358505. necipfazil added a comment. Several review comments are addressed - Don't emit type metadata for Objective-C - Don't emit metadata for function definitions, which leads to duplicates - Improve the test case - Add C struct parameter test - Fix v

[PATCH] D105939: [OpenMP] Add IDs to OpenMP remarks

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105939/new/ https://reviews.llvm.org/D105939 ___

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} balazske wrote: > balazske wrote: > > NoQ wrot

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added subscribers: ributzka, mgorny. arphaman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This patch is a pre-commit for https://reviews.llvm.

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman updated this revision to Diff 358510. arphaman added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958 Files: clang/include/clang/Basic/DarwinSDKInfo.h clang/lib/Basic/DarwinSDKInfo.cpp clang/lib/Driver/ToolCha

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman updated this revision to Diff 358511. arphaman marked 11 inline comments as done. arphaman added a comment. Split patch and address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105257/new/ https://reviews.llvm.org/D105257 Files: clang/include/clang/Basic/Dia

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman added inline comments. Comment at: clang/include/clang/Basic/DarwinSDKInfo.h:129 + static Optional + parseDarwinSDKSettingsJSON(StringRef FilePath, const llvm::json::Object *Obj); + dexonsmith wrote: > Should this take the VFS? No, the Filepath is not

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman added a comment. In D105257#2853438 , @dexonsmith wrote: > Could the DarwinSDKInfo changes be tested directly with C++ unit tests? Since > this stuff is in Basic it'd be nice to test it separately from the driver. If > so, maybe they could als

[PATCH] D105958: [clang][darwin] add support for version remapping to the Darwin SDK Info class

arphaman added a comment. This patch depends on a small NFC commit that moves DarwinSDKInfo over to lib/Basic from lib/Driver, which isn't up on phabricator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105958/new/ https://reviews.llvm.org/D105958

[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. This patch is the last patch in the series of patches for the Mac Catalyst support in clang. It adds dri

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2966 +// other TUs will not know whether the initialization routine exists +// so create a weak, empty, init function to satisfy the linker. +// This is needed whenever a thr

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; What's the purpose of this?

[clang] 5635d2a - [RISCV] Pass -u to linker correctly.

Author: Kito Cheng Date: 2021-07-14T14:25:02+08:00 New Revision: 5635d2a56dab6dc64d3a3f185d68f676b81dc736 URL: https://github.com/llvm/llvm-project/commit/5635d2a56dab6dc64d3a3f185d68f676b81dc736 DIFF: https://github.com/llvm/llvm-project/commit/5635d2a56dab6dc64d3a3f185d68f676b81dc736.diff LO

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5635d2a56dab: [RISCV] Pass -u to linker correctly. (authored by Kito Cheng ). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka added a comment. In D105726#2875482 , @kstoimenov wrote: > Modified UsersManual.rst and added a test. Couldn't find a relevant section in > AddressSanitizer.rst and adding a new one is outside of the scope of this > change. something like: L

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. In D105457#2875672 , @dblaikie wrote: > In D105457#2874783 , @nridge wrote: > >> To be honest, I don't really understand this error. It seems to come from a >> compile step (not a link step

<    1   2   3