[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. For the purposes of not checking a style we are not going to use and because I guess it might make clang-format startup, ever so slightly faster, I think its a reasonable change that likely does no harm. Repository: rG LL

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

pengfei created this revision. pengfei added reviewers: craig.topper, RKSimon, spatel, LiuChen3, FreddyYe, yubing, LuoYuanke. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. E

[clang-tools-extra] 0e2d4bd - [clangd] Fix gRPC build due to missing include path

Author: Sam McCall Date: 2021-07-01T09:33:29+02:00 New Revision: 0e2d4bd4bfa516977d027ece8597fc8dd1f3c656 URL: https://github.com/llvm/llvm-project/commit/0e2d4bd4bfa516977d027ece8597fc8dd1f3c656 DIFF: https://github.com/llvm/llvm-project/commit/0e2d4bd4bfa516977d027ece8597fc8dd1f3c656.diff LO

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355792. pmatos added a comment. Unconditionally set Wasm layout string to include non-integral AS 10 and 20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: c

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -: "e-m:e-p:32:32-i64:64-n32:64-S128

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355793. pmatos added a comment. Remove FIXME comment on data layout strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebAssembl

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

tschuett added a comment. Could you add a link to a reference? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/ https://reviews.llvm.org/D105263 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added a comment. In D105263#2852295 , @tschuett wrote: > Could you add a link to a reference? Done. Thanks for reminding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/ https://reviews.

[clang] 788a5d4 - PoC for Flang Driver Plugins

Author: Stuart Ellis Date: 2021-07-01T08:10:40Z New Revision: 788a5d4afe6407e647454a9832a7b4a27fba06bf URL: https://github.com/llvm/llvm-project/commit/788a5d4afe6407e647454a9832a7b4a27fba06bf DIFF: https://github.com/llvm/llvm-project/commit/788a5d4afe6407e647454a9832a7b4a27fba06bf.diff LOG:

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] c1f068b - [flang] Revert "PoC for Flang Driver Plugins"

Author: Andrzej Warzynski Date: 2021-07-01T08:27:31Z New Revision: c1f068b8f1d5f6ca75acc07fdedf2e7416e834ec URL: https://github.com/llvm/llvm-project/commit/c1f068b8f1d5f6ca75acc07fdedf2e7416e834ec DIFF: https://github.com/llvm/llvm-project/commit/c1f068b8f1d5f6ca75acc07fdedf2e7416e834ec.diff

[clang] aa454dd - [analyzer] LValueToRValueBitCasts should evaluate to an r-value

Author: Balazs Benics Date: 2021-07-01T10:54:22+02:00 New Revision: aa454dda2eed4e71081bc57b1f32dfce2486b177 URL: https://github.com/llvm/llvm-project/commit/aa454dda2eed4e71081bc57b1f32dfce2486b177 DIFF: https://github.com/llvm/llvm-project/commit/aa454dda2eed4e71081bc57b1f32dfce2486b177.diff

[clang] 55662b2 - [analyzer][NFC] Inline ExprEngine::handleLVectorSplat()

Author: Balazs Benics Date: 2021-07-01T10:54:28+02:00 New Revision: 55662b24a4755680e4fd34dc22a3dd555fdb1291 URL: https://github.com/llvm/llvm-project/commit/55662b24a4755680e4fd34dc22a3dd555fdb1291 DIFF: https://github.com/llvm/llvm-project/commit/55662b24a4755680e4fd34dc22a3dd555fdb1291.diff

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa454dda2eed: [analyzer] LValueToRValueBitCasts should evaluate to an r-value (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/ne

[PATCH] D105125: [analyzer][NFC] Inline ExprEngine::handleLVectorSplat()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG55662b24a475: [analyzer][NFC] Inline ExprEngine::handleLVectorSplat() (authored

[PATCH] D105125: [analyzer][NFC] Inline ExprEngine::handleLVectorSplat()

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:523 } +LLVM_FALLTHROUGH; // Various C++ casts that are not handled yet. steakhal wrote: > NoQ wrote: > > Dunno, is this the intended formatting for fal

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

NoQ added a comment. Let's simplify this even further! Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:419-421 + const CheckerNameRef CheckerName; + SymbolRef StreamSym; + const ExplodedNode *NotePosition; I guess it's a matter of preference

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

krasimir added a comment. I'm unfamiliar with the altivec API. What's a reasonable source code update that preserves the current default behavior `-altivec-src-compat=mixed` under `-altivec-src-compat=xl`, i.e., under `-altivec-src-compat=xl` how would we compare vector bool or vector pixel to

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9937106b717: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D105014: added some example code for llvm::Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd8f979fe48c: added some example code for llvm::Expected (authored by kuhnel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d2d5a3a6d7a: [clang] Apply P1825 as Defect Report from C++11 up to C++20. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/

[PATCH] D105254: [RISCV] Support machine constraint "S"

luismarques added a comment. Makes sense. Let's wait for the GCC Bugzilla feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/D105254 ___ cfe-commits mailing list

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

MyDeveloperDay updated this revision to Diff 355817. MyDeveloperDay added a comment. Move Peek next token into a function, add a comment for clarity CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105087/new/ https://reviews.llvm.org/D105087 Files: clang/lib/Format/UnwrappedLineParser

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1019 +FormatToken *NextNext = Tokens->getNextToken(); +Tokens->setPosition(StoredPosition); +if (NextNext && NextNex

[clang] f993710 - [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

Author: mydeveloperday Date: 2021-07-01T10:46:43+01:00 New Revision: f9937106b7171eb1f4f8914e29c2be0c36ebc46d URL: https://github.com/llvm/llvm-project/commit/f9937106b7171eb1f4f8914e29c2be0c36ebc46d DIFF: https://github.com/llvm/llvm-project/commit/f9937106b7171eb1f4f8914e29c2be0c36ebc46d.diff

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 355825. manas added a comment. Reformat comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp cla

[clang] 7d2d5a3 - [clang] Apply P1825 as Defect Report from C++11 up to C++20.

Author: Matheus Izvekov Date: 2021-07-01T12:10:06+02:00 New Revision: 7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 URL: https://github.com/llvm/llvm-project/commit/7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08 DIFF: https://github.com/llvm/llvm-project/commit/7d2d5a3a6d7aaa40468c30250bf6b0938ef02c08.dif

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 355827. chh added a comment. with clang-format suggested change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-extra/clang-tidy/ClangTidyDiagnos

[PATCH] D105273: [analyzer] Introduce range-based reasoning for subtraction operator

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang. Her

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 355830. pmatos added a comment. Make the linter happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104797/new/ https://reviews.llvm.org/D104797 Files: clang/lib/Basic/Targets/WebAssembly.h clang/test/CodeG

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DarwinSDKInfo.h:40 +llvm::Triple::EnvironmentType ToEnv) +: Value(((uint64_t(FromOS) * uint64_t(llvm::Triple::LastOSType) + + uint64_t(FromEnv)) ---

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

mprobst accepted this revision. mprobst added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1001 + if (TokenPosition < AllTokens.size()) { +FormatToken *PeekNext = AllTokens[TokenPosition]; +return PeekNext; nit: just `return AllT

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

pdhaliwal added a comment. Should the name of file be changed as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D105221 ___ cfe-commits mailing list cfe-commits@

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a comment. Yeah, it probably should be. I should also check the blame list for the file to see who else should be on the reviewer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://reviews.llvm.org/D10522

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. Thanks, this looks much closer. Customizing the MatchFinder::matchAST() to set the scope is a neat try but I don't think the design really fits (and we have to abuse inheritance to make it work). Ultimately you need to customize both near `HandleTranslationUnit` and n

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

aaron.ballman added inline comments. Comment at: clang/lib/AST/OSLog.cpp:212 + } else if (Lit->isUTF16()) { +std::wstring_convert, char16_t> Convert; +std::u16string U16 = Lit->getStringAsChar16(); MarcusJohnson91 wrote: > aaron.ballman wrote: > > cor3nt

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added a comment. In D98710#2852645 , @sammccall wrote: >> I reproduced the ClangdTests::TargetDeclTest.Concept failure locally without >> this change, > > I'll have a look, can't reproduce it locally. Have you seen it on any > buildbots? I can

[PATCH] D97187: [Clang][Sema] Warn when function argument is less aligned than parameter

probinson added a comment. Looks like this caused PR49534 (https://bugs.llvm.org/show_bug.cgi?id=49534) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97187/new/ https://reviews.llvm.org/D97187 ___ cfe-co

[clang] 314e456 - [clang] Fix CallExpr dependence bit may not respect all its arguments.

Author: Haojian Wu Date: 2021-07-01T14:40:03+02:00 New Revision: 314e456dfe85f8b5c53b85a7d815f7d463fe02ef URL: https://github.com/llvm/llvm-project/commit/314e456dfe85f8b5c53b85a7d815f7d463fe02ef DIFF: https://github.com/llvm/llvm-project/commit/314e456dfe85f8b5c53b85a7d815f7d463fe02ef.diff LO

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor added a comment. Looks pretty much like a revert of https://reviews.llvm.org/D90415 which was necessary to allow building with `-x cuda -fopenmp`. Won't this break that again? I fear there's no test covering that case and I either wasn't sure where to add such a test.. (also `-x hip -

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

hokein closed this revision. hokein marked an inline comment as done. hokein added a comment. committed in 314e456dfe85f8b5c53b85a7d815f7d463fe02ef . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

MyDeveloperDay updated this revision to Diff 355848. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Updating based on revision comments, but found that the indentation can be incorrec

[PATCH] D97187: [Clang][Sema] Warn when function argument is less aligned than parameter

tmatheson added a comment. I believe PR49534 was fixed by D98548 above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97187/new/ https://reviews.llvm.org/D97187 ___ cfe-c

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a comment. That's interesting. I don't see how there is a semantic change here - _openmp is defined already and the builtins file ignores the cuda define - but I also haven't tried openmp+cuda in combination. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov updated this revision to Diff 355853. azabaznov added a comment. Addressed latest review comments, also refactored the patch by putting diagnostics into OpenCLOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://revi

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355861. cor3ntin added a comment. Mark the feature completion as partial as this PR does not fix explicit(bool) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h:69 +if (AS == WasmAddressSpace::EXTERNREF) + return MVT::externref; +else if (AS == WasmAddressSpace::FUNCREF) tlively wrote: > It might be worth a commen

[PATCH] D103401: [OpenCL] Add support of __opencl_c_generic_address_space feature macro

azabaznov updated this revision to Diff 355873. azabaznov added a comment. Added FIXME. Alternatively, we could add this language option only in `::adjust` if there is still a worry about multiple places of definitions. Btw, there will some more language options which dependent on target setting

[PATCH] D105285: [Clang] Add test dependency on llvm-ar

saiislam created this revision. saiislam added reviewers: rsmith, jdoerfert, yaxunl. Herald added a subscriber: mgorny. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following clang driver tests invoke llvm-ar, so ensure that che

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. Hm, my fix doesn't work either :/ https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8842935257512920928/+/u/package_clang/stdout?format=raw -c /opt/s/w/ir/cache/builder/src/third_party/llvm/clang-tools-extra/clangd/xpc/XPCTransport.cpp I

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. @rsmith, Thanks for pointing out this issue. I have proposed a fix in D105285 . Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 __

[clang-tools-extra] 2f79acb - [clangd] Unbreak mac build differently 0c96a92d8666b8

Author: Nico Weber Date: 2021-07-01T10:51:27-04:00 New Revision: 2f79acb7b701c41494abff588b5f03a74ea2e11d URL: https://github.com/llvm/llvm-project/commit/2f79acb7b701c41494abff588b5f03a74ea2e11d DIFF: https://github.com/llvm/llvm-project/commit/2f79acb7b701c41494abff588b5f03a74ea2e11d.diff LO

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. Tried again in 2f79acb7b701c41494abff588b5f03a74ea2e11d . If someone wants to figure out how to make xpc see Features.inc in the cmake build, that'd work too. Repository: rG LLVM Github Monorepo CH

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. A user reported an issue to me via email that Clang was accepting some code that GCC was rejecting. After investigation, it turne

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

erichkeane added a comment. I guess I don't see how this patch 'works' here. I don't see anything preventing the type-location in C, but not C++? Comment at: clang/test/Sema/attr-c2x.c:14 -void foo(void *c) [[clang::overloadable]]; -void foo(char *c) [[clang::overloadable]]

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 355884. azabaznov added a comment. Fixed latest comment about checking for `== 300`. Btw, there already exists a few places where `>= 300` is checked. Should fix them as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman added a comment. > I guess I don't see how this patch 'works' here. I don't see anything > preventing the type-location in C, but not C++? See comments in the code, I left one where the interesting bit is. Comment at: clang/lib/Sema/SemaType.cpp:8091 + // A

[PATCH] D104915: [OpenCL] Add support of __opencl_c_read_write_images feature macro

azabaznov updated this revision to Diff 355890. azabaznov added a comment. Fixed naming of new methods, fixed comments, removed redundant comments from source file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104915/new/ https://reviews.llvm.org/

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman updated this revision to Diff 355893. aaron.ballman added a comment. Added a test that `overloadable` should fail when in the type position. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105287/new/ https://reviews.llvm.org/D105287 Files: clang/include/clang/Basic/Attri

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

fodinabor requested changes to this revision. fodinabor added a comment. This revision now requires changes to proceed. citing from https://reviews.llvm.org/rG7f1e6fcff9427adfa8efa3bfeeeac801da788b87: > Due to recent changes we cannot use OpenMP in CUDA files anymore (PR45533) as > the math hand

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:419-421 + const CheckerNameRef CheckerName; + SymbolRef StreamSym; + const ExplodedNode *NotePosition; NoQ wrote: > I guess it's a matter of preference but I really

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

tra added inline comments. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:21-24 -__device__ int v1; - -// DEV-NEG-NOT: @v2 -__constant__ int v2; These should be changed to positive checks to verify that they are emitted. Ditto for other tests. =

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492

[clang] bc7cc20 - Fix an accepts-invalid issue with [[]] attributes in the type position in C

Author: Aaron Ballman Date: 2021-07-01T12:41:18-04:00 New Revision: bc7cc2074b7b7043e05cb46346f1368eb4ae9949 URL: https://github.com/llvm/llvm-project/commit/bc7cc2074b7b7043e05cb46346f1368eb4ae9949 DIFF: https://github.com/llvm/llvm-project/commit/bc7cc2074b7b7043e05cb46346f1368eb4ae9949.diff

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review, Erich! I've committed in bc7cc2074b7b7043e05cb46346f1368eb4ae9949 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105287/new/ h

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s MaskRay wrote: > Just place

[PATCH] D105295: [CUDA] Only allow NVIDIA offload-arch during CUDA compilation.

tra created this revision. tra added a reviewer: yaxunl. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. Otherwise, if someone specifies a valid AMD arch, we may end up triggering an assertion on unexpected arch later on. Current tests didn'

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea updated this revision to Diff 355908. labrinea retitled this revision from "[Clang] Inline assembly support for the ACLE type 'data512_t'." to "[Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.". labrinea edited the summary of this revision. labrinea added a reviewe

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

dexonsmith added a comment. Could the DarwinSDKInfo changes be tested directly with C++ unit tests? Since this stuff is in Basic it'd be nice to test it separately from the driver. If so, maybe they could also mostly land in a separate prep commit (except the update to `clang::parseDarwinSDKInf

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

dexonsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:70 + if (!SDKInfo) +llvm::handleAllErrors(SDKInfo.takeError(), + [](const llvm::ErrorInfoBase &) { If you're not looking at the error payload, maybe yo

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Changed the we handle llvm::Constants in sizes arrays. ConstExprs

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov added a comment. In D104381#2838902 , @NoQ wrote: > I bisected. This bug was fixed intentionally by D85817 > , forgot to close I guess. Wow! Nice! It seems that we've duplicated the test file. I think we sh

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 355958. jdoerfert added a comment. Rebase, only look for __kmpc_target_init in AAExecutionDomain as that will isolate the initial thread. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://rev

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jhuber6 added inline comments. Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:29-31 #include "llvm/IR/IntrinsicsAMDGPU.h" #include "llvm/IR/IntrinsicsNVPTX.h" #include "llvm/IR/PatternMatch.h" Not needed now. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: clang/lib/Headers/avx512fp16intrin.h:51 + +static __inline__ __m256h __DEFAULT_FN_ATTRS256 _mm256_undefined_ph() { + return (__m256h)__builtin_ia32_undef256(); I think this should be `_mm256_undefined_ph(void)`

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Thanks! Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64

[clang] e386871 - [clang-repl] Allow passing in code as positional arguments.

Author: Vassil Vassilev Date: 2021-07-01T19:57:21Z New Revision: e386871e1d21cf206a1287356e88c5853563fc77 URL: https://github.com/llvm/llvm-project/commit/e386871e1d21cf206a1287356e88c5853563fc77 DIFF: https://github.com/llvm/llvm-project/commit/e386871e1d21cf206a1287356e88c5853563fc77.diff LO

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. v.g.vassilev marked 2 inline comments as done. Closed by commit rGe386871e1d21: [clang-repl] Allow passing in code as positional arguments. (authored by v.g.vassilev).

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:90 + if (!OptInputs.size()) { +llvm::LineEditor LE("clang-repl"); sgraenitz wrote: > `OptInputs.empty()` ? Good point. Thanks! Repository: rG LLVM Github Monorepo CHA

[PATCH] D105127: Implement P1401R5

mizvekov added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:202 +static_assert(constexprNotBool, "message"); // expected-error {{value of type 'const NotBool' is not contextually convertible to 'bool'}} \ No newline at end of file Missing n

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:29 std::string ABI, CPU; - bool HasM = false; - bool HasA = false; - bool HasF = false; - bool HasD = false; - bool HasC = false; - bool HasB = false; - bool HasV = false; - bool HasZba = f

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:644 + "invalid extension prefix '%s'", + Ext.str().c_str()); +} craig.topper wrote: > does createStringError really r

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:122 StringRef CodeModel = getTargetOpts().CodeModel; + unsigned FLEN = ISAInfo.getFLEN(); if (CodeModel == "default") Capitalise these as FLen and XLen everywhere ===

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev updated this revision to Diff 356015. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104918/new/ https://reviews.llvm.org/D104918 Files: clang/include/clang/AST/ASTContex

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:690-691 + + /// The translation unit is a partial translation unit, growing incrementally. + TU_Partial }; rsmith wrote: > I don't think this is clear enough about the dif

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 356022. cor3ntin added a comment. Missing EOL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inclu

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

fodinabor created this revision. fodinabor added reviewers: jdoerfert, tra. Herald added subscribers: guansong, yaxunl. fodinabor requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This adds a very basic test in `cuda_with_openmp.cu`

[PATCH] D105322: [NFC][OpenMP][CUDA] Add test for using `-x cuda -fopenmp`

fodinabor updated this revision to Diff 356043. fodinabor added a comment. Cleanup left over commented out code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105322/new/ https://reviews.llvm.org/D105322 Files: clang/test/Headers/Inputs/include/

[clang] 9ab5f76 - Support for merging UsingPackDecls across modules.

Author: Richard Smith Date: 2021-07-01T18:43:49-07:00 New Revision: 9ab5f761176c376c0a117c53f0f111fed1bcc842 URL: https://github.com/llvm/llvm-project/commit/9ab5f761176c376c0a117c53f0f111fed1bcc842 DIFF: https://github.com/llvm/llvm-project/commit/9ab5f761176c376c0a117c53f0f111fed1bcc842.diff

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

bnbarham created this revision. bnbarham added reviewers: akyrtzi, arphaman. Herald added a subscriber: mgorny. bnbarham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was possible to re-add a module to a shared in-memory module cache w

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. I am a little busy this week. I would try to look into this next week if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 ___

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei created this revision. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105331 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Sema/DeclSpec.cpp clang/

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/avx512fp16-complex.c:1 +// RUN: %clang_cc1 %s -O0 -fno-experimental-new-pass-manager -emit-llvm -triple x86_64-unknown-unknown -target-feature +avx512fp16 -o - | FileCheck %s --check-prefix=X86 +

[clang-tools-extra] 86c5afa - [clangd] Fix XPC build due to missing include path

Author: Sam McCall Date: 2021-07-02T08:47:46+02:00 New Revision: 86c5afa6e601c4a80d46a7a8b892d5c49bcec078 URL: https://github.com/llvm/llvm-project/commit/86c5afa6e601c4a80d46a7a8b892d5c49bcec078 DIFF: https://github.com/llvm/llvm-project/commit/86c5afa6e601c4a80d46a7a8b892d5c49bcec078.diff LO

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 356110. balazske marked an inline comment as done. balazske added a comment. Not using `auto` declarations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: