[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 __

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

kbobyrev added a comment. Do you need help landing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

sberg added a comment. In D99005#2843201 , @mizvekov wrote: > I have talked to the MSVC STL maintainers. They would be open to a pull > request for fixing this. > The repo can be found at https://github.com/microsoft/STL > Be my guest if you want to submi

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : gentle ping ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 354801. pdhaliwal marked 2 inline comments as done. pdhaliwal added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 Files: c

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:29 +#else #define __DEVICE__ static __device__ inline __attribute__((always_inline)) +#endif JonChesterfield wrote: > wonder if HIP would benefit from nothrow here Would like to ke

[clang] a498553 - [clang][ARM] Mark sanitize-coverage-old-pm.c unsupported on armv7l

Author: David Spickett Date: 2021-06-28T08:32:36Z New Revision: a49855316251aaa3cfe62b797b5650ae55b09378 URL: https://github.com/llvm/llvm-project/commit/a49855316251aaa3cfe62b797b5650ae55b09378 DIFF: https://github.com/llvm/llvm-project/commit/a49855316251aaa3cfe62b797b5650ae55b09378.diff LOG

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 354802. pdhaliwal added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Headers/__clang_h

[clang-tools-extra] 499e39c - [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: 499e39c5983dba35861b5482bd298a8da726f1b6 URL: https://github.com/llvm/llvm-project/commit/499e39c5983dba35861b5482bd298a8da726f1b6 DIFF: https://github.com/llvm/llvm-project/commit/499e39c5983dba35861b5482bd298a8da726f1b6.diff LO

[clang-tools-extra] 26d864b - [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: 26d864b44b9d3326984a7041124aa0f9e8ebc5cb URL: https://github.com/llvm/llvm-project/commit/26d864b44b9d3326984a7041124aa0f9e8ebc5cb DIFF: https://github.com/llvm/llvm-project/commit/26d864b44b9d3326984a7041124aa0f9e8ebc5cb.diff LO

[clang-tools-extra] 961e9e6 - [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: 961e9e6af65ef097678c57fe5f1c18b825eb723f URL: https://github.com/llvm/llvm-project/commit/961e9e6af65ef097678c57fe5f1c18b825eb723f DIFF: https://github.com/llvm/llvm-project/commit/961e9e6af65ef097678c57fe5f1c18b825eb723f.diff LO

[clang-tools-extra] e33d047 - [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: e33d0478831e4a295cb136ce1f58587155309fa2 URL: https://github.com/llvm/llvm-project/commit/e33d0478831e4a295cb136ce1f58587155309fa2 DIFF: https://github.com/llvm/llvm-project/commit/e33d0478831e4a295cb136ce1f58587155309fa2.diff LO

[clang-tools-extra] b9ece03 - [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: b9ece034611239d008ac11d8bb9b3af91313c41f URL: https://github.com/llvm/llvm-project/commit/b9ece034611239d008ac11d8bb9b3af91313c41f DIFF: https://github.com/llvm/llvm-project/commit/b9ece034611239d008ac11d8bb9b3af91313c41f.diff LO

[clang-tools-extra] 0fba450 - [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-06-28T10:49:37+02:00 New Revision: 0fba450b9756a496224efd06e5ba76c9a61d3e15 URL: https://github.com/llvm/llvm-project/commit/0fba450b9756a496224efd06e5ba76c9a61d3e15 DIFF: https://github.com/llvm/llvm-project/commit/0fba450b9756a496224efd06e5ba76c9a61d3e15.diff LO

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

This revision was automatically updated to reflect the committed changes. Closed by commit rG499e39c5983d: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG26d864b44b9d: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

This revision was automatically updated to reflect the committed changes. Closed by commit rG961e9e6af65e: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe33d0478831e: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9ece0346112: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fba450b9756: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone… (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

david-arm added a comment. Hi @junparser, the patch looks sensible to me! I just had a couple of minor comments if that's ok. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:658 +return IC.replaceInstUsesWith(II, VScale); + } else if (Pattern >= AArch64

[PATCH] D105005: [analyzer][solver][NFC] Simplify function signatures

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[clang-tools-extra] f3b55a8 - [clang-tidy][NFC] Fix buildbot failures in 'bugprone-easily-swappable-parameters'

Author: Whisperity Date: 2021-06-28T11:19:16+02:00 New Revision: f3b55a8a06529bee95ed9a1b55c98ce3839b40ea URL: https://github.com/llvm/llvm-project/commit/f3b55a8a06529bee95ed9a1b55c98ce3839b40ea DIFF: https://github.com/llvm/llvm-project/commit/f3b55a8a06529bee95ed9a1b55c98ce3839b40ea.diff LO

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen updated this revision to Diff 354814. steffenlarsen added a comment. Added comment about variant ordering. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104847/new/ https://reviews.llvm.org/D104847 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/C

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

steffenlarsen marked an inline comment as done. steffenlarsen added a comment. In D104847#2841242 , @tra wrote: > LGTM. Would you like me to land the patch on your behalf? If it isn't to much of a bother. Thank you. 😄 CHANGES SINCE LAST ACTION https:

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked 12 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:408-409 + + bool IsParamContinuouslyConst = + !IsParamReference || ParamType.getNonReferenceType().isConstQu

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:694-695 + + for (std::size_t I = 0, E = CalleeFuncDecl->getNumParams(); I != E; ++I) { +if (const auto *Param

[clang] 6f3b775 - [Analyzer][solver] Add dump methods for (dis)equality classes.

Author: Gabor Marton Date: 2021-06-28T12:57:14+02:00 New Revision: 6f3b775c3e9c685f74ecbe2ce1a94af52cc17c2f URL: https://github.com/llvm/llvm-project/commit/6f3b775c3e9c685f74ecbe2ce1a94af52cc17c2f DIFF: https://github.com/llvm/llvm-project/commit/6f3b775c3e9c685f74ecbe2ce1a94af52cc17c2f.diff

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f3b775c3e9c: [Analyzer][solver] Add dump methods for (dis)equality classes. (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/

[PATCH] D105005: [analyzer][solver][NFC] Simplify function signatures

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105005/new/ https://reviews.llvm.org/D105005

[clang] 8474bb1 - [analyzer][solver][NFC] Simplify function signatures

Author: Valeriy Savchenko Date: 2021-06-28T14:20:06+03:00 New Revision: 8474bb13c3270d4195a663013b95e6065075ce56 URL: https://github.com/llvm/llvm-project/commit/8474bb13c3270d4195a663013b95e6065075ce56 DIFF: https://github.com/llvm/llvm-project/commit/8474bb13c3270d4195a663013b95e6065075ce56.d

[PATCH] D105005: [analyzer][solver][NFC] Simplify function signatures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8474bb13c327: [analyzer][solver][NFC] Simplify function signatures (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag updated this revision to Diff 354839. AMDChirag added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 Files: clang/test/OpenMP/master_taskloop_simd_ast_print.cpp clang/test/

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:662 +return IC.replaceInstUsesWith(II, StepVal); + } else if (Pattern == AArch64SVEPredPattern::vl16 && NumElts == 16) { +Constant *StepVal = ConstantInt::get(II.getType()

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354846. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_cnt

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

david-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:671 + case AArch64SVEPredPattern::vl8: +return NumElts >= Pattern + ? Optional(IC.replaceInstUsesWith( I was actually wondering if we could comm

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/40864/step_7.txt Please take a look, and please revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103

[PATCH] D105014: added some example code for llvm::Expected

kuhnel created this revision. kuhnel added a reviewer: sammccall. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. kuhnel requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Since I had some fun

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 354849. kuhnel added a comment. removed stray file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm/include/llvm

[PATCH] D105014: added some example code for llvm::Expected

kuhnel added a comment. Argh, the auto formatter seems to have done some magic. I guess I should revert these? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014

[PATCH] D105014: added some example code for llvm::Expected

kuhnel updated this revision to Diff 354855. kuhnel added a comment. undo of auto formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105014/new/ https://reviews.llvm.org/D105014 Files: llvm/include/llvm/Support/Error.h Index: llvm/includ

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 354856. whisperity marked 2 inline comments as done. whisperity added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Fix comments and code according to comments - Turned `Substring` into a case-insensitive heuristic. - A

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Nope, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

junparser updated this revision to Diff 354857. junparser added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_cnt

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. He

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

darwin marked an inline comment as done. darwin added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1270 !startsExternCBlock(*PreviousLine)) Newlines = 1; MyDeveloperDay wrote: > Nit:I do think at some point we need to hav

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 354867. whisperity added a comment. **NFC** Fix `ReleaseNotes` entry getting out of place during rebases earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20689/new/ https://reviews.llvm.org/D20689 Fil

[clang] 22aa368 - [C++20] Support for lambdas in unevaluated context

Author: Corentin Jabot Date: 2021-06-28T09:01:56-04:00 New Revision: 22aa3680eaccb9b77ca224711c4da3a354aa2d45 URL: https://github.com/llvm/llvm-project/commit/22aa3680eaccb9b77ca224711c4da3a354aa2d45 DIFF: https://github.com/llvm/llvm-project/commit/22aa3680eaccb9b77ca224711c4da3a354aa2d45.diff

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed in 22aa3680eaccb9b77ca224711c4da3a354aa2d45 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D105014: added some example code for llvm::Expected

sammccall added a comment. Yes, please revert the unrelated formatting changes. I agree Error is confusing and better docs might help. (Not as much as removing the confusing part of the design, but I that seems hard at this point!) However I don't think the "hump" you experienced can be avoided

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine added a comment. Following suggestion by @dblaikie and @aaron.ballman I'm preparing a new diff where a function redeclaration that adds `nodebug` is flagged as an error in `Sema::mergeDeclAttributes`. This triggers test failures because of violations in builtin header files, for

[clang] fe0e861 - [Analyzer] Attempt to fix windows bots test failure b/c of new-line

Author: Gabor Marton Date: 2021-06-28T15:41:30+02:00 New Revision: fe0e861a4d9946a3e7de1bc95a3ec12fa602b492 URL: https://github.com/llvm/llvm-project/commit/fe0e861a4d9946a3e7de1bc95a3ec12fa602b492 DIFF: https://github.com/llvm/llvm-project/commit/fe0e861a4d9946a3e7de1bc95a3ec12fa602b492.diff

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. Thanks for the report @thakis ! This seems to be b/c of the different newline handling in windows. I've committed a change that disables the tests on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354882. cor3ntin added a comment. Fix status of P2201 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Thanks. Looks like it flakily fails on mac too every now and then: http://45.33.8.238/mac/33005/step_7.txt Maybe you print something in nondeterministic iteration order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

Quuxplusone added a comment. Shouldn't the "yes/Yes" entries display Clang major version numbers instead? Throughout, "NO" should be "No" (compare to lines 1221 and 1226). Comment at: clang/www/cxx_status.html:1287 + + if consteval + https://wg21.link/P1938R3";>P1

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman added inline comments. Comment at: clang/www/cxx_status.html:1289 + https://wg21.link/P1938R3";>P1938R3 + NO + Same fix applies elsewhere Comment at: clang/www/cxx_status.html:1294 + https://wg21.link/P2156R1";>

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

vsavchenko added a comment. In D103967#2844140 , @thakis wrote: > Thanks. Looks like it flakily fails on mac too every now and then: > http://45.33.8.238/mac/33005/step_7.txt > > Maybe you print something in nondeterministic iteration order? Yes, I thin

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354891. cor3ntin added a comment. Fix cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_status.html ===

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Cool, can we revert this for now then? Flakily failing on my m1 bot too: http://45.33.8.238/macm1/12514/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin updated this revision to Diff 354892. cor3ntin added a comment. Fix status of P2156R1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024 Files: clang/www/cxx_status.html Index: clang/www/cxx_sta

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

catskul abandoned this revision. catskul added a comment. Abandoning because of: https://reviews.llvm.org/D104096 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90238/new/ https://reviews.llvm.org/D90238

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1294 + https://wg21.link/P2156R1";>P2156R1 + Yes + aaron.ballman wrote: > You should find out which version of Clang this support was introduced in and > list the version explici

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ashi1 added a comment. A few small comments, otherwise LGTM on the HIP header side. Comment at: clang/lib/Headers/__clang_hip_cmath.h:30 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static __attribute__((always_inline, nothrow)) +#define __CONSTEXPR__ constexpr ---

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

zahiraam added a comment. This change has made this snippet fail. https://godbolt.org/z/3ehK784hY Pass https://godbolt.org/z/9q48WvsP7 fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

sammccall added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:148 +/// Check if a Decl should be skipped. +std::shared_ptr Filter; }; chh wrote: > sammccall wrote: > > hokein wrote: > > > chh wrote: > > > > sammccall wro

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a comment. In D99005#2844332 , @zahiraam wrote: > This change has made this snippet fail. > https://godbolt.org/z/3ehK784hY Pass > https://godbolt.org/z/9q48WvsP7 fails. Hello! That is expected breakage from the changes proposed in P2266 <

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

zahiraam added a comment. In D99005#2844365 , @mizvekov wrote: > In D99005#2844332 , @zahiraam wrote: > >> This change has made this snippet fail. >> https://godbolt.org/z/3ehK784hY Pass >> https://godbolt.org/z/9q4

[clang] d5402a2 - Revert "[Analyzer][solver] Add dump methods for (dis)equality classes."

Author: Nico Weber Date: 2021-06-28T11:32:57-04:00 New Revision: d5402a2fee5d860e20378f819e200865af3a6113 URL: https://github.com/llvm/llvm-project/commit/d5402a2fee5d860e20378f819e200865af3a6113 DIFF: https://github.com/llvm/llvm-project/commit/d5402a2fee5d860e20378f819e200865af3a6113.diff LO

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. Reverted for now in d5402a2fee5d860e20378f819e200865af3a6113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

thakis added a comment. (here's another flaky failure that was due to this: http://45.33.8.238/mac/33008/step_7.txt ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/ https://reviews.llvm.org/D103967 _

[PATCH] D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0.

AMDChirag added a comment. @kiranchandramohan The tests passed now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93373/new/ https://reviews.llvm.org/D93373 ___ cfe-commits mailing list cfe-commits@lists

Re: [clang] 4a47da2 - [Sema] turns -Wfree-nonheap-object on by default

(ping on this) On Mon, May 10, 2021 at 8:37 AM David Blaikie wrote: > Christopher - had a chance to look into this any further? > > Roman - I'm OK either way on that. I don't think it's the most costly > false positive - not too much code is probably freeing via a reference > (rather than a poin

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal updated this revision to Diff 354913. pdhaliwal marked 2 inline comments as done. pdhaliwal added a comment. - Move __constant__ to openmp_wrappers/cmath - Using push/pop_macro to avoid redefinition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

pdhaliwal added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:30 +#ifdef __OPENMP_AMDGCN__ +#define __DEVICE__ static __attribute__((always_inline, nothrow)) +#define __CONSTEXPR__ constexpr ashi1 wrote: > Does OpenMP not require `__device__`

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D104777#2844077 , @brunodefraine wrote: > That I already encounter this in builtin headers is probably an indication > that the new error will

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 354920. mizvekov added a comment. - Rebase after split. - Add tests which I had forgotten, covering the builtin candidates for the relational operators other than spaceship. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D104777: PR50767: clear non-distinct debuginfo for function with nodebug definition after undecorated declaration

brunodefraine updated this revision to Diff 354922. brunodefraine added a comment. Slightly improved test case (both C and C++). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104777/new/ https://reviews.llvm.org/D104777 Files: clang/lib/CodeGen/

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Some tweaks might edit file typ

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 354924. mizvekov added a comment. - Fix missing period as pointed by rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 Files: clang/include/clang/Basic/Diagn

[clang] c3fe847 - [Clang] Add option to handle behaviour of vector bool/vector pixel.

Author: Stefan Pintilie Date: 2021-06-28T11:16:37-05:00 New Revision: c3fe847f9d90de5a6a76fd1d5f5823ab4719accc URL: https://github.com/llvm/llvm-project/commit/c3fe847f9d90de5a6a76fd1d5f5823ab4719accc DIFF: https://github.com/llvm/llvm-project/commit/c3fe847f9d90de5a6a76fd1d5f5823ab4719accc.dif

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3fe847f9d90: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG - I do think a config knob for this would be nice one day. As discussed offline it would also cover rename, code complete insertion... Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:27 // i -> int -// h -> half +// h -> half (__fp16) +// x -> half (_Float16) This also includes OpenCL half Comment at: clang/test/CodeGen/RISCV/rvv-int

[clang] 2c02b0c - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-28T12:26:53-04:00 New Revision: 2c02b0c3f45414ac6c64583e006a26113c028304 URL: https://github.com/llvm/llvm-project/commit/2c02b0c3f45414ac6c64583e006a26113c028304 DIFF: https://github.com/llvm/llvm-project/commit/2c02b0c3f45414ac6c64583e006a26113c028304.diff

[clang] 4f1238e - [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens

Author: Melanie Blower Date: 2021-06-28T12:26:53-04:00 New Revision: 4f1238e44d803b145997fa984677a6c5cdf1f417 URL: https://github.com/llvm/llvm-project/commit/4f1238e44d803b145997fa984677a6c5cdf1f417 DIFF: https://github.com/llvm/llvm-project/commit/4f1238e44d803b145997fa984677a6c5cdf1f417.diff

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG931e95687d6d: [llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP… (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Mo

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. In D104261#2841356 , @delesley wrote: > since it's restricted to relockable managed locks, I'm not too worried... Not quite, it affects scoped locks with explicit unlock, which was

[clang] 8815ef8 - Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options"

Author: Melanie Blower Date: 2021-06-28T12:42:59-04:00 New Revision: 8815ef823c803e98f328068d1abde255296de9c3 URL: https://github.com/llvm/llvm-project/commit/8815ef823c803e98f328068d1abde255296de9c3 DIFF: https://github.com/llvm/llvm-project/commit/8815ef823c803e98f328068d1abde255296de9c3.diff

[clang] c27e5a2 - Revert "[clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens"

Author: Melanie Blower Date: 2021-06-28T12:42:59-04:00 New Revision: c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70 URL: https://github.com/llvm/llvm-project/commit/c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70 DIFF: https://github.com/llvm/llvm-project/commit/c27e5a2a8e34aaa4c6037498cd8d21df0a8e8e70.diff

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:221-224 +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray, "V4UiUifV4fV4fV4fV4Ui", "nc", "gfx10-insts") +TARGET_BUILTIN(__builtin_amdgcn_image_b

[PATCH] D105039: [clangd] Add a flag to disable formatting of tweak edits

kadircet updated this revision to Diff 354941. kadircet added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105039/new/ https://reviews.llvm.org/D105039 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/c

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 354945. pmatos added a comment. Checks for inttoptr and ptrtoint insts in wasm backend and bails out if necessary. Also addresses @tlively's comments to the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

dmaclach added a comment. Has anything happened with this at all or did it get dropped? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 ___ cfe-commits mailing li

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#2844766 , @dmaclach wrote: > Has anything happened with this at all or did it get dropped? I can work with you and @rjmccall to land a version of this. We can chat offline if you'd like too. Repository: rG LLVM Githu

[clang] 18c3c77 - Add papers adopted by the C++ committee in the June 2021 plenary

Author: Corentin Jabot Date: 2021-06-28T13:45:12-04:00 New Revision: 18c3c7784975700ae463bb461487d46e74324a66 URL: https://github.com/llvm/llvm-project/commit/18c3c7784975700ae463bb461487d46e74324a66 DIFF: https://github.com/llvm/llvm-project/commit/18c3c7784975700ae463bb461487d46e74324a66.diff

  1   2   >