[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:539 +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); + This is incorrect ig. I get warning message : Warning, treated as error: /home/user/llvm-project/c

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); oh just an blank line is needed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); xgupta wrote: > oh just an blank line is needed :) Thanks, fixing this now. Repository: rG L

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were some issues in the patch https://reviews.llvm.org/D104198. I also forgot to address one comment. T

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

SaurabhJha added a comment. This is a light patch that probably does not require a review and I created a patch anyway. Would it be appropriate to get this into main using `arc land` if this is approved? I saw this https://reviews.llvm.org/D78867 which advises against `arc land` but could not

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D104971#2842293 , @SaurabhJha wrote: > This is a light patch that probably does not require a review and I created a > patch anyway. > > Would it

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta added a comment. btw you should use [Docs] or [NFC] for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104971/new/ https://reviews.llvm.org/D104971 ___ cfe-commits mailing list cfe-com

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

SaurabhJha added a comment. In D104971#2842319 , @xgupta wrote: > btw you should use [Docs] or [NFC] tag for this patch. Okay, will follow the linked docs and amend the commit message with [Docs]. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104900/new/ https://reviews.llvm.org/D104900 ___

[clang] c8f3f46 - [Docs] Minor fixes with language extension docs

Author: Saurabh Jha Date: 2021-06-26T10:07:33+01:00 New Revision: c8f3f46c6983b5a87a0a6fc9d9bb476883bee801 URL: https://github.com/llvm/llvm-project/commit/c8f3f46c6983b5a87a0a6fc9d9bb476883bee801 DIFF: https://github.com/llvm/llvm-project/commit/c8f3f46c6983b5a87a0a6fc9d9bb476883bee801.diff L

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f3f46c6983: [Docs] Minor fixes with language extension docs (authored by SaurabhJha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Any comments? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:466 + + clang_analyzer_eval(ptr == ptr); // expected-warning{{TRUE}} + clang_analyzer_eval(ptr > ptr); // expected-warning{{FALSE}} xazax.hun wrote: > RedDocMD wrote: > > xazax.hun w

[clang] 3255db4 - [clang][tests] Specify unwindlib in aix-ld tests

Author: Timm Bäder Date: 2021-06-26T13:09:29+02:00 New Revision: 3255db4919f1b06736f391a0ae670f273c0ba09e URL: https://github.com/llvm/llvm-project/commit/3255db4919f1b06736f391a0ae670f273c0ba09e DIFF: https://github.com/llvm/llvm-project/commit/3255db4919f1b06736f391a0ae670f273c0ba09e.diff LO

[PATCH] D104899: [clang][tests] Specify unwindlib in aix-ld tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG3255db4919f1: [clang][tests] Specify unwindlib in aix-ld tests (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104899/new/ https://revi

[clang] ee3b2c4 - [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

Author: mydeveloperday Date: 2021-06-26T13:29:16+01:00 New Revision: ee3b2c47ce41aeabede85d96e43bee33be73aa2f URL: https://github.com/llvm/llvm-project/commit/ee3b2c47ce41aeabede85d96e43bee33be73aa2f DIFF: https://github.com/llvm/llvm-project/commit/ee3b2c47ce41aeabede85d96e43bee33be73aa2f.diff

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee3b2c47ce41: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in… (authored by MyDeveloperDay). Repository: rG LLVM Gi

[clang] 37c2233 - [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

Author: mydeveloperday Date: 2021-06-26T13:34:07+01:00 New Revision: 37c2233097ac44697b87228d86eef1fce10ea5c1 URL: https://github.com/llvm/llvm-project/commit/37c2233097ac44697b87228d86eef1fce10ea5c1 DIFF: https://github.com/llvm/llvm-project/commit/37c2233097ac44697b87228d86eef1fce10ea5c1.diff

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG37c2233097ac: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D104222?vs=352193&id=354671#toc

[PATCH] D104975: Implement P1949

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds the Unicode 13 data for XID_Start and XID_Continue. The definition of valid identifier is changed in all C++ modes as P1949

[PATCH] D104975: Implement P1949

Quuxplusone added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1462 + static const llvm::sys::UnicodeCharSet XIDStartChars(XIDStartRanges); + return C == '_' || XIDStartChars.contains(C); + } else if (LangOpts.C11) { This is overly inde

[PATCH] D104975: Implement P1949

jfb added a comment. It would be more user friendly to say which character is not allowed in the diagnostic. Do we need to have a backwards compatible flag to preserve the old behavior, or do we believe that nobody will be affected by the change? We should make this choice explicitly and state

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2842425 , @jfb wrote: > It would be more user friendly to say which character is not allowed in the > diagnostic. Agreed > Do we need to have a backwards compatible flag to preserve the old behavior, > or do we bel

[clang] 8b7881a - [clang-format] Add basic support for formatting JSON

Author: mydeveloperday Date: 2021-06-26T15:20:17+01:00 New Revision: 8b7881a084d0bc26499cf93e4ac45b59257a03b3 URL: https://github.com/llvm/llvm-project/commit/8b7881a084d0bc26499cf93e4ac45b59257a03b3 DIFF: https://github.com/llvm/llvm-project/commit/8b7881a084d0bc26499cf93e4ac45b59257a03b3.diff

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b7881a084d0: [clang-format] Add basic support for formatting JSON (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D93528?vs=353570&id=354674#toc Repository: rG LLVM G

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune updated this revision to Diff 354675. aqjune added a comment. Herald added subscribers: llvm-commits, ecnelises, hiraditya. Herald added a project: LLVM. - Update llvm's fast-isels tests for undefined intrinsics to compile freeze(poison) - Update X86ISelLowering's getAVX2GatherNode and get

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune updated this revision to Diff 354678. aqjune added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104790/new/ https://reviews.llvm.org/D104790 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/X86/avx-built

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354679. cor3ntin added a comment. Clang format, cleanup and better diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/Dia

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354681. cor3ntin added a comment. More code format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/l

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune updated this revision to Diff 354682. aqjune added a comment. - Update llvm/test/CodeGen/X86/sse-intrinsics-fast-isel.ll as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104790/new/ https://reviews.llvm.org/D104790 Files: clang/lib/C

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

aqjune added a comment. In D104790#2836463 , @craig.topper wrote: > In D104790#2836253 , @aqjune wrote: > >> I couldn't find end-to-end tests for checking assembly generation. >> To check whether this is working

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354683. cor3ntin added a comment. Improve commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td c

[PATCH] D104975: Implement P1949

cor3ntin updated this revision to Diff 354684. cor3ntin added a comment. Missing EOF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Le

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

nikic added a comment. Is this actually better in any meaningful way? InstCombine will turn `freeze poison` into `zeroinitializer`, and until then this is just a completely opaque value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104790/new/ h

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

darwin added a comment. Sorry I haven't had a chance to look at this bug before it has closed. But I do have question: I observed that this code are formatted incorrectly by the same config: llvm::Optional CurrentCode = None; autoEnv = std::make_unique(Code,

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

bansan created this revision. bansan added a reviewer: clang-tools-extra. bansan added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. bansan requested review of this revision. Herald added a subscriber: cfe-commits. This patch allows the use of --line-filter in clang-tidy.py f

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 354695. RedDocMD added a comment. First try at implementing conversion function from OverloadedOperatorKind to BinaryOperatorKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

darwin updated this revision to Diff 354696. darwin marked an inline comment as done. darwin added a comment. Add new test cases according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D104044 Files: clang/lib/Format/UnwrappedLine

[PATCH] D104984: [clang] add C++ feature test macro for P2266 simpler implicit move

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The feature was implemented in D99005 , but we forgot to add the test macro. Repository: rG LLVM Github Monorepo

[PATCH] D104984: [clang] add C++ feature test macro for P2266 simpler implicit move

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. LGTM. I assume we pick the integer value `202011` for everything C++2b-related until the standard ships with a real value in it, and then we update our integer to match. Repository

[PATCH] D104984: [clang] add C++ feature test macro for P2266 simpler implicit move

mizvekov added a comment. In D104984#2842656 , @Quuxplusone wrote: > LGTM. I assume we pick the integer value `202011` for everything > C++2b-related until the standard ships with a real value in it, and then we > update our integer to match. Yeah tha

[clang] d6144c3 - [clang] add C++ feature test macro for P2266 simpler implicit move

Author: Matheus Izvekov Date: 2021-06-26T23:05:23+02:00 New Revision: d6144c30fb6ae7ac15c82d512f8da7572577c2d2 URL: https://github.com/llvm/llvm-project/commit/d6144c30fb6ae7ac15c82d512f8da7572577c2d2 DIFF: https://github.com/llvm/llvm-project/commit/d6144c30fb6ae7ac15c82d512f8da7572577c2d2.dif

[PATCH] D104984: [clang] add C++ feature test macro for P2266 simpler implicit move

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6144c30fb6a: [clang] add C++ feature test macro for P2266 simpler implicit move (authored by mizvekov). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

dblaikie added a comment. > Admittedly, I focused on changes (of Clang and Polly) like refactoring, > improving comments, minimize difference to upstream (clang-)formatting etc. > during the testing. Yeah, I was more curious about general purpose/average changes, but anyway. > In D104601#28319

[clang] 699d474 - [Driver] do not link _p libs for -pg on FreeBSD 14 and later

Author: Ed Maste Date: 2021-06-26T17:47:54-04:00 New Revision: 699d47472c3f7c5799fe75486689545179cfba03 URL: https://github.com/llvm/llvm-project/commit/699d47472c3f7c5799fe75486689545179cfba03 DIFF: https://github.com/llvm/llvm-project/commit/699d47472c3f7c5799fe75486689545179cfba03.diff LOG:

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG699d47472c3f: [Driver] do not link _p libs for -pg on FreeBSD 14 and later (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov updated this revision to Diff 354715. mizvekov added a comment. Simplify checking first overload reslution result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Bas

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3469 +if (Res == OR_Success || Res == OR_Deleted) { + // Promote "AsRvalue" to the heap, since we now need + // expression node to persist. Looks like you lost a word in this comm

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3478-3481 +// Check that overload resolution selected a conversion operator +// taking an rvalue reference. +if (cast(FD)->getRefQualifier() != RQ_RValue) + break; ---

[clang] 7a11235 - [X86] Correct the conversion of VALIGND/Q intrinsics to shufflevector.

Author: Craig Topper Date: 2021-06-26T19:06:00-07:00 New Revision: 7a112356e4a19c0e63f533548fa95a03a5537fb9 URL: https://github.com/llvm/llvm-project/commit/7a112356e4a19c0e63f533548fa95a03a5537fb9 DIFF: https://github.com/llvm/llvm-project/commit/7a112356e4a19c0e63f533548fa95a03a5537fb9.diff

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

darwin added a comment. And can someone commit it for me? I don't have the right to push it yet. Or let me know how to apply? Thank you very much. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D104044 ___

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks added a comment. In D104900#2842540 , @darwin wrote: > Sorry I haven't had a chance to look at this bug before it has closed. But I > do have a question: > > I observed that this code are formatted incorrectly by the same config: > >

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

HazardyKnusperkeks added a comment. In D104044#2842726 , @darwin wrote: > And can someone commit it for me? I don't have the right to push it yet. Or > let me know how to apply? Thank you very much. https://llvm.org/docs/DeveloperPolicy.html?highlight=c

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

darwin added a comment. In D104044#2842757 , @HazardyKnusperkeks wrote: > In D104044#2842726 , @darwin wrote: > >> And can someone commit it for me? I don't have the right to push it yet. Or >> let me know how t