[clang] d646157 - [analyzer] Fix assertion failure on code with transparent unions

Author: Valeriy Savchenko Date: 2021-06-25T23:09:16+03:00 New Revision: d646157146ccda93cd72dcbaff4a554c61ed9586 URL: https://github.com/llvm/llvm-project/commit/d646157146ccda93cd72dcbaff4a554c61ed9586 DIFF: https://github.com/llvm/llvm-project/commit/d646157146ccda93cd72dcbaff4a554c61ed9586.d

[PATCH] D104716: [analyzer] Fix assertion failure on code with transparent unions

This revision was automatically updated to reflect the committed changes. Closed by commit rGd646157146cc: [analyzer] Fix assertion failure on code with transparent unions (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104716

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:221-224 +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray, "V4UiUifV4fV4fV4fV4Ui", "nc", "gfx10-insts") +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray_h, "V4UiUifV4fV4hV4hV4U

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce02ea8c941: [OpenMP] Add Module metadata for OpenMP compilation (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

mizvekov updated this revision to Diff 354595. mizvekov added a comment. - Make it a regular warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104892/new/ https://reviews.llvm.org/D104892 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. A couple of comments on test coverage but otherwise this looks great, thanks! It'll be instructive to see if people ask for the warning to not be on by default... Comment a

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain created this revision. bcain added a reviewer: kparzysz. Herald added a subscriber: mgorny. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add definitions for Hexagon, Hexagon circular/bit-reverse and HVX intrinsics. Reposito

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

mizvekov updated this revision to Diff 354607. mizvekov added a comment. - Restore tests. - Reimplement fixit in terms of variable template (needs -Wno-c++14-extensions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104892/new/ https://reviews.llv

[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad14b5b008e2: [clang] Stop providing builtin overload candidate for relational function… (authored by mizvekov). Changed prior to commit: https://

[clang] ad14b5b - [clang] Stop providing builtin overload candidate for relational function pointer comparisons

Author: Matheus Izvekov Date: 2021-06-26T00:08:02+02:00 New Revision: ad14b5b008e2f643cb989ec645f12bf26a8659bb URL: https://github.com/llvm/llvm-project/commit/ad14b5b008e2f643cb989ec645f12bf26a8659bb DIFF: https://github.com/llvm/llvm-project/commit/ad14b5b008e2f643cb989ec645f12bf26a8659bb.dif

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu updated this revision to Diff 354615. zequanwu marked an inline comment as done. zequanwu added a comment. Update wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104871/new/ https://reviews.llvm.org/D104871 Files: clang/docs/Clan

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain added a comment. It occurs to me now that some of these are not very useful in the absence of `hexagon_types.h`. So I will add that one too and change the tests to use those definitions instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D103461: [clang][deps] NFC: Preserve the original frontend action

bmahjour added a comment. @jansvoboda11 This change is causing the following LIT tests to fail on AIX: Clang :: ClangScanDeps/headerwithdirname.cpp Clang :: ClangScanDeps/headerwithdirnamefollowedbyinclude.cpp The reason seems to be related to the fact that `-fno-integrated-as` is on by def

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

ahatanak added a comment. I see `assert(DC && "This decl is not contained in a translation unit!");` fail in `Decl::getTranslationUnitDecl` when `DeclRefExpr` is constructed. That's because the `ImplicitParamDecl` passed to `DeclRefExpr`'s constructor doesn't have a decl context if I delete `FD

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:73 + return false; + +// If an operand in the lookup table is not dso_local, pcc wrote: > In the version of the patch that you committed, you have this check

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

dblaikie added a comment. In D104883#2841931 , @ahatanak wrote: > I see `assert(DC && "This decl is not contained in a translation unit!");` > fail in `Decl::getTranslationUnitDecl` when `DeclRefExpr` is constructed. > That's because the `ImplicitParamD

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

tianshilei1992 added a comment. Those changes in OpenMP headers LGTM, except `#define __device__`. Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:93 + +#define __device__ __attribute__((device)) + JonChesterfield wrote: > i thi

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45f6d5522f8d: [DFSan] Change shadow and origin memory layouts to match MSan. (authored by browneee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104896/new

[PATCH] D104899: [clang][tests] Specify unwindlib in aix-ld tests

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104899/new/ https://reviews.llvm.org/D104899 __

[PATCH] D104963: [ODR] Fix using uninitialized FunctionTypeBits.FastTypeQuals in FunctionNoProtoType.

vsapsai created this revision. vsapsai added reviewers: rsmith, riccibruno. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. FastTypeQuals are used only by FunctionProtoType and put in FunctionTypeBitfields in FunctionType to pack with

[PATCH] D104963: [ODR] Fix using uninitialized FunctionTypeBits.FastTypeQuals in FunctionNoProtoType.

vsapsai added a comment. Wasn't actually able to make the test fail because Memory Sanitizer isn't supported on macOS and on Linux I cannot even build clang with MSAN enabled. The test case is reduced from an actual error we've seen internally when clang complaints `Handler` has different defin

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert added a comment. Really looking forward to this! Thanks a lot! I left some comments. Comment at: clang/lib/Headers/__clang_hip_math.h:35 +#ifdef __OPENMP_AMDGCN__ +#define __RETURN_TYPE int +#else JonChesterfield wrote: > I'd expect openmp to match t

<    1   2