[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

curdeius closed this revision. curdeius added a comment. This has been superseded by D103245 . Closing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27651/new/ https://reviews.llvm.org/D27651 ___ cfe-commits

[clang] 72390f0 - DirectoryWatcher-linux.cpp - add missing implicit MathExtras.h header dependency. NFCI.

Author: Simon Pilgrim Date: 2021-06-06T09:40:20+01:00 New Revision: 72390f0c28dddffc53c20ba0ec765b8de4e05383 URL: https://github.com/llvm/llvm-project/commit/72390f0c28dddffc53c20ba0ec765b8de4e05383 DIFF: https://github.com/llvm/llvm-project/commit/72390f0c28dddffc53c20ba0ec765b8de4e05383.diff

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. In D101868#2799563 , @HazardyKnusperkeks wrote: > Remains the issue with the alignment, I would like to know @MyDeveloperDay 's > opinion on that. Should the values be right aligned, or left aligned? As far > as I see al

[PATCH] D103663: [AMDGPU] Add gfx1013 target

bcahoon marked 8 inline comments as done. bcahoon added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:389 - xnack scratch - *pal-amdpal* + ``gfx1013`` ``amdgcn`` dGPU - cumode

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 350103. RedDocMD added a comment. Fixed binding of SVal to variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checkers/SmartP

[clang] d466ca0 - [Clang][OpenMP] Add static version of getSingleClause. NFC.

Author: Michael Kruse Date: 2021-06-06T09:17:42-05:00 New Revision: d466ca087aae958d1c0a965c561be07d2cb3e7e2 URL: https://github.com/llvm/llvm-project/commit/d466ca087aae958d1c0a965c561be07d2cb3e7e2 DIFF: https://github.com/llvm/llvm-project/commit/d466ca087aae958d1c0a965c561be07d2cb3e7e2.diff

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd466ca087aae: [Clang][OpenMP] Add static version of getSingleClause. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. The drawback of the current approach is that we are not using the following piece of information: > std::unique_ptr created from std::make_unique is **not** null (to begin with) I am not being able to use this info since I don't have access to the raw pointer, so cann

[clang] c41a8fb - [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

Author: Michael Kruse Date: 2021-06-06T09:49:46-05:00 New Revision: c41a8fbfbb096995367947e5ef7d36501b04d493 URL: https://github.com/llvm/llvm-project/commit/c41a8fbfbb096995367947e5ef7d36501b04d493 DIFF: https://github.com/llvm/llvm-project/commit/c41a8fbfbb096995367947e5ef7d36501b04d493.diff

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc41a8fbfbb09: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. > I am not being able to use this info since I don't have access to the raw > pointer, so cannot create a `SVal` and then constrain the `SVal` to non-null. > Any suggestions @NoQ, @vsavchenko , @xazax.hun, @teemperor? You can always create a new symbol to represent t

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2801248 , @xazax.hun wrote: > You can always create a new symbol to represent the inner pointer. Something > like this already happens, when you have a unique_ptr formal parameter and > call get on it. The way `hand

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 350109. RedDocMD added a comment. Herald added a reviewer: bollu. Reformatted code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 350110. RedDocMD added a comment. Fixed git history Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. > Since we have CallExpr, we can easily conjure up an SVal. But I don't see how > I can do it similarly in this patch. You should have a `CallExpr` for `std::make_unique` too. I believe that expression is used to determine how the conjured symbol was created (to give

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

zero9178 created this revision. zero9178 added reviewers: rnk, thakis, hans. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using the -fno-rtti option of the GCC style clang++, using typeid results in an error. The MSVC STL

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

zero9178 created this revision. zero9178 added reviewers: rnk, hans, thakis. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch effectively relands https://reviews.llvm.org/D66394, which bac

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

zero9178 updated this revision to Diff 350123. zero9178 added a comment. Rebase & add comment in source code explaining the purpose of the define CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103771/new/ https://reviews.llvm.org/D103771 Files: clang/lib/Driver/ToolChains/MSVC.cpp c

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

zero9178 updated this revision to Diff 350125. zero9178 added a comment. Rebased onto main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103772/new/ https://reviews.llvm.org/D103772 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChai

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 created this revision. zero9178 added reviewers: rnk, thakis, hans, mstorsjo. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the command line options /permissive and /permi

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

thakis added a comment. Some background https://bugs.chromium.org/p/chromium/issues/detail?id=996675 : Back then I thought that MSVC switched to /Zc:twoPhase , but that turned out to not be true. So we never switched the default. I think this patch here still makes sense, but I admit I don't ha

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

thakis added a comment. It was reverted due to build failures, but it didn't reland because it's not the default in cl.exe after all. So we shouldn't make it the default in clang-cl either. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103772/new/ https://reviews.llvm.org/D103772 ___

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

thakis added a comment. I think adding `/permissive-` to make things more conforming is great. The docs say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option implicitly sets the /permissive- option." so maybe we should do that too (doesn't have to be in this patch). Since

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic updated this revision to Diff 350134. asavonic edited the summary of this revision. asavonic added a comment. - Used `llvm::TrackingVH` to track Init changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ https://reviews.llvm.org/D101156 Files: clang/lib/CodeGen/

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4425 + if (ReplaceInitWithGV) +Init = llvm::ConstantExpr::getBitCast(GV, GV->getValueType()); + rjmccall wrote: > Can we actually do this bitcast for arbitrary initializers? Thi

[PATCH] D103777: [X32] Add Triple::isX32(), use it.

hvdijk created this revision. hvdijk added reviewers: MaskRay, craig.topper. Herald added subscribers: dexonsmith, pengfei, hiraditya, dschuff. hvdijk requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. So far, support for x86

[PATCH] D103750: [analyzer][WIP] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. Tests pls! Yes I think you should totally do an `evalCall()` here. The function has no other side effects apart from making a pointer so it's valuable to fully model it so that to avoid unnecessary store invalidations. In D103750#2801320

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

NoQ added a comment. In D98726#2798325 , @RedDocMD wrote: > This is what causes the false suppression. To be more specific, the analyzer > tries to follow the logic of the destructor of unique_ptr into the standard > library. And since that is in the std

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added a comment. In D103605#2800101 , @vsavchenko wrote: >>> Actually, tracker dies when this happens. But hey, can you provide a use >>> case when the checker really needs to know when this happens? >> >> Inlined defensive check suppressions are a

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:81 +if (auto *AT = D->getType()->getContainedAutoType()) { + if (!D->getType()->isDependentType()) { +addInlayHint(D->getLocation(), InlayHintKind::TypeHint, nridge

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Great, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101156/new/ https://reviews.llvm.org/D101156 ___ cfe-commits mailing list c

[PATCH] D103784: [X86] Support __tile_stream_loadd intrinsic for new AMX interface

yubing created this revision. Herald added subscribers: pengfei, hiraditya. yubing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding support for __tile_stream_loadd intrinsic. Repository: rG LLVM Github Monorepo

[PATCH] D103789: [clangd] Type hints for C++14 return type deduction

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Githu