[PATCH] D102936: [CUDA] Work around compatibility issue with libstdc++ 11.1.0

jwakely accepted this revision. jwakely added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102936/new/ https://reviews.llvm.org/D102936 _

[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: ormris. Hi @tra and @yaxunl, I'm commenting as a reviewer of the spack pull request for the rocm 4.2.0 ecosystem. First of all: thanks for caring about spack installations, that's highly appreciated. However, this patch does not seem the right

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 347111. mbenfield added a comment. Move fixes into a separate change https://reviews.llvm.org/D102942. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 Files: clan

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

aprantl added a comment. If gracefully lowering rvalue references to references needs knowledge about the Clang typesystem (or depends on LLVM IR type uniquing to be efficient, as @dblaikie points out) then we should do it in the Clang frontend. As much as we can we should avoid encoding debug

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D100630#2775207 , @aprantl wrote: > If gracefully lowering rvalue references to references needs knowledge about > the Clang typesystem (or dep

[PATCH] D102906: [clang-tidy] Remark was added to clang tooling Diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the nit from @DmitryPolukhin Comment at: clang/include/clang/Tooling/Core/Diagnostic.h:72 +Error = DiagnosticsEngine::Error, +Remark = D

[clang] bf61245 - [HIP] support ThinLTO

Author: Yaxun (Sam) Liu Date: 2021-05-22T10:48:34-04:00 New Revision: bf6124580dfba86b73d828851f03fb9eea1269bd URL: https://github.com/llvm/llvm-project/commit/bf6124580dfba86b73d828851f03fb9eea1269bd DIFF: https://github.com/llvm/llvm-project/commit/bf6124580dfba86b73d828851f03fb9eea1269bd.dif

[PATCH] D99683: [HIP] Support ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6124580dfb: [HIP] support ThinLTO (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D99683?vs=344949&id=347205#toc Repository: rG LLVM Github Mon

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2983 /// \endcode -SBPO_ControlStatementsExceptForEachMacros, +SBPO_ControlStatementsExceptControlMacros, /// Put a space before opening parentheses only if the parentheses

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

davrec accepted this revision. davrec added a comment. Sorry for the delay. Richard should probably weigh in before absolutely committing to 1. BaseUsingDecl/UsingEnumDecl/UsingDecl (as implemented here) vs. single UsingDecl (Nathan's original approach) and 2. Renaming `getUsingDecl()` to `getIn

[PATCH] D102730: [clang-format] Support custom If macros

MyDeveloperDay added a subscriber: krasimir. MyDeveloperDay added a comment. This kind of looks ok to me, I'm not sure about the "lexer" part, I guess I don't know the impact but I'd expect it to be small because it's conditional on your IfMacro I'd like @curdeius or @krasimir to take a look.

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

MyDeveloperDay added a comment. I personally like to keep clang-format and clang-format tests clang formatted all the time so we have a reasonable set of "clang-format-clean" code we can sanity check any change against, the more of LLVM that can be clean the better our testing can be. ==

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. When you made this commit you didn't regenerate the ClangFormatStyleOptions.rst from the Format.h using clang/docs/tool/dump_format_style.py now anyone else using the tool hit issues with code which is incorrect, we need to update Format.h to match what you expec

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

MyDeveloperDay added a comment. Whoops, We forgot to regenerate ClangFormatStyleOptions.rst here following the change to Format.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101344/new/ https://reviews.llvm.org/D101344 _

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 347206. ggeorgakoudis added a comment. Herald added a subscriber: jfb. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOp

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

logan-5 added a comment. Thanks very much; I look forward to any feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102338/new/ https://reviews.llvm.org/D102338 ___ cfe-commits mailing list cfe-comm

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

davrec added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:520-523 + /// Like InstantiatedFromUsingDecl, but for using-enum declarations. Maps + /// from the instantiated using-enum to the templated decl from whence it + /// came. + llvm::DenseMap Instanti

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 347208. feg208 added a comment. This reworks substantially this commit. I recognize there are lacking/broken tests but I just would like to ensure that the general direction doesn't seem likely to end in tears Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 347209. feg208 added a comment. Forgot to alter the documentation to reflect right justified column alignment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files:

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 347211. feg208 added a comment. Adds some tests and fixes a broken test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

davrec added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:520-523 + /// Like InstantiatedFromUsingDecl, but for using-enum declarations. Maps + /// from the instantiated using-enum to the templated decl from whence it + /// came. + llvm::DenseMap Instanti

[clang] b604301 - [Driver] Support libc++ in MSVC

Author: Petr Hosek Date: 2021-05-22T13:32:23-07:00 New Revision: b604301be3559fb85a11779db79fc9bda4b62bce URL: https://github.com/llvm/llvm-project/commit/b604301be3559fb85a11779db79fc9bda4b62bce DIFF: https://github.com/llvm/llvm-project/commit/b604301be3559fb85a11779db79fc9bda4b62bce.diff LO

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb604301be355: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[PATCH] D97340: [HIP] Support Spack packages

haampie reopened this revision. haampie added a comment. This revision is now accepted and ready to land. I've created a pull request to spack here: https://github.com/spack/spack/pull/23859, hopefully that's enough to revert this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 5ff79f0 - Revert "[Driver] Support libc++ in MSVC"

Author: Petr Hosek Date: 2021-05-22T15:49:46-07:00 New Revision: 5ff79f001feb6584e87173348a24f3f317e35984 URL: https://github.com/llvm/llvm-project/commit/5ff79f001feb6584e87173348a24f3f317e35984 DIFF: https://github.com/llvm/llvm-project/commit/5ff79f001feb6584e87173348a24f3f317e35984.diff LO

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mstorsjo created this revision. mstorsjo added reviewers: rnk, mati865. mstorsjo requested review of this revision. Herald added a project: clang. These actually can be automatically imported from another DLL. (This works properly as long as the actual implementation of emutls is linked dynamicall

[PATCH] D102970: [clang] [MinGW] Don't mark emutls variables as DSO local

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. Wow, I haven't expected that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102970/new/ https://reviews.llvm.org/D102970

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102940/new/ https://reviews.llvm.org/D102940 ___

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 _

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

craig.topper added a comment. Isn't the gcc name for this -mno-div? Should we be consistent? Comment at: clang/lib/Basic/Targets/RISCV.cpp:154 + if (DisableHardwareIntDiv) { +Builder.defineMacro("__riscv_no_idiv"); } Does gcc also have this define? Why

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

jrtc27 added a comment. I continue to believe this kind of thing is a bad idea (missing fsqrt for F is another one). M means mul and div, if your hardware lacks div then it's not compliant with the spec. M-mode is free to lie to S-mode and above as to what's supported by the hardware and emulat

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 347230. ggeorgakoudis added a comment. Use non-aggregate captured args and outlining for ordered codegen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files:

[PATCH] D102975: [HIP] Check compatibility of -fgpu-sanitize with offload arch

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. -fgpu-sanitize is incompatible with offload arch containing xnack-. This patch checks that. https://reviews.llvm.org/D102975 File

[PATCH] D102839: [RISCV][Clang] Add -mno-idiv option to disable hardware int division

ksyx added a comment. In D102839#2775732 , @craig.topper wrote: > Isn't the gcc name for this -mno-div? Should we be consistent? I am not sure whether using `-mno-div` might bring in some confusion since from the name `no-div` itself it expresses a sen