[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. Would you mind to add compiler-rt/test/asan which triggers this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 ___ cfe-commits

[clang] 14dfb38 - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-05-17 Thread Arthur Eubanks via cfe-commits
Author: Michael Benfield Date: 2021-05-17T11:02:26-07:00 New Revision: 14dfb3831c425c7f22540a2160424224008c257e URL: https://github.com/llvm/llvm-project/commit/14dfb3831c425c7f22540a2160424224008c257e DIFF: https://github.com/llvm/llvm-project/commit/14dfb3831c425c7f22540a2160424224008c257e.di

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-05-17 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG14dfb3831c42: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable (authored by mbenfield, committed by aeuban

[clang] ebcf030 - [analyzer] Engine: fix crash with SEH __leave keyword

2021-05-17 Thread Balazs Benics via cfe-commits
Author: Abbas Sabra Date: 2021-05-17T20:10:26+02:00 New Revision: ebcf030efc5ef149e423f8fa2ca705b590a129ed URL: https://github.com/llvm/llvm-project/commit/ebcf030efc5ef149e423f8fa2ca705b590a129ed DIFF: https://github.com/llvm/llvm-project/commit/ebcf030efc5ef149e423f8fa2ca705b590a129ed.diff L

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

2021-05-17 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGebcf030efc5e: [analyzer] Engine: fix crash with SEH __leave keyword (authored by AbbasSabra, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

2021-05-17 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: bkramer, martong, NoQ, Szelethus, mikhail.ramalho. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. Herald added

[PATCH] D100919: [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 345949. nickdesaulniers added a comment. - braces, typo fix, add comment about additional approaches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D100919: [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1954 + // than 23760. + // It might be nice to use AArch64::MOVi32imm here, which would get + // expanded in PreSched2

[PATCH] D100919: [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Appreciate the reviews; ++beers_owed; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 ___

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

2021-05-17 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added a comment. We started seeing test failures in our Windows builds in Fuchsia after this patch. FAILED: compiler-rt/lib/hwasan/CMakeFiles/RTHwasanAliases.aarch64.dir/hwasan_interceptors.cpp.o C:\b\s\w\ir\x\w\staging\llvm_build\.\bin\clang++.exe --target=aarch64-unknown-linux-g

[clang] 0f41778 - [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-17T11:49:22-07:00 New Revision: 0f417789192e74f9d2fad0f6aee4efc394257176 URL: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176 DIFF: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176.di

[PATCH] D100919: [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f417789192e: [AArch64] Support customizing stack protector guard (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

2021-05-17 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers abandoned this revision. nickdesaulniers added a comment. I don't plan to land this; I wrote it in case it comes up in code review. llvm's codegen will `report_fatal_error` for garbage sysregs. If it comes up again in the future, this phab review will still exist for reference,

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

2021-05-17 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added a comment. In D102286#2764203 , @gulfem wrote: > We started seeing test failures in our Windows builds in Fuchsia after this > patch. > > FAILED: > compiler-rt/lib/hwasan/CMakeFiles/RTHwasanAliases.aarch64.dir/hwasan_interceptors.cpp.o

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

2021-05-17 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan updated this revision to Diff 345957. urnathan added a comment. rebased onto 3cdd05e519dd , (trying to fix patch 4's precommit failure) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://revie

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559 + // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at +

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

2021-05-17 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan updated this revision to Diff 345959. urnathan edited the summary of this revision. urnathan added a comment. rebased, trying to resolve patch 4's bot fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/B

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

2021-05-17 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan updated this revision to Diff 345960. urnathan added a comment. rebased, trying to resolve bot failure, again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/A

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

2021-05-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { bjope wrote: > e

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

2021-05-17 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. This warning seems to have a lot of false positives on things like reference arguments that are used as output parameters. For example here is a small sample of output from a stage2 build of part of LLVM: In file included from ../llvm/lib/BinaryFormat/Minidump.cpp:9: In

[clang] 3a0b6dc - Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

2021-05-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2021-05-17T12:16:10-07:00 New Revision: 3a0b6dc3e84bb91c0dbd721b1931e4a0ff396142 URL: https://github.com/llvm/llvm-project/commit/3a0b6dc3e84bb91c0dbd721b1931e4a0ff396142 DIFF: https://github.com/llvm/llvm-project/commit/3a0b6dc3e84bb91c0dbd721b1931e4a0ff396142.diff

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. Would you mind to clang-format entire existing compiler-rt/test/scudo/ and than rebase this patch on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 __

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 345967. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) -set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) +set(ALL_SCUDO_STANDALONE_SUPPOR

[PATCH] D102647: [Driver][test] Don't assume integrated-as

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
jsji created this revision. jsji added reviewers: PowerPC, thakis, MaskRay, phosek, hubert.reinterpretcast. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests of fdebug-compilation-dir and -ffile-compilation-dir for `-x assemble

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

2021-05-17 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. You are adding a new global to every translation unit. - Private linkage would not allow them to be merged, this can have significant binary size and RAM overhead. - There is no guarantee that any of these globals will end up to the left of any sanitized globals. With -

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

2021-05-17 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan updated this revision to Diff 345973. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaTemp

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-17 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 345975. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver

[PATCH] D102647: [Driver][test] Don't assume integrated-as

2021-05-17 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Are there any platforms left that don't default to integrated as? Which ones? Is there a tracking bug for switching them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

2021-05-17 Thread Mitch Phillips via Phabricator via cfe-commits
hctim updated this revision to Diff 345977. hctim added a comment. Let's submit the "adding archs" part of the patch first, then land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/l

[PATCH] D102647: [Driver][test] Don't assume integrated-as

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. In D102647#2764376 , @thakis wrote: > Are there any platforms left that don't default to integrated as? Which ones? > Is there a tracking bug for switching them? Thanks! Oh, I should have mentioned that in description, this is expo

[clang] 698568b - [clang CodeGen] Don't crash on large atomic function parameter.

2021-05-17 Thread Eli Friedman via cfe-commits
Author: Eli Friedman Date: 2021-05-17T13:18:23-07:00 New Revision: 698568b74c93ab6d9374adc8bdc6e60fbcf41ff1 URL: https://github.com/llvm/llvm-project/commit/698568b74c93ab6d9374adc8bdc6e60fbcf41ff1 DIFF: https://github.com/llvm/llvm-project/commit/698568b74c93ab6d9374adc8bdc6e60fbcf41ff1.diff

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

2021-05-17 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG698568b74c93: [clang CodeGen] Don't crash on large atomic function parameter. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/ne

[clang] 82b5281 - [Driver][test] Don't assume integrated-as

2021-05-17 Thread Jinsong Ji via cfe-commits
Author: Jinsong Ji Date: 2021-05-17T20:24:21Z New Revision: 82b52812471ca4e7228714aab15110bb740669d0 URL: https://github.com/llvm/llvm-project/commit/82b52812471ca4e7228714aab15110bb740669d0 DIFF: https://github.com/llvm/llvm-project/commit/82b52812471ca4e7228714aab15110bb740669d0.diff LOG: [D

[PATCH] D102647: [Driver][test] Don't assume integrated-as

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG82b52812471c: [Driver][test] Don't assume integrated-as (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102647/new/ https://reviews.llvm.o

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: urnathan. Herald added a subscriber: jfb. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102650 Files: clang/

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
jsji created this revision. jsji added reviewers: PowerPC, dblaikie, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We use `CHECK-LABEL: define` to divide input stream into functions, this works well on most platforms. But t

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

2021-05-17 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added a comment. > Looks like the same issue I fixed in https://reviews.llvm.org/rGd97bab651185. > Let me know if you have the issue after that commit. Thanks, that resolved the build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

2021-05-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-line.cpp:149 -// CHECK-LABEL: define +// CHECK-LABEL: f11 __complex double f11() { Probably flesh that out a bit. Maybe `define{{.*}}f11`? Repository: rG LLVM Github Monorepo CHA

[clang] af5247c - [ADT] Factor out in_place_t and expose in Optional ctor

2021-05-17 Thread Scott Linder via cfe-commits
Author: Scott Linder Date: 2021-05-17T22:25:39Z New Revision: af5247c9347dcf1e30443786bdddf23ca705867a URL: https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a DIFF: https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a.diff LOG:

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

2021-05-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102638/new/ https://reviews.llvm.org/D102638

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

2021-05-17 Thread Scott Linder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5247c9347d: [ADT] Factor out in_place_t and expose in Optional ctor (authored by scott.linder). Changed prior to commit: https://reviews.llvm.or

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

2021-05-17 Thread Mike Rice via Phabricator via cfe-commits
mikerice added a comment. > // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd > -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 Is there a good reason to run this with -O1? Doing so makes it super sensitive to which llvm passes run and now this test fails for

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

2021-05-17 Thread Wei Wang via Phabricator via cfe-commits
weiwang added a comment. In D101793#2760639 , @yaxunl wrote: > I think the root cause might be duplicated decls are added to > Sema::DeclsToCheckForDeferredDiags defined in > > https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Sema/Sema.

[clang] b99e2c5 - [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

2021-05-17 Thread Ben Shi via cfe-commits
Author: Ben Shi Date: 2021-05-18T07:06:12+08:00 New Revision: b99e2c56166a3a74ac9c49512c584d5b158ac9c6 URL: https://github.com/llvm/llvm-project/commit/b99e2c56166a3a74ac9c49512c584d5b158ac9c6 DIFF: https://github.com/llvm/llvm-project/commit/b99e2c56166a3a74ac9c49512c584d5b158ac9c6.diff LOG:

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

2021-05-17 Thread Ben Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2c56166a: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/ne

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

2021-05-17 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 346010. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaTemplate

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
jsji updated this revision to Diff 346011. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102654/new/ https://reviews.llvm.org/D102654 Files: clang/test/CodeGenCXX/debug-info-line.cpp Index: clang/test/Co

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

2021-05-17 Thread Jinsong Ji via Phabricator via cfe-commits
jsji marked an inline comment as done. jsji added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-line.cpp:149 -// CHECK-LABEL: define +// CHECK-LABEL: f11 __complex double f11() { dblaikie wrote: > Probably flesh that out a bit. Maybe `define{{.

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

2021-05-17 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This is a good catch, thank you for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102640/new/ https://reviews.llvm.org/D102640 ___

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

2021-05-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a subscriber: ABataev. jdoerfert added a comment. In D101849#2764703 , @mikerice wrote: >> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >> -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 > > Is there

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

2021-05-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D101849#2764798 , @jdoerfert wrote: > In D101849#2764703 , @mikerice > wrote: > >>> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >>> -emit-llvm %s -o - |

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} The checks for the outlined function are missing? Comment at: clang/test/utils/update_cc_test_chec

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 346030. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Skip duplicates in the line2spell_and_mangled_list as that causes functions to be missed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D102558: [Utils] Check for generated functions inline if possible

2021-05-17 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} ggeorgakoudis wrote: > The checks for the outlined function are missing? Good catch. It turns out functions that showed up

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

2021-05-17 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D96033#2762182 , @v.g.vassilev wrote: > That patch should probably get us to a point where we can mark the test as > `XFAIL: system-aix` I've applied that patch to my 64-bit LLVM build and it does cause the obj

[clang] 9f7d552 - [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

2021-05-17 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2021-05-17T18:41:17-07:00 New Revision: 9f7d552cff8d62250461ef396d9d4ffab4ecd378 URL: https://github.com/llvm/llvm-project/commit/9f7d552cff8d62250461ef396d9d4ffab4ecd378 DIFF: https://github.com/llvm/llvm-project/commit/9f7d552cff8d62250461ef396d9d4ffab4ecd378.diff

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

2021-05-17 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f7d552cff8d: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal (authored by aeubanks). Repository: rG LLVM Github Monorep

[PATCH] D102568: [Driver] Delete -mimplicit-it=

2021-05-17 Thread Khem Raj via Phabricator via cfe-commits
raj.khem accepted this revision. raj.khem added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102568/new/ https://reviews.llvm.org/D102568 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

2021-05-17 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a reviewer: efriedma. benshi001 added a subscriber: efriedma. benshi001 added a comment. @efriedma Could you please help me review this patch? It relates to the one you have reviewed for me, and is also about wrong mangled function name in c++ on AVR. The previous patch has corr

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

2021-05-17 Thread Greg Clayton via Phabricator via cfe-commits
clayborg added inline comments. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:92-93 +#elif defined(__APPLE__) && HAVE_CRASHREPORTER_INFO +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc ___crashreporter_info__, 0

[PATCH] D102663: Bug 49633 - Added warning for static inline global and namespaced declarations for c++17+

2021-05-17 Thread Serberoth via Phabricator via cfe-commits
serberoth created this revision. serberoth added reviewers: erik.pilkington, rsmith, TH3CHARLie, fixing bugs in llvm. serberoth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug 49633 - Added a warning for global and namespace declared v

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

2021-05-17 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D96033#2764946 , @hubert.reinterpretcast wrote: >> If that works on your platform I will happily open a review for the changes. > > From the behaviour observed in the 64-bit build, the 32-bit case might not > fa

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

2021-05-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102654/new/ https://reviews.llvm.org/D102654

[clang] 797ad70 - [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

2021-05-17 Thread Ten Tzen via cfe-commits
Author: Ten Tzen Date: 2021-05-17T22:42:17-07:00 New Revision: 797ad701522988e212495285dade8efac41a24d4 URL: https://github.com/llvm/llvm-project/commit/797ad701522988e212495285dade8efac41a24d4 DIFF: https://github.com/llvm/llvm-project/commit/797ad701522988e212495285dade8efac41a24d4.diff LOG:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

2021-05-17 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie created this revision. OikawaKirie added reviewers: gamesh411, martong, hgabii. OikawaKirie added a project: clang. Herald added subscribers: steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

2021-05-17 Thread Ella Ma via Phabricator via cfe-commits
OikawaKirie abandoned this revision. OikawaKirie added a comment. It seems impossible and not so reasonable to eliminate all white space characters in the USR as mentioned in the test case of revision D102669 . This patch is split to revision D102669

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

2021-05-17 Thread Zhiwei Chen via Phabricator via cfe-commits
condy updated this revision to Diff 346055. condy added a comment. Update as suggected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeG

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

2021-05-17 Thread Zhiwei Chen via Phabricator via cfe-commits
condy marked an inline comment as done. condy added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559 + // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at + // least 32 bytes, optimize when SizeInBytes is

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

2021-05-17 Thread Sergey Dmitriev via Phabricator via cfe-commits
sdmitriev created this revision. sdmitriev added reviewers: ABataev, jdoerfert. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. llvm-objcopy has been

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

2021-05-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 346058. Herald added subscribers: steven_wu, hiraditya. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Frontend/Compi

<    1   2