[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: > Sorry t

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

efriedma added a comment. In D101873#2741903 , @peter.smith wrote: > Looking at the gist I've got one concern for AArch64 and Arm. The ABI relies > on thunks which are only defined for symbols of type STT_FUNC. Changing > branches to STT_FUNC to STT_SE

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sunfish wrote: > tlively wrote: >

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. I'm not sure what better to do that's especially cleaner, except actually just installing i386-fuchsia header subdirs. The easy way to do that would be to just build it all for the

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sbc100 wrote: > sunfish wrote: >

[libunwind] 8408d3f - [libunwind] NFC: Use macros to accommodate differences in representation of PowerPC assemblers

Author: Xing Xue Date: 2021-05-06T14:33:38-04:00 New Revision: 8408d3f2d814b19da450ff162f47981b55a9703a URL: https://github.com/llvm/llvm-project/commit/8408d3f2d814b19da450ff162f47981b55a9703a DIFF: https://github.com/llvm/llvm-project/commit/8408d3f2d814b19da450ff162f47981b55a9703a.diff LOG:

[PATCH] D101873: [clang] Support clang -fpic -fno-semantic-interposition for AArch64

MaskRay added a comment. In D101873#2741903 , @peter.smith wrote: > In D101873#2741299 , @MaskRay wrote: > >> https://gist.github.com/MaskRay/2d4dfcfc897341163f734afb59f689c6 has more >> information about -fno-s

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

phosek created this revision. phosek added reviewers: leonardchan, haowei, mcgrathr, gulfem. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use correct spelling of CMAKE_OSX_DEPLOYMENT_TARGET and b

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 343468. leonardchan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/cmake/c

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 343469. jhuber6 added a comment. Rebasing. The previous change to the test files required massive changes that made the file size too big to upload, so context is limited. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 8cb191b - [Fuchsia][CMake] Update OSX deployment target

Author: Petr Hosek Date: 2021-05-06T12:06:16-07:00 New Revision: 8cb191b724b734a7432a63eb49f54cb9f4333d51 URL: https://github.com/llvm/llvm-project/commit/8cb191b724b734a7432a63eb49f54cb9f4333d51 DIFF: https://github.com/llvm/llvm-project/commit/8cb191b724b734a7432a63eb49f54cb9f4333d51.diff LO

[PATCH] D102013: [Fuchsia][CMake] Update OSX deployment target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb191b724b7: [Fuchsia][CMake] Update OSX deployment target (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101967: [Driver] Use x86-64 libc++ headers with -m32

phosek abandoned this revision. phosek added a comment. After some further discussion, we've decided to generate a `__config_site` in our build only for the specific purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101967/new/ https://review

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma created this revision. efriedma added reviewers: rsmith, ahatanak, rjmccall. Herald added a subscriber: jfb. efriedma requested review of this revision. Herald added a project: clang. I wouldn't recommend writing code like the testcase; a function parameter isn't atomic, so using an atom

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies marked 2 inline comments as done. ffrankies added a comment. @aaron.ballman Thank you! As far as I'm aware, this is the last check that we are planning to submit, so if I do get commit access now it's likely to be unused. However, if that does change, then yes I would be interested in

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added a comment. In D101976#2742188 , @jdoerfert wrote: > In D101976#2742166 , > @JonChesterfield wrote: > >> What are the required semantics of the barrier operations? Amdgcn builds >> them on s

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 343483. jamieschmeiser added a comment. Respond to review comments: add C++ test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/pointer-additio

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits

[PATCH] D102018: [WebAssembly] Use functions instead of macros for const SIMD intrinsics

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To improve hygiene, consisten

[clang] a3a8a1a - [Index] Ignore nullptr decls for indexing

Author: Alex Hoppen Date: 2021-05-06T13:12:26-07:00 New Revision: a3a8a1a15b524d91b5308db68e9d293b34cd88dd URL: https://github.com/llvm/llvm-project/commit/a3a8a1a15b524d91b5308db68e9d293b34cd88dd DIFF: https://github.com/llvm/llvm-project/commit/a3a8a1a15b524d91b5308db68e9d293b34cd88dd.diff L

[PATCH] D102001: [Index] Ignore nullptr decls for indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a8a1a15b52: [Index] Ignore nullptr decls for indexing (authored by ahoppen, committed by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102001/new

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. Looking at `libear/__init__.py`, it's basically replicating CMake build to the point where it even emulates CMake template expansion, see https://github.com/llvm/llvm-project/blob/a3a8a1a15b524d91b5308db68e9d293b34cd88dd/clang/tools/scan-build-py/libear/__init__.py#L204.

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. In D101976#2742788 , @JonChesterfield wrote: > In D101976#2742188 , @jdoerfert > wrote: > >> In D101976#2742166 , >> @JonChesterfield wrote:

[clang-tools-extra] 83af66e - new altera ID dependent backward branch check

Author: Frank Derry Wanye Date: 2021-05-06T17:01:39-04:00 New Revision: 83af66e18e3d3760d56ea7e3bdbff3428ae7730d URL: https://github.com/llvm/llvm-project/commit/83af66e18e3d3760d56ea7e3bdbff3428ae7730d DIFF: https://github.com/llvm/llvm-project/commit/83af66e18e3d3760d56ea7e3bdbff3428ae7730d.d

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

aaron.ballman closed this revision. aaron.ballman added a comment. In D70094#2742760 , @ffrankies wrote: > @aaron.ballman Thank you! As far as I'm aware, this is the last check that we > are planning to submit, so if I do get commit access now it's likely

[clang] d21e1b7 - Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

Author: Aaron Puchert Date: 2021-05-06T23:07:42+02:00 New Revision: d21e1b79ff7d40bca537c30da706e31e48483f21 URL: https://github.com/llvm/llvm-project/commit/d21e1b79ff7d40bca537c30da706e31e48483f21 DIFF: https://github.com/llvm/llvm-project/commit/d21e1b79ff7d40bca537c30da706e31e48483f21.diff

[PATCH] D101755: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21e1b79ff7d: Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's going to become a bit more complicated, so let's have it separate. Repository: rG LLVM G

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to how we allow managed and asserted locks to be held and not held in joining br

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

ogoffart created this revision. ogoffart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit 5baea0560160a693b19022c5d0ba637b6b46b2d8 set the CurCodeDecl because it

[PATCH] D102027: [SEH] Fix regression with SEH in noexpect functions

ogoffart added a comment. As reported in https://reviews.llvm.org/D97687#2741449 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102027/new/ https://reviews.llvm.org/D102027 ___ cfe-commits mailing list cf

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

ogoffart added a comment. Looks like changing CurCodeDecl was not a good idea. Fixed in https://reviews.llvm.org/D102027 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97687/new/ https://reviews.llvm.org/D97687 _

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

davezarzycki added a comment. Yes, Fedora 34 (x86-64). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1279 + if (const GlobalAddressSDNode *GA = dyn_cast(Op)) +return WebAssembly::isManagedAddressSpace(GA->getAddressSpace()); + sunfish wrote: > sbc100 wrote: > >

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 343507. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs/msvc_libcxx_tree/usr/bin/.keep clang/t

[PATCH] D101192: Add support for #elifdef and #elifndef

rsmith added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3254-3265 + Token MacroNameTok; + ReadMacroName(MacroNameTok); + + // Error reading macro name? If so, diagnostic already issued. + if (MacroNameTok.is(tok::eod)) { +// Skip code until we get to #en

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Thank you for your patience :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 __

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 tlively wrote: > sunfish

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_dynamic_shadow.cpp:120 + +void InitShadowGOT() {} + Add comment. Fuchsia never uses dynamic shadow, which is what this sets up in the Linux

[PATCH] D101572: Make `hasTypeLoc` matcher support more node types.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. This looks good to me. I tried running it in clang-query, which crashes with a matcher like m binaryOperator(hasEitherOperand(hasTypeLoc(loc(asString("int") but it also crashes befo

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. These are GCC-compatible multilibs that use the generic Itanium C++ ABI instead of the Fuchsia C++ ABI. Repository: rG LLVM Gith

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") + .flag("+fno-exceptions")); We should prob

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:249-250 + .flag("+fc++-abi=itanium") + .flag("-fexceptions") + .flag("+f

[PATCH] D102030: [clang][Fuchsia] Introduce compat multilibs

leonardchan updated this revision to Diff 343526. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102030/new/ https://reviews.llvm.org/D102030 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test

[clang] c714d03 - [AMDGPU] Expose __builtin_amdgcn_perm for v_perm_b32

Author: Stanislav Mekhanoshin Date: 2021-05-06T16:17:33-07:00 New Revision: c714d037857f9c8e3bbe32e22ec22279121c378d URL: https://github.com/llvm/llvm-project/commit/c714d037857f9c8e3bbe32e22ec22279121c378d DIFF: https://github.com/llvm/llvm-project/commit/c714d037857f9c8e3bbe32e22ec22279121c37

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 updated this revision to Diff 343534. feg208 marked 8 inline comments as done. feg208 added a comment. This addresses most of the review comments. There remain a few tests to add Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ http

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. To answer the question of why I think this is different then other alignment optionsIt seems to me that each alignment option emphasizes a specific thing, be it macros, bitfields, or (maybe closer in spirit) more simple declarations and assignments. I think this case

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. I have a few outstanding questions about additional testing Comment at: clang/unittests/Format/FormatTest.cpp:16371 + Style); +} + HazardyKnusperkeks wrote: > curdeius wrote: > > I think we need more tests: > > * with a com

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 343541. aabbaabb marked 3 inline comments as done. aabbaabb added a comment. Renamed lib to libexec and add custom rules to copy files to build output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 File

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 sunfish wrote: > tlively

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/Utils/WebAssemblyUtilities.h:39 + // pointers are lowered to global.get / global.set or local.get / local.set, + // as appropriate. + WASM_ADDRESS_SPACE_MANAGED = 1 tlively wrote: > sunfish

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added reviewers: RKSimon, craig.topper. TaoPan added a comment. Could you please have a review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 ___ cfe-c

Re: [clang] ed87f51 - [PowerPC] Provide some P8-specific altivec overloads for P7

Sorry about the noise this caused. I somehow managed to look at the wrong log file after running the lit tests prior to committing this. I have since fixed and re-committed this. On Thu, May 6, 2021 at 10:01 AM Nico Weber wrote: > Reverted in 3761b9a2345aff197707d23a68d4a178489f60e4 for now. > >

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. There is a potential hazard here for parallel compilation and to a lesser extent testing. (I have just learned that) kfd imposes a process limit which is low enough that we may see hsa_init fail under multiple processes. @jdoerfert you talked me out of embedding

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added a comment. In D101976#2742919 , @jdoerfert wrote: > So what do you wnat me to change for this patch now? Equivalent change to amdgpu target_impl to the nvptx target_impl, which looks like syncthreads should call a new barrier. Iiu

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield updated this revision to Diff 343557. JonChesterfield added a comment. - rework logic for finding libomptarget.so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101960/new/ https://reviews.llvm.org/D101960 Files: clang/lib/Driver/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. Greg was also interested in having pci ids table in amdgpu-arch. And, keeping this table inside the target/amdgpu directory sounds like a good idea. Overall, I agree with not having dependency on hsa as it has caused many issues. Repository: rG LLVM Github Monorepo

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: openmp/libomptarget/src/rtl.cpp:76 + std::string full_plugin_name; + void *handle = dlopen("libomptarget.so", RTLD_NOW); JonChesterfield wrote: > JonChesterfield wrote: > > This logic is cut from D73657 witho

[clang] 819e0d1 - [CGAtomic] Lift strong requirement for remaining compare_exchange combinations

Author: Bruno Cardoso Lopes Date: 2021-05-06T21:05:20-07:00 New Revision: 819e0d105e84c6081cfcfa0e38fd257b6124553a URL: https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a DIFF: https://github.com/llvm/llvm-project/commit/819e0d105e84c6081cfcfa0e38fd257b6124553a

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1404 + isArrayOfStructuresInit(TheLine)); + if (AlignArrayOfStructuresInit) { +Penalty += AlignedArrayOfStructuresInitLineFormatt

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

rjmccall added a comment. Objective-C object types also have aggregate evaluation kind. Those can only be used as value types in an old, fragile ObjC ABI, but I believe we haven't yet formally decided to remove support for that. Fortunately, however, there's a much better simplification avail

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

pengfei added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s Should we add test under llvm/test? A bit s

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:102 + SmallString<128> SysRootDir; + llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", + getDriver().getTargetTriple()); I a

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343582. OikawaKirie added a comment. - Update the test case as suggested. - Add a case branch for the `index_error_code::success` error code in function `IndexErrorCategory::message` to silent the compiler warnings. CHANGES SINCE LAST ACTION https://r

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

OikawaKirie updated this revision to Diff 343585. OikawaKirie added a comment. Replace `wc -l` with `count`. Sorry for the spam. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101763/new/ https://reviews.llvm.org/D101763 Files: clang/include/clang/CrossTU/CrossTranslationUnit.h cla

[PATCH] D102049: [BareMetal] Ensure that sysroot always comes after library paths

phosek created this revision. phosek added reviewers: abidh, jroelofs. phosek added a project: clang. Herald added a subscriber: ki.stfu. phosek requested review of this revision. Herald added a subscriber: cfe-commits. This addresses an issue introduced in D91559

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan updated this revision to Diff 343589. TaoPan added a comment. Move test from clang/test to llvm/test, remove comma of the last enum item. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101601/new/ https://reviews.llvm.org/D101601 Files: ll

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan marked an inline comment as done. TaoPan added a comment. Thanks Pengfei for your review comments! Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:273-276 +if (TLI->getSchedulingPreference() == Sched::Fast) + return createFastDAGScheduler(IS, OptL

<    1   2