[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/or.ll:1102 +; CHECK-NEXT:[[AND:%.*]] = select i1 [[Y]], i1 [[X]], i1 false +; CHECK-NEXT:[[OR:%.*]] = select i1 [[X_INV]], i1 true, i1 [[AND]] ; CHECK-NEXT:ret i1 [[OR]] nikic

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. Decls in Sema::DeclsToCheckForDeferredDiags is supposed to be unique. Therefore the fact that '1,734,387,685 out of 1,734,404,000 elements are the same' is surprising. Did this happen when you compile the source code and write AST? What language was the source code? C++,

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/or.ll:1135 ; CHECK-NEXT:ret i1 [[OR]] ; %x = icmp sge i16 %a, %b This can be salvaged as well: https://alive2.llvm.org/ce/z/yXF96T But I think there are more patterns that are m

[PATCH] D101788: [AST] AnyCall: Implement arguments().

NoQ added inline comments. Comment at: clang/include/clang/Analysis/AnyCall.h:170 + return {ME->getArgs(), ME->getNumArgs()}; +} else if (const auto *CE = dyn_cast(E)) { + return {CE->getArgs(), CE->getNumArgs()}; xazax.hun wrote: > As far as I reme

[clang] 2669aba - [clang][CodeGen] Use llvm::stable_sort for multi version resolver options

Author: Alex Lorenz Date: 2021-05-03T20:07:00-07:00 New Revision: 2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 URL: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3 DIFF: https://github.com/llvm/llvm-project/commit/2669abaecfc47d4d2436559ab8c1fb49ad6e35c3.diff L

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Abpostelnicu added a comment. I'm seeing here something very strange, if the user provided copy assignment operator is provided but is = delete and the copy constructor is default this warning will still trigger. Is this something expected? I'm referring at this

[PATCH] D101797: [NewPM] Hide pass manager debug logging behind -debug-pass-manager-verbose

ychen added a comment. Looks like the precheck failures are real. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101797/new/ https://reviews.llvm.org/D101797 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D101813: [Driver] Move -print-runtime-dir and -print-resource-dir tests

phosek created this revision. phosek added a reviewer: MaskRay. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Put these into a separate files to match other -print-* options tests. Repository: rG LLVM Github Monorepo https://r

[PATCH] D96215: [clang-tidy] Aliasing: Add support for lambda captures.

njames93 added a comment. In D96215#2550227 , @NoQ wrote: > Umm, looks like we're both missing the elephant in the room: passing a > variable into a function by reference. > > int &hidden_reference(int &x) { > return x; > } > > void test_hidd

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. > I've already run into having to update these two golden file tests twice I think you can just reduce the tests. No need to revert the entire change, unless there is a replacement for it (D101797 is not) Repository: rG LLVM Gith

[PATCH] D101816: [clangd] don't rename if the triggering loc is not actually being renamed.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. See context: https://github.com/clangd/c

<    1   2   3