[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 updated this revision to Diff 341784. DNS320 added a comment. Renamed the IsInsideMatchedForStmt() function according to a comment from the build system. Changed a data type to "auto" according to a comment from Eugene.Zelenko. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] c81ec19 - Fix -fdebug-pass-structure test case

Author: Evgeny Leviant Date: 2021-04-30T10:18:23+03:00 New Revision: c81ec19fba27ec308607aac2e44234eee8e190d1 URL: https://github.com/llvm/llvm-project/commit/c81ec19fba27ec308607aac2e44234eee8e190d1 DIFF: https://github.com/llvm/llvm-project/commit/c81ec19fba27ec308607aac2e44234eee8e190d1.diff

[PATCH] D99599: [NewPM] Add an option to dump pass structure

evgeny777 added a comment. Should be fixed with `c81ec19fba27ec` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99599/new/ https://reviews.llvm.org/D99599 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo requested changes to this revision. h-joo added a comment. This revision now requires changes to proceed. In D101515#2726889 , @krasimir wrote: > @h-joo , seems we had a comment race :D cheers! :D Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thanks for including the references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101595/new/ https://reviews.llvm.org/

[PATCH] D99599: [NewPM] Add an option to dump pass structure

phosek added a comment. In D99599#2728092 , @evgeny777 wrote: > Should be fixed with `c81ec19fba27ec` Thank you, our builders went green after that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9959

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan created this revision. Herald added subscribers: ecnelises, hiraditya. TaoPan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Scheduler can be registered through static RegisterScheduler if the host cpp file is link

[PATCH] D101606: [ARM] vcreateq lane ordering for big endian

tmatheson created this revision. Herald added subscribers: danielkiss, dmgreen, kristof.beyls. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use of bitcast resulted in lanes being swapped for vcreateq with big endian. Fix this b

[PATCH] D101606: [ARM] vcreateq lane ordering for big endian

MarkMurrayARM added a comment. Not sure yet. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // Surely there is a p

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:413 + /// different heuristics may be used in the future (e.g. sysroot paths). + bool inDefaultLibrary(SourceLocation Loc) const { +if (!Loc.isValid()) you can mak

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen added a comment. Sounds good to me. Whilst we are here, are any of the other uses of bitcast in arm_mve.td potentially a problem? I took a quick look and because they both converting the inputs and the outputs, I believe they will be OK. (Two wrongs make a right, if you will). =

[PATCH] D101516: Introduce clangd-server-monitor tool

kadircet added a comment. thanks for doing this! can we also have a lit test? we already have some tests spinning up an index-server, i suppose we can make an extra rpc to those and ensure we get a success response? Comment at: clang-tools-extra/clangd/index/remote/monitor/CM

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

MarkMurrayARM added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // dmgreen wrote: > MarkMurrayAR

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:436 + if (HB.inDefaultLibrary(D->getLocation())) +return HighlightingModifier::DefaultLibrary; const DeclContext *DC = D->getDeclContext(); kadircet wrote: > I

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. This code snippets confused me before: coro.alloc.align: ; preds = %coro.check.align %mask = sub i64 %11, 1 %intptr = ptrtoint i8* %call to i64 %over_boundary = add i64 %intptr, %mask %inverted_mask = xor i64 %mask, -1

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst marked 9 inline comments as done. mprobst added a comment. PTAL, addressed review comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:191 +!(FirstNonImportLine->First->is(tok::comment) && + FirstNonImportLine->First->TokenText.trim() == "//

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341814. mprobst marked 4 inline comments as done. mprobst added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341815. mprobst added a comment. - test for avoiding merges Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format/SortJavaScriptImports.cpp clan

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst marked an inline comment as done. mprobst added a comment. added test for merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 ___ cfe-commits mailin

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:66 // CHECK-NEXT:[[TMP1:%.*]] = insertelement <2 x i64> [[TMP0]], i64 [[B:%.*]], i64 1 // CHECK-NEXT:ret <2 x i64> [[TMP1]] // MarkMurrayARM wrote: > dmgreen wr

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

bader abandoned this revision. bader added a comment. Herald added a subscriber: ldrumm. Committed alternative version - https://reviews.llvm.org/D89909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80932/new/ https://reviews.llvm.org/D80932

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341818. tmatheson edited the summary of this revision. tmatheson added a comment. Use update_cc_test_checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606 Files:

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/admin.c:86 // CHECK-LABEL: @test_vcreateq_s64( // CHECK-NEXT: entry: You have to remove the old checks - the script isn't very good at that. What would probably be even better

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

martong planned changes to this revision. martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:836-837 + NewState, NewNode, + C.getNoteTag([Msg](PathSensitiveBugRep

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341819. tmatheson added a comment. remove old check lines that were not automatically removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606 Files: clang/include

[PATCH] D101611: [clangd][NFC] Remove unnecessary string captures in lambdas.

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Due to a somewhat ann

[PATCH] D101515: clang-format: [JS] handle "off" in imports

h-joo accepted this revision. h-joo added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 __

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson updated this revision to Diff 341823. tmatheson added a comment. Use --check-prefixes=CHECK,CHECK-BE etc to combine common blocks. Sorry for the churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D10

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the updates. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://reviews.llvm.org/D101606

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

tmatheson marked 2 inline comments as done. tmatheson added a comment. In D101606#2728320 , @dmgreen wrote: > Sounds good to me. > > Whilst we are here, are any of the other uses of bitcast in arm_mve.td > potentially a problem? I took a quick look and b

[clang] 109bf25 - [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML

Author: Keith Walker Date: 2021-04-30T11:03:15+01:00 New Revision: 109bf25e2c425ea5dd20836f25176cf9d9479016 URL: https://github.com/llvm/llvm-project/commit/109bf25e2c425ea5dd20836f25176cf9d9479016 DIFF: https://github.com/llvm/llvm-project/commit/109bf25e2c425ea5dd20836f25176cf9d9479016.diff

[PATCH] D101532: [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML

This revision was automatically updated to reflect the committed changes. Closed by commit rG109bf25e2c42: [AArch64] Change __ARM_FEATURE_FP16FML macro name to __ARM_FEATURE_FP16_FML (authored by keith.walker.arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D101611: [clangd][NFC] Remove unnecessary string captures in lambdas.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101611/new/ https://reviews.llvm.org/D101611

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

olestrohm updated this revision to Diff 341831. olestrohm added a comment. Fixed merge error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101168/new/ https://reviews.llvm.org/D101168 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/OpenCLExtensions.def clang/li

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. > The refactoring adding `Triple` to `MCContext::MCContext` [...] should be > separate. In order to make the `MCContext` construction independent from the `MCObjectFileInfo`, passing the `Triple` to the `MCContext` is necessary anyway. Moving it completely to the `MCC

[PATCH] D69498: IR: Invert convergent attribute handling

JonChesterfield added a comment. I wonder if it is necessary for the exec mask to be implicit state, managed by a convergent/divergent abstraction. We could reify it as an argument passed to kernels (where all bits are set), and adjusted by phi nodes at entry to basic blocks. Various intrinsics

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia updated this revision to Diff 341833. Anastasia added a comment. - Added a pedantic warning about use of double even if the extension is in disabled state wrt pragma. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100980/new/ https://reviews.llvm.org/D100980 Files: clang/in

[PATCH] D101515: clang-format: [JS] handle "off" in imports

krasimir accepted this revision. krasimir added inline comments. Comment at: clang/lib/Format/SortJavaScriptImports.cpp:257 +// references per group. +auto *Start = References.begin(); +SmallVector ReferencesSorted; please fix lint warning on line 257

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia updated this revision to Diff 341835. Anastasia added a comment. Test all image types as identifiers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 Files: clang/include/clang/Basic/OpenCLImageTypes.def clang/lib/Parse/ParseDecl.

[PATCH] D101614: [clang-tidy][NFC] Simplify a lot of bugprone-sizeof-expression matchers

njames93 created this revision. njames93 added reviewers: steveire, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. There should be a follow up to this for changing t

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia updated this revision to Diff 341842. Anastasia added a comment. Improved negative testing for `cl_khr_gl_msaa_sharing` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100983/new/ https://reviews.llvm.org/D100983 Files: clang/include/clang/Basic/OpenCLImageTypes.def clang/l

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101549/new/ https://reviews.llvm.org/D101549

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

olestrohm updated this revision to Diff 341844. olestrohm added a comment. Fixed formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101519/new/ https://reviews.llvm.org/D101519 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCast.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D101566: Let -Wweak-template-vtables warn on implicit instantiations

aaronpuchert updated this revision to Diff 341845. aaronpuchert added a comment. - Fix punctuation in expected warning message. - Fix test failure: the instantiated class might not be a template, it could also be the member of another template. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101168/new/ https://reviews.llvm.org/D101168 ___ cfe-commits mailing lis

[clang] 76f84e7 - [Doc] Fix sphinx warnings about wrong code-block format

Author: Alexey Bader Date: 2021-04-30T11:40:10+03:00 New Revision: 76f84e772978a3daef33df5bea7da676a0163f28 URL: https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28 DIFF: https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28.diff

[PATCH] D101549: [Doc] Fix sphynx warnings about wrong code-block format

This revision was automatically updated to reflect the committed changes. Closed by commit rG76f84e772978: [Doc] Fix sphinx warnings about wrong code-block format (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101549/new/ https:/

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. In D69498#2728451 , @JonChesterfield wrote: > I wonder if it is necessary for the exec mask to be implicit state, managed > by a convergent/divergent abstraction. > > We could reify it as an argument passed to kernels (where all

[PATCH] D101515: clang-format: [JS] handle "off" in imports

mprobst updated this revision to Diff 341849. mprobst added a comment. - review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101515/new/ https://reviews.llvm.org/D101515 Files: clang/lib/Format/SortJavaScriptImports.cpp clang/unittes

[clang] b2780cd - clang-format: [JS] handle "off" in imports

Author: Martin Probst Date: 2021-04-30T14:18:52+02:00 New Revision: b2780cd744eaad6f5c7f39165054cf7000a1ff07 URL: https://github.com/llvm/llvm-project/commit/b2780cd744eaad6f5c7f39165054cf7000a1ff07 DIFF: https://github.com/llvm/llvm-project/commit/b2780cd744eaad6f5c7f39165054cf7000a1ff07.diff

[PATCH] D101515: clang-format: [JS] handle "off" in imports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2780cd744ea: clang-format: [JS] handle "off" in imports (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D101616: [clangd] Fix data type of WorkDoneProgressReport::percentage

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. According to the s

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Provide more useful warning locations and diagnostic

[PATCH] D101611: [clangd][NFC] Remove unnecessary string captures in lambdas.

This revision was automatically updated to reflect the committed changes. Closed by commit rG681503708594: [clangd][NFC] Remove unnecessary string captures in lambdas. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101611/new/

[clang-tools-extra] 6815037 - [clangd][NFC] Remove unnecessary string captures in lambdas.

Author: Nathan James Date: 2021-04-30T13:27:24+01:00 New Revision: 6815037085945be8bb758c23b1a5daabe0a8667d URL: https://github.com/llvm/llvm-project/commit/6815037085945be8bb758c23b1a5daabe0a8667d DIFF: https://github.com/llvm/llvm-project/commit/6815037085945be8bb758c23b1a5daabe0a8667d.diff

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 341853. serge-sans-paille marked 10 inline comments as done. serge-sans-paille added a comment. Take into account latest reviews CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/inclu

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann added a comment. Friendly ping, any feedback would be appreciated :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100972/new/ https://reviews.llvm.org/D100972 ___ cfe-commits mailing list cfe-

[PATCH] D99432: [OPENMP]Fix PR48851: the locals are not globalized in SPMD mode.

ABataev added a comment. In D99432#2726997 , @estewart08 wrote: > In D99432#2726845 , @ABataev wrote: > >> In D99432#2726588 , @estewart08 >> wrote: >> >>> In D99432#2726391

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { aqjune wrote: > nikic wrote: > > spatel wrote:

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 341863. fhahn added a comment. Thanks everyone! I rebased the patch and addressed John's comments. I'll commit it shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:796 + bool EmitBoolCondBranch = !C || !C->isOne(); + bool CondIsConst = C; const SourceRange &R = S.getSourceRange(); rjmccall wrote: > fhahn wrote:

[clang] b14a6f0 - [ARM][MVE] vcreateq lane ordering for big endian

Author: Tomas Matheson Date: 2021-04-30T13:48:05+01:00 New Revision: b14a6f06cc8763830a25023edf5b9ccee18e426a URL: https://github.com/llvm/llvm-project/commit/b14a6f06cc8763830a25023edf5b9ccee18e426a DIFF: https://github.com/llvm/llvm-project/commit/b14a6f06cc8763830a25023edf5b9ccee18e426a.diff

[PATCH] D101606: [ARM][MVE] vcreateq lane ordering for big endian

This revision was automatically updated to reflect the committed changes. Closed by commit rGb14a6f06cc87: [ARM][MVE] vcreateq lane ordering for big endian (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101606/new/ https://re

[PATCH] D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a formatting nit. Thanks, this is more clear than a set of booleans. Comment at: clang/lib/Analysis/ThreadSafety.cpp:138 + bool declared() con

[PATCH] D101202: Thread safety analysis: Fix false negative on break

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for explaining the test cases, that helped (and I agree that the drive-by test changes look sensible to me). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

wingo updated this revision to Diff 341868. wingo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang datalayout expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new/ https://reviews.ll

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

Anastasia added a subscriber: rjmccall. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2352 + if (SrcType == DestType || + (Self.LangOpts.OpenCL && + Self.Context.removeAddrSpaceQualType(SrcType) == I am thinking of whether w

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c3129549374: [clang] Refactor mustprogress handling, add it to all loops in c++11+. (authored by fhahn). Repository: rG LLVM Github Monorepo CHA

[clang] 6c31295 - [clang] Refactor mustprogress handling, add it to all loops in c++11+.

Author: Florian Hahn Date: 2021-04-30T14:13:47+01:00 New Revision: 6c3129549374c0e81e28fd0a21e96f8087b63a78 URL: https://github.com/llvm/llvm-project/commit/6c3129549374c0e81e28fd0a21e96f8087b63a78 DIFF: https://github.com/llvm/llvm-project/commit/6c3129549374c0e81e28fd0a21e96f8087b63a78.diff

[PATCH] D101624: [clang-tidy] Make performance-inefficient-vector-operation work on members

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/PR50157 Adds sup

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:489 B == LangAS::opencl_global_host)) || + (A == LangAS::sycl_global && (B == LangAS::sycl_global_device || +

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2495 break; // ::= "SY" [ "global" | "local" | "private" ] case LangAS::sycl_global: Can you also update this comment? Repository: rG LLVM Github Monorep

[PATCH] D101617: [clang-tidy] Tweak diag ranges for bugprone-sizeof-expression

njames93 updated this revision to Diff 341883. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Fix clangd test cases failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101617/new/ https://reviews.llvm.org/D101

[clang] 3ec82e5 - [OpenCL] Prevent adding vendor extensions for all targets

Author: Anastasia Stulova Date: 2021-04-30T14:42:51+01:00 New Revision: 3ec82e519513b231bb0e8dd5e098c4c5a51501a2 URL: https://github.com/llvm/llvm-project/commit/3ec82e519513b231bb0e8dd5e098c4c5a51501a2 DIFF: https://github.com/llvm/llvm-project/commit/3ec82e519513b231bb0e8dd5e098c4c5a51501a2.d

[PATCH] D92244: [OpenCL] Prevent adding vendor extensions for all targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ec82e519513: [OpenCL] Prevent adding vendor extensions for all targets (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang. Changed prior to commit: https://review

[PATCH] D101628: [Format] Don't sort includes if DisableFormat is true

njames93 created this revision. njames93 added a reviewer: MyDeveloperDay. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://llvm.org/PR35099. I'm not sure if this decision was intentional but its definitely confusing

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:413 + /// different heuristics may be used in the future (e.g. sysroot paths). + bool inDefaultLibrary(SourceLocation Loc) const { +if (!Loc.isValid()) kadircet wr

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

bjope added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:765 +R = StateMgr.getStoreManager().castRegion(ER, CastTy); +return loc::MemRegionVal(R); + } This caused some problems with assertion failures, see https

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. When clang compiles a HIP program with -E, there are multiple output files for host and different GPU archs. Clang uses clang-offload-bundler to bundle them as one output file. Currently clang do

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 marked an inline comment as done. DNS320 added a comment. In D100092#2726808 , @steveire wrote: > I implemented something like this recently too. The code I was trying to > refactor was something like > > auto ii = 0; > for (ii = 0; ii < thing

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:436 + if (HB.inDefaultLibrary(D->getLocation())) +return HighlightingModifier::DefaultLibrary; const DeclContext *DC = D->getDeclContext(); dgoldman wrote: > sa

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 341898. adamcz added a comment. typeof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp clang/t

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:131-133 + "invalid argument '-mno-amdgpu-ieee' only allowed with floating point options " + "which do not honor NaNs, e.g. '-fno-honor-nans', '

[PATCH] D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee

yaxunl updated this revision to Diff 341900. yaxunl marked an inline comment as done. yaxunl added a comment. revised by Matt's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77013/new/ https://reviews.llvm.org/D77013 Files: clang/include/clang/Basic/CodeGenOptions.def clan

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

vabridgers created this revision. vabridgers added reviewers: ASDenysPetrov, NoQ, steakhal, martong, vsavchenko. Herald added subscribers: dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this rev

[clang] fbfcfdb - [clang] Fix assert() crash when checking undeduced arg alignment

Author: Adam Czachorowski Date: 2021-04-30T16:24:33+02:00 New Revision: fbfcfdbf6828b8d36f4ec0ff5f4eac11fb1411a5 URL: https://github.com/llvm/llvm-project/commit/fbfcfdbf6828b8d36f4ec0ff5f4eac11fb1411a5 DIFF: https://github.com/llvm/llvm-project/commit/fbfcfdbf6828b8d36f4ec0ff5f4eac11fb1411a5.d

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbfcfdbf6828: [clang] Fix assert() crash when checking undeduced arg alignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc created this revision. mibintc added reviewers: kbsmith1, erichkeane. mibintc added a project: clang-c. Herald added subscribers: dexonsmith, dang, Anastasia. mibintc requested review of this revision. Herald added a project: clang. The Intel C++ and Fortran compilers support the option -

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. @erichkeane Can you suggest reviewers for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 ___ cfe-commits mailing list cfe-

[PATCH] D101641: [Sema] Preserve invalid CXXCtorInitializers using RecoveryExpr in initializer

sammccall created this revision. sammccall added a reviewer: hokein. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, CXXCtorInitializers that don't typecheck get discarded in most cases. In particular: - typos

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 341922. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-

[PATCH] D101519: [C++4OpenCL] Fix reinterpret_cast of vectors and types with address spaces

olestrohm added inline comments. Comment at: clang/test/SemaOpenCLCXX/reinterpret-cast.clcpp:1 +// RUN: %clang_cc1 %s -pedantic -verify -fsyntax-only + Anastasia wrote: > Btw I assume your patch also allows reinterpret_cast between vectors? What > happens if we

[PATCH] D101516: Introduce clangd-server-monitor tool

kbobyrev updated this revision to Diff 341925. kbobyrev added a comment. Inline gRPC deadline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101516/new/ https://reviews.llvm.org/D101516 Files: clang-tools-extra/clangd/index/remote/CMakeLists.txt

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

jdoerfert added a comment. I assume clang tests apply here. It replaces clang functionality after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101503/new/ https://reviews.llvm.org/D101503 ___ cfe-c

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. This is now approved and passing CI, and I have also normalized the quoting @compnerd asked about (in I hope a satisfactory way). Should I be pinging someone to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions

Meinersbur added a comment. In D101503#2729385 , @jdoerfert wrote: > I assume clang tests apply here. It replaces clang functionality after all. The policy so far was to have LLVM functionality tested in LLVM itself. See https://reviews.llvm.org/D91470#

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. @vabridgers Thank you for a good catch! The fix looks fairly reasonable for me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1016

[PATCH] D100092: [clang-tidy] cppcoreguidelines-declare-loop-variable-in-the-initializer: a new check

DNS320 updated this revision to Diff 341929. DNS320 added a comment. Removed a link to the ES.26 C++ Core Guideline in the documentation part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100092/new/ https://reviews.llvm.org/D100092 Files: clan

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:72 + set(COMPILER_RT_INSTALL_PATH "" CACHE PATH +"Prefix where built compiler-rt artifacts should be installed, comes before CMAKE_INSTALL_PREFIX.") option(COMPILER_RT_INCLUDE_TESTS "Ge

  1   2   >