[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4001 + // probably don't want to allow usage of an ARM ABI on an x86 architecture. + auto SupportedCXXABI = [](const llvm::Triple &T, TargetCXXABI::Kind Kind) { +switch (Kind) {

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 341079. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-

[PATCH] D101425: Make LValuePathEntry a discriminated union

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, varungandhi-apple, Tyker, EricWF, george.burgess.iv, nand. Herald added a subscriber: martong. Herald added a reviewer: shafik. sepavloff requested review of this revision. Herald added a project: clang. APValue::LValue

[PATCH] D101426: [RISCV] Update subset naming convertion for the latest spec

Jim created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D101426: [RISCV] Update subset naming convertion for the latest spec

Jim added a comment. GCC has been updated from https://github.com/gcc-mirror/gcc/commit/ca1a9763a1f635d2687ebd5009dd61d4fd0ab5fb#diff-622e89d94803bb804711d5d492a5d4dfa60399bd7a5a7e70a49155534aa6a81f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101

[PATCH] D101429: PR45879: Use LValue object to evaluate active union members

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff requested review of this revision. Herald added a project: clang. The function HandleUnionActiveMemberChange determined union members that become active by analyzing LHS expression. It works for assignment operator but

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

HsiangKai added a comment. In D99741#2721669 , @craig.topper wrote: > In D99741#2721596 , @thakis wrote: > >> In D99741#2721235 , @craig.topper >> wrote: >> >>> I believe w

[PATCH] D101139: Create install targets for scan-build-py.

phosek added a comment. In D101139#2718112 , @aabbaabb wrote: > In D101139#2718057 , @phosek wrote: > >> In D101139#2713530 , @aabbaabb >> wrote: >> >>> The python script

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:312 + desc("Enable preview of InlayHints feature"), init(false), + Hidden}; + njames93 wrote: > Does it make sense to hide this flag?

[clang] 789549b - [clang-cl] Map /QIntel-jcc-erratum to -mbranches-within-32B-boundaries

Author: Hans Wennborg Date: 2021-04-28T11:10:08+02:00 New Revision: 789549bea441f1347458505307db322aea3ac289 URL: https://github.com/llvm/llvm-project/commit/789549bea441f1347458505307db322aea3ac289 DIFF: https://github.com/llvm/llvm-project/commit/789549bea441f1347458505307db322aea3ac289.diff

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. In D98726#2721228 , @NoQ wrote: >> when the visitor encounters an `ExplodedNode` > > Weird. `finalizeVisitor()` accepts not any node but the error node. Your > screenshot suggests that the error node is not in the standard librar

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, but can you amend the description a bit? > We do not have to both locate the symbol and also query the SymbolID (using > getSymbolInfo). IIRC this isn't really the reason, it's beca

[clang] 2d37f21 - Try to fix clang/test/Driver/cl-options.c on non-x86 hosts

Author: Hans Wennborg Date: 2021-04-28T11:57:09+02:00 New Revision: 2d37f2115d173a2c9117c6dbb4720dc7aefb9f42 URL: https://github.com/llvm/llvm-project/commit/2d37f2115d173a2c9117c6dbb4720dc7aefb9f42 DIFF: https://github.com/llvm/llvm-project/commit/2d37f2115d173a2c9117c6dbb4720dc7aefb9f42.diff

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. In D100980#2719322 , @Anastasia wrote: > In D100980#2719196 , @azabaznov > wrote: > >>> When the pragma is parsed we can't know why it is in the code to be able to >>> issue any warnin

[PATCH] D100983: [OpenCL] Fix optional image types

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Thank you! It looks more consistent now. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateI

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

azabaznov updated this revision to Diff 341119. azabaznov added a comment. Add test for C++ for OpenCL diagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D101087 Files: clang/include/clang/Basic/Diagno

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor`

[clang-tools-extra] 858a958 - [clang-query] Add check to prevent setting srcloc when no introspection is available.

Author: Nathan James Date: 2021-04-28T11:21:35+01:00 New Revision: 858a9583e1fed24aa57e5f2769f4117883264ceb URL: https://github.com/llvm/llvm-project/commit/858a9583e1fed24aa57e5f2769f4117883264ceb DIFF: https://github.com/llvm/llvm-project/commit/858a9583e1fed24aa57e5f2769f4117883264ceb.diff

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

This revision was automatically updated to reflect the committed changes. Closed by commit rG858a9583e1fe: [clang-query] Add check to prevent setting srcloc when no introspection is… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2722112 , @azabaznov wrote: > In D100980#2719322 , @Anastasia > wrote: > >> In D100980#2719196 , @azabaznov >> wrote: >> When

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > Not sure what do we want to achieve with this? Do you want to point out that > the code might be somehow less portable let's say between clang revisions, > etc? My main worry is that you are changing the behaviour here: kernels which fail to compile will compile su

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is a pretty straightforward cleanup now, which adds additional functionality by deferring work to CMake. There are a couple of minor points about inconsistent quoting but this seems

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) compnerd wrote: > Why are these

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 341072. Ericson2314 added a comment. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLists.txt

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26 install(FILES ../assets/index.js - DESTINATION share/clang + DESTINATION "${CMAKE_INSTALL_DATADIR}/clang" COMPONENT clang-doc) Ericson2314 wrote: > compnerd wr

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 341088. Herald added a subscriber: arichardson. Herald added a project: libc++abi. Herald added a reviewer: libc++abi. This revision now requires review to proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D890

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Anastasia accepted this revision. Anastasia added a comment. Cool! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101087/new/ https://reviews.llvm.org/D101087 ___ cfe-commits mailing list cfe-comm

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

hans created this revision. hans added reviewers: thakis, rnk. Herald added a subscriber: dang. hans requested review of this revision. Herald added a project: clang. MSVC has added some new flags. Although they're not supported, this adds parsing support for them so clang-cl doesn't treat them a

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2722207 , @azabaznov wrote: >> Not sure what do we want to achieve with this? Do you want to point out that >> the code might be somehow less portable let's say between clang revisions, >> etc? > > My main worry is

[PATCH] D100742: [clangd] Parameter hints for dependent calls

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/InlayHints.cpp:56 +auto CalleeDecls = Resolver->resolveCalleeOfCallExpr(E); +if (CalleeDecls.empty()) + return tru

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Really sorry about the long delays. Working on clearing my backlog... This seems reasonable to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev added a comment. In D99350#2721724 , @jdoerfert wrote: > The cast was never the problem but the fact that the `$ref` lives in the > global address space while the global value might be in the shared one. > D101030

[PATCH] D100972: [clang-tidy] cppcoreguidelines-avoid-non-const-global-variables: add fixes to checks

mgartmann updated this revision to Diff 341155. mgartmann added a comment. Replaced string comparison to check if a character is a space with `std::isspace()`. Added test case for this scenario. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100972

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 added a comment. Herald added a project: clang-tools-extra. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97955/new/ https://reviews.llvm.org/D97955 ___ cfe-commits mailing list cfe-commit

[clang] c835630 - [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

Author: Alexey Bataev Date: 2021-04-28T05:39:10-07:00 New Revision: c835630c25a4f9925517949579f66a43b113fbc9 URL: https://github.com/llvm/llvm-project/commit/c835630c25a4f9925517949579f66a43b113fbc9 DIFF: https://github.com/llvm/llvm-project/commit/c835630c25a4f9925517949579f66a43b113fbc9.diff

[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc835630c25a4: [OPENMP]Fix PR49098: respect firstprivate of declare target variable. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9953

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 341167. njames93 added a comment. Rebase and fix up new checks added and changes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/c

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:385 /// On x86 this can be "fs" or "gs". + /// On AArch64 this can be any value of llvm::AArch64SysReg::SysReg. std::string StackProtectorGuardReg; This is now used

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

usaxena95 updated this revision to Diff 341168. usaxena95 marked 4 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101388/new/ http

[clang] f0efc00 - [OpenCL] Introduce new method for validating OpenCL target

Author: Anton Zabaznov Date: 2021-04-28T16:00:02+03:00 New Revision: f0efc00751313779671746492ded4014b715df6a URL: https://github.com/llvm/llvm-project/commit/f0efc00751313779671746492ded4014b715df6a DIFF: https://github.com/llvm/llvm-project/commit/f0efc00751313779671746492ded4014b715df6a.diff

[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0efc0075131: [OpenCL] Introduce new method for validating OpenCL target (authored by azabaznov). Changed prior to commit: https://reviews.llvm.org/D101087?vs=341119&id=341170#toc Repository: rG LLVM

[clang-tools-extra] d7cb230 - [clangd] Add SymbolID to LocatedSymbol.

Author: Utkarsh Saxena Date: 2021-04-28T15:05:53+02:00 New Revision: d7cb2305a1e86809af6f818a225af0fbe9441b2f URL: https://github.com/llvm/llvm-project/commit/d7cb2305a1e86809af6f818a225af0fbe9441b2f DIFF: https://github.com/llvm/llvm-project/commit/d7cb2305a1e86809af6f818a225af0fbe9441b2f.diff

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cb2305a1e8: [clangd] Add SymbolID to LocatedSymbol. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

thakis added a comment. Do we silently ignore those all now? Are any of them semantically important enough that we should emit an "not implemented, ignoring" diag instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101439/new/ https://reviews.l

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

thakis added inline comments. Comment at: clang/include/clang/Driver/Options.td:6117 def _SLASH_favor : CLJoined<"favor">; +def _SLASH_fsanitize_address_use_after_return : CLJoined<"fsanitize-address-use-after-return">; +def _SLASH_fno_sanitize_address_vcasan_lib : CLJoined<"f

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

hans added a comment. In D101439#2722540 , @thakis wrote: > Do we silently ignore those all now? Are any of them semantically important > enough that we should emit an "not implemented, ignoring" diag instead? No, this patch makes us parse them as oppos

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. In D98726#2721228 , @NoQ wrote: >> when the visitor encounters an `ExplodedNode` > > Weird. `finalizeVisitor()` accepts not any node but the error node. Your > screenshot suggests that the error node is not in the standard librar

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313 +// FIXME: visiting this here allows us to hover on UIColor in +// `UIColor.blackColor` but then `blackColor` no longer refers to

[clang-tools-extra] 39866d2 - [clangd][ObjC] Improve support for class properties

Author: David Goldman Date: 2021-04-28T10:06:27-04:00 New Revision: 39866d249a21fc3c05942a1a4fbbd88acc4660bc URL: https://github.com/llvm/llvm-project/commit/39866d249a21fc3c05942a1a4fbbd88acc4660bc DIFF: https://github.com/llvm/llvm-project/commit/39866d249a21fc3c05942a1a4fbbd88acc4660bc.diff

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG39866d249a21: [clangd][ObjC] Improve support for class properties (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

thakis created this revision. thakis added a reviewer: hans. Herald added a reviewer: aaron.ballman. thakis requested review of this revision. Commit 2a1332245fc extracted this code to a new function checkSectionName() and added a call to it, but didn't remove the original code. The original code

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm The real question is how did you find this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/ https://reviews.llvm.org/D101457 __

[clang] 5d49329 - [clang] remove dead code after 2a1332245fc

Author: Nico Weber Date: 2021-04-28T10:27:31-04:00 New Revision: 5d493291bd010bbba0fdc1e7da0922fd214fdffd URL: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd DIFF: https://github.com/llvm/llvm-project/commit/5d493291bd010bbba0fdc1e7da0922fd214fdffd.diff LO

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d493291bd01: [clang] remove dead code after 2a1332245fc (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D101457: [clang] remove dead code after 2a1332245fc

thakis added a comment. > The real question is how did you find this? :) No exciting answer, I'm afraid: I just happened to read this code while looking at something else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101457/new/ https://reviews.

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341211. Ericson2314 added a comment. Fix stray ':' typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt libclc/CM

[PATCH] D101463: [clang] Make libBasic not depend on MC

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, dang, mgorny. Herald added a reviewer: aaron.ballman. thakis requested review of this revision. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. Reduces numbers of files

[PATCH] D101439: [clang-cl] Add parsing support for a bunch of new flags

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Great :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101439/new/ https://reviews.llvm.org/D101439 ___

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

dcandler added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:36 + bool HasSHA3; + bool HasSM4; bool HasUnaligned; rsanthir.quic wrote: > Would it make sense to further differentiate SM3 and SM4? I see that we > differentiate between the two

[clang] b8baa2a - [ARM][AArch64] Require appropriate features for crypto algorithms

Author: David Candler Date: 2021-04-28T16:26:18+01:00 New Revision: b8baa2a9132498ea286dbb0d03f005760ecc6fdb URL: https://github.com/llvm/llvm-project/commit/b8baa2a9132498ea286dbb0d03f005760ecc6fdb DIFF: https://github.com/llvm/llvm-project/commit/b8baa2a9132498ea286dbb0d03f005760ecc6fdb.diff

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8baa2a91324: [ARM][AArch64] Require appropriate features for crypto algorithms (authored by dcandler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99079/n

[PATCH] D101461: [clangd][NFC] Reserve storage when creating semantic token encoding.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101461/new/ https://reviews.llvm.org/D101461 __

[clang] 1dad8c5 - [analyzer][NFC] Remove duplicated work from retain count leak report

Author: Valeriy Savchenko Date: 2021-04-28T18:37:37+03:00 New Revision: 1dad8c5036bc912078f7859d89e3ea571616fc4a URL: https://github.com/llvm/llvm-project/commit/1dad8c5036bc912078f7859d89e3ea571616fc4a DIFF: https://github.com/llvm/llvm-project/commit/1dad8c5036bc912078f7859d89e3ea571616fc4a.d

[clang] 61ae2db - [analyzer] Adjust the reported variable name in retain count checker

Author: Valeriy Savchenko Date: 2021-04-28T18:37:37+03:00 New Revision: 61ae2db2d7a97af5206afe609a303071711f9e6e URL: https://github.com/llvm/llvm-project/commit/61ae2db2d7a97af5206afe609a303071711f9e6e DIFF: https://github.com/llvm/llvm-project/commit/61ae2db2d7a97af5206afe609a303071711f9e6e.d

[PATCH] D100626: [analyzer][NFC] Remove duplicated work from retain count leak report

This revision was automatically updated to reflect the committed changes. Closed by commit rG1dad8c5036bc: [analyzer][NFC] Remove duplicated work from retain count leak report (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[clang] e273918 - [analyzer] Track leaking object through stores

Author: Valeriy Savchenko Date: 2021-04-28T18:37:38+03:00 New Revision: e273918038a7aa300cb8e6afebd9714bf647eed0 URL: https://github.com/llvm/llvm-project/commit/e273918038a7aa300cb8e6afebd9714bf647eed0 DIFF: https://github.com/llvm/llvm-project/commit/e273918038a7aa300cb8e6afebd9714bf647eed0.d

[clang] ab58238 - [analyzer] Find better description for tracked symbolic values

Author: Valeriy Savchenko Date: 2021-04-28T18:37:38+03:00 New Revision: ab5823867c4aee7f3e02ddfaa217905c87471bf9 URL: https://github.com/llvm/llvm-project/commit/ab5823867c4aee7f3e02ddfaa217905c87471bf9 DIFF: https://github.com/llvm/llvm-project/commit/ab5823867c4aee7f3e02ddfaa217905c87471bf9.d

[PATCH] D100839: [analyzer] Adjust the reported variable name in retain count checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61ae2db2d7a9: [analyzer] Adjust the reported variable name in retain count checker (authored by vsavchenko). Repository: rG LLVM Github Monorepo

[PATCH] D100852: [analyzer] Track leaking object through stores

This revision was automatically updated to reflect the committed changes. Closed by commit rGe273918038a7: [analyzer] Track leaking object through stores (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/ https://rev

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

This revision was automatically updated to reflect the committed changes. Closed by commit rGab5823867c4a: [analyzer] Find better description for tracked symbolic values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/n

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

bmahjour requested changes to this revision. bmahjour added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15130 + Value *Y = EmitScalarExpr(E->getArg(1)); + auto Ret = Builder.CreateFDiv(X, Y, "recipdiv"); +

[clang] 602c8b4 - [analyzer][NFC] Fix tests failing after a rebase

Author: Valeriy Savchenko Date: 2021-04-28T18:55:20+03:00 New Revision: 602c8b4db5dbe88be7080b411455538c9b4cd117 URL: https://github.com/llvm/llvm-project/commit/602c8b4db5dbe88be7080b411455538c9b4cd117 DIFF: https://github.com/llvm/llvm-project/commit/602c8b4db5dbe88be7080b411455538c9b4cd117.d

[PATCH] D101426: [RISCV] Update subset naming convertion for the latest spec

khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:180 + // as described in RISC-V User-Level ISA 20191213. SmallVector Split; Exts.split(Split, StringRef("_")); If we want to update the arch string rules to ISA 20191213,

[clang] 671f0e2 - [clang] Make libBasic not depend on MC

Author: Nico Weber Date: 2021-04-28T12:16:22-04:00 New Revision: 671f0e2e189c561512511331d95de382e2d6d15d URL: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d DIFF: https://github.com/llvm/llvm-project/commit/671f0e2e189c561512511331d95de382e2d6d15d.diff LO

[PATCH] D101463: [clang] Make libBasic not depend on MC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG671f0e2e189c: [clang] Make libBasic not depend on MC (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHA

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 341244. adamcz added a comment. moved the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank created this revision. nicovank added reviewers: alexfh, Prazek, kuhar. nicovank added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. nicovank requested review of this revision. Herald added a subscriber: cfe-commits. modernize-use-emplace only recommends going

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

nicovank added a comment. As you can see, this will fail some tests as there is one corner case which is tricky to handle: std::vector>> vec; // This is valid and should not be changed. vec.emplace_back(std::make_tuple(13, 31)); Does anyone have a suggestion for a good way to handle this?

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

delcypher added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +llvm::AsanDetectStackUseAfterReturnMode::

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2721705 , @dbabokin wrote: > One more false-positive: > > void foo() { > extern int yydebug; > yydebug = 1; > } > > It was triggered in ISPC build. Thanks for the report. It seems the thing to do is to mo

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dbabokin added a comment. > Thanks for the report. It seems the thing to do is to modify the warning so > that variables marked extern are not candidates for this warning. I will make > a new commit with that modification unless there are other suggestions. I agree, this seems to be the right f

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl updated this revision to Diff 341257. yaxunl added a comment. cast return value to default address space since it is expected. also fix debug info CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101389/new/ https://reviews.llvm.org/D101389 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nathanchance added a comment. In D100581#2721430 , @nickdesaulniers wrote: > Huh, maybe not: https://godbolt.org/z/PnE1fMGWo This difference has caused some confusion already for the Linux kernel: https://lore.kernel.org/r/202104280827.lsczw8xg-...@int

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. In D100581#2723329 , @nathanchance wrote: > In D100581#2721430 , > @nickdesaulniers wrote: > >> Huh, maybe not: https://godbolt.org/z/PnE1fMGWo > > This difference has caused some con

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

lebedev.ri added a comment. Also, from the reviewer list, it doesn't look like anyone with much familiarity with clang/clang diags actually participated in the review? I think this might be the point to revert and re-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:225-228 +ENUM_CODEGENOPT(SanitizeAddressDetectStackUseAfterReturnMode, +llvm::AsanDetectStackUseAfterReturnMode, 2, +llvm::AsanDetectStackUseAfterReturnMode:

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

nemanjai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15130 + Value *Y = EmitScalarExpr(E->getArg(1)); + auto Ret = Builder.CreateFDiv(X, Y, "recipdiv"); + Builder.setFastMathFlags(FMF); bmahjour wrote: > I wonder if we can do

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. In D100581#2723348 , @lebedev.ri wrote: > Also, from the reviewer list, it doesn't look like anyone with much > familiarity with clang/clang diags actually participated in the review? > I think this might be the point to rever

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, and I'm always in favor of having a `Leave` Option. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101344/n

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. Please revert this. This change hasn’t been tested nor reviewed enough. Also I don’t remember seeing this proposed on cfe dev mailing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llv

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek created this revision. phosek added reviewers: hans, rnk, thakis. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements support for using libc++ headers in MSVC toolchain. We only support libc++ headers that are part

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 341279. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan updated this revision to Diff 341280. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/inc

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

vitalybuka added a comment. In D99381#2721619 , @phosek wrote: > What I think @vitalybuka meant is keeping > `sanitizer_platform_limits_fuchsia.h` as you had it, but including it > unconditionally. Since the entire file is wrapped in `#if SANITIZER_FUCHS

[clang] 0395f9e - [ARM] Neon Polynomial vadd Intrinsic fix

Author: Ryan Santhirarajan Date: 2021-04-28T11:59:40-07:00 New Revision: 0395f9e70b8f2dc55d3ef0bb7195c3542deffc5a URL: https://github.com/llvm/llvm-project/commit/0395f9e70b8f2dc55d3ef0bb7195c3542deffc5a DIFF: https://github.com/llvm/llvm-project/commit/0395f9e70b8f2dc55d3ef0bb7195c3542deffc5a.

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0395f9e70b8f: [ARM] Neon Polynomial vadd Intrinsic fix (authored by rsanthir.quic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101480: Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

mbenfield created this revision. mbenfield added reviewers: aeubanks, george.burgess.iv, lebedev.ri, Abpostelnicu. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield added a comment. Link for the revert: https://reviews.llvm.org/D101480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits mailing list cf

  1   2   >