[clang] 17139b2 - [clang-format] Reformat. NFC.

Author: Marek Kurdej Date: 2021-04-27T09:10:58+02:00 New Revision: 17139b2b21a080c8584fbfe059e8adf85fd26c07 URL: https://github.com/llvm/llvm-project/commit/17139b2b21a080c8584fbfe059e8adf85fd26c07 DIFF: https://github.com/llvm/llvm-project/commit/17139b2b21a080c8584fbfe059e8adf85fd26c07.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

jansvoboda11 added a comment. In D85802#2717684 , @leonardchan wrote: >> That's odd. Does your `CMakeCache.txt` file have >> `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't >> get switched to `ON` when D97462

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 340738. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-

[clang] 3feb84a - [clang-format] Merge SpacesInAngles tests. NFC.

Author: Marek Kurdej Date: 2021-04-27T09:32:09+02:00 New Revision: 3feb84a36f5128dd0f6e9c65314609a9ce4372bc URL: https://github.com/llvm/llvm-project/commit/3feb84a36f5128dd0f6e9c65314609a9ce4372bc DIFF: https://github.com/llvm/llvm-project/commit/3feb84a36f5128dd0f6e9c65314609a9ce4372bc.diff

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101328/new/ https://reviews.llvm.org/D101328 __

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101059/new/ https://reviews.llvm.org/D101059

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

uabelho added a comment. I noticed that with this patch libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp fails: error: 'warning' diagnostics seen but not expected: File /repo/uabelho/master-github/libcxx/test/std/strings/basic.string/string.cons/iter_alloc_d

[PATCH] D100841: [clangd][Index][NFC] Make local class collection optional

kadircet abandoned this revision. kadircet added a comment. > This seems reasonable, but having found the problem, do we still want to land > it? I suppose not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100841/new/ https://reviews.llvm.org/D1

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

hokein added a comment. thanks, I think we can simplify a bit more. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() || ArgTy->isIncompleteType() || - ParamTy->isUndeducedType() || ArgTy->

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 340743. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/

[clang] d6c6db2 - [X86][AMX] Add description for AMX new interface.

Author: Luo, Yuanke Date: 2021-04-27T16:05:11+08:00 New Revision: d6c6db2feaab42c8132d584b547c18e443ba7f96 URL: https://github.com/llvm/llvm-project/commit/d6c6db2feaab42c8132d584b547c18e443ba7f96 DIFF: https://github.com/llvm/llvm-project/commit/d6c6db2feaab42c8132d584b547c18e443ba7f96.diff L

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6c6db2feaab: [X86][AMX] Add description for AMX new interface. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. FI, I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340746. kda added a comment. Revisions as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include

[PATCH] D101059: [X86][AMX] Add description for AMX new interface.

xiangzhangllvm added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101059/new/ https://reviews.llvm.org/D101059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A need for such an option came up in a few libc++ reviews. That's because libc++ has bot

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340749. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340751. sthibaul added a comment. Retrigger buildable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Drive

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda marked 4 inline comments as done. kda added a comment. Thank you for delineating the steps. Unfortunately, I don't know where to even start looking for the tests you mention in step 1. Are you looking for something like this: https://reviews.llvm.org/differential/changeset/?ref=2496958 Fo

[PATCH] D101122: introduce flag -fsanitize-address-detect-stack-use-after-return-mode. No functional change.

kda updated this revision to Diff 340754. kda added a comment. fixed up some more naming issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101122/new/ https://reviews.llvm.org/D101122 Files: clang/include/clang/Basic/CodeGenOptions.def cla

[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100772/new/ https://reviews.llvm.org/D100772 ___ cfe-commits mailing list

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire created this revision. steveire added a reviewer: rsmith. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All other CallExpr use the location of the member name as the getExprLoc: https://godbolt.org/z/jx16G9Gdr Repos

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Abpostelnicu added a comment. I think this added a regression, where you have this context: uint32_t LocalAccessible::SelectedItemCount() { uint32_t count = 0; AccIterator iter(this, filters::GetSelected); LocalAccessible* selected = nullptr; while ((selected = iter.Next())) ++c

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. I also consider it a bug. LLVM should not be affected as it uses `AllowShortEnumsOnASingleLine: true` whereas this problem arises only with `AllowShortEnumsOnASingleLine: false`. Any

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv updated this revision to Diff 340757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101259/new/ https://reviews.llvm.org/D101259 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3110 +} +if (EffectiveTriple.isAArch64() && Value != "sysreg" && Value != "global") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) Shouldn't this also al

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

DavidSpickett added a comment. A lot of these system registers are going to be unsuitable for the stack canary. They're either read only, they have fixed bits, or they'll get overwritten by various system events. I'm not suggesting we audit this list for those things, what seems reasonable to

[PATCH] D101347: hurd: Clean up test

sthibaul created this revision. sthibaul requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - We dropped windows support - Upgrade to current gcc 10 version Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D101347 Files: c

[PATCH] D101348: [Driver] Fix tests failing in per-target multiarch layout

phosek created this revision. phosek added reviewers: haowei, leonardchan. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These failures were revealed by b4537c3f51bc6c011ddd9c10b80043ac4ce16a01

[PATCH] D100919: [AArch64] Support customizing stack protector guard

DavidSpickett added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:59 +// INVALID-VALUE-AARCH64: error: invalid value 'tls' in 'mstack-protector-guard=','valid arguments to '-mstack-protector-guard=' are:sysreg global' +// INVALID-REG-AARCH64: error: inv

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire updated this revision to Diff 340762. steveire added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101346/new/ https://reviews.llvm.org/D101346 Files: clang/include/clang/AST/ExprCXX.h clang/unittests/AST/Source

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340765. sthibaul added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Dri

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > Anyway since there is not clear benefit that can be found now for the pragma > I think we should minimize its use as much as possible. Unfortunately it's already there :( > Anyway since there is not clear benefit that can be found now for the pragma > I think we sh

[PATCH] D101347: hurd: Clean up test

sthibaul updated this revision to Diff 340769. sthibaul added a comment. Retrigger buildable with the dep Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files: clang/test/Driver/Inputs/basic_cross_hur

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. Judging by this line in the `LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor()` method, it seems that the bug repor

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719043 , @azabaznov wrote: >> I am not sure, to be honest I personally think the extension pragma is a >> spec failure as it is not specified properly or to allow reasonable >> implementation > > Unfortunately it's

[clang] 37bc1dc - [NFC] Workaround MSVC2019 32-bit compiler crash

Author: Sven van Haastregt Date: 2021-04-27T11:15:47+01:00 New Revision: 37bc1dc9877fc480493c85c6d02709b3015bb5e8 URL: https://github.com/llvm/llvm-project/commit/37bc1dc9877fc480493c85c6d02709b3015bb5e8 DIFF: https://github.com/llvm/llvm-project/commit/37bc1dc9877fc480493c85c6d02709b3015bb5e8.

[PATCH] D100492: [OpenCL] Change OpenCL builtin version encoding

svenvh added a comment. Thanks for experimenting! I have pushed 37bc1dc9877f ("[NFC] Workaround MSVC2019 32-bit compiler crash", 2021-04-27). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

jubnzv added a comment. Thanks, I updated my patch and now CI is happy. I also found a few additional cases that can lead to false positives on the platforms which implements `__builtin_va_list` as `void *` or `char *`, and added additional checks for this. CHANGES SINCE LAST ACTION https://

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8651 static OpenCLParamType getOpenCLKernelParameterType(Sema &S, QualType PT) { + if (PT->isDependentType()) +return InvalidKernelParam; Anastasia wrote: > I would rather add an asser

[clang-tools-extra] 4581bf3 - [clangd] Dont index deeply nested symbols

Author: Kadir Cetinkaya Date: 2021-04-27T12:34:56+02:00 New Revision: 4581bf31bb8333dc1372959f7d650ed940eab710 URL: https://github.com/llvm/llvm-project/commit/4581bf31bb8333dc1372959f7d650ed940eab710 DIFF: https://github.com/llvm/llvm-project/commit/4581bf31bb8333dc1372959f7d650ed940eab710.dif

[PATCH] D101066: [clangd] Dont index deeply nested symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4581bf31bb83: [clangd] Dont index deeply nested symbols (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

azabaznov added a comment. > When the pragma is parsed we can't know why it is in the code to be able to > issue any warning. I mean diagnose once when, for example in your particular case, double type is parsed. Does it require much effort? I think this warning might be useful for developers

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There may be something I am overlooking here, but I really don't think we need to or want to change the back end. Just add the new builtins to the front end as aliases to the exi

[clang] 59ad4e0 - Reapply "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"

Author: Pushpinder Singh Date: 2021-04-27T10:47:05Z New Revision: 59ad4e0f01a8402016a690b3915bdd083285561e URL: https://github.com/llvm/llvm-project/commit/59ad4e0f01a8402016a690b3915bdd083285561e DIFF: https://github.com/llvm/llvm-project/commit/59ad4e0f01a8402016a690b3915bdd083285561e.diff L

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

sushmaunnibhavi created this revision. sushmaunnibhavi added reviewers: xgupta, kbarton, nickdesaulniers, tmfink. sushmaunnibhavi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed bug #37411 Bug Link:https://bugs.llvm.org/show_bug.cgi?i

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352

[PATCH] D100983: [OpenCL] Fix optional image types

azabaznov accepted this revision. azabaznov added a comment. This revision is now accepted and ready to land. Generally looks good to me, but maybe a test needed, see a comment. Thanks! But I'm still not sure about completely removing pragmas for type declarations (see https://reviews.llvm.org/D

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 340797. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updating based on review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files: clang/include/clang/

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. In D101192#2716596 , @mibintc wrote: > Wow thanks for doing this! I worked on it a couple days a while ago but I > abandoned the effort and went back to my day job. Happy to help! > It seems like preprocessing ought to be

[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

olestrohm updated this revision to Diff 340796. olestrohm added a comment. Improved the description and example per the feedback. The check for dependent type is needed. If it is not included the diagnostic will get triggered when the extension is disabled, but not when it's enabled. CHANGES S

[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anastasia added a comment. In D100980#2719196 , @azabaznov wrote: >> When the pragma is parsed we can't know why it is in the code to be able to >> issue any warning. > > I mean diagnose once when, for example in your particular case, double type > is p

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc abandoned this revision. mibintc added a comment. There was no resolution about what option name would be acceptable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 _

[clang] 6a92c19 - [C++4OpenCL] Add diagnostics for OpenCL types in templates.

Author: Anastasia Stulova Date: 2021-04-27T13:04:25+01:00 New Revision: 6a92c19f3bbc47827b8844a2b527f6c6fba63afd URL: https://github.com/llvm/llvm-project/commit/6a92c19f3bbc47827b8844a2b527f6c6fba63afd DIFF: https://github.com/llvm/llvm-project/commit/6a92c19f3bbc47827b8844a2b527f6c6fba63afd.d

[PATCH] D100860: [C++4OpenCL] Add missing OpenCL specific diagnostics in templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a92c19f3bbc: [C++4OpenCL] Add diagnostics for OpenCL types in templates. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100860/new/

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 340802. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaCh

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev updated this revision to Diff 340803. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99689/new/ https://reviews.llvm.org/D99689 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19668 T = Context.DependentTy; + else if (const auto *U = T->getUnqualifiedDesugaredType()) +if (U->isUndeducedType()) hokein wrote: > I'm not sure we need this well. I think the abov

[PATCH] D70340: Add a key method to Sema to optimize debug info size

erichkeane added inline comments. Comment at: clang/include/clang/Sema/Sema.h:335 + /// A key method to reduce duplicate type info from Sema. + virtual void anchor(); rnk wrote: > erichkeane wrote: > > rnk wrote: > > > hans wrote: > > > > I worry that this is

[PATCH] D100591: [Clang][AArch64] Disable rounding of return values for AArch64

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks for updating it. A little disappointing that we can't support BE first-class, but much more important that it's not broken and it's not actually that common. So I think th

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. marton

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Looking great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101358/new/ https://reviews.llvm.org/D101358 _

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

martong added a comment. Wow, thanks for the real quick review! I appreciate it! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101358/new/ https://reviews.llvm.org/D101358 ___ cfe-commits mailing list

[clang] 4b99f9c - [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

Author: Gabor Marton Date: 2021-04-27T15:35:58+02:00 New Revision: 4b99f9c7db262aa55d56d3af2f228e624ff7b55f URL: https://github.com/llvm/llvm-project/commit/4b99f9c7db262aa55d56d3af2f228e624ff7b55f DIFF: https://github.com/llvm/llvm-project/commit/4b99f9c7db262aa55d56d3af2f228e624ff7b55f.diff

[PATCH] D101358: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b99f9c7db26: [analyzer][StdLibraryFunctionsChecker] Track dependent arguments (authored by martong). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing") -IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes") +IMAGE_WRITE_TYPE(image

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. In D100807#2718006 , @arphaman wrote: > It appears that your bot is running on a Mac with M1 > is that correct? Which OS do you have > installed? Thanks Correct, it's an M1

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } I'm getting #0 for both functio

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

jdoerfert added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } thopre wrote: > I'm getting

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } jdoerfert wrote: > thopre wrote

[clang] 76a412e - [HIP] Fix help text for -fgpu-allow-device-init

Author: Yaxun (Sam) Liu Date: 2021-04-27T10:06:32-04:00 New Revision: 76a412e7a330964fe9914cbaaa0772feef771a28 URL: https://github.com/llvm/llvm-project/commit/76a412e7a330964fe9914cbaaa0772feef771a28 DIFF: https://github.com/llvm/llvm-project/commit/76a412e7a330964fe9914cbaaa0772feef771a28.dif

[PATCH] D101328: [clangd] run clang-format on FindTargetTests.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG53e1cb88f280: [clangd] run clang-format on FindTargetTests.cpp's FindExplicitReferencesTest (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] 53e1cb8 - [clangd] run clang-format on FindTargetTests.cpp's FindExplicitReferencesTest

Author: David Goldman Date: 2021-04-27T10:07:41-04:00 New Revision: 53e1cb88f28052fa849f28ff164d61e06a3dcfd2 URL: https://github.com/llvm/llvm-project/commit/53e1cb88f28052fa849f28ff164d61e06a3dcfd2 DIFF: https://github.com/llvm/llvm-project/commit/53e1cb88f28052fa849f28ff164d61e06a3dcfd2.diff

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

njames93 created this revision. njames93 added reviewers: steveire, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Checks if introspection support is available set output kind parser. If it isn't present

Re: [PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

On Tue, Apr 27, 2021 at 8:01 AM Melanie Blower via Phabricator < revi...@reviews.llvm.org> wrote: > mibintc abandoned this revision. > mibintc added a comment. > > There was no resolution about what option name would be acceptable > Oh no, I'm sorry that you felt that way. I saw Vitaly's comment

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

dgoldman updated this revision to Diff 340834. dgoldman added a comment. Rebase on top of formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98984/new/ https://reviews.llvm.org/D98984 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

njames93 updated this revision to Diff 340835. njames93 added a comment. Cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101365/new/ https://reviews.llvm.org/D101365 Files: clang-tools-extra/clang-query/QueryParser.cpp Index: clang-tool

[clang-tools-extra] c20e4fb - [clangd] Improve handling of Objective-C protocols in types

Author: David Goldman Date: 2021-04-27T10:20:35-04:00 New Revision: c20e4fbfa6d154616c2dd41e828a02facd000d71 URL: https://github.com/llvm/llvm-project/commit/c20e4fbfa6d154616c2dd41e828a02facd000d71 DIFF: https://github.com/llvm/llvm-project/commit/c20e4fbfa6d154616c2dd41e828a02facd000d71.diff

[PATCH] D98984: [clangd] Improve handling of Objective-C protocols in types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc20e4fbfa6d1: [clangd] Improve handling of Objective-C protocols in types (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340840. dgoldman added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added inline comments. Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385 +; CHECK-NEXT:[[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]] +; CHECK-NEXT:ret i1 [[OR]] ; aqjune wrote: > nikic wrote: > > It looks like this fold cou

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/X86/vector-reductions.ll:282 +; FIXME: this should be vectorized define i1 @cmp_lt_gt(double %a, double %b, double %c) { I don't think we need to worry about regressing this. It's not

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. In D100581#2718840 , @uabelho wrote: > I noticed that with this patch > > libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp > fails: > > error: 'warning' diagnostics seen but not expected: >

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. In D100581#2718947 , @Abpostelnicu wrote: > I think this added a regression, where you have this context: > > uint32_t LocalAccessible::SelectedItemCount() { > uint32_t count = 0; > AccIterator iter(this, filters::GetS

[PATCH] D101347: hurd: Clean up test

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 __

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { Any ideas about what it will take to get those

[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

ABataev updated this revision to Diff 340859. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99530/new/ https://reviews.llvm.org/D99530 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_firstprivate_c

[PATCH] D101317: hurd: Fix i386 research path

sthibaul added a comment. @MaskRay could you review this one as well? Most others are based on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 ___ cfe-commi

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

arphaman added a comment. In D100807#2719561 , @thakis wrote: > In D100807#2718006 , @arphaman > wrote: > >> It appears that your bot is running on a Mac with M1 >> is that correct?

[PATCH] D101317: hurd: Fix i386 research path

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `i386-gnu` no longer exists? That's great. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340871. sthibaul marked 2 inline comments as done. sthibaul added a comment. Rather use i686-gnu triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: cla

[PATCH] D101317: hurd: Fix i386 research path

sthibaul updated this revision to Diff 340875. sthibaul marked an inline comment as done. sthibaul added a comment. Fix triplet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://reviews.llvm.org/D101317 Files: clang/lib/Driver/To

[PATCH] D101317: hurd: Fix i386 research path

sthibaul added inline comments. Comment at: clang/test/Driver/hurd.c:2 // RUN: %clang -no-canonical-prefixes %s -### 2>&1 \ // RUN: --target=i386-pc-gnu \ // RUN: --sysroot=%S/Inputs/basic_hurd_tree \ MaskRay wrote: > While we currently detects several

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul updated this revision to Diff 340878. sthibaul added a comment. Rebase on newer D101317 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Drive

[PATCH] D101347: hurd: Clean up test

sthibaul updated this revision to Diff 340879. sthibaul added a comment. Rebase on refreshed D101331 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files: clang/test

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: arphaman. thakis requested review of this revision. Herald added a project: LLVM. Found files not containing `std::` with: INCL="algorithm|array|list|map|memory|queue|set|string|utility|vector|unordered_map

[PATCH] D99975: [clangd][ObjC] Improve support for class properties

dgoldman updated this revision to Diff 340885. dgoldman marked 2 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99975/new/ https://reviews.llvm.org/D99975 Files: clang-tools-extr

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/InstCombine/logical-select.ll:385 +; CHECK-NEXT:[[OR:%.*]] = select i1 [[AND1]], i1 true, i1 [[AND2]] +; CHECK-NEXT:ret i1 [[OR]] ; nikic wrote: > aqjune wrote: > > nikic wrote: > > > It look

[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101378/new/ https://reviews.llvm.org/D101378 ___ cfe-commits mailing list cfe-commi

  1   2   3   >