[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

njames93 updated this revision to Diff 336960. njames93 added a comment. Add new line at the end of remapped file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100343/new/ https://reviews.llvm.org/D100343 Files: clang/lib/Tooling/CMakeLists.txt

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, +

[clang-tools-extra] c2ad7c2 - Revert "[clangd] Provide a way to disable external index"

Author: Sterling Augustine Date: 2021-04-12T14:39:13-07:00 New Revision: c2ad7c23707cece995ee9070283a72c4afc8c0fe URL: https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe DIFF: https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe.

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

JonChesterfield added a comment. Interesting. Reduction across lanes in warp? If so, this is probably a way to handle the last step reduction for openmp reductions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100124/new/ https://reviews.llvm.org/D100124 __

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD created this revision. ThePhD added a reviewer: aaron.ballman. ThePhD added a project: clang. ThePhD requested review of this revision. Herald added a subscriber: cfe-commits. **//Short version://** Please let us know the encoding that the compiler chooses for it's implementation-defined,

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d created this revision. d requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The existing code causes an infinite recursion. This is likely an oversight of commit c0e5e3fbfa504c37

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 + StringRef TyAsString = + IndexExprType->isSignedIntegerType() ? "ssize_t" : "size_t"; + aaron.ballman wrote: > aaron.b

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 336981. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressed all review notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

njames93 updated this revision to Diff 336982. njames93 added a comment. Add store options method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97683/new/ https://reviews.llvm.org/D97683 Files: clang-tools-extra/clang-tidy/misc/UniqueptrResetRe

[clang-tools-extra] 27dfcd9 - [clang-tidy] Add include to misc-uniqueptr-reset-release

Author: Nathan James Date: 2021-04-12T23:32:15+01:00 New Revision: 27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8 URL: https://github.com/llvm/llvm-project/commit/27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8 DIFF: https://github.com/llvm/llvm-project/commit/27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8.diff

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d updated this revision to Diff 336983. d added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 Files: clang/include/clang/AST/IgnoreExpr.h Index: clang/include/clang/AST/IgnoreExpr.

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27dfcd978edc: [clang-tidy] Add include to misc-uniqueptr-reset-release (authored by njames93). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 336985. lebedev.ri added a comment. Hardcode triple/target in tests, should fix 32-bit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 Files: clang-tools-extra

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. New tests look good to me, thanks. Comment at: clang/include/clang/Driver/Options.td:922 +def amdgpu_arch_tool_EQ : Joined<["--"], "amdgpu-arch-tool=">, Group, + HelpText<"Path to amdgpu_arch tool, used for detecting AMD GPU arch in the system

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:603-604 + ReturnStmt *R = cast(St); + R->setRetValue(IgnoreImplicitAsWritten(R->getRetValue())); + Expr *Ex = R->getRetValue(); + while (!isa(Ex)) { I think this would be clearer, assuming

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, (Last call for review!!) Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks. For late comers, again (1) Original llvm-dev [RFC] discuss

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

rsmith added a comment. In D99790#2681487 , @lebedev.ri wrote: > I think it should be fixed in `CodeGenVTables::maybeEmitThunk()`, likely in > `arrangeGlobalDeclaration()`. > Or is this wrong on the AST level, too? The AST-level `ThunkInfo` doesn't track

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337008. ThePhD added a comment. Fixes formatting derps in the pre-linter check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/lib/Frontend/InitPreproc

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 337009. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. Shouldn't

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683632 , @morehouse wrote: > Also, the descriptions states: > >> Divide the corpus into n parts according to size. > > Is it really according to size? IIUC when there are multiple worker > processes, any new coverage

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. s

[PATCH] D100085: [X86] Support -march=rocketlake

skan accepted this revision. skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SG

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

Jim added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1217 +defm vmv_x : RVVOp0BuiltinSet<"vmv_x_s", "csil", + [["s", "ve", "ev"], +["s", "UvUe", "UeUv"]]>; Inden

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4728 - enum CopyElisionSemanticsKind { -CES_Strict = 0, -CES_AllowParameters = 1, -CES_AllowDifferentTypes = 2, -CES_AllowExceptionVariables = 4, -CES_AllowRValueReferenceType = 8, -

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683622 , @morehouse wrote: > Thanks for sharing your data. Took a quick look and seems promising. > > I would like to try this on FuzzBench before accepting the patch though. > FuzzBench has a very nice experimental

[PATCH] D100085: [X86] Support -march=rocketlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fc1fe8db830: [X86] Support -march=rocketlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

rsmith added a comment. Exposing this information seems fine to me. I think it'd be more useful to expose it in a way the preprocessor can inspect, but it's hard to see how to do that without requiring us to invent identifier-shaped names for all encodings, and perhaps we shouldn't be in the bu

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is in

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337024. ThePhD added a comment. The tests check for macros in strict byte-value "alphabetical" order. We also need documentation, as was suggested!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ htt

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD marked an inline comment as done. ThePhD added a comment. In D100346#2684705 , @rsmith wrote: > Exposing this information seems fine to me. I think it'd be more useful to > expose it in a way the preprocessor can inspect ... The reason it's done

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683632 , @morehouse wrote: > Also, the descriptions states: > >> Divide the corpus into n parts according to size. > > Is it really according to size? IIUC when there are multiple worker > processes, any new coverage

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is in

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337035. ThePhD marked an inline comment as done. Herald added subscribers: aheejin, dschuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/docs/LanguageExtensions.rst clang/lib/Frontend/Ini

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is inst

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM. But wait one or two days to see if there is more comments from Craig and HJ. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 ___

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

ArturGainullin created this revision. ArturGainullin added reviewers: rnk, hamzasood. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PATH usage on Windows is case-insensitive. There could be situations when toolchain path ca

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D10034

<    1   2