[PATCH] D50763: [Parser] Refactor and fix bugs in late-parsing

v.g.vassilev added a comment. @hamzasood, I suppose this is still worth pursuing. Could you address the comment? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50763/new/ https://reviews.llvm.org/D50763 ___ cfe-commits

[PATCH] D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent.

v.g.vassilev added a comment. @teemperor, should we land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37797/new/ https://reviews.llvm.org/D37797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] 6270b3a - Temporairly revert "[CGCall] Annotate `this` argument with alignment"

Author: Roman Lebedev Date: 2021-04-10T10:43:16+03:00 New Revision: 6270b3a1eafaba4279e021418c5a2c5a35abc002 URL: https://github.com/llvm/llvm-project/commit/6270b3a1eafaba4279e021418c5a2c5a35abc002 DIFF: https://github.com/llvm/llvm-project/commit/6270b3a1eafaba4279e021418c5a2c5a35abc002.diff

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri reopened this revision. lebedev.ri added a comment. Temporarily reverted in 6270b3a1eafaba4279e021418c5a2c5a35abc002 . Eagerly awaiting fix for that bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2679922 , @morehouse wrote: > Thanks for the patch! Would you mind sharing the experimental data/results > you obtained for this patch? > > Additionally, could you submit this patch to FuzzBench >

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. F16230733: experiment.tar This is part of raw data , the object from oss-fuzz project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100161/new/ https://reviews.llvm.org/D100161 __

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2681045 , @gtt1995 wrote: > F16230733: experiment.tar > > This is part of raw data , the object from oss-fuzz project. The patched version data in average dir, data of libfuzzer di

[PATCH] D60456: [RISCV] Hard float ABI support

rjmccall added a comment. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, sameer.abuasal, s.egerton. Your use of CoerceAndExpand seems fine; thanks for pinging me on it Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60456/new/ https://reviews.ll

[clang] 71ab6c9 - [Matrix] Implement C-style explicit type conversions for matrix types.

Author: Saurabh Jha Date: 2021-04-10T11:48:41+01:00 New Revision: 71ab6c98a0d1b5590ed12f955dea6dfc714e9490 URL: https://github.com/llvm/llvm-project/commit/71ab6c98a0d1b5590ed12f955dea6dfc714e9490 DIFF: https://github.com/llvm/llvm-project/commit/71ab6c98a0d1b5590ed12f955dea6dfc714e9490.diff L

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

This revision was automatically updated to reflect the committed changes. Closed by commit rG71ab6c98a0d1: [Matrix] Implement C-style explicit type conversions for matrix types. (authored by SaurabhJha, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 336604. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Expr.h clang/include/cla

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rnk wrote: > rsmith wrote: > > rsmith wr

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev added a comment. friendly ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99808/new/ https://reviews.llvm.org/D99808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D99808: [Sema] Move 'char-expression-as-unsigned < 0' into a separate diagnostic

AntonBikineev updated this revision to Diff 336612. AntonBikineev added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99808/new/ https://reviews.llvm.org/D99808 Files: clang/include/clang/Basic/DiagnosticGroups.td cla

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- updated this revision to Diff 336614. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 Files: clang/examples/CMakeLists.txt clang/examples/PrintAttributeTokens/CMakeLists.txt clang/examples/PrintAtt

[PATCH] D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes

Qix- added a comment. @aaron.ballman updated with comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99861/new/ https://reviews.llvm.org/D99861 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] 3b677b8 - [libtooling][clang-tidy] Fix diagnostics not highlighting fed SourceRanges

Author: Whisperity Date: 2021-04-10T16:43:44+02:00 New Revision: 3b677b81cec7b3c5132aee8fccc30252d87deb69 URL: https://github.com/llvm/llvm-project/commit/3b677b81cec7b3c5132aee8fccc30252d87deb69 DIFF: https://github.com/llvm/llvm-project/commit/3b677b81cec7b3c5132aee8fccc30252d87deb69.diff LO

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b677b81cec7: [libtooling][clang-tidy] Fix diagnostics not highlighting fed SourceRanges (authored by whisperity). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1585-1586 InitializedEntity Entity = InitializedEntity::InitializeVariable(GroDecl); - ExprResult Res = S.PerformMoveOrCopyInitialization(Entity, nullptr, GroType, -

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967 if (unsigned BuiltinID = NewFD->getBuiltinID()) { ASTContext::GetBuiltinTypeError Error; LookupNecessaryTypesForBuiltin(S, BuiltinID); QualType T = Context.GetBuiltinType(B

[clang-tools-extra] 8fa3975 - [libtooling][clang-tidy] Fix off-by-one rendering issue with SourceRanges

Author: Whisperity Date: 2021-04-10T18:52:55+02:00 New Revision: 8fa39752477b225294cde0967a3b4c9c492e699c URL: https://github.com/llvm/llvm-project/commit/8fa39752477b225294cde0967a3b4c9c492e699c DIFF: https://github.com/llvm/llvm-project/commit/8fa39752477b225294cde0967a3b4c9c492e699c.diff LO

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 336618. whisperity set the repository for this revision to rG LLVM Github Monorepo. whisperity added a comment. Rebased over D98635 , allowing us to properly highlight the found //"mixable adjacent parameter range"// (assum

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

whisperity updated this revision to Diff 336619. whisperity added a comment. **[NFC]** Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 Files: clang-tools-extra/clang-tidy/bugprone/EasilySwappableP

[PATCH] D96355: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with optionally considering differently qualified types mixable

whisperity updated this revision to Diff 336620. whisperity set the repository for this revision to rG LLVM Github Monorepo. whisperity added a comment. **[NFC]** Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96355/new/ https://reviews.llvm

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 336622. whisperity added a comment. Made sure that the parameter's name is highlighted promptly in the //"first|last parameter of the range is..."// note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 336623. whisperity set the repository for this revision to rG LLVM Github Monorepo. whisperity added a comment. - Fixed a few nits. - Rebased, and added highlighting (under-squiggly) the parameter/return type of conversion operators for extra emphasis. R

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 336625. whisperity edited the summary of this revision. whisperity added a comment. Rebase over D98635 . Highlighting only the parameter's name, not the entire range of the parameter. Repository: rG LLVM Github Monorepo

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 336626. mizvekov added a comment. - Addresses aaronpuchert's review points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov marked 8 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3058 -bool Sema::isCopyElisionCandidate(QualType ReturnType, const VarDecl *VD, - CopyElisionSemanticsKind CESK) { - QualType VDT

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay created this revision. MaskRay added reviewers: Sanitizers, jdoerfert, joerg, nickdesaulniers, rnk. Herald added subscribers: dexonsmith, hiraditya. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. On ELF ta

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3030-3032 + Res.S = Res.S != Sema::NRVOResult::None && CanMove + ? Sema::NRVOResult::MoveEligible + : Sema::NRVOResult::None; mizvekov wrote: > aaronpuchert wro

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 added a comment. In D97653#2675005 , @aaron.ballman wrote: > In D97653#2593287 , @njames93 wrote: > >> Where would be a good place for testing refersToDefaultCapture support? > > Thank you for your patienc

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

njames93 added a comment. Herald added a project: clang-tools-extra. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97683/new/ https://reviews.llvm.org/D97683 ___ cfe-commits mailing list cfe-commits

[PATCH] D96286: [clangd] Change TidyProvider cache to use a linked list approach

njames93 added a comment. Herald added a project: clang-tools-extra. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 ___ cfe-commits mailing list cfe-commits

[PATCH] D100252: Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat created this revision. super_concat added a reviewer: rsmith. super_concat added a project: clang. super_concat requested review of this revision. this patch fixes Bug 27113 by adding support for string literals to the implementation of t

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3140 +/// \param ReturnType This is the return type of the function. +void Sema::updNRVOResultWithRetType(NRVOResult &Res, QualType ReturnType) { + if (!Res.Candidate) aaronpuchert wrote: >

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3140 +/// \param ReturnType This is the return type of the function. +void Sema::updNRVOResultWithRetType(NRVOResult &Res, QualType ReturnType) { + if (!Res.Candidate) mizvekov wrote: > a

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

njames93 updated this revision to Diff 336645. njames93 added a comment. Use implicit capture instead of default capture. @aaron.ballman, Unfortunately the AST dump tests don't work as implicit captures don't appear to show up in the textual representation. Repository: rG LLVM Github Monorep