[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

jhenderson added a comment. @ASDenysPetrov, I think you need to mark this patch as Accepted so that someone can close this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95808/new/ https://reviews.llvm.org/D95808 __

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2236 +} + } + The expected semantics for this conversion are not the ordinary bitwise-reinterpretation semantics of `reinterpret_cast`, so this really should not be allowed as a `reint

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius updated this revision to Diff 334064. curdeius marked 2 inline comments as done. curdeius added a comment. - Clean up tests. - Fix grammar comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99489/new/ https://reviews.llvm.org/D99489 F

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius added inline comments. Comment at: clang/test/Parser/cxx2a-template-lambdas.cpp:17 +#endif +auto L7 = [] requires true {}; // ? +auto L8 = [] requires true noexcept {}; aaron.ballman wrote: > This seems grammatically valid to me, was there a reason for t

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7315 +/// is not a scalar type. +bool Sema::areCompatibleMatrixTypes(QualType srcTy, QualType destTy) { + assert(destTy->isMatrixType() && srcTy->isMatrixType()); rjmccall wrote: > "Compat

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:1642 +Group, Flags<[CoreOption, HelpHidden]>, +HelpText<"Enable transforming aligned vector move instruction to " + "unaligned vector move.">; As far the use

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added a comment. The only use I could really see for this is to prevent a developers code from crashing when it’s distributed to someone else. For paranoia because it’s possible you have a bug and got lucky with alignment in your internal testing before you shipped. If you need th

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:90 return "x86_64-linux-android"; -// We don't want this for x32, otherwise it will match x86_64 libs -if (TargetEnvironment != llvm::Triple::GNUX32 && -D.getVFS().exists(SysR

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 334071. glaubitz retitled this revision from "[Driver] Fix architecture triplets and search paths for Linux x32" to "WIP: [Driver] Fix architecture triplets and search paths for Linux x32". glaubitz added a comment. Updated version which unfortunately still

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

LiuChen3 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1642 +Group, Flags<[CoreOption, HelpHidden]>, +HelpText<"Enable transforming aligned vector move instruction to " + "unaligned vector move.">; craig.topper wrote

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 334072. LevyHsu added a comment. 1. llvm/lib/Target/RISCV/RISCVISelLowering.cpp - Fixed mishandling on op0 2. clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/CodeGen/CGBuiltin.cpp - Reduce port to 2 versions for 32/64 only. 3. clang/test/CodeGen/RISC

[PATCH] D99319: [RISCV] [2/2] Add intrinsic for Zbb extension

LevyHsu updated this revision to Diff 334073. LevyHsu added a comment. 1. clang/lib/Headers/riscv_zbb_intrin.h - Remove extra ports. now orc_b handles xlen op, - _rv64_orc_b and _rv32_orc_b for RV64 - _rv32_orc_b for RV32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D99344: [Analyzer] Track RValue expressions

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1958-1959 + EnableNullFPSuppression); + } else { // Track only the LHS of divisions. +if (LHSV.isZeroConstant()) + trackExpressionValue(InputNode,

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius updated this revision to Diff 334075. curdeius added a comment. - Rebase to fix CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99489/new/ https://reviews.llvm.org/D99489 Files: clang/lib/Parse/ParseExprCXX.cpp clang/test/Parser/cxx

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. It looks like this is breaking the Windows/ARM(64) target - it doesn't produce the right relative relocations for symbol differences. It can be reproduced with a testcase like this: $ cat test.s .text func1: ret func2: ret

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `CompilerInvocationBase` class factors out members of `CompilerInvocation` that need

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 334079. kadircet added a comment. - Have 2 separate hooks for preamble and mainfile ASTs, as they are produced async. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98499/new/ https://reviews.llvm.org/D98499

[clang] 1cbba53 - [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier

Author: Raphael Isemann Date: 2021-03-30T11:07:16+02:00 New Revision: 1cbba533ec93864caab8ad2f3fd4293a56723307 URL: https://github.com/llvm/llvm-project/commit/1cbba533ec93864caab8ad2f3fd4293a56723307 DIFF: https://github.com/llvm/llvm-project/commit/1cbba533ec93864caab8ad2f3fd4293a56723307.dif

[PATCH] D99512: [ObjC][CodeGen] Fix missing debug info in situations where an instance and class property have the same identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbba533ec93: [ObjC][CodeGen] Fix missing debug info in situations where an instance and… (authored by teemperor). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[clang-tools-extra] 6d2fb3c - [clangd] Perform merging for stale symbols in MergeIndex

Author: Kadir Cetinkaya Date: 2021-03-30T11:09:51+02:00 New Revision: 6d2fb3cefba618be0326bb3da85d7568a72fefc4 URL: https://github.com/llvm/llvm-project/commit/6d2fb3cefba618be0326bb3da85d7568a72fefc4 DIFF: https://github.com/llvm/llvm-project/commit/6d2fb3cefba618be0326bb3da85d7568a72fefc4.dif

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2fb3cefba6: [clangd] Perform merging for stale symbols in MergeIndex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98538/new/ http

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong updated this revision to Diff 334086. martong added a comment. - Add check for specialization kind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99421/new/ https://reviews.llvm.org/D99421 Files: clang/lib/AST/ASTImporter.cpp clang/unit

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I may be missing something, but I do not understand the problem. What systems, other than Debian multi-arch, are you looking to also add support for? My own native x32 system uses `(/usr)/libx32` for x32 libraries. Debian uses `(/usr)/lib/x86_64-linux-gnux32`. I can unde

[PATCH] D52050: WIP: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2657952 , @hvdijk wrote: > I may be missing something, but I do not understand the problem. What > systems, other than Debian multi-arch, are you looking to also add support > for? My own native x32 system uses `(/usr)

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. In D98574#2654686 , @joerg wrote: > The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone > but Linux cares at all otherwise as they lack 32bit SPARC support. Well, there were no tests for NetBSD before, s

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

lebedev.ri added a comment. In D99565#2657813 , @craig.topper wrote: > The only use I could really see for this is to prevent a developers code from > crashing when it’s distributed to someone else. For paranoia because it’s > possible you have a bug an

[clang] 98f6cbd - [ASTImporter] Import member specialization/instantiation of enum decls

Author: Gabor Marton Date: 2021-03-30T11:57:46+02:00 New Revision: 98f6cbd68eba04764f318d467abb10feca713776 URL: https://github.com/llvm/llvm-project/commit/98f6cbd68eba04764f318d467abb10feca713776 DIFF: https://github.com/llvm/llvm-project/commit/98f6cbd68eba04764f318d467abb10feca713776.diff

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG98f6cbd68eba: [ASTImporter] Import member specialization/instantiation of enum decls (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D994

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

martong added a comment. Thanks for the review guys! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99421/new/ https://reviews.llvm.org/D99421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D99344: [Analyzer] Track RValue expressions

martong updated this revision to Diff 334093. martong added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang

[PATCH] D99344: [Analyzer] Track RValue expressions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1958-1959 + EnableNullFPSuppression); + } else { // Track only the LHS of divisions. +if (LHSV.isZeroConstant(

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. In D94355#2657881 , @mstorsjo wrote: > It looks like this is breaking the Windows/ARM(64) target - it doesn't > produce the right relative relocations for symbol differences. It can be > reproduced with a testcase like this: > >

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

steakhal created this revision. steakhal added reviewers: martong, teemperor, shafik, balazske, a.sidorin. Herald added subscribers: whisperity, rnkovacs, kristof.beyls. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All three cas

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 3 inline comments as done. AntonBikineev added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:640 isFloat16 = true; continue; } rsmith wrote: > Looks like this might fix [[ https://godbolt.org/z/9Pe4qr1

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334102. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Address comments. Also: - always issue a new diagnostic if size_t/ssize_t is out of range; - prohibit numbers with 'z' suffix and non-10-radix to be interpreted as u

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unhandled-exception-at-new.cpp:143 + f_est_noexcept_dependent_used(); +} balazske wrote: > aaron.ballman wrote: > > You have tests for placement new with `nothrow_t`

[PATCH] D99344: [Analyzer] Track RValue expressions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. land it Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1938 + ProgramStateRef RVState = RVNode->getState(); + SVal V = RVState->getSValAsScalarOrLoc(

[PATCH] D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing

azabaznov created this revision. azabaznov added reviewers: svenvh, Anastasia. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds an option string to clang-check to ignore certain A

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl added a subscriber: shafik. aprantl added a comment. > If LLDB actually does _not_ have behavior change based on dialect, then we > might as well control language codes based on DWARF version, and the patch > should proceed. @shafik Can you think of situations where LLDB is sensitive to

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shafik added a comment. In D99250#2657390 , @aprantl wrote: >> If LLDB actually does _not_ have behavior change based on dialect, then we >> might as well control language codes based on DWARF version, and the patch >> should proceed. > > @shafik Can you

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme updated this revision to Diff 334057. Esme added a comment. Addressed Zheng's comments. Thank you all for your comments. Since no DWARF consumers has dialect-specific behavior, the patch will proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

Esme added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plus_p

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Everything looks fine. I like that regexp matcher so much. <3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.

[PATCH] D98377: [clangd] Show padding following a field on field hover.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98377/new/ https://reviews.llvm.org/D

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

azabaznov added a comment. Thanks for  the patch! Sorry for the delay Can you please elaborate on what issue you are trying to resolve with this fix? You're trying to emit diagnostics for `cl_khr_3d_image_writes` for OpenCL C 3.0? FYI `cl_khr_3d_image_writes` should have no effect in `-cl-ext`

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the test case commenting nit. Thank you! Comment at: clang/test/Parser/cxx2a-template-lambdas.cpp:17 +#if __cplusplus <= 202002L +// expected-wa

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334110. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Set OF_Text for llvm/tools/dsymutil/DwarfLinkerForBinary.cpp instead of OF_TextWithCRLF. This was also another file I recently change

[clang] a99b8ae - [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

Author: Marek Kurdej Date: 2021-03-30T13:53:55+02:00 New Revision: a99b8ae3909106d831d880c1647dabe92f470290 URL: https://github.com/llvm/llvm-project/commit/a99b8ae3909106d831d880c1647dabe92f470290 DIFF: https://github.com/llvm/llvm-project/commit/a99b8ae3909106d831d880c1647dabe92f470290.diff

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa99b8ae39091: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no… (authored by curdeius). Changed prior to commit: htt

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

abhina.sreeskantharajan added a comment. In D99363#2656913 , @aganea wrote: > In D99363#2653476 , > @abhina.sreeskantharajan wrote: > >> There were a lot of similar patches so reverting all of them might be more >

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui created this revision. kamleshbhalui added reviewers: dblaikie, aprantl. kamleshbhalui added a project: LLVM. Herald added a subscriber: mstorsjo. kamleshbhalui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang emits dupli

[clang] 2b30bd2 - clang-format: [JS] do not collapse - - to --.

Author: Martin Probst Date: 2021-03-30T14:31:24+02:00 New Revision: 2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9 URL: https://github.com/llvm/llvm-project/commit/2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9 DIFF: https://github.com/llvm/llvm-project/commit/2b30bd2be0a898d0e7cb9eb3f2cf0e0efeaa83e9.diff

[PATCH] D99495: clang-format: [JS] do not collapse - - to --.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b30bd2be0a8: clang-format: [JS] do not collapse - - to --. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99495/new/ https://reviews.

[clang] 1696b8a - [OPENMP]Fix PR48740: OpenMP declare reduction in C does not require an initializer

Author: Alexey Bataev Date: 2021-03-30T05:38:20-07:00 New Revision: 1696b8ae96b2d8bcbf90894bd344a8a090f43c84 URL: https://github.com/llvm/llvm-project/commit/1696b8ae96b2d8bcbf90894bd344a8a090f43c84 DIFF: https://github.com/llvm/llvm-project/commit/1696b8ae96b2d8bcbf90894bd344a8a090f43c84.diff

[PATCH] D99539: [OPENMP]Fix PR48740: OpenMP declare reduction in C does not require an initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG1696b8ae96b2: [OPENMP]Fix PR48740: OpenMP declare reduction in C does not require an… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D99500: [analyzer] Support allocClassWithName in OSObjectCStyleCast checker

vsavchenko added a comment. In D99500#2657675 , @NoQ wrote: > LGTM! Thanks for formatting ^.^ > > WDYT about a heuristic that literally matches the source code of the casted > expression as plain text to see if it mentions the type? Like, regardless of >

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. @azabaznov Without this change, `opencl-c.h` cannot be parsed with `-cl-std=CL3.0` as the `write_only image3d_t` type is not enabled. The type is currently enabled via `cl_khr_3d_image_writes`. See https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Op

[clang] efa7df1 - [Analyzer] Track RValue expressions

Author: Gabor Marton Date: 2021-03-30T14:48:38+02:00 New Revision: efa7df1682c2859dabe3646ee7dc01e68629417f URL: https://github.com/llvm/llvm-project/commit/efa7df1682c2859dabe3646ee7dc01e68629417f DIFF: https://github.com/llvm/llvm-project/commit/efa7df1682c2859dabe3646ee7dc01e68629417f.diff

[PATCH] D99344: [Analyzer] Track RValue expressions

This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rGefa7df1682c2: [Analyzer] Track RValue expressions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 9037730 - [analyzer] Support allocClassWithName in OSObjectCStyleCast checker

Author: Valeriy Savchenko Date: 2021-03-30T15:58:06+03:00 New Revision: 90377308de6cac8239bc1a1dcd32b57b9ec91444 URL: https://github.com/llvm/llvm-project/commit/90377308de6cac8239bc1a1dcd32b57b9ec91444 DIFF: https://github.com/llvm/llvm-project/commit/90377308de6cac8239bc1a1dcd32b57b9ec91444.d

[PATCH] D99500: [analyzer] Support allocClassWithName in OSObjectCStyleCast checker

This revision was automatically updated to reflect the committed changes. Closed by commit rG90377308de6c: [analyzer] Support allocClassWithName in OSObjectCStyleCast checker (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D995

[clang] af7e1f0 - [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

Author: Valeriy Savchenko Date: 2021-03-30T16:04:19+03:00 New Revision: af7e1f07ac03074647897498358aaec165c1aaea URL: https://github.com/llvm/llvm-project/commit/af7e1f07ac03074647897498358aaec165c1aaea DIFF: https://github.com/llvm/llvm-project/commit/af7e1f07ac03074647897498358aaec165c1aaea.d

[PATCH] D99274: [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7e1f07ac03: [analyzer] Fix crash when reasoning about C11 atomics (PR49422) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99274/n

[PATCH] D95845: [ObjC] Add a command line flag that disables recognition of objc_direct for testability

erik.pilkington updated this revision to Diff 334136. erik.pilkington added a comment. - Use the new marshaling infrastructure - Fix a few places in Sema where we manually checked for `ObjCDirectAttr` instead of using `isDirectMethod` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95845/

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. ping. After some investigation, I think it is quite hard to add tests to avoid inconsistency between clang and clangd. Maybe I could add some tests for CUDA, OpenMP if needed. WDYT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

martong added inline comments. Comment at: clang/test/Analysis/inner-pointer.cpp:23 + +char *data(std::string &c); + Seems like all test are exercising with std::string, this looks like a legacy in this Checker. Still, I miss a bit at least one test for the othe

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

HsiangKai updated this revision to Diff 334145. HsiangKai edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99482/new/ https://reviews.llvm.org/D99482 Files: clang/lib/CodeGen/CGCall.cpp Index: clang/lib/CodeGen/

[PATCH] D99590: [Clang] Do not use memcpy for struct copy.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For scalable struct types, we do not know the

[PATCH] D99592: [PoC][Clang] Use TypeSize instead of uint64_t for getTypeAllocSize().

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The return type of getTypeAllocSize() is TypeS

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai updated this revision to Diff 334150. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/Builtins.def clang/include/clang/Bas

[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 334156. balazske added a comment. Use `mayThrow`, improve test (user and class-specific cases). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files: clang-tools-ex

[PATCH] D99262: [analyzer] Fix dead store checker false positive

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:420-421 + // We should also allow defensive initialization of structs. + if (const auto *ILE = + dyn_cast(E->IgnoreParenCasts())) { +

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1356 +def MustTail : StmtAttr { + let Spellings = [Clang<"musttail">]; + let Documentation = [MustTailDocs]; You should add a `Subjects` list here. Comment at:

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_p

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334152. Ericson2314 added a comment. include(GNUInstallDirs) in each project unconditionally Before projects that might not be built standalone only included it when they were, but then we got into a situation where no project included it, and things brok

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen updated this revision to Diff 334164. khchen added a comment. 1. Address Craig's comments. 2. I didn't add common class for shift instruction. I will add it when we add other shift instruction which have the same argments. Does it make sense? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

azabaznov accepted this revision. azabaznov added a comment. Looks good to me. Thanks! > Without this change, opencl-c.h cannot be parsed with -cl-std=CL3.0 as the > write_only image3d_t type is not enabled. This should be fixed in the following up patches to check for `__opencl_c_3d_image_wri

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. Thanks! I'll commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] bd334c7 - [OPENMP]Fix test checks for 32bit targets, NFC.

Author: Alexey Bataev Date: 2021-03-30T07:45:12-07:00 New Revision: bd334c790f2e43e72270b8044f08303e1c2f283b URL: https://github.com/llvm/llvm-project/commit/bd334c790f2e43e72270b8044f08303e1c2f283b DIFF: https://github.com/llvm/llvm-project/commit/bd334c790f2e43e72270b8044f08303e1c2f283b.diff

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99576/new/ https://reviews.llvm.org/D99576 __

[clang] 9d25ce7 - [OpenCL] Fix parsing of opencl-c.h in CL 3.0

Author: Kevin Petit Date: 2021-03-30T16:17:46+01:00 New Revision: 9d25ce743a95a9ad03c0a4b3a705f85c2de52398 URL: https://github.com/llvm/llvm-project/commit/9d25ce743a95a9ad03c0a4b3a705f85c2de52398 DIFF: https://github.com/llvm/llvm-project/commit/9d25ce743a95a9ad03c0a4b3a705f85c2de52398.diff L

[clang] bc4b0fc - [clang-format] Fix east const pointer alignment of operators

Author: Nico Rieck Date: 2021-03-30T17:18:32+02:00 New Revision: bc4b0fc53e47e08a244df6ee3de52226e49ce37e URL: https://github.com/llvm/llvm-project/commit/bc4b0fc53e47e08a244df6ee3de52226e49ce37e DIFF: https://github.com/llvm/llvm-project/commit/bc4b0fc53e47e08a244df6ee3de52226e49ce37e.diff LO

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4b0fc53e47: [clang-format] Fix east const pointer alignment of operators (authored by nrieck, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D99458?vs=333678&id=334173#toc

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet closed this revision. kpet added a comment. Committed as https://github.com/llvm/llvm-project/commit/9d25ce743a95a9ad03c0a4b3a705f85c2de52398. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 _

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION ${CMAKE_INSTAL

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

aaron.ballman added a comment. In D99278#2657664 , @tbaeder wrote: > This (and https://reviews.llvm.org/D99338) are both NFC changes once > https://reviews.llvm.org/D97362 lands (they need the three-parameter version > of `ProhibitCXX11Attributes()`). I

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 334178. khchen added a comment. Create a common class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clang/include/clang/Basic/riscv_vector.td clang/test/Co

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Decl.h:82 +enum ReservedIdentifierReason { + StartsWithUnderscoreAtGlobalScope, + StartsWithDoubleUnderscore, serge-sans-paille wrote: > aaron.ballman wrote: > > Because this is not a scop

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 334179. tbaeder added a comment. Added the changes from https://reviews.llvm.org/D99338 and https://reviews.llvm.org/D99278 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D97362 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99278/new/ https://reviews.llvm.org/D99278 ___ cfe-commits mailing list cfe-commits

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

tbaeder abandoned this revision. tbaeder added a comment. Abandoning in favor of https://reviews.llvm.org/D97362 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99338/new/ https://reviews.llvm.org/D99338 ___ cfe-commits mailing list cfe-commits

[PATCH] D99601: [-Wcompletion-handler] Don't recognize init methods as conventional

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://75704162 Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:727 +// The AIX library implementation of C11 atomics is not yet complete. +if (Opts.C11 || Opts.C17 || Opts.C2x) { + Builder.defineMacro("__STDC_NO_ATOMICS__"); ---

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 334186. Max_S added a comment. Cleanup of tests and additonal logic for modifiers at the end of a class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 Files: clang/do

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

khchen updated this revision to Diff 334188. khchen added a comment. Create a common class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99528/new/ https://reviews.llvm.org/D99528 Files: clang/include/clang/Basic/riscv_vector.td clang/test/Co

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. I really like how you split your tests into two files: - `werror_scan.f` captures warning generated by the prescanner - `werror.f` captures warnings from the semantic analysis In every case you added multiple RUN lines to make sure that the behavior is consistent acr

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

amccarth added a comment. I like the composability enabled by making `OF_Text` and `OF_CRLF` independent. I wonder, though, if there's a chokepoint where we could/should assert if the caller uses `OF_CRLF` without `OF_Text`, which would be suspicious. I'm not concerned by the number of files t

[PATCH] D99606: [clang][cli] Fix round-trip of OPT_plugin_arg

john.brawn created this revision. john.brawn added reviewers: jansvoboda11, dexonsmith, Bigcheese. john.brawn requested review of this revision. Herald added a project: clang. The test Frontend/plugin-delayed-template.cpp is failing when asserts are enabled because it hits an assertion in denorma

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S marked 9 inline comments as done. Max_S added a comment. In the last update I fixed now everything and changed the tests. The tests use now verify format when possible. A bug here, kept me from doing it in a few places. I submitted a bug report for this: https://bugs.llvm.org/show_bug.cgi

  1   2   3   >