[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 8e2f5f9 - [Driver] Simplify mips multilib path and fix comments. NFC

Author: Fangrui Song Date: 2021-03-28T00:30:38-07:00 New Revision: 8e2f5f95b5432a6bce14c86a7f2de67fbb5f9dfc URL: https://github.com/llvm/llvm-project/commit/8e2f5f95b5432a6bce14c86a7f2de67fbb5f9dfc DIFF: https://github.com/llvm/llvm-project/commit/8e2f5f95b5432a6bce14c86a7f2de67fbb5f9dfc.diff

[PATCH] D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0

kpet added a comment. Thanks! I'll wait for a couple of days before committing then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99425/new/ https://reviews.llvm.org/D99425 ___ cfe-commits mailing list

[clang-tools-extra] ea2225a - [clang-tidy] Simplify readability checks to not need ignoring* matchers

Author: Stephen Kelly Date: 2021-03-28T11:25:41+01:00 New Revision: ea2225a10be986d226e041d20d36dff17e78daed URL: https://github.com/llvm/llvm-project/commit/ea2225a10be986d226e041d20d36dff17e78daed DIFF: https://github.com/llvm/llvm-project/commit/ea2225a10be986d226e041d20d36dff17e78daed.diff

[PATCH] D98296: [clang-tidy] Simplify readability checks to not need ignoring* matchers

This revision was automatically updated to reflect the committed changes. Closed by commit rGea2225a10be9: [clang-tidy] Simplify readability checks to not need ignoring* matchers (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

LemonBoy created this revision. LemonBoy added a reviewer: craig.topper. LemonBoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AMD Zen3 architecture supports the VAES instruction set but not the 512bit variants, add a feature gate on __

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We treat the expression void() as CXXScalarValueInitExpr for historic reasons probably, but void isn't a

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98548/new/ https://reviews.llvm.org/D98548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

aaronpuchert updated this revision to Diff 333719. aaronpuchert added a comment. Replace `E->getType()` argument by `T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99466/new/ https://reviews.llvm.org/D99466 Files: clang/lib/CodeGen/CGExprScal

[clang] 581b429 - Update the documentation for recent changes to statement attributes.

Author: Aaron Ballman Date: 2021-03-28T09:54:36-04:00 New Revision: 581b429f7d416709f5c78338828beb705bedb396 URL: https://github.com/llvm/llvm-project/commit/581b429f7d416709f5c78338828beb705bedb396 DIFF: https://github.com/llvm/llvm-project/commit/581b429f7d416709f5c78338828beb705bedb396.diff

[clang] c5243c6 - [clang-format] Fix aligning with linebreaks

Author: Björn Schäpers Date: 2021-03-28T16:26:27+02:00 New Revision: c5243c63cda3c740d6e9c7e501f6518c21688da3 URL: https://github.com/llvm/llvm-project/commit/c5243c63cda3c740d6e9c7e501f6518c21688da3 DIFF: https://github.com/llvm/llvm-project/commit/c5243c63cda3c740d6e9c7e501f6518c21688da3.diff

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5243c63cda3: [clang-format] Fix aligning with linebreaks (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. Lets see what others think about this. Im fine with it on my part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org/D83660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

arsenm closed this revision. arsenm added a comment. 4fefed65637ec46c8c2edad6b07b5569ac61e9e5 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98146/new/ https://reviews.llvm.org/D98146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. @nick Sorry that getting these changes merged takes so long. @njames93 If you have an alternative way forward, please let us know what it is. Otherwise, this LGTM too and we should merge it soon unless there are objections which haven't been addressed. =

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

steveire added a comment. @nick I think this also might need to be rebased again, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG821547cabb58: [RISCV][Clang] Update new overloading rules for RVV intrinsics. (authored by khchen). Changed prior to commit: https://reviews.llvm.org/D99189?vs=333486&id=333727#toc Repository: rG LLV

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

craig.topper added a comment. We can't use preprocessor defines in the intrinsic header files. It prevents being able to use the intrinsics with attribute(target("avx512f,vaes")). What's preventing __m512i from being defined? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

LemonBoy added a comment. In D99465#2654633 , @craig.topper wrote: > We can't use preprocessor defines in the intrinsic header files. It prevents > being able to use the intrinsics with attribute(target("avx512f,vaes")). > What's preventing __m512i from

[clang] 3fb40ce - [X86] Don't define vpclmulqdq or vaes intrinsics in the headers unless avx512fintrin.h has been included.

Author: Craig Topper Date: 2021-03-28T11:26:30-07:00 New Revision: 3fb40ce167ff5f05afadf8f525ff9e17350d6d7f URL: https://github.com/llvm/llvm-project/commit/3fb40ce167ff5f05afadf8f525ff9e17350d6d7f DIFF: https://github.com/llvm/llvm-project/commit/3fb40ce167ff5f05afadf8f525ff9e17350d6d7f.diff

[PATCH] D99465: [Clang][X86] Mark some VAES builtins as conditionally defined

craig.topper added a comment. I think I've fixed this in 3fb40ce167ff5f05afadf8f525ff9e17350d6d7f . We need to use the preprocessor define that says avx512fintrin.h was included rather than the feature define. We already did a

[clang] 53c98d8 - [Driver] Suppress libstdc++/libc++ path with -nostdinc

Author: Fangrui Song Date: 2021-03-28T11:30:27-07:00 New Revision: 53c98d85a8a609552448043d5512e70313b1eb1b URL: https://github.com/llvm/llvm-project/commit/53c98d85a8a609552448043d5512e70313b1eb1b DIFF: https://github.com/llvm/llvm-project/commit/53c98d85a8a609552448043d5512e70313b1eb1b.diff

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

nick updated this revision to Diff 333728. nick added a comment. In D69218#2654614 , @steveire wrote: > @nick Sorry that getting these changes merged takes so long. > > @njames93 If you have an alternative way forward, please let us know what it > is. > >

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:466-469 +// [expr.type.conv]: if the type is cv void and the initializer is () or {}, +// the expression is a prva

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

nick added inline comments. Comment at: clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp:301 +TEST_F(RegistryTest, CXXBaseSpecifier) { + // TODO: rewrite with top-level cxxBaseSpecifier matcher when available + DeclarationMatcher ClassHasAnyDirectBase = ste

[clang] 2a28d1d - [Driver] Linux.cpp: move resource directory before /usr/local/include for non-musl

Author: Fangrui Song Date: 2021-03-28T12:44:21-07:00 New Revision: 2a28d1d3b7bf2062288b46af34e33ccc543a99fa URL: https://github.com/llvm/llvm-project/commit/2a28d1d3b7bf2062288b46af34e33ccc543a99fa DIFF: https://github.com/llvm/llvm-project/commit/2a28d1d3b7bf2062288b46af34e33ccc543a99fa.diff

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

joerg added a comment. The NetBSD part looks ok, but also lacks proper testing. I'm not sure anyone but Linux cares at all otherwise as they lack 32bit SPARC support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.or

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng updated this revision to Diff 333737. fanbo-meng set the repository for this revision to rG LLVM Github Monorepo. fanbo-meng added a comment. rebasing to latest master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://revi

[PATCH] D99466: Fix PR48889: assertion failure for void() in flattened ternary expression

aaronpuchert added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:466-469 +// [expr.type.conv]: if the type is cv void and the initializer is () or {}, +// the expression is a prvalue of type void that performs no initialization. +QualType T = E->ge

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333745. mizvekov added a comment. So it turns out there was a pre-existing bug where ObjC++ blocks with dependent return type were not getting copy elision. My latest refactoring accidentally fixed this in the return statement sema action, but unfortunately

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added a subscriber: rjmccall. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else @rjmcca

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333749. mizvekov added a comment. small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333756. mizvekov added a comment. some further simplifications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sem

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17865 +ID = Intrinsic::riscv_crc32_b; +IntrinsicTypes = {ResultType, Ops[0]->getType()}; +break; With the llvm_any_ty change, you'll only need ResultType here. =

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, efriedma, c-rhodes, sdesmalen, rogfer01, frasercrmck, david-arm. Herald added a subscriber: StephenFan. HsiangKai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We

[PATCH] D99483: [clang][AIX] Define __STDC_NO_ATOMICS__ for c11 and above

daltenty created this revision. Herald added a subscriber: jfb. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc implementation on AIX does not have stdatomic.h and the requisite interfaces for c11 atomics, so for now it's

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM although I'm becoming worried about the impact on build times given the rapidly increasing number of multilib variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else mizvekov wrote: > @rjmccall Hello! Do you have