[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added a comment. Hey Aaron, do you have any more comments on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

balazske updated this revision to Diff 332551. balazske added a comment. Rebase and changed test code format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99062/new/ https://reviews.llvm.org/D99062 Files: clang/lib/AST/ASTImporter.cpp clang/u

[PATCH] D98498: [clangd] Enable modules to contribute tweaks.

kadircet updated this revision to Diff 332552. kadircet marked 4 inline comments as done. kadircet added a comment. Herald added a subscriber: mgorny. - Add test - Move forward declarations out of signatures - Move FeatureModuleSets to the last parameter in prepareTweaks Repository: rG LLVM Gi

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke created this revision. Herald added a subscriber: pengfei. LuoYuanke requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Introduce new intrinsic to cast vector and amx. This can prevent middle-end optimization on bit

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. I'm a little bit lost with all this AMX stuff. Could you please explain in normal human words, what does `__tile_loadd()` do? I.e. given void wrapper(__tile& dst, const void *base, int stride) { _tile_loadd(dst, const void *base, int stride); } which bytes fro

[PATCH] D99145: [clang] Fix a crash when CTAD fails

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/Sema/check-arg-alignment.cpp:1 +// Ensure we don't crash when CTAD fails. +// RUN: %clang_cc1 -std=c++17 -verify %s I'd move t

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 332558. curdeius added a comment. - Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Pars

[PATCH] D94355: [Passes] Add relative lookup table converter pass

arichardson added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConverter.cpp:91 + ArrayType::get(Type::getInt32Ty(M.getContext()), NumElts); + GlobalVariable *RelLookupTable = new GlobalVariable( + M, IntArrayTy, LookupTable.isConstant(), Lookup

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. If you follow people tweeting about clang-format (as I do) and you look through the bug tracking system, one major criticism of clang-format is that the second clang-format can be different from the first, sometimes an equilibrium can be found sometimes not. Whe

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. @lebedev.ri, this patch is mainly for discussing the approach that Florian proposed, so I didn't polish my code. Nevertheless your comments for amx_cast.c is right. For __tile_loadd() is to load a 2d tile from memory. There is an extra parameter stride. As I explain i

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

MyDeveloperDay added a comment. In D99031#2640654 , @HazardyKnusperkeks wrote: > In D99031#2640425 , @aybassiouny > wrote: > >>> How about verifyFormat? Would that fail without your patch? >> >> @HazardyKnusperkek

[clang] 3cde27b - [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

Author: Balázs Kéri Date: 2021-03-23T09:54:25+01:00 New Revision: 3cde27bc563ce82ba081be5b650bec523df2c928 URL: https://github.com/llvm/llvm-project/commit/3cde27bc563ce82ba081be5b650bec523df2c928 DIFF: https://github.com/llvm/llvm-project/commit/3cde27bc563ce82ba081be5b650bec523df2c928.diff L

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cde27bc563c: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D99152#2643821 , @LuoYuanke wrote: > @lebedev.ri, this patch is mainly for discussing the approach that Florian > proposed, so I d

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 332562. LevyHsu edited the summary of this revision. LevyHsu added a comment. 1. Fix format issue 2. For SemaChecking.cpp now it should allow Diag to print all missing features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

LevyHsu updated this revision to Diff 332565. LevyHsu edited the summary of this revision. LevyHsu added a comment. 1. Format fix 2. rvintrin.c is moved to the second part of the pach Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99008/new/ https:/

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added a comment. A quick search of github shows over 1 billion hits to the word struct, in a variety of flavours, I'm just not convinced we want a separate option for each and every case, Could we not look for a sequence of "tok::kw_struct,tok::identifier,tok::lbrace" or kw_strc

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. I'd be quite interested to understand what the impact (if any) would be on javascript and C# formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 _

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz updated this revision to Diff 332567. glaubitz edited the summary of this revision. Herald added subscribers: arichardson, emaste. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 Files: clang/lib/B

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

glaubitz added a comment. Updated as I previously forgot to account for FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98574/new/ https://reviews.llvm.org/D98574 ___ cfe-commits mailing l

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

alok created this revision. alok added reviewers: aprantl, jmorse, djtodoro. alok added a project: debug-info. Herald added subscribers: jansvoboda11, pengfei, ormris, hiraditya. Herald added a reviewer: sscalpone. alok requested review of this revision. Herald added projects: clang, LLVM. Herald a

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. @lebedev.ri, our goal is seeking a ideal solution, not arguing who is right. I hope there is no bias during the discussion. I hope Florian and James set a role model for you. They are trying to understand the problem and helping solve the problem. I don't know if it i

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. load instruction loads contigious bytes. If that is not what is AMX is trying to use it for, then it is being used incorrectly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

jansvoboda11 requested changes to this revision. jansvoboda11 added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:4872 + "optimizations.">; +def fverify_debuginfo_preserve_export +: Joined<["-"]

[clang] 54e4654 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-23T05:09:19-05:00 New Revision: 54e4654f0465a960c1a6aeb02bb4ca33a3f19e67 URL: https://github.com/llvm/llvm-project/commit/54e4654f0465a960c1a6aeb02bb4ca33a3f19e67 DIFF: https://github.com/llvm/llvm-project/commit/54e4654f0465a960c1a6aeb02bb4ca33a3f19e67.di

[clang] 1c6521a - [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

Author: Sven van Haastregt Date: 2021-03-23T10:20:13Z New Revision: 1c6521a0ddfabb9c451f57164369e49b2826ee6d URL: https://github.com/llvm/llvm-project/commit/1c6521a0ddfabb9c451f57164369e49b2826ee6d DIFF: https://github.com/llvm/llvm-project/commit/1c6521a0ddfabb9c451f57164369e49b2826ee6d.diff

[PATCH] D98418: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c6521a0ddfa: [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h (authored by svenvh). Herald added a subscriber: ldrumm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99165: [clang] Fix a crash on checkDestructorReference.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. The LookupDestructor requires a complete class definition, the callside (checkDesturctorReference) didnt't guarantee that. Repository: rG LLVM Github Monor

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. In D99152#2644017 , @lebedev.ri wrote: > load instruction loads > contigious bytes. > If that is not what is AMX is trying to use it for, then it is being used > incorrectly

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

lebedev.ri updated this revision to Diff 332600. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Herald added subscribers: cfe-commits, pengfei. Herald added a project: clang. Also update a few clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

djtodoro added a comment. Cool -- thanks for working on this! Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) I think t

[clang] 2f782a7 - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-23T05:52:36-05:00 New Revision: 2f782a796a2b0a4bb5ff772577f96eacdb9254c1 URL: https://github.com/llvm/llvm-project/commit/2f782a796a2b0a4bb5ff772577f96eacdb9254c1 DIFF: https://github.com/llvm/llvm-project/commit/2f782a796a2b0a4bb5ff772577f96eacdb9254c1.di

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

nlopes added a comment. The pointee type in LLVM doesn't really matter. It's even supposed to disappear one day after the migration is completed. E.g., i8* and i64* are exactly the same thing: they are pointers to data. So, I don't understand the motivation for this patch. It doesn't solve the ro

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2668 // ::= g # __float128 + // ::= g # __ibm128 // UNSUPPORTED:::= Dd # IEEE 754r decimal floating point (64 bits) steven.zhang wrote: > This

[PATCH] D99165: [clang] Fix a crash on checkDestructorReference.

sammccall added a subscriber: erik.pilkington. sammccall added a comment. The fix doesn't look obviously correct: the side effect of marking the destructor reference seems important if we actually generate code. It's not obvious to me why the type can only be incomplete if there are errors. Thi

[clang] a234d03 - [NFC] Formatting changes

Author: Abhina Sreeskantharajan Date: 2021-03-23T07:17:54-04:00 New Revision: a234d0319891ae25cdf020dc32bce1c37c0e9867 URL: https://github.com/llvm/llvm-project/commit/a234d0319891ae25cdf020dc32bce1c37c0e9867 DIFF: https://github.com/llvm/llvm-project/commit/a234d0319891ae25cdf020dc32bce1c37c0e

[PATCH] D99072: [NFC] Formatting changes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa234d0319891: [NFC] Formatting changes (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet marked an inline comment as done. kadircet added a comment. In D98499#2626502 , @sammccall wrote: > My model for modules using this diagnostic stuff (apart from the build-system > stuff which sadly can't be meaningfully upstreamed) are IncludeFix

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 332613. kadircet added a comment. - Rename ParsedASTHooks to Listeners. - Generate list of hooks on each parse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98499/new/ https://reviews.llvm.org/D98499 Files:

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet abandoned this revision. kadircet added a comment. > Is this entirely obsoleted by the approach in D98499 > ? yes it is! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

kadircet added a comment. Herald added a project: clang-tools-extra. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98538/new/ https://reviews.llvm.org/D98538 ___ cfe-commits mailing list cfe-commits

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet abandoned this revision. kadircet added a comment. Herald added a project: clang-tools-extra. abandoning in favor of D98498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

lebedev.ri added a comment. In D99152#2644171 , @LuoYuanke wrote: > In D99152#2644017 , @lebedev.ri > wrote: > >> load instruction loads >> contigious bytes. >

[PATCH] D99145: [clang] Fix a crash when CTAD fails

kadircet updated this revision to Diff 332619. kadircet added a comment. - Move test into existing file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99145/new/ https://reviews.llvm.org/D99145 Files: clang/lib/Sema/SemaChecking.cpp clang/test

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

lebedev.ri added subscribers: t.p.northover, dblaikie. lebedev.ri added a comment. In D99121#2644223 , @nlopes wrote: > The pointee type in LLVM doesn't really matter. It's even supposed to > disappear one day after the migration is completed. > E.g., i8*

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

sammccall added a comment. Thanks for finding and working on this hotspot. (I'm curious *why* `isBeforeInTranslationUnit` is slow if you have any insight - it has sad worst-case but I thought we'd hit the one-element cache often enough in practice). I don't see a better way to optimize this, m

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. > To be honest i don't really understand why `x86_amx` type is even there. > It seems to me that if you just directly used > `@llvm.x86.tileloadd64.internal` / `@llvm.x86.tilestored64.internal`, > and `s/x86_amx/<256 x i32>/`, none of these problems would be here. I ex

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

arichardson added a comment. How expensive are these checks? If it is non-trivial overhead, maybe it should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97

[clang] 8f80c66 - [clang] Fix a crash when CTAD fails

Author: Kadir Cetinkaya Date: 2021-03-23T13:03:30+01:00 New Revision: 8f80c66bd2982788a8eede4419684ca72f48b9a2 URL: https://github.com/llvm/llvm-project/commit/8f80c66bd2982788a8eede4419684ca72f48b9a2 DIFF: https://github.com/llvm/llvm-project/commit/8f80c66bd2982788a8eede4419684ca72f48b9a2.dif

[PATCH] D99145: [clang] Fix a crash when CTAD fails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f80c66bd298: [clang] Fix a crash when CTAD fails (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; sammccall wrote: > kadircet wrote: > > usaxena

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:1618 + +if (Tok && (*Tok).is(tok::l_square)) { + Diag(Attrs.Range.getBegin(), diag::err_attributes_not_allowed) << Attrs.Range; tbaeder wrote: > aaron.ballman wrote: > > This

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet updated this revision to Diff 332636. kadircet marked 2 inline comments as done. kadircet added a comment. - Ignore capability - Store data as a json::Object rather than an Array. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98505/new/ ht

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov, martong. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, yaxunl. vsavchenko requested review of this revision.

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, thopre, rupprecht, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. abhina.sreeskantharajan requested review of this revision. Herald added projects

[clang] 274907c - [ASTImporter] Split out Objective-C related unit tests

Author: Raphael Isemann Date: 2021-03-23T13:58:45+01:00 New Revision: 274907c0a4d6dbdc8815f9a37ea2e444bdfee528 URL: https://github.com/llvm/llvm-project/commit/274907c0a4d6dbdc8815f9a37ea2e444bdfee528 DIFF: https://github.com/llvm/llvm-project/commit/274907c0a4d6dbdc8815f9a37ea2e444bdfee528.dif

[PATCH] D99162: [ASTImporter] Split out Objective-C related unit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG274907c0a4d6: [ASTImporter] Split out Objective-C related unit tests (authored by teemperor). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332644. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Herald added a subscriber: JDevlieghere. Move FileSize to the end because it is never used. Repository: rG LLVM Github Monorepo C

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1453 - -Diag(Tok, diag::err_lambda_missing_parens) - << TokKind I believe you can remove this diagnostic from DiagnosticParseKinds.td now. Comment at: cl

[clang] 0bc1959 - [RISCV][NFC] Fix RVV intrinsic tests.

Author: Zakk Chen Date: 2021-03-23T06:06:05-07:00 New Revision: 0bc1959f51e9adcd8de1f89cc93144caa57bd653 URL: https://github.com/llvm/llvm-project/commit/0bc1959f51e9adcd8de1f89cc93144caa57bd653 DIFF: https://github.com/llvm/llvm-project/commit/0bc1959f51e9adcd8de1f89cc93144caa57bd653.diff LOG

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Hmm, there recently were quite some changes in the MultiArch and GCC search path functionality in the Driver and I can unfortunately no longer get it to work on x32. I had a relatively simple approach but I cannot get it to add the path for the crt.o objects and so on

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 332649. arnamoy10 added a comment. Addressing minor issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D97993: [Driver] Suppress GCC detection under -B

thakis added a comment. Also broke something in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1191244 (since fixed by switching something from `-B` to `--gcc-toolchain`. This only landed 4 days ago and already broke a lot of things (see above) -- chances are it's going to bre

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 332658. yaxunl added a comment. Re-use existing warning instead of introducing new diagnostics. Ping. Can some one help review this patch? I believe all comments addressed. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://re

[PATCH] D99185: [PowerPC] Change option to mrop-protect

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: jansvoboda11, dang, shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. In order to have the same option on p

[clang] 4146864 - [PowerPC][NFC] Use valid type for offset in altivec.h

Author: Nemanja Ivanovic Date: 2021-03-23T08:45:37-05:00 New Revision: 4146864735443a827490c7715191f3b8ba16f0e3 URL: https://github.com/llvm/llvm-project/commit/4146864735443a827490c7715191f3b8ba16f0e3 DIFF: https://github.com/llvm/llvm-project/commit/4146864735443a827490c7715191f3b8ba16f0e3.di

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

sberg added a comment. FWIW, LibreOffice `make check` (which started to consistently fail with D88220 ) succeeds with this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98971/new/ https://reviews.llvm.org/D

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen updated this revision to Diff 332660. khchen marked 8 inline comments as done. khchen added a comment. 1. address Craig's comments. 2. add 'REQUIRES: riscv-registered-target' for tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/

[PATCH] D99158: [RISCV][WIP] Implement intrinsics for P extension

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11170-11175 // RISC-V V-extension def err_riscvv_builtin_requires_v : Error< "builtin requires 'V' extension support to be enabled">; +// RISC-V P-extension +def err_riscvv_builtin_re

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

Quuxplusone updated this revision to Diff 332663. Quuxplusone added a comment. Shrink the code by one line, by introducing another local named variable. Still hoping for an "accept" here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98971/new/ htt

[clang] bc6b139 - [clang][parser] Don't prohibit attributes on objc @try/@throw

Author: Timm Bäder Date: 2021-03-23T15:26:25+01:00 New Revision: bc6b139392f638a69e85a474eb0eb59e13d9791a URL: https://github.com/llvm/llvm-project/commit/bc6b139392f638a69e85a474eb0eb59e13d9791a DIFF: https://github.com/llvm/llvm-project/commit/bc6b139392f638a69e85a474eb0eb59e13d9791a.diff LO

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc6b139392f6: [clang][parser] Don't prohibit attributes on objc @try/@throw (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Thanks everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

liaolucy added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98848/new/ https://reviews.llvm.org/D98848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh updated this revision to Diff 332675. svenvh added a comment. Emit `#if` guards for extensions and versions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 Files: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp clang/utils/TableGe

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader created this revision. Herald added subscribers: mstorsjo, Anastasia, ebevhan, yaxunl. bader requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Initial version of the document covers most of t

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. I thought maybe you wanted to follow @mizvekov's proposal to simplify, but I understand you want to stick close to the standard language. So LGTM. Repository: rG LLVM Github Mo

[PATCH] D98971: [C++20] [P1825] Fix bugs with implicit-move from variables of reference type

mizvekov added a comment. In D98971#2644747 , @Quuxplusone wrote: > Shrink the code by one line, by introducing another local named variable. > Still hoping for an "accept" here. My two cents: Functionality-wise I think it is OK, but like I said before,

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. In D98237#2643815 , @MyDeveloperDay wrote: > If you follow people tweeting about clang-format (as I do) and you look > through the bug tracking system, one major criticism of clang-format is that > the second clang-format can be d

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added inline comments. Comment at: clang/include/clang/Driver/Options.td:4872 + "optimizations.">; +def fverify_debuginfo_preserve_export +: Joined<["-"], "fverify-debuginfo-preserve-export=">, jansvoboda11 wrote: > Please, update the n

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 332679. djtodoro added a comment. - addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h c

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske updated this revision to Diff 332686. balazske added a comment. Fixed according to the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 Files: clang/lib/AST/Expr.cpp clang/unittests/To

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99106/new/ https://reviews.llvm.org/D99106 __

[PATCH] D99193: [PowerPC] Add mprivileged option

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: jansvoboda11, dang, shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Add an option to tell the compiler th

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske marked 3 inline comments as done. balazske added a comment. Ping. I am not sure how to the test should be changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 __

[PATCH] D98950: [clang][deps] NFC: Document collector, rename members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. Code makes more sense now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98950/new/ https://reviews.llvm.org/D9895

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, steakhal, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, kristof.beyls. vsavchenko requested review of this revision. H

[PATCH] D99194: [analyzer] Fix body farm for Obj-C++ properties

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I'm not familiar with Objective-C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99194/new/ https://reviews.llvm.org/D99194 __

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 added inline comments. Comment at: flang/test/Semantics/dosemantics03.f90:1-2 ! RUN: %S/test_errors.sh %s %t %f18 -Mstandard -Werror +! RUN: %S/test_errors.sh %s %t %flang_fc1 -Werror awarzynski wrote: > Rather than adding the 2nd line, could you upd

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332692. arnamoy10 added a comment. Thanks @awarzynski for the comments. 1. Moving diagnostics options parsing to a separate function 2. Adding a check so that `-Wblah` does not trigger the treatment of warnings as werrors, only `-Werror` triggers it 3. Add

[clang] cd4abc5 - [flang][driver] Add -fintrinsic-modules-path option

Author: Arnamoy Bhattacharyya Date: 2021-03-23T12:28:19-04:00 New Revision: cd4abc5242c03804b3d88277b03b52215a899f75 URL: https://github.com/llvm/llvm-project/commit/cd4abc5242c03804b3d88277b03b52215a899f75 DIFF: https://github.com/llvm/llvm-project/commit/cd4abc5242c03804b3d88277b03b52215a899f

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4abc5242c0: [flang][driver] Add -fintrinsic-modules-path option (authored by Arnamoy Bhattacharyya , committed b

[PATCH] D98712: [Utils] Support lit-like substitutions in update_cc_test_checks

ggeorgakoudis added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:228 + '%t' : tempfile.NamedTemporaryFile().name, + '%S' : os.getcwd(), +} arichardson wrote: > Shouldn't this be the directory containing the test? You are right,

[PATCH] D99106: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

This revision was automatically updated to reflect the committed changes. Closed by commit rG8298899e56cd: [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 8298899 - [ASTMatchers][NFC] Use SmallVector when building variadic matcher descriptor

Author: Nathan James Date: 2021-03-23T16:38:45Z New Revision: 8298899e56cdf89c68215853010352c45398ab10 URL: https://github.com/llvm/llvm-project/commit/8298899e56cdf89c68215853010352c45398ab10 DIFF: https://github.com/llvm/llvm-project/commit/8298899e56cdf89c68215853010352c45398ab10.diff LOG:

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332703. arnamoy10 added a comment. 1. Leaning out the "wrong-option" test case 2. Adding aliases in f18 (`-pedantic` and `-std=2018` for `-Mstandard`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files:

[PATCH] D33029: [clang-format] add option for dangling parenthesis

jakar added a comment. @catskul can you share your changes somehow? If you did, sorry, I'm new to Phabricator. Before I saw @catskul's comment, I rebased @stringham's diff and got the existing unit tests to work. But after some experimentation, I found that it didn't always behave like I expec

  1   2   >