[clang] ace56d4 - [WoA][MSVC] Use default linker setting in MSVC-compatible driver

Author: Maxim Kuvyrkov Date: 2021-03-18T07:42:55Z New Revision: ace56d41aca8cac7cead9c2c97278aa50fc945b1 URL: https://github.com/llvm/llvm-project/commit/ace56d41aca8cac7cead9c2c97278aa50fc945b1 DIFF: https://github.com/llvm/llvm-project/commit/ace56d41aca8cac7cead9c2c97278aa50fc945b1.diff LOG

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGace56d41aca8: [WoA][MSVC] Use default linker setting in MSVC-compatible driver (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a subscriber: tstellar. maxim-kuvyrkov added a comment. @tstellar , OK to backport to release/12.x if buildbots are happy with this? I've filed https://bugs.llvm.org/show_bug.cgi?id=49624 with background info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6802fdf - [NFC] Minor cleanup to use default setting of getLastArg()

Author: Maxim Kuvyrkov Date: 2021-03-18T07:47:31Z New Revision: 6802fdf8871f69d52b06d0a2b7f62f3af8292690 URL: https://github.com/llvm/llvm-project/commit/6802fdf8871f69d52b06d0a2b7f62f3af8292690 DIFF: https://github.com/llvm/llvm-project/commit/6802fdf8871f69d52b06d0a2b7f62f3af8292690.diff LOG

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6802fdf8871f: [NFC] Minor cleanup to use default setting of getLastArg() (authored by maxim-kuvyrkov). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cf

[PATCH] D87981: [X86] AMX programming model.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:90 +INITIALIZE_PASS_BEGIN(X86PreTileConfig, "tilepreconfig", + "Tile Register Configure", false, false) +INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree) It sh

[clang] 62948c4 - Revert "[NFC] Minor cleanup to use default setting of getLastArg()"

Author: Maxim Kuvyrkov Date: 2021-03-18T08:07:02Z New Revision: 62948c4532d59b59f63409eae5d7f9e4990e5626 URL: https://github.com/llvm/llvm-project/commit/62948c4532d59b59f63409eae5d7f9e4990e5626 DIFF: https://github.com/llvm/llvm-project/commit/62948c4532d59b59f63409eae5d7f9e4990e5626.diff LOG

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov added a comment. The patch was wrong. We use "const Arg *A" at the end of GetLinkerPath, so can't remove it. I thought I tested this, but, apparently, not. Reverted in 62948c4532d59b59f63409eae5d7f9e4990e5626

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

asl added a comment. Indeed! And even worse, there is another 'A' shadowing definition below :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 ___ cfe-commits ma

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 331484. balazske added a comment. Change of text in dump, add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files: clang/lib/StaticAnalyzer/Checkers/Pthrea

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske updated this revision to Diff 331485. balazske added a comment. Add accidentally removed empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98502/new/ https://reviews.llvm.org/D98502 Files: clang/lib/StaticAnalyzer/Checkers/Pthre

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:90 +INITIALIZE_PASS_BEGIN(X86PreTileConfig, "tilepreconfig", + "Tile Register Configure", false, false) +INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree) yu

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Thank you. I'm not looking at this test case: void opaque(void); void opaque2(void); void opaque3(void); @class C; int main(int argc, const char * argv[]) { __attribute__((nomerge)) @try { opaque(); } @catch(C *c) { opaque2(); } @f

[PATCH] D98824: [Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+

kadircet added a comment. thanks for looking into this! we also had a related report about this in clangd , but didn't have time to dive into it. this is definitely fixing an issue in interpolating compilation database, but unfortunately there are s

[clang] f1a7d5a - [-Wcalled-once-parameter] Harden analysis in terms of block use

Author: Valeriy Savchenko Date: 2021-03-18T12:12:18+03:00 New Revision: f1a7d5a7b0ec810057ff6e88371ab86d1fce812c URL: https://github.com/llvm/llvm-project/commit/f1a7d5a7b0ec810057ff6e88371ab86d1fce812c DIFF: https://github.com/llvm/llvm-project/commit/f1a7d5a7b0ec810057ff6e88371ab86d1fce812c.d

[PATCH] D98688: [-Wcalled-once-parameter] Harden analysis in terms of block use

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1a7d5a7b0ec: [-Wcalled-once-parameter] Harden analysis in terms of block use (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98688/n

[PATCH] D98757: [AMX] Not fold constant bitcast into amx intrisic

fhahn added a comment. In D98757#2633396 , @xiangzhangllvm wrote: > In D98757#2631042 , @lebedev.ri > wrote: > >> The ongoing special-casing of `X86_AMXTy` through the llvm due to the >> inability of the existing

[clang] 4a7afc9 - [-Wcalled-once-parameter] Fix false positives for cleanup attr

Author: Valeriy Savchenko Date: 2021-03-18T12:32:16+03:00 New Revision: 4a7afc9a8843f4793296a260f7153fd2ef4ec497 URL: https://github.com/llvm/llvm-project/commit/4a7afc9a8843f4793296a260f7153fd2ef4ec497 DIFF: https://github.com/llvm/llvm-project/commit/4a7afc9a8843f4793296a260f7153fd2ef4ec497.d

[PATCH] D98694: [-Wcalled-once-parameter] Fix false positives for cleanup attr

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7afc9a8843: [-Wcalled-once-parameter] Fix false positives for cleanup attr (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98694/ne

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked 8 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro

[PATCH] D98848: [RISCV][Clang] Add RVV Vector Indexed Load intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai, evandro. Herald added subscribers: vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, edward

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

varjujan added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro-Winkler. whisperity wrote: >

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. What if CLANG_DEFAULT_LINKER=ld? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. This patch broke clang-ppc64le-rhel builder. The patch makes MSVC-compatible driver honour CLANG_DEFAULT_LINKER setting, which this builder sets to “lld”. Therefore there’s an expected change in the output now that CLANG_DEFAULT_LINKER can override link.exe. T

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634089 , @SureYeaah wrote: > What if CLANG_DEFAULT_LINKER=ld? @SureYeaah , then *-msvc targets will attempt to use "ld" linker as instructed. Or are you asking about something else? Repository: rG LLVM Gith

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant. Can we revert this patch until then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre created this revision. thopre added reviewers: andwar, david-arm, sdesmalen, SjoerdMeijer, kmclaughlin. Herald added a subscriber: tschuett. thopre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang test acle_sve_ld1.sh is missing

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov added a comment. In D98493#2634107 , @SureYeaah wrote: > We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER > is set to ld. It would be nice to make the tests more tolerant. > > Can we revert this patch until then?

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing! I'm curious, how did you find this case? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/ https://rev

[clang] d8b8f54 - [Reland] "Do not apply calling conventions to MSVC entry points"

Author: Elizabeth Andrews Date: 2021-03-18T04:26:47-07:00 New Revision: d8b8f544d9de30cd14584094596090d3f9992345 URL: https://github.com/llvm/llvm-project/commit/d8b8f544d9de30cd14584094596090d3f9992345 DIFF: https://github.com/llvm/llvm-project/commit/d8b8f544d9de30cd14584094596090d3f9992345.d

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

This revision was automatically updated to reflect the committed changes. eandrews marked an inline comment as done. Closed by commit rGd8b8f544d9de: [Reland] "Do not apply calling conventions to MSVC entry points" (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Githu

[clang] 8b8b9af - [-Wcalled-once-parameter][NFC] Fix GCC compilation error

Author: Valeriy Savchenko Date: 2021-03-18T14:49:24+03:00 New Revision: 8b8b9af8c9132acb446fc42569de8a0f57c6b556 URL: https://github.com/llvm/llvm-project/commit/8b8b9af8c9132acb446fc42569de8a0f57c6b556 DIFF: https://github.com/llvm/llvm-project/commit/8b8b9af8c9132acb446fc42569de8a0f57c6b556.d

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Implement the TreeTransform for AsTypeExpr. Split `BuildAsTypeExpr` out of `ActOnAs

[clang] c1fb23c - [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

Author: Balazs Benics Date: 2021-03-18T13:06:38+01:00 New Revision: c1fb23c1aadd22e736c4a1c36c146bbfbc48f959 URL: https://github.com/llvm/llvm-project/commit/c1fb23c1aadd22e736c4a1c36c146bbfbc48f959 DIFF: https://github.com/llvm/llvm-project/commit/c1fb23c1aadd22e736c4a1c36c146bbfbc48f959.diff

[PATCH] D98707: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1fb23c1aadd: [clang][ASTImporter] Fix import of VarDecl regarding thread local storage spec (authored by Balazs Benics ). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls, mgorny. sdesmalen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In order to bring up scalable vector support in LLVM increm

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

thopre added a comment. In D98852#2634189 , @sdesmalen wrote: > LGTM, thanks for fixing! > > I'm curious, how did you find this case? :) The issue was caught by a patch of mine to FileCheck: https://reviews.llvm.org/D98691 Repository: rG LLVM Github

[clang] e5cd5b3 - [test] Fix variable definition in acle_sve_ld1.sh

Author: Thomas Preud'homme Date: 2021-03-18T12:15:45Z New Revision: e5cd5b352ff481f02e1f4555033edf87112dcc0c URL: https://github.com/llvm/llvm-project/commit/e5cd5b352ff481f02e1f4555033edf87112dcc0c DIFF: https://github.com/llvm/llvm-project/commit/e5cd5b352ff481f02e1f4555033edf87112dcc0c.diff

[PATCH] D98852: [test] Fix variable definition in acle_sve_ld1.sh

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5cd5b352ff4: [test] Fix variable definition in acle_sve_ld1.sh (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98852/new/ https://revie

[clang] c5c4a88 - [OpenCL] Remove spurious atomic_fetch tablegen builtins

Author: Sven van Haastregt Date: 2021-03-18T12:17:12Z New Revision: c5c4a88a840037fd38cb35d5efd524d51dcc091b URL: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b DIFF: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b.diff

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5c4a88a8400: [OpenCL] Remove spurious atomic_fetch tablegen builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98520/new/ https:/

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 331528. arnamoy10 added a comment. Fixing bug in test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 331532. whisperity marked 3 inline comments as done. whisperity added a comment. **NFC** Made the code more legible, updated and clarified some comments, fixed grammar issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:31-32 + + char DissimilarBelow; + char SimilarAbove; + aaron.ballman wrote: > `signed char` since we're doing `> -1` below? Or better yet, `i

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro-Winkler. varjujan wrote:

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:657-660 +} else { + ParamTypes.push_back(QualType()); + ParamNames.push_back(StringRef()); +} ---

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski added a comment. Hi @protze.joachim, Thank you for your feedback. I'm sorry that this is causing issues in your set-up. In D95460#2632844 , @protze.joachim wrote: > Before this patch, clang would happily ignore a `-ffree-form` flag. It's a

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

jansvoboda11 removed a reviewer: jansvoboda11. jansvoboda11 added inline comments. Herald added a subscriber: jansvoboda11. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:640 +StringRef CheckList = A->getValue(); +Opts.TidyChecks.emplace_back(CheckList); + } -

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov created this revision. maxim-kuvyrkov added a reviewer: asl. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://reviews.llvm.org/D98493 clang driver for *-msvc target uses linker from CLANG_DEFAULT_L

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:347-349 +static bool areTypesCompatible(QualType ArgType, QualType ParamType, + const ASTContext &Ctx) { + if (ArgType.isNull(

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. In D97869#2628679 , @azabaznov wrote: > I have one more though. > > I like the idea of turning `opencl-c.h` into the test: as it is already in > the repo and is already being used for quite a while we can assume it as a > mainl

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../include/flang/"

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity marked 12 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:657-660 +} else { + ParamTypes.push_back(QualType()); + ParamNames.push_back(StringRef()); +} --

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, muiez, Kai, anirudhp, DanielMcIntosh-IBM. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On z/OS there is a hard limitation on on the maximu

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng updated this revision to Diff 331553. fanbo-meng added a comment. Herald added subscribers: sstefan1, phosek, s.egerton, jfb, mgrang, simoncook, fedor.sergeev, aheejin, krytarowski, dschuff. Herald added a reviewer: jfb. Herald added a reviewer: jdoerfert. clang-formatted CHANGES SIN

[clang] eefda60 - [flang][driver] Add support for `-fget-symbols-sources`

Author: Andrzej Warzynski Date: 2021-03-18T14:13:24Z New Revision: eefda605fe1701937a8fe5379357e0990ad2fb4e URL: https://github.com/llvm/llvm-project/commit/eefda605fe1701937a8fe5379357e0990ad2fb4e DIFF: https://github.com/llvm/llvm-project/commit/eefda605fe1701937a8fe5379357e0990ad2fb4e.diff

[PATCH] D98191: [flang][driver] Add support for `-fdebug-dump-symbols-sources`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeefda605fe17: [flang][driver] Add support for `-fget-symbols-sources` (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D98867: [HIP] Fix ROCm detection

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. ROCm has changed installation path to /opt/rocm-{release}. Add detection for that. Also support ROCM_PATH environment variable. https://revi

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

fanbo-meng updated this revision to Diff 331559. fanbo-meng added a comment. remove accidentally included diff patch file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://reviews.llvm.org/D98864 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/ASTContext.

[PATCH] D98868: [Driver] Add -print-runtime-dir

zero9178 created this revision. zero9178 added reviewers: rnk, phosek, MaskRay. Herald added subscribers: jansvoboda11, dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new command line option to clang which

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2632848 , @rjmccall wrote: > In D96033#2630978 , @v.g.vassilev > wrote: > I'm nervous in general about the looming idea of declaration unloading, but the fact that

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 331560. whisperity marked 2 inline comments as done. whisperity added a comment. - **NFC** Fixed some nits - Added a new check option, //`MinimumIdentifierNameLength`// instead of a hardcoded `3` value. Defaults to `3`. - Fixed an issue with heuristics mat

[clang] c539be1 - [Hexagon] Add support for named registers cs0 and cs1

Author: Sid Manning Date: 2021-03-18T09:53:22-05:00 New Revision: c539be1dcbcf88530cfaf1728b077feb564b72ec URL: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec DIFF: https://github.com/llvm/llvm-project/commit/c539be1dcbcf88530cfaf1728b077feb564b72ec.diff L

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity updated this revision to Diff 331564. whisperity marked 4 inline comments as done. whisperity added a comment. **NFC** Turned some `Optional` into just `T`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78652/new/ https://reviews.llvm.or

[PATCH] D78652: [clang-tidy] Suppress reports to similarly used parameters in 'bugprone-easily-swappable-parameters'

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:529 +/// ReturnStmts return them from the function. +class Returned { + llvm::SmallVector ReturnedParams; aaron.ballman wrote: > whisperity w

[PATCH] D72235: [clang-tidy] new altera unroll loops check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Mostly just nits for the check, otherwise this LGTM. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:65 +} +if (isa(Loop) || isa(Lo

[PATCH] D95736: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with `typedef` and `const &` diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 ___ cfe-commits mailing list

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert updated this revision to Diff 331567. aaronpuchert added a comment. Negative capabilities don't need to be considered as managed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98747/new/ https://reviews.llvm.org/D98747 Files: clang/

[PATCH] D98855: [OpenCL] Support template parameters for as_type

Anastasia accepted this revision. Anastasia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: siz

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331570. jnykiel retitled this revision from "[Tooling] Handle compilation databases with clang-cl commands generated by CMake 3.19+" to "[Tooling] Handle compilation databases containing commands with double dashes". jnykiel edited the summary of this revisio

[PATCH] D98873: Document -fcrash-diagnostics-dir

probinson created this revision. probinson added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. probinson requested review of this revision. Herald added a project: clang. This was added in LLVM 7.0 but without help text or other docs. Repository: rG LLVM Github Monorepo http

[PATCH] D98862: [clang] Update unit-tests after linker selection fix for *-msvc targets

maxim-kuvyrkov added a comment. @SureYeaah , does this fix your internal buildbot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98862/new/ https://reviews.llvm.org/D98862 ___ cfe-commits mailing list cf

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + Should this be `MIX_WorkaroundDisableCanonicalEquivalence` instead

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2634758 , @luismarques wrote: > I just looked at this again and I don't have the full context in my mind > right now but won't the test just exercise the BareMetal toolchain and not > your changes? I've since lost my re

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331581. njames93 added a comment. Fix formatting issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/test/SemaCXX/constructor-initializer.cpp clang

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331582. njames93 added a comment. Arc got confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D98415: [aarch64][WOA64][docs] Release note for WoA-hosted LLVM 12 binary

maxim-kuvyrkov closed this revision. maxim-kuvyrkov added a comment. This is merged to release/12.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98415/new/ https://reviews.llvm.org/D98415 ___ cf

[clang] c2f8e15 - [OPENMP51]Support for the 'destroy' clause with interop variable.

Author: Mike Rice Date: 2021-03-18T09:12:56-07:00 New Revision: c2f8e158f57c173298ac39db8fd44211604ed003 URL: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003 DIFF: https://github.com/llvm/llvm-project/commit/c2f8e158f57c173298ac39db8fd44211604ed003.diff LOG

[PATCH] D98834: [OPENMP51]Support for the 'destroy' clause with interop variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f8e158f57c: [OPENMP51]Support for the 'destroy' clause with interop variable. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 5 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:377 + + bool indicatesMixability() const { return Flags > MIX_None; } + aaron.ballman wrote: > Sh

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

protze.joachim added a comment. Hi Andrzej, thanks for the detailed insights. I think I really misunderstood, what the -W flags can do here. I also was not up-to-date regarding the state of the flang implementation. I just found, that compiling Spec OMP 2012 with clang-12 worked fine with my

[clang] 92ccc6c - Reapply "[NPM][CGSCC] FunctionAnalysisManagerCGSCCProxy: do not clear immutable function passes"

Author: Mircea Trofin Date: 2021-03-18T09:44:34-07:00 New Revision: 92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345 URL: https://github.com/llvm/llvm-project/commit/92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345 DIFF: https://github.com/llvm/llvm-project/commit/92ccc6cb17a4fd1b9506bac51f2eb1a96f4cd345.diff

[PATCH] D98864: [SystemZ][z/OS] Set maximum value to truncate attribute aligned to for static variables on z/OS target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98864/new/ https://reviews.llvm.org/D98864 ___ cfe-co

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8611 +def warn_some_initializers_out_of_order : Warning< + "some initializers aren't given in the correct order">, + InGroup, DefaultIgnore; Hmmm, how about `initi

[PATCH] D98876: [clang][ASTImporter] Add import support for SourceLocExpr.

balazske created this revision. Herald added subscribers: martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is

[PATCH] D98824: [Tooling] Handle compilation databases containing commands with double dashes

jnykiel updated this revision to Diff 331605. jnykiel added a comment. Fixed logic error in `injectResourceDir` causing a test failure on the build machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98824/new/ https://reviews.llvm.org/D98824 Files: clang/lib/Tooling/ArgumentsAdj

[PATCH] D98855: [OpenCL] Support template parameters for as_type

svenvh added inline comments. Herald added a subscriber: ldrumm. Comment at: clang/test/SemaOpenCLCXX/template-astype.cl:5 +auto templated_astype(T x) { + return as_int2(x); + // expected-error@-1{{invalid reinterpretation: sizes of 'int2' (vector of 2 'int' values) and '__pri

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

ashi1 added a comment. In D98278#2618936 , @zero9178 wrote: > In D98278#2616932 , @mstorsjo wrote: > >> In D98278#2616916 , @zero9178 wrote: >> >>> Add GetErrcMessages.cmake,

[PATCH] D98812: [OPENMP]Map data field with l-value reference types.

ABataev updated this revision to Diff 331623. ABataev added a comment. Rebase + fixes for references to complex data structures mapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98812/new/ https://reviews.llvm.org/D98812 Files: clang/lib/Cod

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2635190 , @ashi1 wrote: > In D98278#2618936 , @zero9178 wrote: > >> In D98278#2616932 , @mstorsjo wrote: >> >>> In D98278#2616916

[PATCH] D98867: [HIP] Fix ROCm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:271 +} +if (LatestROCm < FileName) + LatestROCm = FileName.str(); This will rank `rocm-3.9` higher than `rocm-3.10`. I think you do need to extract and compare the version

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5242 + if (Previous->isAnyMemberInitializer()) +Diag << 0 << Previous->getAnyMember()->getDeclName(); + else aaron.ballman wrote: > This w

[PATCH] D98745: [clang] Add fixit for Wreorder-ctor

njames93 updated this revision to Diff 331635. njames93 marked an inline comment as done. njames93 added a comment. Address nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98745/new/ https://reviews.llvm.org/D98745 Files: clang/include/clang

[clang] 2f2ae08 - [WebAssembly] Remove experimental SIMD instructions

Author: Thomas Lively Date: 2021-03-18T11:21:24-07:00 New Revision: 2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a URL: https://github.com/llvm/llvm-project/commit/2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a DIFF: https://github.com/llvm/llvm-project/commit/2f2ae08da91dc5c188d5bb4d8b0b096d0a120a4a.diff

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f2ae08da91d: [WebAssembly] Remove experimental SIMD instructions (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D98466?

[clang] f5764a8 - [WebAssembly] Finalize SIMD names and opcodes

Author: Thomas Lively Date: 2021-03-18T11:21:25-07:00 New Revision: f5764a8654e3caa6ca5dab3a89238c165062228f URL: https://github.com/llvm/llvm-project/commit/f5764a8654e3caa6ca5dab3a89238c165062228f DIFF: https://github.com/llvm/llvm-project/commit/f5764a8654e3caa6ca5dab3a89238c165062228f.diff

[PATCH] D98676: [WebAssembly] Finalize SIMD names and opcodes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5764a8654e3: [WebAssembly] Finalize SIMD names and opcodes (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D98676?vs=330

[PATCH] D98827: [AST] Ensure that an empty json file is generated if compile errors

njames93 added a comment. Are there any tests that ensure something is always outputted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98827/new/ https://reviews.llvm.org/D98827 ___ cfe-commits mailing l

  1   2   >