[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

sammccall updated this revision to Diff 330163. sammccall added a comment. Omit narrower, now-redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98459/new/ https://reviews.llvm.org/D98459 Files: clang/include/clang/Parse/Parser.h cl

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: usaxena95. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This hides such tokens from TokenWatcher, preventing crashes

[clang] 840643b - [OpenCL] Refactor diagnostic for OpenCL extension/feature

Author: Anton Zabaznov Date: 2021-03-12T11:43:53+03:00 New Revision: 840643bbe1d25c88b0832f93c8bf3b2c451c7b14 URL: https://github.com/llvm/llvm-project/commit/840643bbe1d25c88b0832f93c8bf3b2c451c7b14 DIFF: https://github.com/llvm/llvm-project/commit/840643bbe1d25c88b0832f93c8bf3b2c451c7b14.diff

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG840643bbe1d2: [OpenCL] Refactor diagnostic for OpenCL extension/feature (authored by azabaznov). Changed prior to commit: https://reviews.llvm.org

[PATCH] D98459: [CodeCompletion] Don't track preferred types if code completion is disabled.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/include/clang/Parse/Parser.h:944 public: -explicit TentativeParsingAction(Parser& p) : P(p) { - PrevPreferredType = P.Preferre

[clang] 194861f - [Matrix] Add missing newline to appease sphinx.

Author: Florian Hahn Date: 2021-03-12T09:33:36Z New Revision: 194861fa1bdfa852f18cb5690509ac0f05219ba1 URL: https://github.com/llvm/llvm-project/commit/194861fa1bdfa852f18cb5690509ac0f05219ba1 DIFF: https://github.com/llvm/llvm-project/commit/194861fa1bdfa852f18cb5690509ac0f05219ba1.diff LOG:

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); --

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet updated this revision to Diff 330184. kadircet added a comment. - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98483/new/ https://reviews.llvm.org/D98483 Files: clang/lib/Parse/ParsePragma.cpp clang/unittests/Tooling/Syntax/

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:364 + if (HasRandGen) +Builder.defineMacro("__ARM_FEATURE_RNG", "1"); + This needs a clang preprocessor test: both a check for its presence and absence. Have a look/grep wher

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

RKSimon added a comment. @azabaznov This has broken some buildbots http://lab.llvm.org:8011/#/builders/105/builds/6855 - can you take a look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058 ___

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon abandoned this revision. segoon added a comment. see https://reviews.llvm.org/D94622#2617417 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

ldrumm added a subscriber: svenvh. ldrumm added a comment. @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews.llvm.org/D98411 ___

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, joechrisellis, CarolineConcatto, dmgreen. Herald added subscribers: hiraditya, kristof.beyls, tschuett. bsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Somewhat surprisingly, signature help is emitted as a side-effec

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330205. bsmith marked 3 inline comments as done. bsmith added a comment. - State what lack of vscale_range attribute means in LangRef - Minor formatting change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98030/

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:570 +Result += utostr(MinValue); +Result += ','; +Result += utostr(MaxValue); peterwaller-arm wrote: > Nit: The only other precedent I can see for this is `allocsize`. Grepping the

[clang] e448310 - Add support for digit separators in C2x.

Author: Aaron Ballman Date: 2021-03-12T07:21:03-05:00 New Revision: e448310059053d69fbdd6c66dd95ad5d3cfc6243 URL: https://github.com/llvm/llvm-project/commit/e448310059053d69fbdd6c66dd95ad5d3cfc6243 DIFF: https://github.com/llvm/llvm-project/commit/e448310059053d69fbdd6c66dd95ad5d3cfc6243.diff

[PATCH] D98337: Add support for digit separators in C2x

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review, I've commit in e448310059053d69fbdd6c66dd95ad5d3cfc6243 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D98030: [IR] Add vscale_range IR function attribute

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Looks fine to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98030/new/ https://reviews.llvm.org/D98030 __

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

stefanp accepted this revision. stefanp added a comment. This revision is now accepted and ready to land. Thank you for adding this! Other than one minor nit I think this LGTM. Feel free to address nits on commits. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8834 +

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a small, technical nit to be fixed. Comment at: clang/include/clang/Basic/Attr.td:1664 +def StandaloneDebug : InheritableAttr { + let Spellings = [Clang<"standalone_debug">]; + let Subjects = Subje

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

aaron.ballman added a comment. I should note, you need to also fix the CI build failures: https://reviews.llvm.org/harbormaster/unit/view/421174/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 ___

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

hokein added a comment. This looks like a reasonable solution to me -- if we don't know the function call result type (e.g. dependent-type callExpr in template context), modeling it as a dependent type. Comment at: clang/lib/AST/Expr.cpp:1387 + + auto CreateDependentType = [

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz added a comment. I think this makes good progress. I found two details in the test code that need attention. The stdout issue might be done now or in a follow-up patch some time soon. Otherwise, this seems to get ready to land. @teemperor What about your notes. Are there any open issu

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

MForster added a comment. That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it was his suggestion in the first place to go to declref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450 __

[clang] f50aef7 - Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user"

Author: Hans Wennborg Date: 2021-03-12T13:53:46+01:00 New Revision: f50aef745c3ba981f3d0bf118b809d0c3880a490 URL: https://github.com/llvm/llvm-project/commit/f50aef745c3ba981f3d0bf118b809d0c3880a490 DIFF: https://github.com/llvm/llvm-project/commit/f50aef745c3ba981f3d0bf118b809d0c3880a490.diff

[clang] 6dc1523 - [analyzer][solver] Prevent infeasible states (PR49490)

Author: Valeriy Savchenko Date: 2021-03-12T15:56:48+03:00 New Revision: 6dc152350824d0abcf4e1836c2846f8f9256779c URL: https://github.com/llvm/llvm-project/commit/6dc152350824d0abcf4e1836c2846f8f9256779c DIFF: https://github.com/llvm/llvm-project/commit/6dc152350824d0abcf4e1836c2846f8f9256779c.d

[PATCH] D98341: [analyzer][solver] Prevent infeasible states (PR49490)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc152350824: [analyzer][solver] Prevent infeasible states (PR49490) (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:2610 EoF.setKind(tok::eof); + EoF.setFlag(clang::Token::IsReinjected); AnnotTok.startToken(); It

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

aaron.ballman added a comment. In D98450#2621877 , @MForster wrote: > That's ok for me. I'd suggest to wait for Aaron's feedback, because IIRC it > was his suggestion in the first place to go to declref. I have the same concerns with this patch as I did

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment "link.exe" is hard-coded as default linker in MSVC.cpp, so there's no way to use LLD as default linker for MSVC driver. This

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov created this revision. maxim-kuvyrkov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Noticed this while I was looking at linker defaults. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98494 Files: cla

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

svenvh accepted this revision. svenvh added a comment. In D98411#2621736 , @ldrumm wrote: > @Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 > ? D98039 adds the calling convention for OpenCL

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

sammccall updated this revision to Diff 330218. sammccall added a comment. oops, enable clangd test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98488/new/ https://reviews.llvm.org/D98488 Files: clang-tools-extra/clangd/unittests/CodeCompleteTe

[PATCH] D98497: [ASTMatchers] Don't forward matchers in MapAnyOf

njames93 created this revision. njames93 added reviewers: aaron.ballman, steveire, klimek. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Forwarding these means that if an r-value reference is passed, the matcher will be moved. H

[PATCH] D98498: [clangd] Enable modules to contribute tweaks.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. First patch to enable diagnostic fix genera

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. These can be invoked at differ

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. Kindly ping. Maybe I should add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, your views? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} arnamoy10 wrote: > tskeith wrote: > > Does this

[PATCH] D98502: [clang][Checkers] Extend PthreadLockChecker state dump (NFC).

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add printing of map 'DestroyRetVal'. Repository:

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330230. stelios-arm marked an inline comment as done. stelios-arm added a comment. 1. Removed a redundant comment 2. Removed the changes made in the `test/CodeGen/arm_acle.c`, since the test is disabled. 3. Added a clang preprocessor test to check the pre

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: SjoerdMeijer wrote: > Not sure if I am surprised that this wor

[PATCH] D98504: [clang][Checkers] Fix state cleanup at dead symbol.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: Szelethus. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is possible that an entry in 'DestroyRetVal' li

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo http

[clang] 731b3d7 - [clang] Use Constant::getAllOnesValue helper. NFCI.

Author: Simon Pilgrim Date: 2021-03-12T15:16:36Z New Revision: 731b3d766420ce05726174ff0e1527dca8a63791 URL: https://github.com/llvm/llvm-project/commit/731b3d766420ce05726174ff0e1527dca8a63791 DIFF: https://github.com/llvm/llvm-project/commit/731b3d766420ce05726174ff0e1527dca8a63791.diff LOG:

[PATCH] D98504: [clang][Checkers] Fix state cleanup at dead symbol.

balazske updated this revision to Diff 330243. balazske added a comment. Improved commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98504/new/ https://reviews.llvm.org/D98504 Files: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecke

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 __

[PATCH] D98514: [RGT] Fix ASTMatchersTest so all assertions are executed

probinson created this revision. probinson added a reviewer: Prazek. probinson requested review of this revision. Herald added a project: clang. Some 'if' conditions turn out always to be false, so change test expectations to match. Found by the Rotten Green Tests project. Repository: rG LLVM

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2622039 , @RedDocMD wrote: > @steakhal, your views? I'm somewhat busy. If it's not urgent, I would postpone this. Ping me in a few weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet updated this revision to Diff 330258. kadircet added a comment. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98499/new/ https://reviews.llvm.org/D98499 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/cl

[clang] b5fae4b - [PowerPC] Add more missing overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-12T10:51:57-06:00 New Revision: b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f URL: https://github.com/llvm/llvm-project/commit/b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f DIFF: https://github.com/llvm/llvm-project/commit/b5fae4b9b2fd0ac8f0ad99178f876dc78ba5613f.di

[PATCH] D98488: [CodeCompletion] Avoid spurious signature help for init-list args

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/lib/Parse/Parser.cpp:2117 if (S->getFlags() & Scope::FnScope) { + cutOffParsing(); Actions.CodeCompleteOrdinaryName(getCu

[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

khchen marked 6 inline comments as done. khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:689 + skew = 1; +for (unsigned i = 0; i < PermuteOperands.size(); ++i) { + if (i != PermuteOperands[i]) rogfer01 wrote: > These

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

kadircet updated this revision to Diff 330266. kadircet added a comment. - Introduce a helper to mark tokens as reinjected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98483/new/ https://reviews.llvm.org/D98483 Files: clang/lib/Parse/ParsePragm

[PATCH] D98520: [OpenCL] Remove spurious atomic_fetch tablegen builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The `int` and `long` versions of these builtins already provide the necessary ov

[clang] f43ff34 - [clang] Mark re-injected tokens appropriately during pragma handling

Author: Kadir Cetinkaya Date: 2021-03-12T18:18:17+01:00 New Revision: f43ff34ae67a6557fe9fd1ba0e992da18bd102f7 URL: https://github.com/llvm/llvm-project/commit/f43ff34ae67a6557fe9fd1ba0e992da18bd102f7 DIFF: https://github.com/llvm/llvm-project/commit/f43ff34ae67a6557fe9fd1ba0e992da18bd102f7.dif

[PATCH] D98483: [clang] Mark re-injected tokens appropriately during pragma handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf43ff34ae67a: [clang] Mark re-injected tokens appropriately during pragma handling (authored by kadircet). Repository: rG LLVM Github Monorepo CH

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

maxim-kuvyrkov updated this revision to Diff 330272. maxim-kuvyrkov added a comment. Added missing header to pull in definition of CLANG_DEFAULT_LINKER. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 Files

[PATCH] D98494: [NFC] Minor cleanup to use default setting of getLastArg()

maxim-kuvyrkov updated this revision to Diff 330273. maxim-kuvyrkov added a comment. Fixed thinko: GetLastArg -> GetLastArgValue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98494/new/ https://reviews.llvm.org/D98494 Files: clang/lib/Driver/Too

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a identifier has a correct prefix/suffix but a bad case, the

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added a comment. In D97224#2621328 , @rjmccall wrote: > In D97224#2604537 , @jyknight wrote: > >>> I'm less certain about what to do with the `__atomic_*` builtins >> >> The `__atomic` builtins have already

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > arnamoy10 wrote: > > tskeith w

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:293 + driverPath = driverPath.substr(0, driverPath.size() - 9); + return driverPath.append("/../tools/flang/include/flang/"); +} tskeith wrote: > tskeith wrote: > > arnamoy10

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Hi, this breaks check-clang on arm macs: http://45.33.8.238/macm1/5421/step_6.txt (The `fatal error: 'opencl-c-base.h' file not found` bit is printed when the test passes too, and is unrelated.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Hi! Yeah,  I'm looking into it, but I can't reproduce it locally: the test passes at x86_64 linux system. I'll revert the change if it takes too much time to investigate what's going on. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test on the RUN line of that test? Here's the output of that RUN line on an arm mac when the test fails: http://pastie.org/p/1go1Y9WXjs5T371RtyJ3Gi Let's revert for now, things have been broken for

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

svenvh added a comment. In D97058#2622669 , @thakis wrote: > Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test > on the RUN line of that test? I also had trouble reproducing the failure locally, but by specifying this target I

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. It repros for me with this local diff % git diff diff --git a/clang/test/Index/opencl-types.cl b/clang/test/Index/opencl-types.cl index 496f38752fa2..13f6058864b5 100644 --- a/clang/test/Index/opencl-types.cl +++ b/clang/test/Index/opencl-types.cl @@ -1,4 +1,4

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622681 , @svenvh wrote: > In D97058#2622669 , @thakis wrote: > >> Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test >> on the RUN line of that test?

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Thanks guys, I'm on way to trying that, just building clang from scratch. >   If it is, then just adding a fixed triple is fine. Yeah, it is expected as this change removes types which require extension from parsers state. X86 and SPIR support all extensions by defau

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. > (The `fatal error: 'opencl-c-base.h' file not found` bit is printed when the > test passes too, and is unrelated.) I can't reproduce this locally neither with nor without this commit. I think there is something wrong with the way this test runs, this might explai

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. In case it's useful, here's the output of the RUN line on an m1 mac with this patch locally reverted (where the test passes): http://pastie.org/p/2F3Y0xUMtH5RP9TVRzG4LI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/ne

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622717 , @thakis wrote: > In case it's useful, here's the output of the RUN line on an m1 mac with this > patch locally reverted (where the test passes): > http://pastie.org/p/2F3Y0xUMtH5RP9TVRzG4LI Thanks, this see

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622750 , @Anastasia wrote: > In D97058#2622717 , @thakis wrote: > >> In case it's useful, here's the output of the RUN line on an m1 mac with >> this patch locally reverted (wh

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. I can't find why and how `opencl-c-base.h` is used for the test. But it feels it is adding the random noise to the testing as it is not expected to be used. I don't feel that this commit is affecting the header though, so it is something that might have already been b

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. In D96976#2622342 , @steakhal wrote: > I'm somewhat busy. If it's not urgent, I would postpone this. > Ping me in a few weeks. Sure ok. Is it okay if I tell someone else to take a look at this in the meanwhile? Repository: r

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd drops symbols from static index when

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh, thakis. Herald added subscribers: arphaman, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise (for other targets) testing may be non-de

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Yes, I was able to reproduce the failure with `-target arm64-apple-macosx` flag, I provided the fix to set explicit target: https://reviews.llvm.org/D98539. @Anastasia, I tried to cherry-pick https://reviews.llvm.org/D92244, but the error is still reproducible. Rep

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I can't see why we would need to tests anything target-specific here anyway, so I think the change is reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622883 , @azabaznov wrote: > Yes, I was able to reproduce the failure with `-target arm64-apple-macosx` > flag, I provided the fix to set explicit target: > https://reviews.llvm.org/D98539. I have approved it. Thank

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangCommandLineReference.rst:3801 Pass -z to the linker - extraneous change? Comment at: clang/include/cla

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:191 -TARGET_BUILTIN(__builtin_wasm_qfma_f32x4, "V4fV4fV4fV4f", "nc", "simd128") -TARGET_BUILTIN(__builti

[clang] 5ae949a - [Clang][ARM] Reenable arm_acle.c test.

Author: David Green Date: 2021-03-12T19:21:21Z New Revision: 5ae949a9276542b46f41374fbe7aee01e480d9d6 URL: https://github.com/llvm/llvm-project/commit/5ae949a9276542b46f41374fbe7aee01e480d9d6 DIFF: https://github.com/llvm/llvm-project/commit/5ae949a9276542b46f41374fbe7aee01e480d9d6.diff LOG: [

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330316. akhuang added a comment. Herald added a subscriber: jdoerfert. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Bas

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra closed this revision. amilendra added a comment. Commited to LLVM Release 12.x branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 ___ cfe-commits ma

[clang] d7b7e20 - Revert "[Clang][ARM] Reenable arm_acle.c test."

Author: Nico Weber Date: 2021-03-12T14:37:37-05:00 New Revision: d7b7e2026b0a8b575df9ee7c4042ecff450f6549 URL: https://github.com/llvm/llvm-project/commit/d7b7e2026b0a8b575df9ee7c4042ecff450f6549 DIFF: https://github.com/llvm/llvm-project/commit/d7b7e2026b0a8b575df9ee7c4042ecff450f6549.diff LO

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

thakis added a comment. Can we get this landed asap please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra reopened this revision. amilendra added a comment. This revision is now accepted and ready to land. Reopening to add a missing empty line before starting the level-2 list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://r

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

ASDenysPetrov added a comment. Hi, @balazske Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:290-304 // Existence in DestroyRetVal ensures existence in LockMap. // Existence in Destroyed also ensures that the lock state for lockR is either // Unto

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:191 -TARGET_BUILTIN(__builtin_wasm_qfma_f32x4, "V4fV4fV4fV4f", "nc", "unimplemented-simd128") -TARGET_BUILTIN(__builtin_wasm_qfms_f32x4, "V4fV4fV4fV4f", "nc", "unimplemented-simd128")

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

tlively added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3801 Pass -z to the linker - dschuff wrote: > extraneous change? Yes, will revert, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330337. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Update the path based on the patch D98522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080

[clang] 42eb658 - [OpaquePtrs] Remove some uses of type-less CreateGEP() (NFC)

Author: Nikita Popov Date: 2021-03-12T21:01:16+01:00 New Revision: 42eb658f656c43ee63e25222f32acb86ad7b URL: https://github.com/llvm/llvm-project/commit/42eb658f656c43ee63e25222f32acb86ad7b DIFF: https://github.com/llvm/llvm-project/commit/42eb658f656c43ee63e25222f32acb86ad7b.diff

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. This patch adds the __PCREL__ define when PC Relative addressing is enabled. Repository: rG LLVM Github Monor

[clang] eed88e9 - [OpenCL] Use spir target for CIndex tests for OpenCL.

Author: Anastasia Stulova Date: 2021-03-12T20:11:26Z New Revision: eed88e91f331d158d3d0c91e91fca408c9f1d1e1 URL: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1 DIFF: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1.diff

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeed88e91f331: [OpenCL] Use spir target for CIndex tests for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. I'm going to revert this in 30 minutes. The tree has been red for 12h due to this then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058 _

  1   2   >