[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 324823. njames93 added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1229-1235 +static void buildLambdaThisCaptureFixit(Sema &Sema, LambdaScopeInfo *LSI) { + SourceLocation DiagLoc = LSI->IntroducerRange.getEnd(); + assert(!LSI->isCXXThisCaptured()); + Sema.Diag(DiagLoc,

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") need to pop PTX72 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

This revision was automatically updated to reflect the committed changes. shafik marked an inline comment as done. Closed by commit rGecb90b55454e: Modify TypePrinter to differentiate between anonymous struct and unnamed struct (authored by shafik). Herald added projects: clang, LLDB. Repository:

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

tianshilei1992 added a comment. According to D97012 , if we want to completely drop CUDA version, it should be CUDA 9.2. Do we want to change the minimum version to CUDA 9.2? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D96195: [HIP] Fix managed variable linkage

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017 + +void CGNVCUDARuntime::transformManagedVars() { + for (auto &&Info : DeviceVars) { A comment about how exactly we're transforming the vars would be helpful. Comment a

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra updated this revision to Diff 324829. tra added a comment. pop the macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/test/CodeGen/builtin

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra marked an inline comment as done. tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") yaxunl wrote: > need to pop PTX72 ? Good catch. Done. Repository: rG LLVM Gith

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik added a comment. Herald added a subscriber: JDevlieghere. Reverted the changes because I missed the clangd test suite and don't know how long it will take to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017 + +void CGNVCUDARuntime::transformManagedVars() { + for (auto &&Info : DeviceVars) { tra wrote: > A comment about how exactly we're transformin

[clang] bdf6fbc - PR49239: Don't take shortcuts when constant evaluating in 'warn on UB'

Author: Richard Smith Date: 2021-02-18T18:31:08-08:00 New Revision: bdf6fbc939646b52af61c0bae7335623a8be59f4 URL: https://github.com/llvm/llvm-project/commit/bdf6fbc939646b52af61c0bae7335623a8be59f4 DIFF: https://github.com/llvm/llvm-project/commit/bdf6fbc939646b52af61c0bae7335623a8be59f4.diff

[clang] 51ade31 - [HIP] Support device sanitizer

Author: Yaxun (Sam) Liu Date: 2021-02-18T23:30:25-05:00 New Revision: 51ade31e67897bbd6f363f26d9110ec4d6ddaa7f URL: https://github.com/llvm/llvm-project/commit/51ade31e67897bbd6f363f26d9110ec4d6ddaa7f DIFF: https://github.com/llvm/llvm-project/commit/51ade31e67897bbd6f363f26d9110ec4d6ddaa7f.dif

[PATCH] D96835: [HIP] Support device sanitizer

This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG51ade31e6789: [HIP] Support device sanitizer (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96835?vs=324

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

aeubanks added a comment. In D96803#2571316 , @zatrazz wrote: > In D96803#2569436 , @aeubanks wrote: > >> In D96803#2568179 , @zatrazz wrote: >> >>> In D96803#2566322

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 324874. zoecarver added a comment. - Fix the case where an object inherits from two objects, one with a deleted copy constructor and the other with a deleted move constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. Sorry for the delay in updating. @ahatanak let me know if you've found another way to break this patch :P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 324875. zoecarver added a comment. - * Format with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td clan

<    1   2   3