[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added a comment. (I haven't read through the discussion.) -fprofile-prefix-map has been added. Does this option has overlap with that option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 __

[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>, Us

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge abandoned this revision. nridge added a comment. Abandoning as this was superseded by { D77811 , D95701 , D95706 }. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge abandoned this revision. nridge added a comment. Abandoning as this was superseded by D77811 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66990/new/ https://reviews.llvm.org/D66990 ___

[PATCH] D96738: [docs] Fix doxygen comments wrongly attached to the clang namespace

nicolas17 created this revision. Herald added a subscriber: zzheng. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looking at the Doxygen-generated documentation for the clang namespace currently shows several random comments fro

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 -The improvements are... +- New :doc:`bugprone-thread-canceltype-asynchronous + ` check. Please add subsections for new checks and aliases. Looks like they were remove

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc created this revision. poelmanc added reviewers: MyDeveloperDay, hokein, sammccall. poelmanc added projects: clang-tools-extra, clang-format. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most modern libraries and applic

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies created this revision. lightmelodies added reviewers: sammccall, kadircet. lightmelodies added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lightmelodies requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. H

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge updated this revision to Diff 323886. nridge marked 10 inline comments as done. nridge added a comment. Rebase and address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files:

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added a comment. Ok, I've made `HeuristicResolver` nullable, in the sense that I've added null checks arounds its use in `TargetFinder`. I haven't refactored the tests to pass in a null resolver / annotate the ones that do or don't need one. Would you like that done in this patch, or a

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + aaronpuchert wrote: > jlebar wrote: > > aaronpuchert wrote: > > > Why not in the following `if`? I assume we want to show a long

<    1   2