[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 323601. pengfei added a comment. Address Sanjay's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/li

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9305 + * 1. The elements are reassociable when using fadd/fmul intrinsics; + * 2. There's no nan and signed zero in the elements when using fmin/max + intrinsics; spatel wrote: > If I un

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 323602. pengfei added a comment. Update test accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/lib

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

2021-02-14 Thread George Rokos via Phabricator via cfe-commits
grokos added a comment. In D86119#2561163 , @abhinavgaba wrote: > Thanks for the changes, Alexey! I tried the patch locally, and it looks > stable. It handled several tests I tried, including the following case > involving array section on a pointer to p

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 323603. pengfei added a comment. Minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/lib/CodeGen/CGBui

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Sanjay Patel via Phabricator via cfe-commits
spatel added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9305 + * 1. The elements are reassociable when using fadd/fmul intrinsics; + * 2. There's no nan and signed zero in the elements when using fmin/max + intrinsics; pengfei wrote: > spatel

[clang] 39ff002 - [ASTMatchers] Clarify example in docs

2021-02-14 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-02-14T13:49:06Z New Revision: 39ff002e526e1df3e4bebbfdd2beebf0440d7d92 URL: https://github.com/llvm/llvm-project/commit/39ff002e526e1df3e4bebbfdd2beebf0440d7d92 DIFF: https://github.com/llvm/llvm-project/commit/39ff002e526e1df3e4bebbfdd2beebf0440d7d92.diff LOG:

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Headers/avx512fintrin.h:9305 + * 1. The elements are reassociable when using fadd/fmul intrinsics; + * 2. There's no nan and signed zero in the elements when using fmin/max + intrinsics; spatel wrote: > pengfei

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 323616. pengfei added a comment. Address Sanjay's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179 Files: clang/include/clang/Basic/BuiltinsX86.def clang/li

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Sanjay Patel via Phabricator via cfe-commits
spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

2021-02-14 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 9148302a (2019-08-22) which broke the pre-existing unit test for the matcher. A

[clang] 25f753c - [clang-format] Add possibility to be based on parent directory

2021-02-14 Thread Björn Schäpers via cfe-commits
Author: Björn Schäpers Date: 2021-02-14T19:56:10+01:00 New Revision: 25f753c51e7b17bfca08155c1d777c5667110970 URL: https://github.com/llvm/llvm-project/commit/25f753c51e7b17bfca08155c1d777c5667110970 DIFF: https://github.com/llvm/llvm-project/commit/25f753c51e7b17bfca08155c1d777c5667110970.diff

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-02-14 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f753c51e7b: [clang-format] Add possibility to be based on parent directory (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

2021-02-14 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D95754#2561849 , @jlebar wrote: > Not sure who can review this, but looking through blame it seems like maybe > @aaronpuchert? I'm by no means an expert on overloading, but this seems more like a usability question. I l

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

2021-02-14 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho added a comment. I'm glad to see these patches, the SMT API will benefit greatly from them! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 ___ cfe-commits mailing list cfe-commits@list

[clang] 61da205 - [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread via cfe-commits
Author: Wang, Pengfei Date: 2021-02-15T08:52:06+08:00 New Revision: 61da20575d6c6bc72438bb3d169b4b2797e909e4 URL: https://github.com/llvm/llvm-project/commit/61da20575d6c6bc72438bb3d169b4b2797e909e4 DIFF: https://github.com/llvm/llvm-project/commit/61da20575d6c6bc72438bb3d169b4b2797e909e4.diff

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

2021-02-14 Thread Pengfei Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61da20575d6c: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction… (authored by pengfei). Repository: rG LLVM Github Monorepo

[PATCH] D96685: [WIP] Add noexcept clang-tidy codemod

2021-02-14 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya created this revision. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96685 Files: clang-tools-extra/clang-tidy/modernize/AddNoexceptCheck.cpp clang-