[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 323414. cjdb added a comment. fixes block expressions @aaron.ballman I'm not sure I follow what you're after re lambdas. Could you please provide a test case that I can work with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked 3 inline comments as done. cjdb added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object :

[clang] 51bf4c0 - [clang] Add -ffinite-loops & -fno-finite-loops options.

Author: Florian Hahn Date: 2021-02-12T19:25:49Z New Revision: 51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f URL: https://github.com/llvm/llvm-project/commit/51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f DIFF: https://github.com/llvm/llvm-project/commit/51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f.diff LOG:

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51bf4c0e6d4c: [clang] Add -ffinite-loops & -fno-finite-loops options. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D9641

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov updated this revision to Diff 323421. azabaznov added a comment. Rewrote 'RemoveAddressSpaceFromPtr' to return canonical type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 Files: clang/lib/AST

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

dexonsmith updated this revision to Diff 323422. dexonsmith added a comment. ping / rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Frontend/output-paths.c Index: clang/test/

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. This patch is relatively recent. I'd like to revert this for D96203 Can we user just pointo to /dev/null if file is not needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. In D96203#2559792 , @mibintc wrote: > In D96203#2559426 , @vitalybuka > wrote: > FWIW I would prefer denylist as well. (Also uses of whitelist should be allowlist, but also in

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reopen to attract attention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/ https://reviews.llvm.org/D79043 __

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15289 +ExpectedResultType->getAs()) { + ExpectedResultType = SemaRef.Context.getCanonicalType( + RemoveAddressSpaceFromPtr(SemaRef, Ex

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

jyknight added a comment. > I ended up reverting the changes I made to llvm/lib/IR/AutoUpgrade.cpp as the > file was including llvm/Analysis/ObjCARCUtil.h, which was violating layering. It looks like it was not actually reverted in the version ultimately submitted. I've pushed commit 3c06676de1

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:20 #include #include This file should go into a separate patch. It touches multiple files with simple changes but unlikely will case rollback. It's unrelated to mo

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

dexonsmith updated this revision to Diff 323435. dexonsmith added a comment. Herald added a subscriber: jfb. Rebase on top of newer https://reviews.llvm.org/D95501. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95502/new/ https://reviews.llvm.org/D95502 Files: clang/include/clang/Fro

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

MartinG added a comment. More than 3.5 years later and this extremely basic feature hasn't been merged yet? Clang-tidy's interface is completely broken. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

dblaikie accepted this revision. dblaikie added a subscriber: aprantl. dblaikie added a comment. This revision is now accepted and ready to land. @aprantl - mind having a look at this/signing off as well, if you're OK with it? Since it's a core metadata change, wouldn't mind some extra eyes on it

[clang] 13bd6fb - [docs/Coverage] Answer FAQ about optimization

Author: Vedant Kumar Date: 2021-02-12T12:05:38-08:00 New Revision: 13bd6fb43da9e9b1d7e82272325ec781d1f16456 URL: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456 DIFF: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456.diff

[clang] 0c4935b - [docs/Coverage] Document -show-region-summary

Author: Vedant Kumar Date: 2021-02-12T12:05:45-08:00 New Revision: 0c4935bb85166a4a0bf87a320b81e400d7be04f0 URL: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0 DIFF: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0.diff

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323436. sammccall added a comment. [clangd] Allow modules to bind LSP methods/notifications/commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-t

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall added a comment. whoops, meant to create a new review for that followup change, not update this one... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323438. sammccall added a comment. Revert to previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang] 6280bb4 - [clang] Remove redundant condition (NFC).

Author: Florian Hahn Date: 2021-02-12T20:14:24Z New Revision: 6280bb4cd80e39b0e54b1c8dd091f2b7175381eb URL: https://github.com/llvm/llvm-project/commit/6280bb4cd80e39b0e54b1c8dd091f2b7175381eb DIFF: https://github.com/llvm/llvm-project/commit/6280bb4cd80e39b0e54b1c8dd091f2b7175381eb.diff LOG:

[PATCH] D96625: [clangd] Allow modules to bind LSP methods/notifications/commands

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo ht

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 323443. dgoldman added a comment. - Add class method test case + swap to auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323449. sammccall added a comment. Add doc comments to bind methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-tools-extra/clangd/ClangdLSPServer.

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

aganea added a comment. In D79043#2560710 , @vitalybuka wrote: > This patch is relatively recent. I'd like to revert this for D96203 > > Can we user just pointo to /dev/null if file is not needed? You mean just use `-fn

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Thanks! I didn't realize it hadn't been fixed in the patch I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 ___ cfe-commits

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir updated this revision to Diff 323451. saghir added a comment. Updated tests to add run line for llc and target datalayout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 Files: clang/lib/Basic/Tar

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. Just a note: >> 4.b. still feels like a hack because there are captures variables outside of >> any CapturedStmt and therefore complicated the AST. Comparable directive >> such as master don't do this. It is not a hack, this was an optimization to minimize the number o

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 323455. delcypher added a comment. Add documentation for `-fsanitize-address-destructor-kind=` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 Files: clang/

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Thank you for your patience. LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 ___

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > vitalybuka wrote

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

ArturGainullin updated this revision to Diff 323456. ArturGainullin added a comment. Rebase for retesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538 Files: clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz added a comment. @v.g.vassilev Great to see this getting upstreamed! @teemperor Thanks for adding, I will take a look in the next days. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cf

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > delcypher wrote

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. In D79043#2560867 , @aganea wrote: > In D79043#2560710 , @vitalybuka > wrote: > >> This patch is relatively recent. I'd like to revert this for D96203 >>

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:166 +assert((isa(S) || isa(S)) && + "Canonical loop must be a for loop (range-based or otherwise)"); +SubStmts[LOOPY_STMT] = S; Meinersbur wrote: > jdenny wrote: > >

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 323480. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Addressing reviewers' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

abhinavgaba added a comment. Thanks for the changes, Alexey! I tried the patch locally, and it looks stable. It handled several tests I tried, including the following case involving array section on a pointer to pointer base, and nested mappers with `PTR_AND_OBJ` maps successfully: #include

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 created this revision. zero9178 added reviewers: rnk, russell.gallop. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting a MSVC triple, --dependant-libs with the name of the clang runtime library for profiling

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

Eugene.Zelenko added a comment. I think it'll be much more reasonable to use `clang-format` and filter its output to select only changes with stars in build rule. `clang-format-diff` is another method to introduce formatting changes gradually. Comment at: clang-tools-extra/c

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

jdoerfert added a comment. ping and follow up patches. Fixes PR49158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. @jansvoboda11 I noticed that the `Options.td` file is making use of some fancy mixins that mean the option gets automatically marshalled by the frontend into the codegen options :). I tried this out using the patch to this patch and all my tests seem to pass. Should I

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 ___ c

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > delcypher wrote

[clang] b3ac5b8 - [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

Author: Jonas Paulsson Date: 2021-02-12T18:26:36-06:00 New Revision: b3ac5b84cdd46fc62a7215ae6b11f3c005900461 URL: https://github.com/llvm/llvm-project/commit/b3ac5b84cdd46fc62a7215ae6b11f3c005900461 DIFF: https://github.com/llvm/llvm-project/commit/b3ac5b84cdd46fc62a7215ae6b11f3c005900461.diff

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb3ac5b84cdd4: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst. (authored by jonpa). Herald added a

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

jonpa added a comment. Committed after changed to use __builtin_memcpy() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96471/new/ https://reviews.llvm.org/D96471 ___ cfe-commits mailing list cfe

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

njames93 added a comment. I don't see the use case you suggest as a strong enough motivation for this, clang-format does this job very well and we shouldn't be reinventing the wheel here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96607/new/ h

[clang] ff50b12 - [SYCL] Ignore file-scope asm during device-side SYCL compilation.

Author: Artur Gainullin Date: 2021-02-12T17:00:45-08:00 New Revision: ff50b121e336503621da80676116f82d82e91196 URL: https://github.com/llvm/llvm-project/commit/ff50b121e336503621da80676116f82d82e91196 DIFF: https://github.com/llvm/llvm-project/commit/ff50b121e336503621da80676116f82d82e91196.dif

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation. (authored by ArturGainullin). Repository: rG LLVM Github Monorepo

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1069 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) { +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and tri

<    1   2