[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Herald added a subscriber: vkmr. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

vsavchenko added a comment. In D95307#2532669 , @RedDocMD wrote: > I clearly am taking the wrong approach to this problem. I will need to > reconsider how PointerToMember is actually modelled before solving this > problem I don't know if this is useful

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. I agree that we should aim to avoid broad memory impact for uncommon features, and this seems to apply. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320409. hliao added a comment. Rebase to the main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov created this revision. azabaznov added reviewers: Anastasia, mantognini. Herald added subscribers: jfb, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds possibility to define OpenCL C 3.0 feature m

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov abandoned this revision. azabaznov added a comment. Due to refactoring in https://reviews.llvm.org/D92277 this flow is no longer valid. New patch for this functionality is here: https://reviews.llvm.org/D95776. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89869/new/ https:

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added a comment. I suggest that renaming 'extension' to 'option' (extensions + features) concept to be done in separate commit. There are a lot of places to change all over the place in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

jeroen.dobbelaere added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:929 -if (MDNode *M = NI->getMetadata(LLVMContext::MD_alias_scope)) - NI->setMetadata(LLVMContext::MD_alias_scope, MDMap[M]); +if (MDNode *M = I->getMetadata(LLVMContex

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: dexonsmith, yaxunl. Herald added a reviewer: jansvoboda11. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenCL keywords 'p

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

GoBigorGoHome updated this revision to Diff 320426. GoBigorGoHome added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/Unwrap

[clang-tools-extra] 94fac81 - [Branch-Rename] Fix some links

Author: xgupta Date: 2021-02-01T16:43:21+05:30 New Revision: 94fac81fccfef9917e94bed398781744fb82e159 URL: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159 DIFF: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159.diff LOG: [

[libunwind] 94fac81 - [Branch-Rename] Fix some links

Author: xgupta Date: 2021-02-01T16:43:21+05:30 New Revision: 94fac81fccfef9917e94bed398781744fb82e159 URL: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159 DIFF: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159.diff LOG: [

[clang] 94fac81 - [Branch-Rename] Fix some links

Author: xgupta Date: 2021-02-01T16:43:21+05:30 New Revision: 94fac81fccfef9917e94bed398781744fb82e159 URL: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159 DIFF: https://github.com/llvm/llvm-project/commit/94fac81fccfef9917e94bed398781744fb82e159.diff LOG: [

[PATCH] D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.

nikic added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:929 -if (MDNode *M = NI->getMetadata(LLVMContext::MD_alias_scope)) - NI->setMetadata(LLVMContext::MD_alias_scope, MDMap[M]); +if (MDNode *M = I->getMetadata(LLVMContext::MD_alias_

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

saiislam added a comment. LGTM. But, please wait from someone outside AMD to accept it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 ___ cfe-commits mailing li

[clang] eefa8a9 - Revert "[clang][cli] Port OpenMP-related LangOpts to marshalling system"

Author: Jan Svoboda Date: 2021-02-01T12:50:48+01:00 New Revision: eefa8a9ff859153c510e740b33a9e721e42b88c5 URL: https://github.com/llvm/llvm-project/commit/eefa8a9ff859153c510e740b33a9e721e42b88c5 DIFF: https://github.com/llvm/llvm-project/commit/eefa8a9ff859153c510e740b33a9e721e42b88c5.diff L

[PATCH] D95766: [Branch-Rename] Fix some links

xgupta created this revision. xgupta added reviewers: mehdi_amini, sqlbyme. Herald added a reviewer: bollu. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,

[PATCH] D95766: [Branch-Rename] Fix some links

mehdi_amini accepted this revision. mehdi_amini added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:20 // Check for underscores in the names of googletest tests, per -// https://github.com/google/googletest/blob/master/

[PATCH] D95766: [Branch-Rename] Fix some links

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:20 // Check for underscores in the names of googletest tests, per -// https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-su

[PATCH] D95766: [Branch-Rename] Fix some links

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fac81fccfe: [Branch-Rename] Fix some links (authored by xgupta).

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

awarzynski added a comment. @arnamoy10 Thank you for addressing my comments! As for testing that `-J/-module-dir` are taken into account when specifying the output directory for modules, could try adding the following: ! RUN: mkdir -p %t/dir-f18 && %f18 -fparse-only -I tools/flang/include/fla

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a reviewer: djasper. aaron.ballman added a comment. In D69764#2532413 , @steveire wrote: > What can be done to move this change along? Here is my thinking, which is largely unchanged from previous discussion: a code formatting tool sh

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 edited reviewers, added: aaron.ballman, alexfh, njames93; removed: sammccall, hokein. njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, Can you fix the formatting as well. Comment at: clang-tools-extra/t

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia updated this revision to Diff 320447. Anastasia added a comment. Added address space compatibility check and improved testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95608/new/ https://reviews.llvm.org/D95608 Files: clang/lib/Sema/SemaInit.cpp clang/test/CodeGenOpe

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4297 + ? S.Context.getQualifiedType(T1, T1Quals.withoutAddressSpace()) + : cv1T1; // Not reference-related. Create a temporary and bind to tha

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

awarzynski added inline comments. Comment at: flang/test/Flang-Driver/include-module.f90:15 +! RUN: not %flang-new -fsyntax-only -module-dir %S/Inputs %s 2>&1 | FileCheck %s --check-prefix=SINGLEINCLUDE +! RUN: not %flang-new -fsyntax-only -J %S/Inputs/module-dir -J %S/Inputs/

[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

martong accepted this revision. martong added a comment. Still looks good to me! Thanks for handling the pragma cases! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93222/new/ https://reviews.llvm.org/D93222 ___ cfe-commits mailing list cfe-c

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Still looks good. (The parent is an NFC and only this patch changes the behavior (and only if the cmdline flag is there), right? So, I'd expect the big impact from this patch.) CHANGES SIN

[PATCH] D95759: [clangd] Rename: merge index/AST refs path-insensitively where needed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb63cd4db915c: [clangd] Rename: merge index/AST refs path-insensitively where needed (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang-tools-extra] b63cd4d - [clangd] Rename: merge index/AST refs path-insensitively where needed

Author: Sam McCall Date: 2021-02-01T15:15:21+01:00 New Revision: b63cd4db915c08e0cb4cf668a18de24b67f2c44c URL: https://github.com/llvm/llvm-project/commit/b63cd4db915c08e0cb4cf668a18de24b67f2c44c DIFF: https://github.com/llvm/llvm-project/commit/b63cd4db915c08e0cb4cf668a18de24b67f2c44c.diff LO

[PATCH] D95782: [Syntax] Support condition for IfStmt.

hokein created this revision. hokein added a reviewer: sammccall. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95782 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/Syntax/BuildT

[PATCH] D95670: [clangd] Don't rely on builtin headers for document-link.test.

sammccall accepted this revision. sammccall added a comment. Thanks for fixing this, we don't want to depend on clang and I didn't realize we still did! Comment at: clang-tools-extra/clangd/test/document-link.test:3 +# create a fake resource_dir so that the test can find the h

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/Dynamic/Registry.h:36-37 +/// A smart (owning) pointer for MatcherDescriptor +/// We can't use unique_ptr because MatcherDescriptor is forward declared +class MatcherDescriptorPtr { ---

[PATCH] D95670: [clangd] Don't rely on builtin headers for document-link.test.

hokein updated this revision to Diff 320454. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95670/new/ https://reviews.llvm.org/D95670 Files: clang-tools-extra/clangd/test/document-link.test Index: clan

[clang-tools-extra] 78c22fb - [clangd] Don't rely on builtin headers for document-link.test.

Author: Haojian Wu Date: 2021-02-01T15:36:34+01:00 New Revision: 78c22fbce991bb5ef49db36473b71fc4386e1e85 URL: https://github.com/llvm/llvm-project/commit/78c22fbce991bb5ef49db36473b71fc4386e1e85 DIFF: https://github.com/llvm/llvm-project/commit/78c22fbce991bb5ef49db36473b71fc4386e1e85.diff LO

[PATCH] D95670: [clangd] Don't rely on builtin headers for document-link.test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked 3 inline comments as done. Closed by commit rG78c22fbce991: [clangd] Don't rely on builtin headers for document-link.test. (authored by hokein). Reposito

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. In D95307#2533259 , @vsavchenko wrote: > I don't know if this is useful or not, but pointer-to-members used to be > `void *` up until very recently. Here is my change on that topic (and it > probably where the bug you're trying

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

aaron.ballman added inline comments. Comment at: clang/test/AST/ast-print-attr.c:31 +// CHECK: int fun_annotate() __attribute__((annotate("annotation"))) +int fun_annotate() __attribute__((annotate("annotation"))); Can you add a second test that shows we properly

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall updated this revision to Diff 320464. sammccall marked an inline comment as done. sammccall added a comment. add missing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77811/new/ https://reviews.llvm.org/D77811 Files: clang-tools-e

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall added a comment. In D77811#2533237 , @nridge wrote: > Thanks a lot for working on this! I agree this is well aligned with the goals > of D77702 (and in fact goes even further > and meets the goals of D66990

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a subscriber: aaron.ballman. bader added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9996 + if (CGM.isTypeConstant(D->getType(), false)) { +if (auto ConstAS = CGM.getTarget().getConstantAddressSpace()) + return ConstAS.getValue(); -

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

jdoerfert added a comment. Overall, looks reasonable. I'm not a fan of the way things are hooked up but that is also true for the NVPTX toolchain and for now unavoidable I guess. Some nits below. Comment at: clang/lib/Driver/Driver.cpp:2999 +if (VStr.startswith("-

[clang-tools-extra] ff4832d - [clangd] Respect ReferencesParams.context.includeDeclarations

Author: Sam McCall Date: 2021-02-01T17:07:02+01:00 New Revision: ff4832dbff0ccf1fd29f726efe72fd1220cd645a URL: https://github.com/llvm/llvm-project/commit/ff4832dbff0ccf1fd29f726efe72fd1220cd645a DIFF: https://github.com/llvm/llvm-project/commit/ff4832dbff0ccf1fd29f726efe72fd1220cd645a.diff LO

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:86 + enum ReferenceAttributes : unsigned { +Plain = 0, +Declaration = 1 << 0, kbobyrev wrote: > nit: `Plain` means neither `Declaration` nor `Definition`, right? Maybe > `None

[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGff4832dbff0c: [clangd] Respect ReferencesParams.context.includeDeclarations (authored by sammccall). Cha

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

tskeith added inline comments. Comment at: flang/include/flang/Frontend/CompilerInstance.h:105 /// { + Fortran::semantics::SemanticsContext &semaChecking() const { return *semantics_; } awarzynski wrote: > tskeith wrote: > > `semanticsContext` would be a b

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added a comment. In D94961#2533848 , @jdoerfert wrote: > Overall, looks reasonable. I'm not a fan of the way things are hooked up but > that is also true for the NVPTX toolchain and for now unavoidable I guess. This is loosely based on th

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 7 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1478 + enum class AtomicOperationKind { +Unsupported, +Init, rjmccall wrote: > This shouldn't be here; if you have places that don't

[clang-tools-extra] 8712df7 - [clangd] references: decls of overrides of x are refs to x, not decls

Author: Sam McCall Date: 2021-02-01T17:19:19+01:00 New Revision: 8712df7a621d1d00a3fd4641ef72639a8faa6284 URL: https://github.com/llvm/llvm-project/commit/8712df7a621d1d00a3fd4641ef72639a8faa6284 DIFF: https://github.com/llvm/llvm-project/commit/8712df7a621d1d00a3fd4641ef72639a8faa6284.diff LO

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 320477. yaxunl marked 7 inline comments as done. yaxunl added a comment. Herald added a reviewer: jfb. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/A

[PATCH] D95451: [clangd] references: decls of overrides of x are refs to x, not decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8712df7a621d: [clangd] references: decls of overrides of x are refs to x, not decls (authored by sammccal

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:65 + .Case("g", "1") + .Default("2"); +} JonChesterfield wrote: > jdoerfert wrote: > > To verify, O0 is not mapped to O2, correct?

[PATCH] D95571: [clangd] Remove some obsolete options that are now always on

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1eb7fd089e2f: [clangd] Remove some obsolete options that are now always on (authored by sammccall). Changed prior to commit: https://reviews.llvm.

[clang-tools-extra] 1eb7fd0 - [clangd] Remove some obsolete options that are now always on

Author: Sam McCall Date: 2021-02-01T17:24:03+01:00 New Revision: 1eb7fd089e2fcf3fe211f865b28e2fed12128c3f URL: https://github.com/llvm/llvm-project/commit/1eb7fd089e2fcf3fe211f865b28e2fed12128c3f DIFF: https://github.com/llvm/llvm-project/commit/1eb7fd089e2fcf3fe211f865b28e2fed12128c3f.diff LO

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

aaron.ballman added a comment. In D95714#2532957 , @poelmanc wrote: > In D95714#2532565 , @njames93 wrote: > >> This does highlight an issue where the mimicked std library stubs used for >> tests don't correspond e

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

Anastasia updated this revision to Diff 320484. Anastasia retitled this revision from "[OpenCL][PR48896] Add default address space in template argument deduction only if missing" to "[OpenCL][PR48896] Fix default address space in template argument deduction". Anastasia edited the summary of this

[PATCH] D95782: [Syntax] Support condition for IfStmt.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:803 + bool TraverseIfStmt(IfStmt *S) { +bool Result = [&, this]() { is it clear to you wh

[PATCH] D95739: [ASTMatchers] Add matchers for decomposition decls

aaron.ballman added a comment. Thanks for this! It generally looks good, aside from some minor nits. Btw, it looks like the HTML documentation wasn't regenerated for the patch. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7392 +/// Matches the DecompositionDecl

[PATCH] D95790: [WIP][clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95790 Files: clang/doc

[PATCH] D95792: [clang][cli] Report result of ParseLangArgs

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch correctly reports success/failure of `ParseLangArgs`. Besides being consistent

[PATCH] D95793: [clang][cli] Generate and round-trip language options

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added subscribers: dang, mgorny. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This

[PATCH] D95616: [OpenCL] Change extension handling for -fdeclare-opencl-builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95616/new/ https://reviews.llvm.org/D95616 __

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. I let you coordinate with @Mydeveloperday concerning the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://revie

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:160 +parent directory (or its parent if there is none). If there is no parent +file found it falls back to the ``LLVM`` style. + Why should it fallback to LLVM and not the

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

vsk added a comment. For context, the reason abspaths are used here is because users don't expect coverage results to go missing if the build directory changes (e.g. given `cd A; cc x.c; cd ../B; cc x.c`, the expectation is that coverage for two distinct x.c's is reported). I think it's import

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added a comment. I believe this is 'safe', in the sense that it can't break anything other than AMDGPU's openmp implementation, which doesn't work yet anyway. The change to non-amd code is to OpenMPActionBuilder, and while parsing `-march=gfx` isn't pretty, it won't fire on nvpt

[PATCH] D95772: [DebugInfo] Normalize paths by removing unnecessary dots

dblaikie added a subscriber: rnk. dblaikie added a comment. Does this address @rnk's feedback about symlinks? ( https://reviews.llvm.org/D87657#2296028 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95772/new/ https://reviews.llvm.org/D95772 ___

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay added a comment. > The !associated metadata may be attached to a global object declaration with > a single argument that references another global object. This metadata > prevents discarding of the global object in linker GC unless the referenced > object is also discarded. "prevents d

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:377 + "%0 is a reserved identifier">, + InGroup, DefaultIgnore; + Quuxplusone wrote: > If you leave it like this, you //will// receive multiple bug reports per yea

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. Thanks for the update! The approach with operand bundles and the no-op uses looks cleaner than the original version. The special handling in the inliner seems a bit unfortunate, but I guess there's no way around that? (as a side note, it might be easier to submit if this

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, xazax.hun, baloghadamsoftware, steakhal, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet. ASDenysPetr

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

stefanp added a comment. There is one more thing that does not look quite right. It may be an encoding problem for one of the instructions. I found it in the test but you will have to trace it back to the place where it is generated in order to fix it. Comment at: lld/ELF/Dri

[PATCH] D95673: [dllimport] Honor always_inline when deciding whether a dllimport function should be available for inlining (PR48925)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95673/new/ https://reviews.llvm.org/D95673 ___ cfe-com

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

tra added a comment. LGTM for CUDA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D95740: [ASTMatchers] Ignore parts of BindingDecls which are not spelled in source

aaron.ballman added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2607 +EXPECT_TRUE(matches(Code, traverse(TK_AsIs, M))); +EXPECT_FALSE(matches(Code, traverse(TK_IgnoreUnlessSpelledInSource, M))); + } Can you help

[clang] c4d6f27 - [NFC] Disallow unused prefixes under clang/test/Driver

Author: Mircea Trofin Date: 2021-02-01T10:34:38-08:00 New Revision: c4d6f2707a1e6c4e9bd93480dd913121fef122b7 URL: https://github.com/llvm/llvm-project/commit/c4d6f2707a1e6c4e9bd93480dd913121fef122b7 DIFF: https://github.com/llvm/llvm-project/commit/c4d6f2707a1e6c4e9bd93480dd913121fef122b7.diff

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4d6f2707a1e: [NFC] Disallow unused prefixes under clang/test/Driv

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2496269 , @bader wrote: > In D89909#2448443 , @Anastasia wrote: > >> If you prefer to continue this route then you should just document your >> dialect sematic somewhere publicl

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In the absence of a response, let's land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95482/new/ https://reviews.llvm.org/D95482 _

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:157 llvm::Function *makeModuleDtorFunction() override; + void + adjustShadowVarLinkage(const VarDecl *D, tra wrote: > clang-format it? `void` ha

[PATCH] D95558: [NFC][CUDA] Refactor registering device variable

yaxunl updated this revision to Diff 320526. yaxunl marked 4 inline comments as done. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95558/new/ https://reviews.llvm.org/D95558 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/lib/CodeGen

[clang] 08d46d5 - [clang][PATCH] Fix bug 48848 assertion related to recoverFromMSUnqualifiedLookup

Author: Melanie Blower Date: 2021-02-01T10:56:47-08:00 New Revision: 08d46d50599a7005380e1a9eebb276ceb2b0ad93 URL: https://github.com/llvm/llvm-project/commit/08d46d50599a7005380e1a9eebb276ceb2b0ad93 DIFF: https://github.com/llvm/llvm-project/commit/08d46d50599a7005380e1a9eebb276ceb2b0ad93.diff

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08d46d50599a: [clang][PATCH] Fix bug 48848 assertion related to recoverFromMSUnqualifiedLookup (authored by mibintc). Repository: rG LLVM Github M

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:35 +// Enable extensions that are enabled in opencl-c-base.h. +#if (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) +#define cl_khr_subgroup_ballot 1 No

[PATCH] D95482: [PATCH] [clang] Fix bug 48848 by removing assertion related to recoverFromMSUnqualifiedLookup

erik.pilkington added a comment. Sorry, yeah, I'm OK with this change. Comment at: clang/test/SemaCXX/lambda-expressions.cpp:671 +#else +template +void Decider(const RT &sp, ET &ep) { I think it makes more sense for this test to be in its own file since entire

[PATCH] D95735: [ASTMatchers] Fix matching after generic top-level matcher

aaron.ballman added a comment. I'm a bit confused -- I only get one match when I try out your example: https://godbolt.org/z/xn9efY Are there other changes in-flight that necessitate this, or is something else going on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

rnk added subscribers: smeenai, compnerd. rnk added a comment. +People who have spent time on cross-compilation Windows sysroots in the past: @smeenai @compnerd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D955

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: muiez, fanbo-meng, Kai, jhenderson, grimar. Herald added subscribers: delcypher, emaste. abhina.sreeskantharajan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay.

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

smeenai added a comment. I saw this on LLVM Weekly, and I like it a lot :) Now if only Windows could case-correct their SDKs so we didn't need VFS overlays and symlinks for the linker... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ ht

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

phosek added a comment. In D95753#2534061 , @vsk wrote: > For context, the reason abspaths are used here is because users don't expect > coverage results to go missing if the build directory changes (e.g. given `cd > A; cc x.c; cd ../B; cc x.c`, the expe

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. I still have the same fundamental objection as before to the parts of this patch for prohibiting FP add/sub on some targets. If a particular LLVM target cannot handle transforming an FP add/sub (or any other RMW operations!) into the correct cmpxchg or LL/SC loop, that

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1479 +Unsupported, +Init, +C11LoadStore, yaxunl wrote: > rjmccall wrote: > > `atomic_init` is not actually an atomic operation, so there's never an > > inherent reason

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 320562. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-gc-sections.c llvm/include/llvm/Transforms/Instrumentation.h llvm/incl

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2534118 , @MaskRay wrote: > "prevents discarding" is not accurate in the context. `__llvm_prf_*` cannot > be discarded because C identifier name input sections are GC roots. > > Add "C identifier name input sections are G

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320563. usaxena95 added a comment. Move Index query to more logical place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D95814: [NFC] Simplify test to use multiple FileCheck prefixes.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: aschwaighofer. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Minor cleanup where we can avoid calling the compiler twice with the same argument

  1   2   >