[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

2021-01-26 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93260/new/ https://reviews.llvm.org/D93260 ___

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

2021-01-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + akhuang wrote: > rnk wrote: > > I think I would prefer to have this return a number. I think CGDebugInfo > > sho

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

2021-01-26 Thread Amy Huang via Phabricator via cfe-commits
akhuang added inline comments. Comment at: clang/include/clang/AST/Mangle.h:92 + virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0; + rnk wrote: > akhuang wrote: > > rnk wrote: > > > I think I would prefer to have this return a number. I think

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

2021-01-26 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > steveire wrote: > > > > aaron.ball

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

2021-01-26 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seem reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://reviews.llvm.org/D94596 ___

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8afabff6b11c: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream (authored by dexonsmith). Repository: rG LLVM Github Monorepo

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f721476d10c: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC (authored by dexonsmith). Repository: rG LLVM Github Mon

[PATCH] D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

2021-01-26 Thread James Y Knight via Phabricator via cfe-commits
jyknight updated this revision to Diff 319422. jyknight retitled this revision from "Mangle `__alignof__` differently than `alignof`." to "Itanium Mangling: Mangle `__alignof__` differently than `alignof`.". jyknight added a comment. Minor updates. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95487: Itanium Mangling: Fix handling of in .

2021-01-26 Thread James Y Knight via Phabricator via cfe-commits
jyknight created this revision. Herald added a subscriber: kristof.beyls. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, we were emitting an extraneous X .. E in around an if the template argument was constructed fro

[PATCH] D95488: Itanium Mangling: In 'enable_if', omit X/E around .

2021-01-26 Thread James Y Knight via Phabricator via cfe-commits
jyknight created this revision. jyknight added reviewers: rsmith, rjmccall. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang enable_if extension is mangled as an , which is supposed to contain . However, we were unconditio

[PATCH] D93922: Itanium Mangling: Mangle `__alignof__` differently than `alignof`.

2021-01-26 Thread James Y Knight via Phabricator via cfe-commits
jyknight added a comment. OK, I've posted two follow-up changes now. https://reviews.llvm.org/D95487 fixes the issue with mangleTemplateArg given expressions -- this turned out to be a larged-scoped problem than I had thought, affecting manglings other than just that used the matrix extension.

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad7aaa475e5e: Frontend: Fix layering between create{,Default}OutputFile, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95166: Disable rosegment for old Android versions.

2021-01-26 Thread Dan Albert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfae16fc0eed7: Disable rosegment for old Android versions. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/ https://reviews.

[PATCH] D94880: Add clang-query support for mapAnyOf

2021-01-26 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 319431. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 Files: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h clang/include

[PATCH] D94881: WIP: Add a way to define matcher builders in the dynamic registry

2021-01-26 Thread Stephen Kelly via Phabricator via cfe-commits
steveire abandoned this revision. steveire added a comment. The split here is artificial. This can't be tested without the changes adding mapAnyOf support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94881/new/ https://reviews.llvm.org/D94881 _

[PATCH] D95492: Pack relocations for Android when possible.

2021-01-26 Thread Dan Albert via Phabricator via cfe-commits
danalbert created this revision. danalbert added reviewers: rprichard, srhines, rahulchaudhry. danalbert added a project: clang. danalbert requested review of this revision. First supported by API 28. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95492 Files: clang/lib/Driv

[PATCH] D95313: [WIP] Move part of nvptx devicertl under clang

2021-01-26 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield abandoned this revision. JonChesterfield added a comment. Abandoned in favour of multiple instantiations of the devicertl, which works across all languages and doesn't require hacks to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D94820: Support for instrumenting only selected files or functions

2021-01-26 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9eb1982980: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=319359&id=319444#toc Repository: rG LLVM Git

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

2021-01-26 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGStmt.cpp:2491 +std::string::size_type position1 = +Constraints.find("={" + Clobber.str() + "}"); +if (posi

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

2021-01-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. We need a solution to our problem in the short term, though: there must be a code pattern that can be used in -std=c++14 modes to accomplish what the `, ## __VA_ARGS__` code pattern accomplishes with GCC extensions. As of right now, my understanding is that `__VA_OPT__` is

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonicial loop.

2021-01-26 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, AMDChirag, anchu-rajendran, kiranchandramohan, SouraVX, ftynse, kiranktp, fghanim, ABataev, craig.topper, dblaikie, rsmith, aaron.ballman. Herald added subscribers: dexonsmith, martong, guansong, hiraditya, yaxunl. Herald ad

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added a reviewer: erik.pilkington. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Call `FixupRelativePath` when opening output files to ensure that `-working-directory` is used when chec

[PATCH] D95499: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

2021-01-26 Thread Mircea Trofin via Phabricator via cfe-commits
mtrofin created this revision. mtrofin added a reviewer: rnk. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The only test that needed change had 'QUAL' as an unused prefix. The rest of the changes are to simplify the prefix lists.

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: sammccall, erik.pilkington, marcrasi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. [This is supporting an RFC I'll post in a bit; marked WIP for now] Adopt the new ll

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

2021-01-26 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78058: option to write files to memory instead of disk

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D78058#2481050 , @dexonsmith wrote: > In D78058#2480411 , @dexonsmith > wrote: > >> In D78058#2471735 , @sammccall >> wrote: >> >>> @dexonsmi

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

2021-01-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. RFC is up at https://lists.llvm.org/pipermail/cfe-dev/2021-January/067576.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95502/new/ https://reviews.llvm.org/D95502 ___ cfe

[PATCH] D95346: [clang][cli] Port LangOpts to marshalling system, pt.1

2021-01-26 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d87e6a92a9: [clang][cli] Port LangOpts to marshalling system, pt.1 (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org

<    1   2