[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. my bad -- I missed the test case. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 ___ cfe

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. MyDeveloperDay wrote: > Are you sure `Includ

[PATCH] D95279: Support: Remove duplicated code in {File,clang::ModulesDependency}Collector, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG080952a9447a: Support: Remove duplicated code in {File,clang::ModulesDependency}Collector, NFC (authored by dexonsmith). Changed prior to commit:

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith updated this revision to Diff 319138. keith added a comment. Herald added a reviewer: jansvoboda11. Add group to warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90646/new/ https://reviews.llvm.org/D90646 Files: clang/include/clang/Ba

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

MaskRay added a comment. There are many options whether the latter one overrides the previous ones. How is this special? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90646/new/ https://reviews.llvm.org/D90646

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

Conanap updated this revision to Diff 319140. Conanap marked 7 inline comments as done. Conanap added a comment. Fixed some formatting and comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

Conanap added a comment. Addressed comments Comment at: lld/ELF/Config.h:74 +// For --power10-stub +enum class P10Stub { Default, No }; + amyk wrote: > We have a "yes", but does it need to be here, too? After a bit of discussion, since we don't have a concrete

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

NoQ created this revision. NoQ added reviewers: vsavchenko, xazax.hun, martong, Szelethus, baloghadamsoftware, Charusso, steakhal, gribozavr2, alexfh, aaron.ballman. Herald added subscribers: dang, ASDenysPetrov, phosek, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, mgorny. He

[PATCH] D90646: [clang] Add warning when `-include-pch` is passed multiple times

keith added a comment. Fair question! I think this case is a bit different since it's quite subtle. The strange thing here is that the header you're intending to provide a pch for can still be read successfully, but not getting the benefits of the pch that you were expecting without knowing abo

[PATCH] D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0e94e997473: [clang][Fuchsia] Add relative-vtables + asan multilibs (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D95253?vs=318588&id=319142#toc Repository: rG LLVM Gi

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added a comment. Couple of minor suggestions inline, but overall this looks pretty good. Hopefully device-only compilation works already, the rest could be left for after this patch. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:100 +

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:16 +# TODO: This part can also be removed if we can change the clang driver to make +# it support device only compilation. +if(CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "x86_64") -

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:25 +#define NOINLINE __attribute__((noinline)) +#define ALIGN(N) __attribute__((aligned(N))) JonChesterfield wrote: > Suggest we drop the DEVICE annotation

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added a comment. > the access size (8 bytes) exceeds the max lock-free size (0 bytes) > [-Watomic-alignment That's not a useful warning. Every size is greater than 0. I guess nvptx hasn't set a value somewhere in clang for max lock free size. Fortunately we only compile with c

[PATCH] D95249: [NFC] Disallow unused prefixes in clang/test/Analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG91b61abafb5a: [NFC] Disallow unused prefixes in clang/test/Analysis (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95249/new/ https://

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319154. tianshilei1992 added a comment. Final refinement before moving to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolCh

[PATCH] D95407: [clangd] NFC Silence some buildbot warnings

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. clang-tools-extra/clangd/unittest

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, aaron.ballman. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When declaring an anonymous struct with `const` or `volatile` qualifiers, ensure

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:98 #ifndef CUDA_VERSION #error CUDA_VERSION macro is undefined, something wrong with cuda. #endif This should be firing now that cuda.h is removed Repos

[PATCH] D95408: [Sema][C] members of anonymous struct inherit QualType

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5179 if (RecordDecl *OwningClass = dyn_cast(Owner)) { -Anon = FieldDecl::Create( -Context, OwningClass, DS.getBeginLoc(), Record->getLocation(), -/*IdentifierInfo=*/nullptr, Cont

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov created this revision. Herald added a subscriber: yaxunl. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See bug #48856 Definitions of classes with member function pointers and default spaceship operator were getting acc

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:103-104 + For example, ``-fbinutils-version=2.35`` means compatibility with GNU as/ld + before 2.35 is not needed: new features can be used and don't work around old + GNU as/ld bugs. (Jus

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 319170. timwoj added a comment. Restored lost single-nesting namespace test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/lib/Format/UnwrappedLineFormat

[PATCH] D92983: SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d67b9e2461d: SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC (authored by dexonsmith). Changed prior to commit: https://re

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/omptarget.h:301 +extern DEVICE uint8_t parallelLevel[MAX_THREADS_PER_TEAM / WARPSIZE]; +#pragma omp allocate(parallelLevel) allocator(omp_pteam_mem_alloc) +extern DEVICE uint16_t EXTERN_SHARE

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

evandro added a comment. Also, when the V spec becomes official, it'll be labeled v2.0. Therefore, as long as v0.9 or v1.0 is implemented, V is only available as an experimental feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ h

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 319174. MaskRay marked 8 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319176. tianshilei1992 added a comment. Fixed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/test

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

JonChesterfield added a comment. The deviceRTL is changing from cuda/hip to openmp at present. It would be good to be able to compile that as openmp for amdgpu, which needs a patch roughly like this and probably some follow up. It's plausible that the contents of this file are only really of in

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

dmajor added a comment. Our bots are green at b43c26d036dc . Many thanks @hvdijk for the quick response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d02fbe418d: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a comment. Thanks for the reviews; pushed f4d02fbe418db55375b78b8f57e47126e4642fb6 . Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocati

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/allocator.h:16 + +// Follows the pattern in interface.h +// Clang sema checks this type carefully, needs to closely match that from omp.h If we guard this with #ifdef _OPENM

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 319180. tianshilei1992 added a comment. Herald added a subscriber: jvesely. - Fixed CMake error on CMake 3.16 or lower version as `ZIP_LISTS` doesn't work; - Fixed (hopefully) compilation break on AMDGCN by gaurding `allocator.h` with macro. Reposito

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rsmith added a comment. In D94987#2507481 , @rjmccall wrote: > How does this new rule work if we find overlapping but non-equal sets of > declarations in different subobjects? I'm sure you can get that with `using` > declarations. You can. The rule is

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. > You can. The rule is that you resolve using-declarations to the declarations > they name, and you resolve typedef declarations to the types they name, and > the resulting set of declarations and types must be the same in every > subobject in which there are (non-shad

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM! Thank you for iterating on this, and for trying to keep amdgpu working. With this patch, the devicertl no longer needs the cuda sdk installed to compile. I believe ther

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

dexonsmith added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93249/new/ https://reviews.llvm.org/D93249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

dexonsmith added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93248/new/ https://reviews.llvm.org/D93248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

dexonsmith added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93260/new/ https://reviews.llvm.org/D93260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4642 +int Num; +if (V == "future") + A->render(Args, CmdArgs); rsmith wrote: > dblaikie wrote: > > ro wrote: > > > MaskRay wrote: > > > > phosek wrote: > > > > > Another

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf19849a07b67: [RISCV] Update V extension to v1.0-draft 08a0b464. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd756286d2e7: [OpenMP][FIX] Enforce a function boundary for a new data environment (authored by jdoerfert). Herald added a reviewer: bollu. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

GoBigorGoHome added a comment. Comment at: clang/unittests/Format/FormatTest.cpp:995 TEST_F(FormatTest, ForEachLoops) { verifyFormat("void f() {\n" + " foreach (Item *item, itemlist) {\n" MyDeveloperDay wrote: > I'd like you to assert that s

[PATCH] D95417: [NFC] Disallow unused prefixes under clang/test/CodeGen

mtrofin created this revision. mtrofin added a reviewer: MaskRay. mtrofin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95417 F

[PATCH] D95417: [NFC] Disallow unused prefixes under clang/test/CodeGen

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp:2 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple x86_64-linux-gnu | F

[PATCH] D95419: [clangd] Fix filename completion at the end of file

kadircet created this revision. kadircet added reviewers: hokein, kbobyrev. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clang

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique(s

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

FreddyYe created this revision. Herald added subscribers: pengfei, tpr, hiraditya, qcolombet, MatzeB. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. These warning are reported by static code analysis tool: Klocwo

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. Should we then revert ASAP and rework it later? @mydeveloperday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___ cfe-commits mailing

[PATCH] D95423: [clangd] Add std::size_t to StdSymbol mapping

kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is a common symbol that's missi

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. Thanks @NoQ for the tip on the right test command! My own belief is that this patch is just a hack that squelches the problem, instead of solving it. I am limited by my own inexperience with the codebase and am trying to learn more to help better. That said, couple of

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. In D95017#2522063 , @curdeius wrote: > Should we then revert ASAP and rework it later? @mydeveloperday Reverting would also be fine with me. I am happy to drive towards a feature (and flags) that everyone is comfortable with i

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rsmith added a comment. In D94987#2521774 , @rjmccall wrote: >> You can. The rule is that you resolve using-declarations to the declarations >> they name, and you resolve typedef declarations to the types they name, and >> the resulting set of declaratio

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

FreddyYe updated this revision to Diff 319216. FreddyYe added a comment. refine according to Lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://reviews.llvm.org/D95421 Files: clang/lib/CodeGen/CGBlocks.cpp llvm/lib/CodeGen/R

[PATCH] D95421: [NFC] Refine some uninitialized used variables.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95421/new/ https://reviews.llvm.org/D95421 __

[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

rsmith added a comment. In D91913#2521031 , @thakis wrote: > In D91913#2520503 , @hvdijk wrote: > >> Chrome `-std=c++*` when building with clang, but `-std=gnu++*` when building >> with GCC for exactly this reason,

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D95340: [clang][cli] NFC: Simplify BoolOption API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb61639985e21: [clang][cli] NFC: Simplify BoolOption API (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 319144. HsiangKai added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h c

[PATCH] D95342: [clang][cli] Store LangStandard::Kind in LangOptions

jansvoboda11 added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:18 #include "clang/Basic/CommentOptions.h" +#include "clang/Basic/LangStandard.h" #include "clang/Basic/LLVM.h" dexonsmith wrote: > Nit: clang-format wants you to move this

<    1   2   3