[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

MaskRay updated this revision to Diff 316238. MaskRay added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94463/new/ https://reviews.llvm.org/D94463 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/

[clang] cf45731 - [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

Author: Fangrui Song Date: 2021-01-12T14:19:55-08:00 New Revision: cf45731f0eaead79e1ac501b397e330df41ec152 URL: https://github.com/llvm/llvm-project/commit/cf45731f0eaead79e1ac501b397e330df41ec152 DIFF: https://github.com/llvm/llvm-project/commit/cf45731f0eaead79e1ac501b397e330df41ec152.diff

[PATCH] D94463: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate are used together

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf45731f0eae: [Driver] Fix assertion failure when -fprofile-generate -fcs-profile-generate… (authored by MaskRay). Repository: rG LLVM Github Mono

[PATCH] D94554: [clangd][WIP] Add a Filesystem that overlays Dirty files.

njames93 created this revision. Herald added subscribers: arphaman, javed.absar. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Before I start, this should probably be on clangd-dev, but that list seems kinda dead so I've

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. In D94391#2494316 , @MaskRay wrote: > I removed `CurLoc` from call sites and tried a stage 2 build. There is such a > difference: > > 0x00062228: DW_TAG_structure_type > DW_AT_calling_convention(DW_C

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

aprantl added a comment. I like that this makes getLineNumber behave less "magic". I'm slightly worried that this isn't quite as NFC as think (and the other cases are just not caught by the testsuite). Perhaps you could compile Clang (and a sample of Clang's ObjC(xx) tests) with the patch and d

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu accepted this revision. jasonliu added a comment. LGTM with minor nits. Comment at: clang/lib/Sema/SemaAttr.cpp:74 return; - // The #pragma align/pack affected a record in an included file, so Clang - // should warn when that the pragma was written in a file tha

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

compnerd added a comment. I think that it makes more sense to ignore the `aapcs-vfp` calling convention attribute (returning `CCCR_Ignore`), and warn on the `aapcs`. The redundant calling convention attribute does nothing, and I think that simply ignoring it would solve your issue. However, c

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay updated this revision to Diff 316286. MaskRay edited the summary of this revision. MaskRay added a comment. Add another workaround. stage 2 -DCMAKE_BUILD_TYPE=Debug clang is byte identical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9439

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2494531 , @dblaikie wrote: > In D94391#2494316 , @MaskRay wrote: > >> I removed `CurLoc` from call sites and tried a stage 2 build. There is such >> a difference: >> >> 0x000622

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0066a09579ca: [libc++] Give extern templates default visibility on gcc (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 316302. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/c

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

dblaikie added a comment. I'll leave this one to @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a comment. @nullptr.cpp: I may or may not come up with more review comments, but either way I'm a dead end — I don't consider myself authorized to "accept" Clang changes. You're still going to have to attract the attention of someone with the authority and/or force-of-will to

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } nit: any special reason for adding this? doesn't seem consistent with other remarks we have. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder added a comment. Thanks for the commits, Aaron. If you don't mind I have a short question: both commits don't seem to list the test cases, have they not been committed at all or are they filtered out in github and/or phabricator? Did I mess something up? CHANGES SINCE LAST ACTION htt

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 316324. FreddyYe added a comment. consider "=A" into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeG

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, evandro, rogfer01, frasercrmck, asb, luismarques, kito-cheng. Herald added subscribers: NickHung, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2493 +} +std::string::size_type position2 = Constraints.find("=A"); +if (position2 != std::string::npos) { Should consider the `Clobber == "edx"`? Repository: rG L

[PATCH] D94477: [clangd] Add main file macros into the main-file index.

ArcsinX updated this revision to Diff 316331. ArcsinX added a comment. - std::pair => struct MacroOccurrence - remove addressed fixme comment - assert() => cantFail() - use toSourceCode() to get the macro name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

<    1   2