[PATCH] D92714: Make -fno-pic respect -fno-direct-access-external-data

MaskRay updated this revision to Diff 315575. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92714/new/ https://reviews.llvm.org/D92714 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/dso-loc

[clang] 1d3ebbf - Add -f[no-]direct-access-external-data to supersede -mpie-copy-relocations

Author: Fangrui Song Date: 2021-01-09T00:32:01-08:00 New Revision: 1d3ebbf537832f80be97739abc4f6962caad1dab URL: https://github.com/llvm/llvm-project/commit/1d3ebbf537832f80be97739abc4f6962caad1dab DIFF: https://github.com/llvm/llvm-project/commit/1d3ebbf537832f80be97739abc4f6962caad1dab.diff

[clang] 38a716c - Make -fno-pic respect -fno-direct-access-external-data

Author: Fangrui Song Date: 2021-01-09T00:32:02-08:00 New Revision: 38a716c30f095c7d7148482070ea4a3352b926d5 URL: https://github.com/llvm/llvm-project/commit/38a716c30f095c7d7148482070ea4a3352b926d5 DIFF: https://github.com/llvm/llvm-project/commit/38a716c30f095c7d7148482070ea4a3352b926d5.diff

[PATCH] D92633: Add -f[no-]direct-access-external-data to supersede -mpie-copy-relocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3ebbf53783: Add -f[no-]direct-access-external-data to supersede -mpie-copy-relocations (authored by MaskRay). Changed prior to commit: https://r

[PATCH] D92714: Make -fno-pic respect -fno-direct-access-external-data

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38a716c30f09: Make -fno-pic respect -fno-direct-access-external-da

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217

[clang] 052b8fe - Fix CodeGenCXX/difile_entry.cpp on Windows

Author: Fangrui Song Date: 2021-01-09T00:46:02-08:00 New Revision: 052b8fe478194018944eac944af7ca853ec3ced7 URL: https://github.com/llvm/llvm-project/commit/052b8fe478194018944eac944af7ca853ec3ced7 DIFF: https://github.com/llvm/llvm-project/commit/052b8fe478194018944eac944af7ca853ec3ced7.diff

[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/difile_entry.cpp:11 +// CHECK: {{.*}} = distinct !DISubprogram(name: "__cxx_global_var_init", scope: {{.*}}, file: [[FILE]] +// CHECK: {{.*}} = distinct !DISubprogram(linkageName: "_GLOBAL__sub_I_difile_entry.cpp"

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 315578. thezbyg added a comment. Diff updated. Previous diff was generated after rebase, and Phabricator change preview did not show any unrelated changes, so I thought that everything is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/ne

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

sameeranjoshi added inline comments. Comment at: flang/test/Flang-Driver/driver-help.f90:22 ! HELP-NEXT: -### Print (but do not run) the commands to run for this compilation +! HELP-NEXT: -D = Define to (or 1 if omitted) ! HELP-NEXT: -E

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D94359: [clangd] Remove ScratchFS from tests

njames93 created this revision. njames93 added reviewers: adamcz, hokein, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This can lead to i

[PATCH] D94359: [clangd] Remove ScratchFS from tests

njames93 updated this revision to Diff 315596. njames93 added a comment. Fix windows tests failing(hopefully). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94359/new/ https://reviews.llvm.org/D94359 Files: clang-tools-extra/clangd/unittests/Glo

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added a comment. In D93846#2488469 , @thezbyg wrote: > Diff updated. Previous diff was generated after rebase, and Phabricator > change preview did not show any unrelated changes, so I thought that > everything is fine. Now your diff

[clang] 9f76788 - [clang][Sema] Compare SourceLocations directly [NFCI]

Author: Mikhail Maltsev Date: 2021-01-09T14:13:18Z New Revision: 9f76788b0930ed48f5f20a25f1b30d63c8486531 URL: https://github.com/llvm/llvm-project/commit/9f76788b0930ed48f5f20a25f1b30d63c8486531 DIFF: https://github.com/llvm/llvm-project/commit/9f76788b0930ed48f5f20a25f1b30d63c8486531.diff LO

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f76788b0930: [clang][Sema] Compare SourceLocations directly [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94231/new/ https://r

[PATCH] D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation.

antiagainst requested changes to this revision. antiagainst added a comment. This revision now requires changes to proceed. Awesome! I just have a few nits left now. Marked as blocking because we need to avoid change Clang code. Comment at: clang-tools-extra/clangd/ClangdLSPSe

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau added a comment. New year's ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93873/new/ https://reviews.llvm.org/D93873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

miyuki updated this revision to Diff 315601. miyuki edited the summary of this revision. miyuki added a comment. Removed alignas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files: clang/include/clang/

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 315613. ilinpv edited the summary of this revision. ilinpv added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. RT library detection and check for outline atomics support added to the driver. Repository: rG LLVM Github Mon

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

RKSimon added a comment. This all needs properly documenting in the release notes, and possibly in the clang docs as well explaining that mmx/3dnow is supported only inside assembly, Are we likely to get all of the 3dnow and mmx changes done before the 12.00 branch? Otherwise I'm tempted to sug

[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/difile_entry.cpp:11 +// CHECK: {{.*}} = distinct !DISubprogram(name: "__cxx_global_var_init", scope: {{.*}}, file: [[FILE]] +// CHECK: {{.*}} = distinct !DISubprogram(linkageName: "_GLOBAL__sub_I_difile_entry.cpp

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

jyknight added a comment. Agreed w.r.t. timing -- I would like to get all of these changes landed soon after the LLVM 12 branch-cut, to allow plenty time to stew on the main branch before they make it into a release to try to identify any issues. I'd still appreciate review and approval with th

[clang] 4dbb3f5 - [clang] Add llvm-strip to test dependencies

Author: Shoaib Meenai Date: 2021-01-09T11:57:27-08:00 New Revision: 4dbb3f57c6fe581ef525dbe49a401f4bab834eff URL: https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff DIFF: https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff.diff

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, smeenai. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94364 Files: clang/lib/Basic/Ta

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang does not emit the `mustprogress` loop or function attribute for loops with no

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

atmnpatel updated this revision to Diff 315639. atmnpatel added a comment. `while(1)` case was mishandled for C++11 onwards, fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94366/new/ https://reviews.llvm.org/D94366 Files: clang/lib/Cod

[clang] e2e82c9 - [CodeGenModule] Drop dso_local on function declarations for ELF -fno-pic -fno-direct-access-external-data

Author: Fangrui Song Date: 2021-01-09T16:31:56-08:00 New Revision: e2e82c9983f0dff671dd47d3e256d80faa40e892 URL: https://github.com/llvm/llvm-project/commit/e2e82c9983f0dff671dd47d3e256d80faa40e892 DIFF: https://github.com/llvm/llvm-project/commit/e2e82c9983f0dff671dd47d3e256d80faa40e892.diff

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel created this revision. atmnpatel added reviewers: fhahn, jdoerfert, xbolva00. Herald added subscribers: dexonsmith, dang. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following D94366

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel updated this revision to Diff 315641. atmnpatel added a comment. Update CommandLineReference.rst to also include `-fno-finite-loops` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 Files: clang/

Re: [clang] 9c4b222 - Revert "Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""""

Hi, Could you please point out the specific problem? I don't see any errors myself in a number of configurations that i tested locally (shared library builds and builds with modules) and all buildbots are silent. How do you even discover these issues? Is there a tool for that that i'm missing

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. Just to be clear, this is currently a WIP - it would still be good if someone took a look at this because I don't know if this approach makes any sense. I made this change with the aim of allowing language servers and other tools to cleanly handle .cuh files, but in

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast updated this revision to Diff 315648. hubert.reinterpretcast added a comment. - Address review: Mention plain char only when it appears Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999

[clang] b41b743 - [test] Improve weakref & weak_import tests

Author: Fangrui Song Date: 2021-01-09T23:56:55-08:00 New Revision: b41b743d461168300ae0121937b50e334563d307 URL: https://github.com/llvm/llvm-project/commit/b41b743d461168300ae0121937b50e334563d307 DIFF: https://github.com/llvm/llvm-project/commit/b41b743d461168300ae0121937b50e334563d307.diff