aqjune added inline comments.
Comment at: llvm/lib/IR/IRBuilder.cpp:1021
Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC));
return CreateShuffleVector(V, Undef, Zeros, Name + ".splat");
}
nlopes wrote:
> while at it, don't you want to c
aqjune added a comment.
I'll make two more patches - the instsimplify/vectorizer/ changes that make
insertelement poison, and the langref update to shufflevector.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93586/new/
https://reviews.llvm.or
curdeius accepted this revision.
curdeius added a comment.
It would be great if we had some spec for this style, it gets a bit hard to
verify if the formatting is actually what is expected.
Having said that, LGTM if the bug reporter confirms the behaviour is ok.
Comment at: cl
vabridgers added subscribers: balazske, vabridgers.
vabridgers added a comment.
I was referred to this patch from https://reviews.llvm.org/D86743. I pulled
this patch under review, brought it up to date and pushed to github at
https://github.com/vabridgers/llvm-project-dev.git, branch: vla-fam-f
vabridgers added a comment.
I pulled https://reviews.llvm.org/D69726, brought it up to date and pushed to
github at https://github.com/vabridgers/llvm-project-dev.git, branch:
vla-fam-fixes. Everything seems ok on this branch (LITs pass, reproducers from
https://bugs.llvm.org/show_bug.cgi?id=47
steakhal added a reviewer: steakhal.
steakhal requested changes to this revision.
steakhal added a comment.
This revision now requires changes to proceed.
This form of macro expansion is obsolete - I hope that the community agrees on
this.
Crashes for many more cases then just the one you mention
