[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

2020-12-19 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93579

[PATCH] D93452: [clangd] Trim memory periodically

2020-12-19 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau planned changes to this revision. qchateau marked 2 inline comments as done. qchateau added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:52 +// Malloc trim minimal period +std::chrono::seconds MemoryCleanupPeriod = std::chrono::seconds(

[clang] 9c895ae - [ARM] Add clang command line support for -mharden-sls=

2020-12-19 Thread Kristof Beyls via cfe-commits
Author: Kristof Beyls Date: 2020-12-19T12:49:26Z New Revision: 9c895aea118a2f50ca8413372363c3ff6ecc21bf URL: https://github.com/llvm/llvm-project/commit/9c895aea118a2f50ca8413372363c3ff6ecc21bf DIFF: https://github.com/llvm/llvm-project/commit/9c895aea118a2f50ca8413372363c3ff6ecc21bf.diff LOG:

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

2020-12-19 Thread Kristof Beyls via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c895aea118a: [ARM] Add clang command line support for -mharden-sls= (authored by kristof.beyls). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

2020-12-19 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 312930. njames93 added a comment. Remove input buffers, but keep output as its easy to reason about. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://reviews.llvm.org/D93531 Files: clang-too

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

2020-12-19 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > With my maintainer-of-`Support/JSON` hat on, I don't like the idea of these > features being shoehorned into the library to make clang-format an > incrementally more featureful JSON formatter. They're likely to

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

2020-12-19 Thread Zakk Chen via Phabricator via cfe-commits
khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:194 HasV = true; -else if (Feature == "+experimental-zfh") + HasRISCVVTypes = true; +} else if (Feature == "+experimental-zfh") HasRISCVVTypes is an undefined variable

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

2020-12-19 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added subscribers: mdtoguchi, erichkeane. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! @erichkeane, @mdtoguchi, we should upstream support for SYCL-2020 version in addition to SYCL-2017. Repository: rG LLVM Github M

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

2020-12-19 Thread Krystian Kuzniarek via Phabricator via cfe-commits
kuzkry updated this revision to Diff 312940. kuzkry retitled this revision from "[clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation" to "[clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option". kuzkry edited the summary o

[PATCH] D87587: [clang-format][PR47290] Add MaxUnwrappedLinesForShortNamespace format option

2020-12-19 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thanks for making the changes, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 __

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

2020-12-19 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver added a comment. > We could probably do something like what this patch is doing and determine > whether a class can be passed in registers based on whether its subobjects > can be passed in registers. If all of the subobjects can be passed in > registers, the current class can be pass

[PATCH] D93587: [hip] Fix HIP version parsing.

2020-12-19 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added reviewers: yaxunl, tra. Herald added subscribers: kerbowa, nhaehnle, jvesely. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Need trimming before parsing major or minor version numbers. This

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

2020-12-19 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:194 HasV = true; -else if (Feature == "+experimental-zfh") + HasRISCVVTypes = true; +} else if (Feature == "+experimental-zfh") khchen wrote: > HasRISCVVTypes is an

[PATCH] D93452: [clangd] Trim memory periodically

2020-12-19 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Just attached a debugger and ran malloc_trim on my clangd instance which was sitting at 6.7GB, afterwards it was 1.3GB. Interestingly clangd held rock solid at 1.0GB recorded memory usage throughout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

2020-12-19 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/ibm128-declarations.cpp:25 + +__ibm128 func4(__ibm128 a, __ibm128 b) { + return a + b; hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > There's a lot of missing test