[PATCH] D92577: Don't reject tag declarations in for loop clause-1

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:1846 +(*Iter)->setInvalidDecl(); + } } You can have multiple tag declarations because of complex declarators or type-specifiers, e.g. `struct A (*var)(struct B)

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. `byval` actually means it'll be passed on the stack, not as a pointer, so yes, that's a real change in conventions from an indirect argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.o

[PATCH] D93458: clang-cl: Remove /Zd flag

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93458/new/ https://reviews.llvm.org/D93458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] f4c8b80 - [openmp] Remove clause from OMPKinds.def and use OMP.td info

Author: Valentin Clement Date: 2020-12-17T14:08:12-05:00 New Revision: f4c8b80318005ca61bfed9b40ee9e6039194159b URL: https://github.com/llvm/llvm-project/commit/f4c8b80318005ca61bfed9b40ee9e6039194159b DIFF: https://github.com/llvm/llvm-project/commit/f4c8b80318005ca61bfed9b40ee9e6039194159b.di

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c8b8031800: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane created this revision. erichkeane added reviewers: fhahn, rjmccall. erichkeane requested review of this revision. As shown by bug 48540, GCC vector types would cause a crash when the declaration hada ParenType. This was because the walking of the declaration would try to expand the 'inn

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 _

[clang] e75fec2 - [AttrDocs] document always_inline

Author: Nick Desaulniers Date: 2020-12-17T12:34:23-08:00 New Revision: e75fec2b238f0e26cfb7645f2208baebe3440d41 URL: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41 DIFF: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41.di

[PATCH] D68410: [AttrDocs] document always_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGe75fec2b238f: [AttrDocs] document always_inline (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm

[clang] 994bb6e - [OpenMP][NFC] Provide a new remark and documentation

Author: Johannes Doerfert Date: 2020-12-17T14:38:26-06:00 New Revision: 994bb6eb7d01db1d9461e54d17a63af2ba1af2c9 URL: https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9 DIFF: https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9.d

[PATCH] D93439: [OpenMP][NFC] Provide a new remark and documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG994bb6eb7d01: [OpenMP][NFC] Provide a new remark and documentation (authored by jdoerfert). Herald added a project: clang. Herald added a subscriber:

[clang] 49c248b - clang-cl: Remove /Zd flag

Author: Nico Weber Date: 2020-12-17T15:39:40-05:00 New Revision: 49c248bd62a3cb2f0e7e3991ee0190943bd2bbec URL: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec DIFF: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec.diff LO

[PATCH] D93458: clang-cl: Remove /Zd flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG49c248bd62a3: clang-cl: Remove /Zd flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93458/new/ https:/

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Thanks Daniel for the explanation. Was the support added for GNU assembler as well? Is it the same flag name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93428/new/ https://reviews.llvm.org/D93428 ___

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312596. fodinabor added a comment. Update ClangFormat.rst. This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, JakeMerdichAMD, JVApen. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48539 Add support for Qt Translator Comment

[clang] c755e41 - Fix -Wno-error= parsing in clang-format.

Author: Joachim Meyer Date: 2020-12-17T22:23:42+01:00 New Revision: c755e41c336c898873db6c3c58a2819a982f60de URL: https://github.com/llvm/llvm-project/commit/c755e41c336c898873db6c3c58a2819a982f60de DIFF: https://github.com/llvm/llvm-project/commit/c755e41c336c898873db6c3c58a2819a982f60de.diff

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc755e41c336c: Fix -Wno-error= parsing in clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

danielkiss added a comment. In D93428#2461343 , @apazos wrote: > Thanks Daniel for the explanation. No problem at all. In D93428#2461343 , @apazos wrote: > Was the support added for GNU assembler as well? Is it t

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a subscriber: dmajor. lebedev.ri added a comment. @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, and unfortunately it came back green.. I don't recall if i can reproduce it locally (on vanilla test suite, i'll recheck), but right now it would seem th

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2461497 , @lebedev.ri wrote: > @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, > and unfortunately it came back green.. > I don't recall if i can reproduce it locally (on vanilla test suite,

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman updated this revision to Diff 312613. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 Files: clang/lib/Sema/SemaStmt.cpp clang/test/Sema/for.c Index: clang/tes

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:1846 +(*Iter)->setInvalidDecl(); + } } rjmccall wrote: > You can have multiple tag declarations because of complex declarators or > type-specifiers, e.g. `

[PATCH] D93333: tidy: supress warning for default member funcs

malcolm.parsons accepted this revision as: malcolm.parsons. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 ___

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

This revision was automatically updated to reflect the committed changes. tstellar marked an inline comment as done. Closed by commit rG3203143f1356: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int) (authored by tstellar). Herald added a subscriber: pengfei. Repository:

[clang] 3203143 - CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

Author: Tom Stellard Date: 2020-12-17T14:30:31-08:00 New Revision: 3203143f1356a4e4e3ada231156fc6da6e1a9f9d URL: https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9d DIFF: https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9d.diff

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 ___ cfe-commits mailing list cfe-commits

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 312629. zoecarver added a comment. - Fix base-derived case. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. @ahatanak this patch should now be a nfc for types that don't have anything to do with the trivial-abi attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

JonChesterfield added a comment. Ah, this may be one of the things aomp changed for nvptx. We did something around linking but I've never looked into exactly what. In that case fine by me - it's a sharp edge, but I'd expect it to make a difference in benchmarks until whole program optimisation

[PATCH] D78058: option to write files to memory instead of disk

sammccall added a comment. It's great that you're looking at this! Clang tooling in general and clangd in particular a lot of use of VFS (particularly when deployed inside google), so I've got a fair bit of interest/experience in these interfaces. And we'd also looked at virtualizing module cac

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I think this is in pretty good shape, remaining stuff is up to you. Let me know if/when you want me to land this! Comment at: clang-tools-extra/clangd/Hover.cp

[clang-tools-extra] 2808f59 - [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

Author: Nathan James Date: 2020-12-18T02:07:27Z New Revision: 2808f597f872e68a8bd69d5b53f5d583665b4c4f URL: https://github.com/llvm/llvm-project/commit/2808f597f872e68a8bd69d5b53f5d583665b4c4f DIFF: https://github.com/llvm/llvm-project/commit/2808f597f872e68a8bd69d5b53f5d583665b4c4f.diff LOG:

[PATCH] D93436: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2808f597f872: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 312658. ffrankies marked an inline comment as done. ffrankies added a comment. @aaron.ballman hmm, that is strange. I've rebased the patch and updated the diff, let me know if this one doesn't work either or there's something else you'd like me to try. Tha

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

ayermolo added a comment. @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in general where can I find more information about it. When I step through the code in emitVTableTypeMetadata, it's still. @0 = private unnamed_addr constant { [2 x i8*] } { [2 x i8*] [i8* bitcast (%

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, Is there any more concerns, feedbacks or suggestions? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing

[clang] 3733463 - [IR][PGO] Add hot func attribute and use hot/cold attribute in func section

Author: Rong Xu Date: 2020-12-17T18:41:12-08:00 New Revision: 3733463dbb58a29892be3872bd32f93cb9af492c URL: https://github.com/llvm/llvm-project/commit/3733463dbb58a29892be3872bd32f93cb9af492c DIFF: https://github.com/llvm/llvm-project/commit/3733463dbb58a29892be3872bd32f93cb9af492c.diff LOG:

[PATCH] D92493: [IR] Add hot to function attributes and use hot/cold attribute in function section prefix/suffix

This revision was automatically updated to reflect the committed changes. Closed by commit rG3733463dbb58: [IR][PGO] Add hot func attribute and use hot/cold attribute in func section (authored by xur). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:20-21 #include "clang/Basic/Version.h" #include "clang/CrossTU/CrossTranslationUnit.h" #include "clang/Frontend/ASTUnit.h" #include "clang/Lex/Preprocessor.h" Will these

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson added a comment. In D73418#2461943 , @ayermolo wrote: > @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in > general where can I find more information about it. > > When I step through the code in emitVTableTypeMetadata, it'

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312675. ffrankies marked 9 inline comments as done. ffrankies added a comment. - Rebased with master branch - Diagnostics are re-worded so they're not complete sentences Check ready for further review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312676. ffrankies added a comment. - removed unnecessary comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp clang-tools-extra/clang-

[clang] d3bf0bb - PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence of

Author: Richard Smith Date: 2020-12-17T21:31:23-08:00 New Revision: d3bf0bb18952d830fe6df6f791a64552b271000b URL: https://github.com/llvm/llvm-project/commit/d3bf0bb18952d830fe6df6f791a64552b271000b DIFF: https://github.com/llvm/llvm-project/commit/d3bf0bb18952d830fe6df6f791a64552b271000b.diff

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93490/new/ https://reviews.llvm.org/D93490

[clang] 638867a - DR2064: decltype(E) is only a dependent type if E is type-dependent, not

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 638867afd4bce4a2c56dea041299428af3727d61 URL: https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61 DIFF: https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61.diff

[clang] 71886c5 - Where possible, don't try to ask whether a template argument is

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 71886c56f336667969be4cac0b6a17a3f75b7555 URL: https://github.com/llvm/llvm-project/commit/71886c56f336667969be4cac0b6a17a3f75b7555 DIFF: https://github.com/llvm/llvm-project/commit/71886c56f336667969be4cac0b6a17a3f75b7555.diff

[clang] 4b38885 - Ensure that we transform types into the current instantiation even if

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 4b388859f527f822a27bcee409242c421f199f1d URL: https://github.com/llvm/llvm-project/commit/4b388859f527f822a27bcee409242c421f199f1d DIFF: https://github.com/llvm/llvm-project/commit/4b388859f527f822a27bcee409242c421f199f1d.diff

[clang] 8c1f2d1 - Following up on PR48517, fix handling of template arguments that refer

Author: Richard Smith Date: 2020-12-17T23:54:37-08:00 New Revision: 8c1f2d15b826591cdf6bd6b468b8a7d23377b29e URL: https://github.com/llvm/llvm-project/commit/8c1f2d15b826591cdf6bd6b468b8a7d23377b29e DIFF: https://github.com/llvm/llvm-project/commit/8c1f2d15b826591cdf6bd6b468b8a7d23377b29e.diff

[clang] caeb565 - [clang][cli] Convert Analyzer option string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T08:56:06+01:00 New Revision: caeb56503ec897c7244cff0657c11e87d2644f82 URL: https://github.com/llvm/llvm-project/commit/caeb56503ec897c7244cff0657c11e87d2644f82 DIFF: https://github.com/llvm/llvm-project/commit/caeb56503ec897c7244cff0657c11e87d2644f82.diff L

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaeb56503ec8: [clang][cli] Convert Analyzer option string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM Git

<    1   2