[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

mehdi_amini added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +}; + This is broken on gcc-5: ``` llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101:1: error: could not convert

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:20 +namespace ast_matchers { +AST_POLYMORPHIC_MATCHER_P2(hasAnyArgumentWithParam, + AST_POLYMORPHIC_SUPPORTED_TYPES(CallExpr, --

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

dexonsmith added a comment. There were also two Windows bots that emailed me yesterday afternoon, I just missed them somehow :/. - http://lab.llvm.org:8011/#/builders/119/builds/1381 (llvm-clang-win-x-aarch64) - http://lab.llvm.org:8011/#/builders/60/builds/1175 (llvm-clang-win-x-armv7l) FTR, t

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. I guess I revert it for now :( Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +}; + mehdi_amini wrote: > This is broken on gcc-5: > ``` > llvm/include/llvm/Frontend/Open

[clang] 1efd7a7 - Revert "[OpenMP] Add initial support for `omp [begin/end] assumes`"

Author: Johannes Doerfert Date: 2020-12-15T18:03:10-06:00 New Revision: 1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b URL: https://github.com/llvm/llvm-project/commit/1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b DIFF: https://github.com/llvm/llvm-project/commit/1efd7a73acdf1e3f61bbcf82d3c30be41771ce6b.d

[PATCH] D93356: [libomptarget][amdgpu] Call into deviceRTL instead of ockl

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, grokos, ABataev, ronlieb, tianshilei1992. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added a comment. In D78938#2450915 , @nlopes wrote: > Thanks @lebedev.ri for the pointer! > I started working on exactly the same thing as I was trying to link a C++20 > project with LLVM. > @BRevzin is there anything missing in this patch? Do you

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 312071. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

thakis added a comment. In addition to the build error, it also broke check-clang everywhere as far as I can tell. mac: http://45.33.8.238/macm1/292/step_6.txt linux: http://45.33.8.238/linux/35399/step_7.txt win: http://45.33.8.238/win/29934/step_7.txt Repository: rG LLVM Github Monorepo CH

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2456600 , @thakis wrote: > In addition to the build error, it also broke check-clang everywhere as far > as I can tell. > mac: http://45.33.8.238/macm1/292/step_6.txt > linux: http://45.33.8.238/linux/35399/step_7.txt

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 312078. zequanwu marked 4 inline comments as done. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files: clang/include/c

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:73 +// CHECK-DAG: attributes #[[ATTR2]] = {{{.*}}nomerge{{.*}}} +// CHECK-DAG: attributes #[[ATTR3]] = {{{.*}}nomerge{{.*}}} aaron.ballman wrote: > Can you also add a test case to dem

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, + &Handler); --

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 updated this revision to Diff 312080. njames93 added a comment. Added back null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92920/new/ https://reviews.llvm.org/D92920 Files: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp cl

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

ast requested changes to this revision. ast added a comment. This revision now requires changes to proceed. What's a use case? The test is necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103

[clang] c415e70 - [ASTMatchers][NFC] Strip prefixes eagerly in dynamic matcher arg traits.

Author: Nathan James Date: 2020-12-16T01:56:30Z New Revision: c415e709e9926b4aed897b55931f319a5f512e85 URL: https://github.com/llvm/llvm-project/commit/c415e709e9926b4aed897b55931f319a5f512e85 DIFF: https://github.com/llvm/llvm-project/commit/c415e709e9926b4aed897b55931f319a5f512e85.diff LOG:

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

dexonsmith reopened this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Reopening for now, although I haven't updated the patch yet, or quite tracked down the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

dexonsmith planned changes to this revision. dexonsmith added a comment. Given that 5de00f3b56805c7e980f049ceb3f166f8c69cec0 updates the return value of `FileEntry::getDir` as a (self-described) hack, and `FileEntryRef::getDir` won't be similarly updated, it's somewhat reasonable that this would

[clang] 4f14b80 - [HIP] unbundle bundled preprocessor output

Author: Yaxun (Sam) Liu Date: 2020-12-15T22:14:18-05:00 New Revision: 4f14b80803a458209b6b11daa3ec05076b8c4973 URL: https://github.com/llvm/llvm-project/commit/4f14b80803a458209b6b11daa3ec05076b8c4973 DIFF: https://github.com/llvm/llvm-project/commit/4f14b80803a458209b6b11daa3ec05076b8c4973.dif

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f14b80803a4: [HIP] unbundle bundled preprocessor output (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

SouraVX added a comment. Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard output">; -def emit_obj : Flag<["-"], "emit-obj">, - Hel

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei added inline comments. Comment at: llvm/utils/update_analyze_test_checks.py:129 + +common.warn_on_failed_prefixes(func_dict) is_in_function = False mtrofin wrote: > pengfei wrote: > > Can we move these warn to common.py? > Come to think of it

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added a comment. In D92041#2454236 , @sammccall wrote: > Very nice, thanks! > I'll land this for you now. Thank you very much! Learned a lot about clangd and clang AST from this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. I am interested in this, since we are currently bootstrapping an entire ppcle userland in our distribution (glibc and musl) - we already have everything generally working (on ppc64le host), with llvm being a notable blocker for some things - so i will be testing this in nea

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. we are also interested in running this on "true" 32-bit hardware eventually, so not restricting to POWER7 would be a good thing, potentially Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder created this revision. tbaeder added a reviewer: dang. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -ansi is documented as being the "same as -std=c89", but there are differences when passing it to a link: clang -c te

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf created this revision. qiucf added reviewers: nemanjai, rjmccall, rsmith, hubert.reinterpretcast, akyrtzi, PowerPC. Herald added subscribers: dexonsmith, steven.zhang, shchenz, arphaman, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscr

<    1   2   3