[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4847 + /// Do we need to mangle template arguments with exactly correct types? + bool needExactType(unsigned I) const { +// We need correct types when the template-name is unresolved or when it --

[PATCH] D80977: Diagnose cases where the name of a class member is used within a class definition before the member name is declared.

rsmith updated this revision to Diff 311085. rsmith added a comment. Rebase and fix test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80977/new/ https://reviews.llvm.org/D80977 Files: clang/include/clang/Basic/DiagnosticGroups.td cla

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 311092. ahatanak added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib/CodeGen/CGObjC.cpp clang/test/CodeGenObjC/arc-rv-attr.m

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 311094. njames93 added a comment. Dont check for globs coverage instead use a fast set based approach that only matches tidy checks exactly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92874/new/ https://re

[PATCH] D93068: [clang-offload-bundler] Add option -fail-on-missing-bundles

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:980 + if (FailOnMissingBundles && !Worklist.empty()) { +std::string ErrMsg = "Can't find bundles for"; +std::set Sorted; -

[clang] 8c5ca7c - [analyzer] OSObjectCStyleCast: Improve warning message.

Author: Artem Dergachev Date: 2020-12-10T19:46:33-08:00 New Revision: 8c5ca7c6e62c203b9642dca2a1d9118c36777ad5 URL: https://github.com/llvm/llvm-project/commit/8c5ca7c6e62c203b9642dca2a1d9118c36777ad5 DIFF: https://github.com/llvm/llvm-project/commit/8c5ca7c6e62c203b9642dca2a1d9118c36777ad5.dif

[PATCH] D93068: [clang-offload-bundler] Add option -allow-missing-bundles

yaxunl updated this revision to Diff 311099. yaxunl marked 3 inline comments as done. yaxunl retitled this revision from "[clang-offload-bundler] Add option -fail-on-missing-bundles" to "[clang-offload-bundler] Add option -allow-missing-bundles". yaxunl edited the summary of this revision. yaxunl

[PATCH] D93084: [VE] Optimize toolchain regression test

kaz7 created this revision. kaz7 added reviewers: MaskRay, simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added a subscriber: ormris. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Optimize toolchain regression test for VE by removing not a useful test

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/device-use-host-var.cu:169 + static texture ref; + __attribute__((device)) int c() { +auto &x = ref; use `__device__` will make it more readable. same as below. Repository: rG LLVM Github Mon

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 311105. jdoerfert added a comment. Herald added a reviewer: aaron.ballman. Herald added projects: clang, OpenMP. Herald added a subscriber: cfe-commits. Add remark and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 311106. jdoerfert added a comment. Add remark summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/clang/Basic/AttrDocs.td llvm/lib/Transf

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. Status? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM if you revise the test based on Sam's suggestion on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.l

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

OikawaKirie added a comment. Replies from the original author Hao Zhang -- > ...split the data structures between relative and absolute paths. The > existing data structures would only store absolute paths, but there are new > ones f

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 38. zoecarver added a comment. - Add lots of tests for S0. - Implement discussed change for handling S0. - Update docs to reflect change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://r

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. Sorry for the slow update. This patch now implements the suggested change (to "inherit" the trivial-abi attribute if there are no user-defined special members and its copy/move constructor is deleted solely because of a subobject with the attribute). Let me know what

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a subscriber: t.p.northover. lebedev.ri added a comment. In D87188#2447025 , @craig.topper wrote: > In D87188#2446096 , @spatel wrote: > >> In D87188#2445506

<    1   2   3