[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau added a comment. Not sure what's wrong with the unit test "x64 windows > LLVM.CodeGen/XCore::threads.ll", I don't see how it's related to my patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92977/new/ https://reviews.llvm.org/D92977 _

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

sammccall added a comment. Thanks for doing this! I wonder a simpler version would reach the 80/20 point... if we were to validate only that entries *without wildcards* matched a check name, I think we'd catch most of the typos, and it'd just be a simple set lookup. (`bugprone-*` is quadraticall

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, + &Handler); -

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. That's a nice improvement. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92930/new/ https://reviews.llvm.org/D92930 _

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

awarzynski added a comment. In D93027#2445718 , @sameeranjoshi wrote: > Thanks for extracting it from D92854 . > I think the tests in D92854 were failing > for the same reason. > LGTM. T

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

aaron.ballman added a comment. In D84924#2421116 , @njames93 wrote: > Fix documentation. > > Ping?? Ah, sorry, this fell to the bottom of my review list because the title still says [WIP] and so I thought there was more work being done on it. You may wan

[clang] a84599f - [OpenCL] Implement extended subgroups fully in headers.

Author: Anastasia Stulova Date: 2020-12-10T16:40:15Z New Revision: a84599f177a67d4a8c1c30ccd96c99fa40af75f7 URL: https://github.com/llvm/llvm-project/commit/a84599f177a67d4a8c1c30ccd96c99fa40af75f7 DIFF: https://github.com/llvm/llvm-project/commit/a84599f177a67d4a8c1c30ccd96c99fa40af75f7.diff

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa84599f177a6: [OpenCL] Implement extended subgroups fully in headers. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91373/new/ https://reviews.llvm.org/D91373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

spatel added a comment. In D87188#2445506 , @lebedev.ri wrote: > Partial rebase (without updating test coverage) Thanks for reducing! If I'm seeing it correctly, the codegen looks fine - the difference is in the IR icmp predicate changing from `slt` to `

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

sammccall added a comment. This is cool! Detecting basic typos could save a fair bit of time. I do want to be a bit wary of spending too much complexity on small enhancements to rarely used code - if it's more than a simple typo we're correcting, then I think it's ok to make the user look it up.

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen_01.cpp:1523 -// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4096, i64 4, i64 {{.+}}] +// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4, i64 4096, i64 {{.+}}] // Map

[clang] 9c4cddb - [Clang] Add vcmla and rotated variants for Arm ACLE.

Author: Florian Hahn Date: 2020-12-10T16:54:08Z New Revision: 9c4cddb53a7b94d83d1a7417c9a1aea00a139545 URL: https://github.com/llvm/llvm-project/commit/9c4cddb53a7b94d83d1a7417c9a1aea00a139545 DIFF: https://github.com/llvm/llvm-project/commit/9c4cddb53a7b94d83d1a7417c9a1aea00a139545.diff LOG:

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4cddb53a7b: [Clang] Add vcmla and rotated variants for Arm ACLE. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310930. tmroeder added a comment. Fixed a formatting problem brought up by clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatc

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2445612 , @martong wrote: > I wouldn't worry much about the `ASTMerge` tests, those are mostly legacy and > not actively used nowadays. (At one point we were thinking even to remove > them because we could got rid of t

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added a comment. Hmm, I think that the function is marked as `noexcept`, so the the funclet shouldn't be invoked and should get DCE'd, but that seems unrelated to ARC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://revie

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 310938. jdoerfert marked 8 inline comments as done. jdoerfert added a comment. Addressed remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/L

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert added a comment. Dropping the attribute and forcing the attribute to be somehow registered makes various use cases impossible. All we would allow is an integrated compilation where the consumers are available and the FE is aware of them. This is hard for optional LLVM plugins, potenti

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski marked 4 inline comments as done. awarzynski added a comment. Thank you for your reviews! I'll submit an updated patch shortly. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44 } else if (isa(JA) || isa(JA)) { -CmdArgs.push_back("-triple"); -CmdArgs

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

ABataev added a comment. Restore original formatting in test cases that were not directly affected by the patch. Also, I would start with a single kind of expression rather than trying to cover as many kinds of expressions as possible. It makes it easier to understand and to review it. =

[PATCH] D92041: [clangd] Add hover info for `this` expr

sammccall added a comment. Sorry for the delay here. Kadir is out on vacation. Yikes - it's a shame reusing our existing type printing doesn't do the right thing, but injected-classname and partial specializations are indeed weird. I'm tempted to say just to live with the "type-parameter-0-0" no

[clang] 764690b - [clang] Remove `-triple` from the invocations of `flang-new -fc1`

Author: Andrzej Warzynski Date: 2020-12-10T17:54:12Z New Revision: 764690b8a883c9466324f9c33ab1047a0661e8ef URL: https://github.com/llvm/llvm-project/commit/764690b8a883c9466324f9c33ab1047a0661e8ef DIFF: https://github.com/llvm/llvm-project/commit/764690b8a883c9466324f9c33ab1047a0661e8ef.diff

[PATCH] D93027: [clang] Remove `-triple` from the invocations of `flang-new -fc1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG764690b8a883: [clang] Remove `-triple` from the invocations of `flang-new -fc1` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHA

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3593 +def EnforceTCBLeaf : InheritableAttr { + let Spellings = [Clang<"enforce_tcb_leaf">]; + let Subjects = SubjectList<[Function]>; Are these two attributes mutually exclusive,

[PATCH] D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks. Comment at: clang-tools-extra/clangd/XRefs.cpp:316 +if (!DefLoc) { + elog("Failed to convert location:", DefLoc.takeError()); + return; --

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 ___ cf

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 310952. awarzynski added a comment. Update according to PR comments - extracted the `-triple` related part into https://reviews.llvm.org/D93027 - made sure that `flang-new` and `flang-new -fc1` return error when semantic checks fail - fixed typos Reposi

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

Flow requested review of this revision. Flow added a comment. In D90972#2394516 , @JonasToth wrote: > LGTM! thanks for fixing. I am unable to commit this myself. The latest version of this change

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

bryanpkc added a comment. Herald added a subscriber: dang. @erikjv Are you still working on this? Or is a better alternative being pursued? IIUC, this functionality is still missing in trunk. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63329/new/ https://revie

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added a subscriber: cfe-commits. Anastasia added a comment. This looks much cleaner than the current flow! Thanks! We should just figure out a better place for defining the macros (see detailed comment in Targets.cpp). I am adding @cfe-commits since it's an important change to be vis

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. I think it would be possible to add a new attribute to define these types. But only specific values for parameters would be allowed so that it could only generate the exact types we see here and the future segment load patches. It wouldn't be general purpose like v

[PATCH] D93002: [NPM] Support -fmerge-functions

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Thank you for adding this support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93002/new/ https://reviews.llvm.org/D93002 ___

[PATCH] D92954: [clang-offload-bundler] Add option -list

tra added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:188 + + if (Error Err = Func()) +return Err; Now, if we could save the triple in a `BundleInfo` when it's parsed, and pass `BundleInfo` to `Func()` that

[clang] ea66410 - Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""""

Author: Artem Dergachev Date: 2020-12-10T11:02:54-08:00 New Revision: ea6641085d025ca0a5cef940465ef14d0ccace02 URL: https://github.com/llvm/llvm-project/commit/ea6641085d025ca0a5cef940465ef14d0ccace02 DIFF: https://github.com/llvm/llvm-project/commit/ea6641085d025ca0a5cef940465ef14d0ccace02.dif

[clang] 00ffea7 - [analyzer][CTU] Add an abstraction layer between libCrossTU and libAnalysis.

Author: Artem Dergachev Date: 2020-12-10T11:02:54-08:00 New Revision: 00ffea77ad887b576e9db82d98c97a31fee172cb URL: https://github.com/llvm/llvm-project/commit/00ffea77ad887b576e9db82d98c97a31fee172cb DIFF: https://github.com/llvm/llvm-project/commit/00ffea77ad887b576e9db82d98c97a31fee172cb.dif

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00ffea77ad88: [analyzer][CTU] Add an abstraction layer between libCrossTU and libAnalysis. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for verifying! Aside from the minor nit with `isa<>`, this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ ht

[PATCH] D93002: [NPM] Support -fmerge-functions

nikic added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1776 + if (PTO.MergeFunctions) +MPM.addPass(MergeFunctionsPass()); + In the legacy PM this is placed after the AlwaysInlinerPass rather than before it: https://github.com/llvm/llvm-pr

[PATCH] D93002: [NPM] Support -fmerge-functions

aeubanks updated this revision to Diff 310969. aeubanks added a comment. move -O0 MergeFunctions after inlining add to LTO pipeline (matches legacy PM) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93002/new/ https://reviews.llvm.org/D93002 Files:

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

rnk added a comment. Nice, that wasn't too difficult. I had some suggestions for improving the test case, and I'd like to hear from Aaron. Comment at: clang/test/CodeGen/attr-nomerge.cpp:8 + [[clang::nomerge]] void f(); + [[clang::nomerge]] virtual void g(); + [[clang::nome

[PATCH] D93002: [NPM] Support -fmerge-functions

nikic accepted this revision. nikic added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93002/new/ https://reviews.llvm.org/D93002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] ff7e1da - [NPM] Support -fmerge-functions

Author: Arthur Eubanks Date: 2020-12-10T11:45:08-08:00 New Revision: ff7e1da68f2a74797d0d3454f6cac62064f7d982 URL: https://github.com/llvm/llvm-project/commit/ff7e1da68f2a74797d0d3454f6cac62064f7d982 DIFF: https://github.com/llvm/llvm-project/commit/ff7e1da68f2a74797d0d3454f6cac62064f7d982.diff

[PATCH] D93002: [NPM] Support -fmerge-functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff7e1da68f2a: [NPM] Support -fmerge-functions (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310974. tmroeder added a comment. Rebased to the latest head version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval updated this revision to Diff 310980. clementval added a comment. Herald added a subscriber: mgorny. Fix -Werror=covered-switch-default problems + rename OMP.cpp.inc to OMP.inc since the .cpp does not make sense anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. If you do this, `testroot-riscv64-baremetal-nogcc/` is probably also not useful (or you can replace it with a shorter string`. Can you fix the tests when gcc-riscv64-linux-gnu is installed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5216b295049: [PGO] Enable preinline and cleanup when optimize for size (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92996/new/ https://reviews.llvm.org/D92996 __

[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

jyknight added a comment. I don't think we should change the meaning of `__attribute__((const))` to exclude depending on thread-id. However, if we do want to do so, and call the existing uses of `__attribute__((const))` in glibc invalid, we need to special case many more functions. Looking thr

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. In D93023#2446757 , @MaskRay wrote: > If you do this, `testroot-riscv64-baremetal-nogcc/` is probably also not > useful (or you can replace it with a shorter string`. > > Can you fix the tests when gcc-riscv64-linux-gnu is installed

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx updated this revision to Diff 310997. flx marked an inline comment as done. flx added a comment. Shortened isa<> expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://reviews.llvm.org/D91893 Files: clang-tools-extra/cl

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

yaxunl requested changes to this revision. yaxunl added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown -Wpedantic-core-featu

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:400 +DiagCallback Handler) { + llvm::yaml::Input Input(Config, nullptr, Handler ? diagHandlerImpl : nullptr, + &Handler); --

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

dexonsmith updated this revision to Diff 311004. dexonsmith retitled this revision from "Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"" to "Basic: Support named pipes natively in SourceManager". dexonsmith edited the summary of this revision. dexonsmith added

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 311005. mibintc added a comment. Fixed a couple CallInst, setting the CallingConvention from information in the Function node. Updated LIT tests. I'd like to push the patch this weekend, looking for review thanks! Repository: rG LLVM Github Monorepo CHA

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:567 + if (IR.ContentsEntry->isNamedPipe()) +(void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation()); + jansvoboda11 wrote:

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith updated this revision to Diff 311008. rsmith added a comment. - Handle @rjmccall's review feedback. - Properly handle the case of a pack expansion into a non-pack and add tests for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91488/ne

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3758 TemplateArgument TA(T->getNumBitsExpr()); - mangleTemplateArgs(&TA, 1); + mangleTemplateArgs(TemplateName(), &TA, 1); if (T->isUnsigned()) -

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311010. jdoerfert added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya, mgorny. Herald added a project: LLVM. Allow to register assumption stings through llvm-core. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc added a comment. Answering my own questions In D92721#2441068 , @mibintc wrote: > Thanks @Anastasia ; I modified CGBuiltin.cpp to use EmitRuntimeCall when > creating calls to runtime functions instead of Builder.CreateCall so this is > setting t

[PATCH] D93068: [clang-offload-bundler] Add option -fail-on-missing-bundles

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. There are out-of-tree tools using clang-offload-bundler to extract bundles from bundled files. When a bundle is not in the

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 -

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

craig.topper added a comment. In D87188#2446096 , @spatel wrote: > In D87188#2445506 , @lebedev.ri > wrote: > >> Partial rebase (without updating test coverage) > > Thanks for reducing! > If I'm seeing it correctly

[clang] 0978c83 - Basic: Initialize FileEntry's fields inline, almost NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-10T13:57:21-08:00 New Revision: 0978c83e6fcc7a8aea18e24eb3b2ad5523581757 URL: https://github.com/llvm/llvm-project/commit/0978c83e6fcc7a8aea18e24eb3b2ad5523581757 DIFF: https://github.com/llvm/llvm-project/commit/0978c83e6fcc7a8aea18e24eb3b2ad552358

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG671ad580610a: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false… (authored by flx). Repository: rG LLVM Github Monorepo CHA

[clang-tools-extra] 671ad58 - [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

Author: Felix Berger Date: 2020-12-10T16:58:17-05:00 New Revision: 671ad580610ad91139358b7786e02ff70433a90e URL: https://github.com/llvm/llvm-project/commit/671ad580610ad91139358b7786e02ff70433a90e DIFF: https://github.com/llvm/llvm-project/commit/671ad580610ad91139358b7786e02ff70433a90e.diff

[PATCH] D93068: [clang-offload-bundler] Add option -fail-on-missing-bundles

tra added a comment. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:980 + if (FailOnMissingBundles && !Worklist.empty()) { +std::string ErrMsg = "Can't find bundles for"; +std::set Sorted; Do we need to report complete list of m

[PATCH] D93072: Fix PR35902: incorrect alignment used for ubsan check.

jyknight created this revision. jyknight added reviewers: rsmith, rnk. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. UBSan was using the complete-object align rather than nv alignment when checking the "this" pointer of a method.

[PATCH] D93031: Enable fexec-charset option

rsmith added a comment. I'm overall pretty happy about how clean and non-invasive the changes required here are. But please make sure you don't change the encodings of `u8"..."` / `u"..."` / `U"..."` literals; those need to stay as UTF-8 / UTF-16 / UTF-32. Also, we should have a story for how t

[PATCH] D93072: Fix PR35902: incorrect alignment used for ubsan check.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCXXABI.cpp:138 if (MD->getParent()->getNumVBases() == 0 || // avoid vcall in common case MD->getParent()->hasAttr() || + is

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

kaz7 added a comment. Thanks! Working on sysroot stuff now. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92996/new/ https://reviews.llvm.org/D92996 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] cd5855a - [VE] Remove -faddrsig and -fnoaddrsig tests

Author: Kazushi (Jam) Marukawa Date: 2020-12-11T08:25:38+09:00 New Revision: cd5855ac3ba7a91b2a4a7c97b2723c95038dacbe URL: https://github.com/llvm/llvm-project/commit/cd5855ac3ba7a91b2a4a7c97b2723c95038dacbe DIFF: https://github.com/llvm/llvm-project/commit/cd5855ac3ba7a91b2a4a7c97b2723c95038da

[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5855ac3ba7: [VE] Remove -faddrsig and -fnoaddrsig tests (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added inline comments. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 nickdesaulniers wrote: > Do we want to add checks for the a

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/asan-globals-alias.cpp:30 +// KASAN: @aliased_global_2{{.*}} global i32 +// KASAN: @joydev_ids{{.*}} global [1 x {{.*}}i64 1234 }], align 16 melver wrote: > nickdesaulniers wrote: > > Do we w

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 311042. zequanwu marked an inline comment as done. zequanwu added a comment. Add test for virutal function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files: cl

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:8 + [[clang::nomerge]] void f(); + [[clang::nomerge]] virtual void g(); + [[clang::nomerge]] static void f1(); rnk wrote: > Hm, virtual functions, there's something worth thinking

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:17 + +[[clang::nomerge]] bool bar() { + return true; rnk wrote: > I would leave this declaration as it was, so that all the statement attribute > test cases you wrote below remain a

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

rnk added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:8 + [[clang::nomerge]] void f(); + [[clang::nomerge]] virtual void g(); + [[clang::nomerge]] static void f1(); zequanwu wrote: > rnk wrote: > > Hm, virtual functions, there's something

[PATCH] D92662: [Clang][Coroutine] Drop const attribute on pthread_self when coroutine is enabled

lxfind added a comment. In D92662#2446777 , @jyknight wrote: > I don't think we should change the meaning of `__attribute__((const))` to > exclude depending on thread-id. > > However, if we do want to do so, and call the existing uses of > `__attribute__

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311060. jdoerfert added a comment. Move into LLVMCore and provide more helper to extracts assumptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/d

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu updated this revision to Diff 311062. zequanwu marked an inline comment as done. zequanwu added a comment. Add docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92800/new/ https://reviews.llvm.org/D92800 Files: clang/include/clang/AST

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

zequanwu added inline comments. Comment at: clang/test/CodeGen/attr-nomerge.cpp:17 + +[[clang::nomerge]] bool bar() { + return true; rnk wrote: > zequanwu wrote: > > rnk wrote: > > > I would leave this declaration as it was, so that all the statement > > > attr

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

tra updated this revision to Diff 311065. tra edited the summary of this revision. tra added a comment. Herald added a reviewer: aaron.ballman. Found another corner case (reference within a template with the surface/texture attibute.) and figured out a better fix. Added a test case. Repository:

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 updated this revision to Diff 311067. njames93 marked 3 inline comments as done. njames93 added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92990/new/ https://reviews.llvm.org/D92990 Files: clang-tools

[PATCH] D92990: [clangd] Provide suggestions with invalid config keys

njames93 added a comment. In D92990#2446097 , @sammccall wrote: > This is cool! Detecting basic typos could save a fair bit of time. > I do want to be a bit wary of spending too much complexity on small > enhancements to rarely used code - if it's more th

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

tra added a subscriber: rsmith. tra added a comment. My first variant of the patch only helped with some cases when the surface/texture attribute type was used. Trying to reduce real-world failure resulted in an example that I've added as the test case which was still failing with this patch app

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 311070. jdoerfert added a comment. Remove accidental test change and ensure users create `KnownAssumptionString` objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D919

[clang] a3fe12d - Ensure that we don't leave behind "InstantiatingSpecialization" entries

Author: Richard Smith Date: 2020-12-10T17:01:44-08:00 New Revision: a3fe12dc58aa2a0dd7292d748b7c104225f863ba URL: https://github.com/llvm/llvm-project/commit/a3fe12dc58aa2a0dd7292d748b7c104225f863ba DIFF: https://github.com/llvm/llvm-project/commit/a3fe12dc58aa2a0dd7292d748b7c104225f863ba.diff

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311079. tmroeder added a comment. I think I've fixed the Windows tests; I got a build working on a Windows machine and was able to debug. It looks like the problem is again due to delayed template parsing: the templatized functions in the test both came ou

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311081. tmroeder added a comment. Removed an unintentionally added extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersRefere

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added subscribers: Bigcheese, jansvoboda11, arphaman. dexonsmith added a comment. In D92160#2444732 , @OikawaKirie wrote: > - In my solution, I use a pretty straightforward approach, which is to have > an individual cache (for `FileEntry` and a

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added a comment. In D92160#2447586 , @dexonsmith wrote: > /// Current working directory. Grabbed from the (new) VFS whenever it's > /// changed, and updated if the file manager is notified that the VFS's > /// CWD changes. > std::string

[clang] 494aacd - Tooling: Migrate some tests to FileEntryRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-10T18:05:03-08:00 New Revision: 494aacd72c6a85a6d586fa58a8481e13b68acf24 URL: https://github.com/llvm/llvm-project/commit/494aacd72c6a85a6d586fa58a8481e13b68acf24 DIFF: https://github.com/llvm/llvm-project/commit/494aacd72c6a85a6d586fa58a8481e13b68a

[PATCH] D92967: Tooling: Migrate some tests to FileEntryRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG494aacd72c6a: Tooling: Migrate some tests to FileEntryRef, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92967/new/ https://re

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems fine to me. Comment at: clang/lib/AST/ItaniumMangle.cpp:4847 + /// Do we need to mangle template arguments with exactly correct types? + bool needExactType(unsign

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.llvm.org/D93008 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2384 + let Spellings = [Clang<"preferred_name", /*AllowInC*/0>]; + let Subjects = SubjectList<[ClassTmpl]>; + let Args = [TypeArgument<"TypedefType">]; jyknight wrote: > I wonder if th

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks for working through this! Updated patch LGTM, with one nit. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:314 FrontendOptions &FrontendOpts = Invoca

<    1   2   3   >