[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien created this revision. pvellien added reviewers: rampitec, arsenm, sameerds. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added projects: clang, LLVM. pvellien requested review of this revi

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added a comment. You need to add a new test for this new error. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA O

[clang-tools-extra] 73fdd99 - [clangd] Implement clang-tidy options from config

Author: Nathan James Date: 2020-11-25T18:35:35Z New Revision: 73fdd998701cce3aa6c4d8d2a73ab97351a0313b URL: https://github.com/llvm/llvm-project/commit/73fdd998701cce3aa6c4d8d2a73ab97351a0313b DIFF: https://github.com/llvm/llvm-project/commit/73fdd998701cce3aa6c4d8d2a73ab97351a0313b.diff LOG:

[PATCH] D91029: [clangd] Implement clang-tidy options from config

This revision was automatically updated to reflect the committed changes. Closed by commit rG73fdd998701c: [clangd] Implement clang-tidy options from config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://rev

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added a comment. Whoops, probably should've updated the summary before pushing, ah well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 ___ cfe-commits

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->

[PATCH] D92117: [AIX] Enabling vectory types for AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, jasonliu, Xiangling_L, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. ZarkoCA requested review of this revision. This patch enables vector types for AIX. Repository:

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. You think it's worth it to have a test for a user-specified deduction guide? I think this is missing an 'explicit' deduction guide test, so maybe we could test both things in a

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > jdoerfert wrote: >

[PATCH] D89065: [clang] Tweaked fixit for static assert with no message

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89065/new/ https://reviews.llvm.org/D89065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington updated this revision to Diff 307669. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: dexonsmith. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D916

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

erik.pilkington added a comment. In D91630#235 , @aaron.ballman wrote: > Can you mention this change in the release notes? Also, should we document it > explicitly in the Language Extensions documentation, or do you think this is > too tiny of a fea

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 307670. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188/new/ https://reviews.llvm.org/D90188 Files: clang/include/clang/AST/De

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1704-1707 +void ASTDeclReader::VisitUnresolvedUsingIfExistsDecl( +UnresolvedUsingIfExistsDecl *D) { + VisitNamedDecl(D); +} aaron.ballman wrote: > I'm not super fami

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

rnk marked an inline comment as done. rnk added a comment. Thanks! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: +break; + case ARM::BI_BitScanForward: thakis wrote: > Maybe `return None` here and LLVM_UNREACHABLE at the bottom? Sure, why no

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. One thing that just occurred to me: does this need an index version bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 ___ cfe-commits

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bd067272671: [MS] Fix double evaluation of MSVC builtin arguments (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D92061?vs=307468&id=307674#toc Repository: rG LLVM Github Monor

[clang] 3bd0672 - [MS] Fix double evaluation of MSVC builtin arguments

Author: Reid Kleckner Date: 2020-11-25T11:55:01-08:00 New Revision: 3bd06727267184223464f11d4e2470048ac40cb1 URL: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1 DIFF: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1.diff

[PATCH] D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins

kpn created this revision. kpn added reviewers: sepavloff, mibintc, rjmccall. kpn added a project: clang. Herald added a subscriber: cfe-commits. kpn requested review of this revision. Currently clang is not correctly retrieving from the AST the metadata for constrained FP builtins. This patch fi

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

rnk updated this revision to Diff 307678. rnk marked an inline comment as done. rnk added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92062/new/ https://reviews.llvm.org/D92062 Files: clang/include/clang/Basic/BuiltinsAA

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:336 + + // For Release ordering, the failure ordering should be Monotonic. + auto FailureOrdering = SuccessOrdering == AtomicOrdering::Release thakis wr

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. nope, as it doesn't change the serialization format. but any existing shards won't have refs from the main file, they'll accumulate over time as sources gets modified. (i don't think it is worth bumping the version to invalidate existing shards, if a user cares enough

[clang] 1e843a9 - [MS] Add more 128bit cmpxchg intrinsics for AArch64

Author: Reid Kleckner Date: 2020-11-25T12:07:28-08:00 New Revision: 1e843a987d847da48aaf41801b79cfb364937e8f URL: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f DIFF: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f.diff

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e843a987d84: [MS] Add more 128bit cmpxchg intrinsics for AArch64 (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM from the libc++ point of view. The CI is passing -- those failures are flaky modules tests that we need to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. Why don't yo want to try to implement the scheme similar to the declare target? Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssum

[clang-tools-extra] cbf336a - [clangd] Track deprecation of 'member' semantic token type in LSP.

Author: Sam McCall Date: 2020-11-25T21:31:46+01:00 New Revision: cbf336ad76cd619495b213e8364acaccb7a7c0d6 URL: https://github.com/llvm/llvm-project/commit/cbf336ad76cd619495b213e8364acaccb7a7c0d6 DIFF: https://github.com/llvm/llvm-project/commit/cbf336ad76cd619495b213e8364acaccb7a7c0d6.diff LO

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307685. Xiangling_L added a comment. Update the logic to tell if two AlignPackInfo are equal; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic/Attr.td clang/include/cl

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

ABataev updated this revision to Diff 307694. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91261/new/ https://reviews.llvm.org/D91261 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_mappe

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert updated this revision to Diff 307697. jdoerfert marked 8 inline comments as done. jdoerfert added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91980/new/ https://reviews.llvm.org/D91980 Files: clang/inclu

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2416950 , @ABataev wrote: > Why don't yo want to try to implement the scheme similar to the declare > target? Because it is not clear that the standard even says that right now. Even if, as you noted, what is the use

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added a comment. In D91980#2417049 , @jdoerfert wrote: > In D91980#2416950 , @ABataev wrote: > >> Why don't yo want to try to implement the scheme similar to the declare >> target? > > Because it is not cle

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall created this revision. sammccall added reviewers: njames93, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This cache went away i

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

kees added a comment. The kernel's [[ https://www.kernel.org/doc/html/latest/process/deprecated.html#implicit-switch-case-fall-through | stance ]] on switch statements reads: | | All switch/case blocks must end in one of: break; fallthrough; continue; goto ; return [expression]

[PATCH] D92117: [AIX] Enabling vector types for AIX

Xiangling_L accepted this revision. Xiangling_L added a comment. This revision is now accepted and ready to land. Just a minor suggestion: Maybe `Enabling return and argument vector types for AIX` is more accurate. Otherwise, LGTM. Comment at: clang/test/CodeGen/aix-altivec.c:

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi created this revision. saudi added reviewers: rnk, thakis, rsmith, AndyG. saudi added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ormris, hiraditya. Herald added a project: LLVM. saudi requested review of this revision. The test now moves the header fi

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added a comment. In D91980#2417129 , @ABataev wrote: > In D91980#2417049 , @jdoerfert wrote: > >> In D91980#2416950 , @ABataev wrote: >> >>> Why don't yo want to tr

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:1569-1593 +int idx = -1; +if (Tok.isAnyIdentifier()) { + II = Tok.getIdentifierInfo(); + llvm::StringSwitch SS(II->getName()); + for (const AssumptionClauseMappingInfo &ACMI : Assump

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

Quuxplusone added a comment. In D91895#2417170 , @kees wrote: > I think this should warn too. While this won't turn into a "missing break" > error, there's no way to know (from looking at code) what the _intent_ is > here. Hear, hear. +1 on everything @

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:34 + llvm::Optional + get(const ThreadsafeFS &TFS, + std::chrono::steady_clock::time_point FreshTime) const { To save a copy, could this not return a const pointer to wha

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added a comment. In D91311#2416940 , @ldionne wrote: > LGTM from the libc++ point of view. The CI is passing -- those failures are > flaky modules tests that we need to fix. Perhaps we need to specify `-fmodules-validate-system-headers` in the tes

[PATCH] D92140: Fix noderef for array member of deref expr

thejh created this revision. thejh added reviewers: leonardchan, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. Given an __attribute__((noderef)) pointer "p" to the struct struct s { int a[2]; }; ensure that the fo

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh created this revision. thejh added reviewers: leonardchan, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. As part of this change, one existing test case has to be adjusted because it accidentally stripped the NoD

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh added a comment. (I marked this as depending on D92140 because if you apply this patch to the current HEAD directly, the tests will break.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://re

[clang] 3fb0879 - Refactor and simplify class scope name lookup.

Author: Richard Smith Date: 2020-11-25T16:25:33-08:00 New Revision: 3fb0879867d7039cb61ffb6287ac17ac949adfa9 URL: https://github.com/llvm/llvm-project/commit/3fb0879867d7039cb61ffb6287ac17ac949adfa9 DIFF: https://github.com/llvm/llvm-project/commit/3fb0879867d7039cb61ffb6287ac17ac949adfa9.diff

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Thanks for catching this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 _

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a;// ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warn

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh updated this revision to Diff 307728. thejh added a comment. Removed duplicate tests as suggested by leonardchan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 Files: clang/lib/Sema/SemaExprMember.

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

thejh marked an inline comment as done. thejh added inline comments. Comment at: clang/test/Frontend/noderef.c:75-76 + // enclosing AddrOf. + p = &s->a;// ok + p = &(*s).a; // ok + p2 = &s->a; // expected-warning{{casting to dereferenceable pointer removes 'noderef' a

[clang] 7c327db - Part of C++ DR 39: a class member lookup is not ambiguous if it finds the

Author: Richard Smith Date: 2020-11-25T17:03:11-08:00 New Revision: 7c327db3ef73d771bc022d0723672fc356dc9017 URL: https://github.com/llvm/llvm-project/commit/7c327db3ef73d771bc022d0723672fc356dc9017 DIFF: https://github.com/llvm/llvm-project/commit/7c327db3ef73d771bc022d0723672fc356dc9017.diff

[PATCH] D92000: [clangd] Collect main file refs by default

nridge updated this revision to Diff 307730. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 Files: clang-tools-extra/clangd/ClangdServer.h clang-tools-ext

[clang-tools-extra] c6cb47b - [clangd] Collect main file refs by default

Author: Nathan Ridge Date: 2020-11-25T20:33:57-05:00 New Revision: c6cb47b640ffafda113581c488a73fb62b6ea38a URL: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a DIFF: https://github.com/llvm/llvm-project/commit/c6cb47b640ffafda113581c488a73fb62b6ea38a.diff

[PATCH] D92000: [clangd] Collect main file refs by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6cb47b640ff: [clangd] Collect main file refs by default (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/602 Repository: rG LLVM G

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92117: [AIX] Enabling vector types for AIX

ZarkoCA updated this revision to Diff 307748. ZarkoCA added a comment. Added regex and variable for function attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92117/new/ https://reviews.llvm.org/D92117 Files: clang/lib/CodeGen/TargetInfo.c

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2416625 , @craig.topper wrote: > gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc > here? Ah, yes, so this should be PPC-only change. But I see under x86 `-mlong-double-128`, std functions (`p

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307749. xndcn added a comment. Thanks! Update the commit as review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittests/Hov

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. I have replied to the comments and will update the code accordingly. Some of the codes are intentionally left to be update in 5.1 implementation. Will add TODO comments there. I will revisit the implementation of getBestWhenMatchForContext and also add more test

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

faisalv added a comment. In D91651#2416423 , @thakis wrote: > Do you have any numbers on false positives / true positives uncovered by this > tweak? That's a great question - and unfortunately not only do I have no hard data to support or discourage the

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 created this revision. psionic12 added reviewers: njames93, grosser, chapuni, john.brawn, alexfh, sammccall, nridge. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. psionic12 requested review of this revision. Herald added a su

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 updated this revision to Diff 307763. psionic12 added a comment. Fix some syntax Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92155/new/ https://reviews.llvm.org/D92155 Files: clang-tools-extra/clangd/tool/CMakeLists.txt clang/lib/F

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

njames93 added a comment. Is it possible to write tests for this, obviously they will only work with plugin support on the current platform. Also now that this is loaded from the command line, how will this play nicely with other tools that haven't been built with plugin support? Repository:

[PATCH] D92148: [clangd] Do not treat line as inactive if skipped range ends at character position 0

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92148/new/ https://reviews.llvm.org/D92148 __

<    1   2