[PATCH] D92041: Add hover info for `this` expr

xndcn added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->get

[PATCH] D92077: [clangd] Avoid type hierarchy crash on incomplete type

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/597 Repository: rG LLVM G

[PATCH] D92041: Add hover info for `this` expr

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->

[PATCH] D92077: [clangd] Avoid type hierarchy crash on incomplete type

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92077/new/ https://reviews.llvm.org/D92077

[PATCH] D83892: Port CodeGen option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D8

[clang-tools-extra] 3d2c681 - [clangd] Avoid type hierarchy crash on incomplete type

Author: Nathan Ridge Date: 2020-11-25T03:45:00-05:00 New Revision: 3d2c681f2835261599654c1b82dacdae05c9b4c4 URL: https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4 DIFF: https://github.com/llvm/llvm-project/commit/3d2c681f2835261599654c1b82dacdae05c9b4c4.diff

[PATCH] D92077: [clangd] Avoid type hierarchy crash on incomplete type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d2c681f2835: [clangd] Avoid type hierarchy crash on incomplete type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:610 +/// Generate a \p Hover object given the \p this pointer. +HoverInfo getHoverContents(const CXXThisExpr *CTE, const SymbolIndex *Index) { + const NamedDecl *D = CTE->getType()->getPointeeType()->get

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf created this revision. qiucf added reviewers: craig.topper, spatel, nemanjai, jsji, steven.zhang, PowerPC, kpn, RKSimon. Herald added subscribers: cfe-commits, pengfei. Herald added a project: clang. qiucf requested review of this revision. Under `-mlong-double-128` on x86 and `-mabi=ieeelo

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 abandoned this revision. gamesh411 added a comment. In D83717#2370154 , @NoQ wrote: > I don't think you actually need active support for invoking exit handlers > path-sensitively at the end of `main()` in order to implement your checker. > You

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307535. jansvoboda11 added a comment. Herald added a subscriber: jfb. Rebase, undo unnecessary moves, port recently added options, add TODOs (WIP) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ h

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3009-3010 + + if (!EffectiveTriple.isOSLinux()) +return; + emaste wrote: > Is there anything OS-dependent here? > > I plan to add `EffectiveTriple.isOSFreeBSD()` to F

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:134 +// although it might be a bigger effort. +const auto *FieldParent = dyn_cast(Field->getParent()) + ->getTemplateInstantiationPattern(); ---

[PATCH] D92082: [clangd] Add metrics for invalid name.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:683 +.. option:: EnumConstantIgnoredRegexp + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9028

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev added a comment. Sorry for such a tremendous delay. Mostly looks good functionally, I just have a few questions about semantics and several stylistic nits. Also, thanks for the amount of documentation - it makes it really nice to navigate around and review. Comment

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/support/FileCacheTests.cpp:15 +#include +#include + kbobyrev wrote: > Please sort the includes here (clangd should have a Code Action here). The includes are sorted, this is a bug in

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/support/FileCacheTests.cpp:15 +#include +#include + njames93 wrote: > kbobyrev wrote: > > Please sort the includes here (clangd should have a Code Action here). > The includes are so

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added subscribers: hvdijk, RKSimon. RKSimon added a reviewer: hvdijk. RKSimon added a comment. Adding @hvdijk as IIRC has been looking at gnux32 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D5205

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. Yeah, @hvdijk has made multiple other improvements which should finally allow the backend to be usable. We still disagree on the search paths for libraries and headers though if I remember correctly. My goal is to make LLVM and Rust work on an full Debian x32 system w

[PATCH] D74704: Support -fuse-ld=lld for riscv

serge-sans-paille added inline comments. Comment at: clang/test/lit.site.cfg.py.in:50 +if not "@CLANG_DEFAULT_LINKER@": +config.available_features('platform-linker') + thakis wrote: > Why do you need this feature? clang invocations that want to use the platfo

[clang-tools-extra] fb6f425 - [clangd] Add metrics for invalid name.

Author: Haojian Wu Date: 2020-11-25T10:50:43+01:00 New Revision: fb6f425d1b06480f4e61109852b1761cc15c81c1 URL: https://github.com/llvm/llvm-project/commit/fb6f425d1b06480f4e61109852b1761cc15c81c1 DIFF: https://github.com/llvm/llvm-project/commit/fb6f425d1b06480f4e61109852b1761cc15c81c1.diff LO

[PATCH] D92082: [clangd] Add metrics for invalid name.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb6f425d1b06: [clangd] Add metrics for invalid name. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/FileCache.cpp:18 +// The cached value does not reflect the current content on disk. +static constexpr uint64_t CacheDiskMismatch = -1; +// The cached value re

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall marked 3 inline comments as done. sammccall added a comment. (oops, missed a merge conflict. New snapshot shortly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88172/new/ https://reviews.llvm.org/D88172 _

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307549. njames93 added a comment. Tweak disableUnusableChecks to take an ArrayRef over a vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-e

[clang] e592dde - [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

Author: Francesco Petrogalli Date: 2020-11-25T10:16:43Z New Revision: e592dde6889b5119eb2794a30aca57c3760cab67 URL: https://github.com/llvm/llvm-project/commit/e592dde6889b5119eb2794a30aca57c3760cab67 DIFF: https://github.com/llvm/llvm-project/commit/e592dde6889b5119eb2794a30aca57c3760cab67.dif

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall updated this revision to Diff 307551. sammccall marked 2 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88172/new/ https://reviews.llvm.org/D88172 Files: clang-

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe592dde6889b: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CH

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/FileCache.h:58 + void read(const ThreadsafeFS &TFS, +std::chrono::steady_clock::time_point FreshTime, +llvm::function_ref)> Parse, kbobyrev wrote: > So the clie

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with `std::numeric_limits` in the second place :) Thanks! Comment at: clang-tools-extra/clangd/support/FileCache.cpp:21 +// The cached value reflects that the file d

[clang] 633cae3 - [OpenCL] Move kernel arg type tests into one file

Author: Sven van Haastregt Date: 2020-11-25T10:20:30Z New Revision: 633cae30599cc5ec99f679079499a1f2ca4d3af3 URL: https://github.com/llvm/llvm-project/commit/633cae30599cc5ec99f679079499a1f2ca4d3af3 DIFF: https://github.com/llvm/llvm-project/commit/633cae30599cc5ec99f679079499a1f2ca4d3af3.diff

[PATCH] D92033: [OpenCL] Move kernel arg type tests into one file

This revision was automatically updated to reflect the committed changes. Closed by commit rG633cae30599c: [OpenCL] Move kernel arg type tests into one file (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92033/new/ https://revie

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307557. njames93 added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/ClangdS

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. OK, I would love to get this landed. I think the simplest thing is to compute the config eagerly and load it in with DefaultOptionsProvider as you mentioned. I might fiddle with checking the filename afterwards, but I don't think this is blocking. Similarly I want to

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2414692 , @airlied wrote: > In D92004#2413560 , @Anastasia wrote: > >> Btw how about making some checks simpler. We could always define feature >> macros `__opencl_c_atomic_scop

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/support/FileCache.cpp:59 + // If the modified-time and size match, assume the content does too. + if (Size == Stat->getSize() && + ModifiedTime == Stat->getLastModificationTime()) Is trac

[clang-tools-extra] 0cb3869 - [clangd] Fix a tsan failure.

Author: Haojian Wu Date: 2020-11-25T11:47:44+01:00 New Revision: 0cb38699a09d859dd40da0e4216b6066c63035f6 URL: https://github.com/llvm/llvm-project/commit/0cb38699a09d859dd40da0e4216b6066c63035f6 DIFF: https://github.com/llvm/llvm-project/commit/0cb38699a09d859dd40da0e4216b6066c63035f6.diff LO

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) MaskRay wrote: > MaskRay wrote: > > ro wrote: > > > MaskRay wrote: > > > > ro wrote: > > > > > MaskRay wrote

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/FileCache.cpp:59 + // If the modified-time and size match, assume the content does too. + if (Size == Stat->getSize() && + ModifiedTime == Stat->getLas

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307565. njames93 added a comment. Use DefaultOptionsProvider for initializing ClangTidyContext. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-ex

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 + /*Priority=*/unsigned &, + /*CWD*/ PathRef); +} // namespace detail

[PATCH] D88172: [clangd] Extract common file-caching logic from ConfigProvider.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd95db1693cbf: [clangd] Extract common file-caching logic from ConfigProvider. (authored by sammccall). Changed prior to commit: https://reviews.ll

[clang-tools-extra] d95db16 - [clangd] Extract common file-caching logic from ConfigProvider.

Author: Sam McCall Date: 2020-11-25T12:09:13+01:00 New Revision: d95db1693cbf80b9de58a94b50178fddd62c3e15 URL: https://github.com/llvm/llvm-project/commit/d95db1693cbf80b9de58a94b50178fddd62c3e15 DIFF: https://github.com/llvm/llvm-project/commit/d95db1693cbf80b9de58a94b50178fddd62c3e15.diff LO

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 307569. vsavchenko added a comment. Herald added a subscriber: jdoerfert. Add more comments and fix another test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Fil

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:76 + +// Defined elements should maintain the following properties: +// 1. for any Kind K: NoReturn | K == K NoQ wrote: > M

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this LG! (The change to global makes sense but doesn't block us I think) Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +

[clang] 6d56823 - SemaExpr.cpp - use castAs<> instead of getAs<> as we dereference the pointer directly. NFCI.

Author: Simon Pilgrim Date: 2020-11-25T11:38:29Z New Revision: 6d56823116820962984cdd535cbed1191be696c9 URL: https://github.com/llvm/llvm-project/commit/6d56823116820962984cdd535cbed1191be696c9 DIFF: https://github.com/llvm/llvm-project/commit/6d56823116820962984cdd535cbed1191be696c9.diff LOG:

[clang] eb7ea5a - CGCall.cpp - use castAs<> instead of getAs<> as we dereference the pointer directly. NFCI.

Author: Simon Pilgrim Date: 2020-11-25T11:38:29Z New Revision: eb7ea5aa1ac6030b7bc94c5f2fb42de675cd392f URL: https://github.com/llvm/llvm-project/commit/eb7ea5aa1ac6030b7bc94c5f2fb42de675cd392f DIFF: https://github.com/llvm/llvm-project/commit/eb7ea5aa1ac6030b7bc94c5f2fb42de675cd392f.diff LOG:

[clang] 9d996c0 - TargetInfo.cpp - use castAs<> instead of getAs<> as we dereference the pointer directly. NFCI.

Author: Simon Pilgrim Date: 2020-11-25T11:38:29Z New Revision: 9d996c01aad5371ccf3790ce937b1cc85d1b07ab URL: https://github.com/llvm/llvm-project/commit/9d996c01aad5371ccf3790ce937b1cc85d1b07ab DIFF: https://github.com/llvm/llvm-project/commit/9d996c01aad5371ccf3790ce937b1cc85d1b07ab.diff LOG:

[clang] 88bb265 - SemaExpr.cpp - use castAs<> instead of getAs<> as we dereference the pointer directly. NFCI.

Author: Simon Pilgrim Date: 2020-11-25T11:38:30Z New Revision: 88bb2656708050bdb012c9046b3e30f3975f9949 URL: https://github.com/llvm/llvm-project/commit/88bb2656708050bdb012c9046b3e30f3975f9949 DIFF: https://github.com/llvm/llvm-project/commit/88bb2656708050bdb012c9046b3e30f3975f9949.diff LOG:

[clang] 2b66918 - [ARM][AArch64] Adding Neoverse N2 CPU support

Author: Mark Murray Date: 2020-11-25T11:42:54Z New Revision: 2b6691894ab671706051a6d7ef54571546c20d3b URL: https://github.com/llvm/llvm-project/commit/2b6691894ab671706051a6d7ef54571546c20d3b DIFF: https://github.com/llvm/llvm-project/commit/2b6691894ab671706051a6d7ef54571546c20d3b.diff LOG: [

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b6691894ab6: [ARM][AArch64] Adding Neoverse N2 CPU support (authored by MarkMurrayARM). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] a38d13e - [clangd] Use TimePoint<> instead of system_clock::time_point, it does matter after all.

Author: Sam McCall Date: 2020-11-25T12:49:24+01:00 New Revision: a38d13ed3635bfdd35226e8d8d0661a42bcd35c6 URL: https://github.com/llvm/llvm-project/commit/a38d13ed3635bfdd35226e8d8d0661a42bcd35c6 DIFF: https://github.com/llvm/llvm-project/commit/a38d13ed3635bfdd35226e8d8d0661a42bcd35c6.diff LO

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:492 desc("Store references to main-file-only symbols in the index"), -init(false), +in

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307577. jansvoboda11 added a comment. Introduce OptOutPositiveFFlag, simplify a couple of boolean options with multiclasses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.or

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307578. jansvoboda11 added a comment. Add squashed commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. The restriction on pointer-to-pointer kernel arguments has been relaxed in OpenCL 2.0. Apply the same address space restric

[PATCH] D71124: [RISCV] support clang driver to select cpu

oceanfish81 added a comment. Herald added subscribers: frasercrmck, dexonsmith, NickHung, pengfei. I tried to build the following: https://gist.github.com/advancedwebdeveloper/09033869445a09a2e297a73387d46c41/raw/bf7dac33e256621c445f9e61f88a832e50d901a3/llvm_cpu_features_investigation.cpp but it

[PATCH] D91930: [clangd] Implement textDocument/codeLens

kadircet added a comment. Thanks for the explanations. I've also had some discussions with @sammccall about this and would like to summarize them. There are two important things to keep in mind: - Collection is performed for the whole document. - Resolve requests cannot fail. (there's no `null`

[clang-tools-extra] ed242da - Fix a typo in the documentation to unbreak the sphinx builder.

Author: Aaron Ballman Date: 2020-11-25T07:34:08-05:00 New Revision: ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7 URL: https://github.com/llvm/llvm-project/commit/ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7 DIFF: https://github.com/llvm/llvm-project/commit/ed242da0ffa28493d8a5ee6b80ecbe2441ca48a7.diff

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

aaron.ballman added a comment. In D90282#2415189 , @smhc wrote: > There's a build failure from this merge, looks like a typo: > > diff --git > a/clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst > b/clang-tools-extra/docs/clang-t

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX updated this revision to Diff 307585. ArcsinX added a comment. Add structure to hold system includes and target. Use state machine to go though lines of the driver output. Handle invalid target Use '--target=X' instead of '-target X' Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D92012: [clangd][query-driver] Extract target

ArcsinX marked 5 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:134 elog("System include extraction: end marker missing: {0}", Output); -return {}; - } - - for (llvm::StringRef Line : llvm::make_rang

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 307587. reikdas added a comment. Address @rsmith 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td

[PATCH] D92012: [clangd][query-driver] Extract target

kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:67 + +bool isValidTarget(llvm::StringRef Triple) { + std::shared_ptr TargetOpts(new TargetOptions); i think you can just do `TargetRegistry::lookupTarget`

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! just nits, apart from the "-target already explicitly set" issue Kadir raised. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:99 + } +

[PATCH] D92012: [clangd][query-driver] Extract target

sammccall added a comment. Sorry, code reviews are racy :-) Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:134 elog("System include extraction: end marker missing: {0}", Output); -return {}; - } - - for (llvm::StringRef Line : llvm::make_range(StartIt,

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas marked 25 inline comments as done. reikdas added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:471 + template struct X {}; + X<1, 1u>::type y; // expected-error {{no type named 'type' in 'TypeSuffix::X<1, 1u>'}} + X<1, 1>::type z; //

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2414171 , @spatel wrote: > In D88712#2413877 , > @venkataramanan.kumar.llvm wrote: > >> In D88712#2413688 , @spatel wrot

[clang-tools-extra] f697050 - [clangd] PopulateSwitch: disable on dependent enums.

Author: Adam Czachorowski Date: 2020-11-25T14:12:29+01:00 New Revision: f6970503d291b7cae70fe583bed392387f93f9e4 URL: https://github.com/llvm/llvm-project/commit/f6970503d291b7cae70fe583bed392387f93f9e4 DIFF: https://github.com/llvm/llvm-project/commit/f6970503d291b7cae70fe583bed392387f93f9e4.d

[PATCH] D92051: [clangd] PopulateSwitch: disable on dependent enums.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6970503d291: [clangd] PopulateSwitch: disable on dependent enums. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92051/new/ https://re

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 307594. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add another comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/i

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt updated this revision to Diff 307602. trixirt added a comment. Addresses issues before refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91789/new/ https://reviews.llvm.org/D91789 Files: clang-tools-extra/clang-tidy/linuxkernel/

[PATCH] D92061: [MS] Fix double evaluation of MSVC builtin arguments

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1019 + default: +break; + case ARM::BI_BitScanForward: Maybe `return None` here and LLVM_UNREACHABLE

[PATCH] D92062: [MS] Add more 128bit cmpxchg intrinsics for AArch64

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:336 + + // For Release ordering, the failure ordering should be Monotonic. + auto FailureOrdering = SuccessOrdering == Atomi

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong created this revision. martong added a reviewer: rsmith. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: shafik. Herald added a project: clang. martong requested review of this revision. http://lists.llvm.org/pipermail/cfe-dev/2020-No

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5893 + // in the global scope. + EXPECT_EQ(Param->getType()->getAs()->getDecl(), Typedef); +} Note, this "expectation" fails in baseline. Repository: rG LLVM Github Monorepo

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307615. njames93 added a comment. Removed duplicated logging of options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files: clang-tools-extra/clangd/CMakeLists.t

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 307617. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Addressed the comments; Handle PCH for AIX; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.o

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L added inline comments. Comment at: clang/include/clang/Sema/Sema.h:637 PragmaStack VtorDispStack; - // #pragma pack. - // Sentinel to represent when the stack is set to mac68k alignment. - static const unsigned kMac68kAlignmentSentinel = ~0U; - PragmaStack Pack

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5906 + Lang_CXX17, "input.cc"); + TU->dump(); + auto *Guide = FirstDeclMatcher().match( These `dump` calls should be removed (in the other case too)? Repository: rG LLV

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

thakis added a comment. Do you have any numbers on false positives / true positives uncovered by this tweak? In general, warning at use time instead of at declaration time tends to be much better for this rate, and we do this differently than gcc in several instances, because the gcc way has so

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 307622. xndcn added a comment. Update the diff with `getHoverContents(const NamedDecl ..)` overload function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 Files: clang-tools-extra/clangd/Hover.cpp clang

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: > CW

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + njames93 wrote: > sa

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: > n

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nigelp-xmos requested review of this revision. Function Parser::ParseAvailabilityAttribute checks that the message string of an availability attribute is not a wide string literal. Test case c

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Alternatively, if all 1-byte-character strings are acceptable, should I remove the check that the first token is a string literal, and omit the failing test case on XCore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 added inline comments. Comment at: clang-tools-extra/clangd/TidyProvider.h:25 +/*Filename=*/llvm::StringRef, +/*CWD*/ PathRef) const>; + sammccall wrote: > sa

[clang] dc96cc3 - [clang][test] Fix prefix operator++ signature in iterators

Author: Endre Fülöp Date: 2020-11-25T18:05:11+01:00 New Revision: dc96cc33c13e1e38382118c25bf26de480eb2b12 URL: https://github.com/llvm/llvm-project/commit/dc96cc33c13e1e38382118c25bf26de480eb2b12 DIFF: https://github.com/llvm/llvm-project/commit/dc96cc33c13e1e38382118c25bf26de480eb2b12.diff L

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc96cc33c13e: [clang][test] Fix prefix operator++ signature in iterators (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89528/new/ h

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. Thanks @david-arm for posting this proposal to the cfe list. My confusion has been cleared up. The (new) proposal is to have: 1. vectorize_width(X) where X is an integer. 2. vectorize_width(X, fixed|scalable) 3. vectorize_width(fixed|scalable) And with that 3rd opti

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307636. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos updated this revision to Diff 307638. nigelp-xmos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108 Files: clang/lib/Parse/ParseDecl.cpp clang/test/Parser/att

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong created this revision. martong added reviewers: teemperor, shafik, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong requested review of this revision. CXXDeductionGuideDecl is

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307642. njames93 added a comment. Removed CWD references. Added some fixme comments about function_ref<->unique_function and null values. Added asserts in provideClangTidyFiles ensuring path is absolute. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 _

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis updated this revision to Diff 307646. zinovy.nis added a comment. Handle ref & val mixed cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp clang-

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall accepted this revision. sammccall added a comment. Hooray, ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 ___ cfe-commits mailing list cfe-com

  1   2   >