[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

kadircet added inline comments. Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation &Invocation, -const llvm::MemoryBuffer *MainFileBuffer, PreambleBounds Bounds, -llvm::vfs::FileSystem *VFS

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306334. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-to

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90750/new/ https://reviews.llvm.org/D90750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] 47518d6 - [clang-tidy] Improving bugprone-sizeof-expr check.

Author: Balázs Kéri Date: 2020-11-19T10:26:33+01:00 New Revision: 47518d6a0aed7ec3607aeacfa511dedda2cd67cb URL: https://github.com/llvm/llvm-project/commit/47518d6a0aed7ec3607aeacfa511dedda2cd67cb DIFF: https://github.com/llvm/llvm-project/commit/47518d6a0aed7ec3607aeacfa511dedda2cd67cb.diff L

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG47518d6a0aed: [clang-tidy] Improving bugprone-sizeof-expr check. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91543/new/ https://re

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. With your latest patch update clang segfaults for me even when '-feh-asynch' is not passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-c

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d1f471e45af: [Mach0] Fix unused-variable warnings (authored by ehjogab, committed by dstenb). Herald added a project: LLVM. Changed prior to commit

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas requested review of this revision. This introduces command-line support for the 'armv8.7-a' architecture name (and an alias wit

[PATCH] D91777: [clangd] No crash on "-verify" mode.

hokein created this revision. hokein added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If there is a "-verify" flag in the compile command, cl

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis updated this revision to Diff 306351. joechrisellis marked an inline comment as done. joechrisellis added a comment. Address @c-rhodes's comments regarding lax conversion when __ARM_FEATURE_SVE_BITS != N for GNU vectors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:278-283 -// Test implicit conversion between SVE and GNU vector is invalid when -// __ARM_FEATURE_SVE_BITS != N -#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512 -typed

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs &SA = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 &&

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

MyDeveloperDay added a comment. Can you rerun clang/docs/tools/dump_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91507/new/ https://reviews.llvm.org/D91507 ___ cfe-commits mailing list cfe-com

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

MyDeveloperDay added a comment. make sure you build the other clang-extra tools (I'm not sure who else uses the lib/Tooling) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91507/new/ https://reviews.llvm.org/D91507

[PATCH] D91428: Add support for multiple program address spaces

pmatos added a comment. The RFC has now been sent to the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2020-November/146723.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 ___

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91776/new/ https://reviews.llvm.org/D91776 ___

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

joechrisellis updated this revision to Diff 306358. joechrisellis added a comment. Avoid doing `FirstType->getAs()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91262/new/ https://reviews.llvm.org/D91262 Files: clang/include/clang/Sema/Sema.h

[clang] 1e2da38 - [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

Author: Joe Ellis Date: 2020-11-19T11:18:35Z New Revision: 1e2da3839cc3543629ecb847fd3aa34edb64b42a URL: https://github.com/llvm/llvm-project/commit/1e2da3839cc3543629ecb847fd3aa34edb64b42a DIFF: https://github.com/llvm/llvm-project/commit/1e2da3839cc3543629ecb847fd3aa34edb64b42a.diff LOG: [AA

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e2da3839cc3: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors (authored by joechrisellis). Repository: rG LLVM Github M

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. Can we please keep barriers out of scope? I think there's a lot of design to be done there and I'd rather just get the core atomics working first. BTW I got [ 31%] Building LanaiGenDAGISel.inc...

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); rjmccall wr

[PATCH] D87981: [X86] AMX programming model.

rengolin added a comment. You should at least get @craig.topper's feedback, given this is a significant change in the x86 backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 __

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added a comment. In D87981#2405187 , @rengolin wrote: > You should at least get @craig.topper's feedback, given this is a significant > change in the x86 backend. We had internal review with Craig on the design before. Craig In D87981#2405187

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

andreadb added a comment. LGTM for llvm-mca. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang-tools-extra] 1407833 - [clangd] Disable SerializationTest.NoCrashOnBadArraySize with ASAN

Author: Kirill Bobyrev Date: 2020-11-19T13:24:55+01:00 New Revision: 140783347afb6e1848c81617d7fa3e556087cadd URL: https://github.com/llvm/llvm-project/commit/140783347afb6e1848c81617d7fa3e556087cadd DIFF: https://github.com/llvm/llvm-project/commit/140783347afb6e1848c81617d7fa3e556087cadd.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. In D91311#2404098 , @rsmith wrote: > In D91311#2403805 , @ldionne wrote: > >> We can stick with this design, but I'd like to understand why `#if >> _LIBCPP_HAS_NO_PREFERRED_NAME` is necessa

[PATCH] D91784: [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines

kprovost created this revision. kprovost added reviewers: kito-cheng, khchen, s.egerton, emaste. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, luismarques, apazos, sameer.abuasal, pzheng, lenary, Jim, benna, psnobl, jocewei, PkmX, jfb, the_o, brucehoult, MartinMosbeck, ro

[PATCH] D91784: [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines

jrtc27 accepted this revision. jrtc27 added reviewers: asb, lenary, luismarques. jrtc27 added a comment. This revision is now accepted and ready to land. This seems correct. GCC doesn't define the 1 and 2 variants but it implements those with libcalls rather than inline like LLVM so that's to be

[PATCH] D91784: [RISCV] Set __GCC_HAVE_SYNC_COMPARE_AND_SWAP_x defines

kprovost added a comment. Thanks for the review. I don't have commit access to the LLVM repo, so I'd appreciate it if someone who does can commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91784/new/ https://reviews.llvm.org/D91784

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306373. MarkMurrayARM added a comment. Address more review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c c

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:909 + FeatureMTE, + FeatureSVE2, + FeatureTRBE]>; SVE2 Bitperm is missing

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:51 + // check specific version of feature) + void supportFeatureForPreOCL30(StringRef Feat, bool On = true) { +assert(CLVer < 300 && "Can'be called for OpenCL C higher 3.0");

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:88 +inline bool operator<(const Config::ExternalIndexSpec &LHS, + const Config::ExternalIndexSpec &RHS) { Maybe we could use DenseMap instead? Defining an order

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-else-after-return-pp-no-crash.cpp:1 +// RUN: clang-tidy %s -checks=-*,readability-else-after-return -- -std=c++11 + Yo

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new plugin example! Do you need me to commit on your behalf? If so, are you okay with `Yafei Liu ` for attribution? Repository: rG LLVM Github Monorep

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman. trixirt added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. trixirt requested review of this revision. Cleaning up -Wextr

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 __

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 added a comment. Thanks. Committing this without the NFC change. Comment at: clang/include/clang/Driver/Options.td:407 + +def fparse_all_comments : Flag<["-"], "fparse-all-comments">, Group, Flags<[CC1Option]>, + MarshallingInfoFlag<"LangOpts->CommentOpts.ParseAl

[clang] 17497ec - [AIX][FE] Support constructor/destructor attribute

Author: Xiangling Liao Date: 2020-11-19T09:24:01-05:00 New Revision: 17497ec514f7a87e0ac39a803534b3a324a19324 URL: https://github.com/llvm/llvm-project/commit/17497ec514f7a87e0ac39a803534b3a324a19324 DIFF: https://github.com/llvm/llvm-project/commit/17497ec514f7a87e0ac39a803534b3a324a19324.diff

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG17497ec514f7: [AIX][FE] Support constructor/destructor attribute (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https:/

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman added a comment. Thank you for the documentation effort! Comment at: clang/docs/LibASTMatchersReference.html:100 + +Traverse Mode + I think this section should go above the Node Matchers section in the document so that Node Matchers stays directl

[PATCH] D83691: Port Comment option flags to new parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1702a297b8b: [clang][cli] Port Comment option flags to new parsing system (authored by jansvoboda11). Changed prior to commit: https://reviews.ll

[clang] a1702a2 - [clang][cli] Port Comment option flags to new parsing system

Author: Jan Svoboda Date: 2020-11-19T15:27:13+01:00 New Revision: a1702a297b8bb1e4ed15673c6e122ac9dab4c802 URL: https://github.com/llvm/llvm-project/commit/a1702a297b8bb1e4ed15673c6e122ac9dab4c802 DIFF: https://github.com/llvm/llvm-project/commit/a1702a297b8bb1e4ed15673c6e122ac9dab4c802.diff L

[PATCH] D91104: APINotes: add property models for YAML attributes

martong added inline comments. Comment at: clang/include/clang/APINotes/Types.h:60 + /// Whether SwiftPrivate was specified. + unsigned SwiftPrivateSpecified : 1; + I was wondering whether Swift specific properties are meaningful to all descendants of `CommonE

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:25 +struct basic_string_view { + using size_type = unsigned; + nit: `using size_type = decltype(sizeof(0));` Com

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

psmith added a comment. Personally I'm in favour of clang and gcc behaving the same way unless there is a good reason not to. I've shared the review internally to see if anyone has any concerns. May be worth informing the clang built linux community to see if they will need to make any alterati

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

aaron.ballman added a comment. In D90282#2395956 , @smhc wrote: > I updated it to use XXShortSizeThreshold. > > But I was thinking.. perhaps a more generic approach could be > "xxIgnoreRegex", this would allow you to do things such as : > > VariableIgnore

[clang] 7a0ea12 - [clang][cli] Port analyzer flags to new option parsing system

Author: Jan Svoboda Date: 2020-11-19T15:42:34+01:00 New Revision: 7a0ea120e2a1fffab71f9c8e3d5337899f7a42af URL: https://github.com/llvm/llvm-project/commit/7a0ea120e2a1fffab71f9c8e3d5337899f7a42af DIFF: https://github.com/llvm/llvm-project/commit/7a0ea120e2a1fffab71f9c8e3d5337899f7a42af.diff L

[PATCH] D83693: Port analyzer flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a0ea120e2a1: [clang][cli] Port analyzer flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] 734d2f9 - [clangd] No crash on "-verify" mode.

Author: Haojian Wu Date: 2020-11-19T15:51:53+01:00 New Revision: 734d2f98f64940b1f545d677729d213a954c7a3f URL: https://github.com/llvm/llvm-project/commit/734d2f98f64940b1f545d677729d213a954c7a3f DIFF: https://github.com/llvm/llvm-project/commit/734d2f98f64940b1f545d677729d213a954c7a3f.diff LO

[PATCH] D91777: [clangd] No crash on "-verify" mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG734d2f98f649: [clangd] No crash on "-verify" mode. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91777/new/ https://reviews.llvm.org/D

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTrailingSemiCheck.cpp:31 +const MacroDirective *MD) override { +auto *MI = MD->getMacroInfo(); + Please don't use auto when type is not spelle

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306408. MarkMurrayARM added a comment. Address reviewer comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c clang

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

ilinpv added a comment. Have you got any further comments? Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2170 + SmallVector Ops; + if (TLI.getLibcallName(LC)) { +Ops.append(Node->op_begin() + 2, Node->op_end()); t.p.northover wrote: >

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:492 + +#define MACRO1 struct InMacro1 { int i; InMacro1() { i = 0; } }; +// CHECK

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. LG after fixing the minor nits. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6377 +} else { + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added a comment. Thanks. Somehow my build is successful. I kind of know what is the possible issue but wonder why I did not hit it. > Can we please keep barriers out of scope? I think there's a lot of design to > be done there and I'd rather just get the core atomics working first

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert accepted this revision. jdoerfert added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:57 +const MatchFinder::MatchResult &Result) { + bool IsPosix = PP->isMacroDefined("_POSIX_C_SOURCE") || + Result.Context->getTargetIn

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTrailingSemiCheck.cpp:15 + +#include + Any reason for including the c standard header? Comment at: clang-tools-extra/clang-tidy/linuxkernel/MacroTraili

[PATCH] D91799: [clang-format] State where clang-format-diff.py should be run from

DavidSpickett created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DavidSpickett requested review of this revision. At least with git, file paths in a diff will be relative to the repo root. So if you are in "llvm-project/lldb" and the diff shows "clang/foo

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

Anastasia added a comment. LGTM for the fix! Do you think we could improve testing? I presume there is something that triggers a failure without your change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D9092

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. I'm fine with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing list

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda8bec47ab8c: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging (authored by jhuber6). Changed prior to commit: https://reviews.l

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 +Matches[1] != "lto") { + MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default")); return Error::success(); I think it would be clearer to check against

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:60 + /// Whether SwiftPrivate was specified. + unsigned SwiftPrivateSpecified : 1; + martong wrote: > I was wondering whether Swift speci

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 306448. aeubanks added a comment. check 'thinlto-pre-link'/'lto-pre-link' explicitly add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGe

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 + // Don't do anything for (thin)lto backend compiles at O0. + if (Matches[1] != "thinlto" && Matches[1] != "lto") +MPM.addPass(buildO0Def

[PATCH] D91805: [OPENMP]Use the real pointer value as base, not indexed value.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. After fix for PR48174 the base pointer for pointer-based array-sections/array-subscripts will be emitt

[PATCH] D91806: [SVE] Remove warnings from release notes example on SVE ACLE.

fpetrogalli created this revision. fpetrogalli added reviewers: peterwaller-arm, efriedma, paulwalker-arm, joechrisellis, sdesmalen. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, lxfind, psnobl, hiraditya, tschuett. Herald added projects: clang, LLVM. fpetrogalli requested revi

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

sammccall added a comment. In D89743#2363201 , @aaron.ballman wrote: > In D89743#2360258 , @sammccall wrote: > >> (while this is useful to you, let's keep discussing, but I'm also happy to >> stop and land this wi

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:2365 +Matches[1] != "lto") { + MPM.addPass(buildO0DefaultPipeline(L, Matches[1] != "default")); return Error::success(); tejohnson wrote: > I think it would be cleare

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, yaxunl. Herald added a project: clang. tra requested review of this revision. Standard libc++ headers in stdc++ mode include which picks up cuda_wrappers/new before any of the CUDA macros have been defined.

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Seems that sufficient approvals have been received. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91410/new/ https://reviews.llvm.org/D91410

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

sfertile added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask) ZarkoCA

[clang-tools-extra] 617e8e5 - [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

Author: Nathan James Date: 2020-11-19T18:20:32Z New Revision: 617e8e5ee3bb3316baae7a69d74b5ff95031d571 URL: https://github.com/llvm/llvm-project/commit/617e8e5ee3bb3316baae7a69d74b5ff95031d571 DIFF: https://github.com/llvm/llvm-project/commit/617e8e5ee3bb3316baae7a69d74b5ff95031d571.diff LOG:

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG617e8e5ee3bb: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches… (authored by njames93). Cha

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. How fun. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91807/new/ https://reviews.llvm.org/D91807 _

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

ilinpv added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6377 +} else { + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("-outline-atomics"); jyknight wrote: > We don't usually explicitly use negative features like

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90568/new/ https://reviews.llvm.org/D90568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. LG, I have no further comments, though see what other say about this first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LinuxKernelTidyModule.cpp:25 "linuxkernel-must-check-errs"); CheckFactories.registerCheck("linuxkernel-switch-semi"); } This check hasn't landed, can you please

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks updated this revision to Diff 306473. aeubanks added a comment. change strings to check for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include

[clang] 9a46505 - [CUDA] Unbreak CUDA compilation with -std=c++20

Author: Artem Belevich Date: 2020-11-19T10:35:47-08:00 New Revision: 9a465057a64dba8a8614424d26136f5c0452bcc3 URL: https://github.com/llvm/llvm-project/commit/9a465057a64dba8a8614424d26136f5c0452bcc3 DIFF: https://github.com/llvm/llvm-project/commit/9a465057a64dba8a8614424d26136f5c0452bcc3.diff

[PATCH] D91807: [CUDA] Unbreak CUDA compilation with -std=c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a465057a64d: [CUDA] Unbreak CUDA compilation with -std=c++20 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91585/new/ https://reviews.llvm.org/D91585 ___

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306469. tentzen added a comment. Fixed the clang fault when built without '-feh-asynch' option. EHStack's CGF field must be initialized even without -feh-asynch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 306472. leonardchan added a comment. Rebased. @rjmccall This might've changed a bit since you last accepted the revision. Will wait a couple of days before submitting if you have any more comments on this. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Thanks, looks like I'll try to see if libcxx code can be changed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://reviews.llvm.org/D90719 ___ cfe-commits ma

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306477. ayermolo marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +std::string Val = HNOption.General.lookup(Opt.first); +if (Val.empty()) { + HNOption.General.insert({Opt.first, Opt.second.str()}); -

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 306478. MaskRay edited the summary of this revision. MaskRay added a comment. Switch to -fbinutils-version=none from 'future' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D8

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4023 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "DWARVv3 or greater"; +else if (!RawTriple.isArch64Bit())

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. *ping* any more comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306482. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ c

[clang-tools-extra] d7747da - [clangd] Also detect corrupt stri table size.

Author: Sam McCall Date: 2020-11-19T20:11:14+01:00 New Revision: d7747dacba8e4a7784ea8ef20abbff87d5681b81 URL: https://github.com/llvm/llvm-project/commit/d7747dacba8e4a7784ea8ef20abbff87d5681b81 DIFF: https://github.com/llvm/llvm-project/commit/d7747dacba8e4a7784ea8ef20abbff87d5681b81.diff LO

[PATCH] D91299: [clangd] Also detect corrupt stri table size.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7747dacba8e: [clangd] Also detect corrupt stri table size. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D91299?vs=304641&id=306484#toc Repository: rG LLVM Github Monore

[clang-tools-extra] ad5a195 - [clangd] Express ASAN interactions of tests more clearly. NFC

Author: Sam McCall Date: 2020-11-19T20:14:51+01:00 New Revision: ad5a195ae510fbfaf7885549e4899c85f0593fa5 URL: https://github.com/llvm/llvm-project/commit/ad5a195ae510fbfaf7885549e4899c85f0593fa5 DIFF: https://github.com/llvm/llvm-project/commit/ad5a195ae510fbfaf7885549e4899c85f0593fa5.diff LO

  1   2   >