[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 __

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:699 + let Inst{51-48} = addr{19-16}; // base reg + let Inst{55-52} = dst; + let Inst{47-32} = addr{15-0}; // offset jackmanb wrote: > There is another mismatch between what I

[PATCH] D91702: [clangd] Implement textDocument/implementation (Xref layer)

usaxena95 updated this revision to Diff 306114. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91702/new/ https://reviews.llvm.org/D91702 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306115. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. Because I was not understanding, we have discussed this further offline. I think the conclusion was: pragma `vectorize_width` controls the vectorisation vector `VF` in ``. where `vscale` is not just a separate thing but it defines a VectorType. That's why it would

[clang-tools-extra] 4324320 - [clangd] Implement textDocument/implementation (Xref layer)

Author: Utkarsh Saxena Date: 2020-11-18T17:06:47+01:00 New Revision: 43243208fa6fafe8b91e42c82bc56db9d99f76d3 URL: https://github.com/llvm/llvm-project/commit/43243208fa6fafe8b91e42c82bc56db9d99f76d3 DIFF: https://github.com/llvm/llvm-project/commit/43243208fa6fafe8b91e42c82bc56db9d99f76d3.diff

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:317 + sum = sizeof(PtrArray) / sizeof(PtrArray1[0]); + // There is no warning for 'sizeof(T*)/sizeof(Q)' case. + sum += sizeof(PtrArray) / sizeof(A[0]); -

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-sizeof-expression.cpp:317 + sum = sizeof(PtrArray) / sizeof(PtrArray1[0]); + // There is no warning for 'sizeof(T*)/sizeof(Q)' case. +

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91721 Files:

[clang] 7046be1 - [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

Author: dreachem Date: 2020-11-18T10:46:42-06:00 New Revision: 7046be17307d7439053d6693bf81540e3dc479d2 URL: https://github.com/llvm/llvm-project/commit/7046be17307d7439053d6693bf81540e3dc479d2 DIFF: https://github.com/llvm/llvm-project/commit/7046be17307d7439053d6693bf81540e3dc479d2.diff LOG:

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC] (authored by dreachem, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 057e6bb - [SystemZ][NFC] Group SystemZ tests in SystemZ folder

Author: Abhina Sreeskantharajan Date: 2020-11-18T11:49:15-05:00 New Revision: 057e6bb5540b5ec57e73c56dca80c17fabc949e5 URL: https://github.com/llvm/llvm-project/commit/057e6bb5540b5ec57e73c56dca80c17fabc949e5 DIFF: https://github.com/llvm/llvm-project/commit/057e6bb5540b5ec57e73c56dca80c17fabc9

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. > Did anyone conclude there that the language address spaces should be added > for SYCL? I can't see any of this. In fact I don't even think there was any > conclusion on the RFC. You should first make your design clear and agreed > before going ahead with the implementat

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG057e6bb5540b: [SystemZ][NFC] Group SystemZ tests in SystemZ folder (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHA

[clang] 0415cf4 - Fix unused variable warning. NFCI.

Author: Simon Pilgrim Date: 2020-11-18T16:50:51Z New Revision: 0415cf470bfbf16a06938424c3cad30c12cc2284 URL: https://github.com/llvm/llvm-project/commit/0415cf470bfbf16a06938424c3cad30c12cc2284 DIFF: https://github.com/llvm/llvm-project/commit/0415cf470bfbf16a06938424c3cad30c12cc2284.diff LOG:

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

tianshilei1992 added a comment. In D89802#2402886 , @jhuber6 wrote: > Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash > using this patch, I haven't encountered any errors on my machine. Could you > verify that this doesn't cau

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:116 +Defining CallSuperAttr +== psionic12 wrote: > After a whole day's research of `Sphinx`, I figured out that > `ClangPlugins.rst` is the "proto-type" of > htt

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

sfertile accepted this revision. sfertile added a comment. Thanks for the updates. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske updated this revision to Diff 306134. balazske added a comment. Adding FIXME comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91543/new/ https://reviews.llvm.org/D91543 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressio

[clang-tools-extra] 0016ab6 - Revert "[clangd] Implement textDocument/implementation (Xref layer)"

Author: Utkarsh Saxena Date: 2020-11-18T18:05:16+01:00 New Revision: 0016ab6f3632968e52eb83de021908f0c94bbb10 URL: https://github.com/llvm/llvm-project/commit/0016ab6f3632968e52eb83de021908f0c94bbb10 DIFF: https://github.com/llvm/llvm-project/commit/0016ab6f3632968e52eb83de021908f0c94bbb10.diff

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes accepted this revision. c-rhodes added a comment. This revision is now accepted and ready to land. LGTM I've left one minor comment, if that suggestion works it should be fine to fix it before committing Comment at: clang/lib/Sema/SemaExpr.cpp:7210-7212 +const au

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/M68k.cpp:51 +} +return CPUName.str(); + } Can't we just use StringSwitch here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. In D91567#2400699 , @mtrofin wrote: > In D91567#2400207 , @aeubanks wrote: > >> What about removing the existing AlwaysInlinerPass and replacing it with >> this one? Or is that something y

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin updated this revision to Diff 306141. mtrofin added a comment. Running just the always inliner variant, without other passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91567/new/ https://reviews.llvm.org/D91567 Files: clang/test/Fron

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

google-llvm-upstream-contributions added a comment. In D91567#2403173 , @aeubanks wrote: > In D91567#2400699 , @mtrofin wrote: > >> In D91567#2400207 , @aeubanks wrote: >> >>

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. >> I'll run this through llvm-compile-time-tracker to see what the compile time >> implications are. > > You mean for the variant where we ran some of the function passes, or you'd > try running all of them? Probably the latter would be quite interesting as a > 'worst

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403173 , @aeubanks wrote: > In D91567#2400699 , @mtrofin wrote: > >> In D91567#2400207 , @aeubanks wrote: >> >>> What about removing the e

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:278-283 -// Test implicit conversion between SVE and GNU vector is invalid when -// __ARM_FEATURE_SVE_BITS != N -#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512 -typedef in

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403216 , @aeubanks wrote: >>> I'll run this through llvm-compile-time-tracker to see what the compile >>> time implications are. >> >> You mean for the variant where we ran some of the function passes, or you'd >> try

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. One thing that would be nice would be to have both inliners in the same CGSCC pass manager to avoid doing SCC construction twice, but that would require some shuffling of module/cgscc passes in ModuleInlinerWrapperPass. Maybe as a future cleanup. Repository: rG LLV

[clang-tools-extra] 130da80 - Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)""

Author: Utkarsh Saxena Date: 2020-11-18T19:09:16+01:00 New Revision: 130da802ff6e59d59ac5afce9e6a4235f3fe4959 URL: https://github.com/llvm/llvm-project/commit/130da802ff6e59d59ac5afce9e6a4235f3fe4959 DIFF: https://github.com/llvm/llvm-project/commit/130da802ff6e59d59ac5afce9e6a4235f3fe4959.diff

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 306143. njames93 added a comment. Added test cases to ensure clang-tidy doesn't crash. Expanded auto out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91485/new/ https://reviews.llvm.org/D91485 Files: clan

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403236 , @aeubanks wrote: > One thing that would be nice would be to have both inliners in the same CGSCC > pass manager to avoid doing SCC construction twice, but that would require > some shuffling of module/cgscc pa

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306146. yonghong-song edited the summary of this revision. yonghong-song added a comment. add fetch_and_{and,or,xor} support force cmpxchg insn return results in r0 like r0 = cmpxchg(addr, r0, new) Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang-tools-extra] 068da2c - [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

Author: Yitzhak Mandelbaum Date: 2020-11-18T18:25:21Z New Revision: 068da2c749a58b46bd59381890a6a137d6e3128e URL: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e DIFF: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e.diff

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG068da2c749a5: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly. (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D91544?vs=305516&id=306151#toc Re

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy added a comment. In D86502#2245734 , @wmi wrote: > In D86502#2245578 , @hoy wrote: > >> In D86502#2245460 , @wmi wrote: >> The early instrumentation also allows the

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306162. zibi marked an inline comment as done. zibi added a comment. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. I moved the logic from `memory_resource.cpp` to `__config` as since I'm not famili

[PATCH] D83693: Port analyzer flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 ___

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); arichardson wr

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/include/clang/AST/StmtDataCollectors.td:67-75 +if (auto *ParamTypeDecl = dyn_cast(TemplParam)) { + const clang::Type *ParamType = ParamTypeDecl->getTypeForDecl(); + if (auto *autoT = ParamType->

[PATCH] D83691: Port Comment option flags to new parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you fix a couple of nits. Comment at: clang/include/clang/Driver/Options.td:405 +// Comment Options + Nit: please end the comment with a

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

rnk added a comment. Zequan, to build clang with PGO, you can follow the steps in Chrome's script to build clang with PGO: https://source.chromium.org/chromium/chromium/src/+/master:tools/clang/scripts/build.py;l=703?q=clang%2Fscripts%2F%20build.py&ss=chromium Regarding -Oz / minsize / SizeLevel

[PATCH] D91565: Guard init_priority attribute within libc++

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/include/experimental/__config:80 +// Detect if the init_priority attribute is supported. +#if (defined(_LIBCPP_COMPILER_GCC) && defined(__A

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306172. yonghong-song edited the summary of this revision. yonghong-song added a comment. add support for a barrier function. The correspond C code is __sync_synchronize(). If we want to have variant like barrier for read/write/rw, etc. we may need to

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91625/new/ https://reviews.llvm.org/D91625 __

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. In D91567#2403252 , @mtrofin wrote: > In D91567#2403236 , @aeubanks wrote: > >> One thing that would be nice would be to have both inliners in the same >> CGSCC pass manager to avoid doing

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT

[clang] c6c8d4a - [modules] Fix crash in call to `FunctionDecl::setPure()`

Author: Andrew Gallagher Date: 2020-11-18T11:55:29-08:00 New Revision: c6c8d4a13ebd5ce1c3c7e8632312ab8c2dc6afa0 URL: https://github.com/llvm/llvm-project/commit/c6c8d4a13ebd5ce1c3c7e8632312ab8c2dc6afa0 DIFF: https://github.com/llvm/llvm-project/commit/c6c8d4a13ebd5ce1c3c7e8632312ab8c2dc6afa0.di

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c8d4a13ebd: [modules] Fix crash in call to `FunctionDecl::setPure()` (authored by andrewjcg, committed by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:968 + } +} + aaron.ballman wrote: > Another test that would be interesting is: > ``` > if (tryToExtinguish(isSet) && isSet) { > if

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

tejohnson added a comment. Thanks for adding the Driver test. I was thinking of something to test the CompilerInvocation changes, similar to your test using opt, that ensures the option has the desired behavior when invoked via clang. Looks like there is an existing test clang/test/Frontend/opt

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 306180. abidh added a comment. Herald added a subscriber: MaskRay. This update contains following changes. 1. Address issue raised by lenary. I have introduced a static function that checks for the presence of gcc toolchain first by --gcc-toolchain argument or

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

sfertile added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask) `CSR_64_

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403544 , @aeubanks wrote: > In D91567#2403252 , @mtrofin wrote: > >> In D91567#2403236 , @aeubanks wrote: >> >>> One thing that would be n

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306183. zibi marked an inline comment as done. zibi added a comment. Moving macro to common place as requested. This makes assumption that MS and Apple restrictions were lifted at some point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask) sfertile

[PATCH] D91565: Guard init_priority attribute within libc++

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:384 +def ExcludeTarget : TargetSpec { + let CustomCode = [{ !Target.getTriple().isOSzOS() }]; This is not a very descriptive name -- if this is only supposed to be used for `in

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComme

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:274 +return canonicalRenameDecl(Function); + return D; +} I think we should call `getCanonicalDecl` before returning the final result (calling it at the beginning doesn't

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 ___ cfe-commits

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne accepted this revision as: libc++. ldionne added a comment. This revision is now accepted and ready to land. In D91311#2400998 , @dblaikie wrote: > A concrete/real-world example might be helpful, if you happen to have one on > hand. See what Rich

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Actually, apologies -- I might have accepted this too quickly. We can stick with this design, but I'd like to understand why `#if _LIBCPP_HAS_NO_PREFERRED_NAME` is necessary in ``,

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4018 + if (Args.hasArg(options::OPT_gdwarf64)) { +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); `if (const Arg *A = Args.getLastArg(options::OPT_gdwarf64)`) ===

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added a comment. > Adding DWARF64 clang flag It is important to mention the exact option name: Add `-gdwarf-64` to enable 64-bit DWARF format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 __

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 306210. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/capturing_i

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. I think this looks good. I must admit I'm a bit worried about any unintended consequences this might have or breakage this might cause in cases where we'd switch from linking against the SDK libc++.dylib to the toolchain one. This would only impact the toolchain release

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

stefanp added a comment. In D91279#2400854 , @stefanp wrote: > In D91279#2390160 , @shchenz wrote: > >> Using dform with offset 0 can save one register r0/X0, this is benefit for >> register allocation? But adding

[clang] 5f2c554 - Fix assert on valid due to incorrect assumption that a field name must

Author: Richard Smith Date: 2020-11-18T14:04:02-08:00 New Revision: 5f2c5541f78750c21004e0172f13db4632966fd3 URL: https://github.com/llvm/llvm-project/commit/5f2c5541f78750c21004e0172f13db4632966fd3 DIFF: https://github.com/llvm/llvm-project/commit/5f2c5541f78750c21004e0172f13db4632966fd3.diff

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

lxfind added a comment. @rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But definitely shout at me if more feedback needs to be addressed. Happy to follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86853/new/ https://

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306223. ayermolo retitled this revision from "Adding DWARF64 clang flag" to "Adding DWARF64 clang flag: -gdwarf64". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 File

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020 +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); +const llvm::Triple &RawTriple = TC.getTriple(); +if (DWARFVersion < 3) MaskRay wrote: > The variable is onl

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

bruno added a comment. I forgot to follow up, but LGTM too. > @rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But > definitely shout at me if more feedback needs to be addressed. Happy to > follow up. FWIW, this has been working on our code base for sometime now. Reposi

[PATCH] D91669: Don’t break before nested block param when prior param is not a block

kastiglione accepted this revision. kastiglione added a comment. The purpose and the tests LGTM! Hopefully someone will weigh in on the implementation in ContinuationIndenter.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91669/new/ https://re

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug informa

[PATCH] D91743: [NPM] Remove -enable-npm-optnone flag

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: llvm-commits, cfe-commits, jfb, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. It has been on by default for a couple months without complaint. Reposit

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { I am wondering what cases are not c

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:783 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = new; + let Inst{7-4} = BPF_CMPXCHG.Value; yonghong-song wrote: > jackmanb wrote: > > If we go down the route of matching

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer abandoned this revision. DaanDeMeyer added a comment. Abandoning as the end result is too slow even when including a limited number of files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 ___

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

zequanwu created this revision. zequanwu added reviewers: EricWF, rnk, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. According to https://eel.is/c++draft/cpp.predefined#2.6, `__STDCPP_THREADS__` is a predefined macro.

[PATCH] D91743: [NPM] Remove -enable-npm-optnone flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67f16e9e91f2: [NPM] Remove -enable-npm-optnone flag (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 67f16e9 - [NPM] Remove -enable-npm-optnone flag

Author: Arthur Eubanks Date: 2020-11-18T15:49:16-08:00 New Revision: 67f16e9e91f2f07cdb9813b60c195f5a1cd1f57d URL: https://github.com/llvm/llvm-project/commit/67f16e9e91f2f07cdb9813b60c195f5a1cd1f57d DIFF: https://github.com/llvm/llvm-project/commit/67f16e9e91f2f07cdb9813b60c195f5a1cd1f57d.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added a comment. In D91311#2403805 , @ldionne wrote: > We can stick with this design, but I'd like to understand why `#if > _LIBCPP_HAS_NO_PREFERRED_NAME` is necessary in ``, and also the CI is > failing on MacOS. You mean the HWAddressSanitizer

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 306256. weiwang added a comment. 1. Add clang test with remarks output. 2. Fix a missing dependency on PSI in legacy pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.o

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2403587 , @tejohnson wrote: > Thanks for adding the Driver test. I was thinking of something to test the > CompilerInvocation changes, similar to your test using opt, that ensures the > option has the desired behavior w

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91296/new/ https://reviews.llvm.org/D91296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91297/new/ https://reviews.llvm.org/D91297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91298: Frontend: Always create a new FileManager in ASTUnit::CodeComplete

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91298/new/ https://reviews.llvm.org/D91298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.org/D90484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90888/new/ https://reviews.llvm.org/D90888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90889/new/ https://reviews.llvm.org/D90889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   >