[PATCH] D90212: [AMDGPU] Add missing support for targets

t-tye created this revision. t-tye added reviewers: kzhuravl, scott.linder, tpr. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, rupprecht, hiraditya, dstuttard, yaxunl, nhaehnle, jvesely, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jhenderson. Herald added p

[clang] c6a05eb - [Syntax] Disallow invalid Node operations

Author: Sam McCall Date: 2020-10-27T08:36:35+01:00 New Revision: c6a05eb62f2ab392eba4e7a056e95c821587ae47 URL: https://github.com/llvm/llvm-project/commit/c6a05eb62f2ab392eba4e7a056e95c821587ae47 DIFF: https://github.com/llvm/llvm-project/commit/c6a05eb62f2ab392eba4e7a056e95c821587ae47.diff LO

[PATCH] D90163: [Syntax] Disallow invalid Node operations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6a05eb62f2a: [Syntax] Disallow invalid Node operations (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90163/new/ https://reviews.ll

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo updated this revision to Diff 300911. Hiralo marked an inline comment as done. Hiralo added a comment. Incorporated review comments and updated patch. (a) renamed var 'ClangTidyConfig' with 'ConfigFile' (b) renamed function 'tryReadConfigFile(AbsoluteFilePath, true);' to 'readConfigFile(Co

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. A few `nits:` and mostly style comments inline: Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h"

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

Hiralo added a comment. In D89936#2353048 , @DmitryPolukhin wrote: > ...I think this diff needs some improvements Thanks @DmitryPolukhin for your valuable comments/feedback. Please review updated patch. > + test for new option. I am planning to add fol

[clang-tools-extra] 2ef2841 - [clangd] Fix proto deps, for real this time.

Author: Sam McCall Date: 2020-10-27T09:15:42+01:00 New Revision: 2ef2841c0d0b49a76ea9026f37207a473d7d1332 URL: https://github.com/llvm/llvm-project/commit/2ef2841c0d0b49a76ea9026f37207a473d7d1332 DIFF: https://github.com/llvm/llvm-project/commit/2ef2841c0d0b49a76ea9026f37207a473d7d1332.diff LO

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

kiranchandramohan added a comment. Updated mlir test also to include this change. https://reviews.llvm.org/rG0fc1aa22ee6ac337a5d51fa5666c9cd61da61b07 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88609/new/ https://reviews.llvm.org/D88609

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. JFYI: using --quiet avoids call to following write calls...so that is useful. write(2, "Suppressed ", 11) = 11 write(2, "10703", 5) = 5 write(2, " warnings (", 11) = 11 write(2, "10703", 5) = 5 write(2, " in non-user code", 17) = 17 write(2, ").\n", 3) = 3 write(2, "Use -he

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

Hiralo added a comment. Another observation w.r.t. stdout... For example, consider following sample program: #include #include using namespace std; static long long A = 0ull; void f(const std::string& a) { std::cout << a << std::endl; } int main() { } When running clang-tidy on this..

[clang] 2c2dc7c - [clang][RecoveryExpr] Add tests for ObjectiveC.

Author: Haojian Wu Date: 2020-10-27T09:42:19+01:00 New Revision: 2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8 URL: https://github.com/llvm/llvm-project/commit/2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8 DIFF: https://github.com/llvm/llvm-project/commit/2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8.diff LO

[PATCH] D90140: [clang][RecoveryExpr] Add tests for ObjectiveC.

hokein added inline comments. Comment at: clang/test/AST/ast-dump-recovery.m:8 +void k(Foo *foo) { + // CHECK: ObjCMessageExpr {{.*}} 'void' contains-errors + // CHECK-CHECK: |-ImplicitCastExpr {{.*}} 'Foo *' sammccall wrote: > this contains the resolve

[PATCH] D90140: [clang][RecoveryExpr] Add tests for ObjectiveC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c2dc7c392a3: [clang][RecoveryExpr] Add tests for ObjectiveC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2618247 - Correct examples after d3205bbca3e0002d76282878986993e7e7994779

Author: Tyker Date: 2020-10-27T09:49:33+01:00 New Revision: 2618247c61c25cf9bd4cb315ee51cff2b3ab3add URL: https://github.com/llvm/llvm-project/commit/2618247c61c25cf9bd4cb315ee51cff2b3ab3add DIFF: https://github.com/llvm/llvm-project/commit/2618247c61c25cf9bd4cb315ee51cff2b3ab3add.diff LOG: Co

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf created this revision. qiucf added reviewers: echristo, stefanp, nemanjai, jsji, steven.zhang, PowerPC. Herald added subscribers: cfe-commits, dexonsmith, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. As Power9 introduced hardware support for IEEE

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added a comment. In D88645#2353152 , @thakis wrote: > Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt > > Please take a look, and revert for now if it takes a while to fix. this is fixed by 4afa077899b

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added projects: clang, LLVM. sammccall requested review of this revision. Repository: rG LLVM Github Monorepo https://review

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson added a comment. Herald added a subscriber: dexonsmith. ping @arsenm . I'd really like to land D70947 so that I can upstream further changes and that review is blocked on this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D89851: [clangd] Separate final_result into a different message

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/Index.proto:15 +message FinalResult { optional bool has_more = 1; } + this deserves a comment:

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kadircet added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:117 + # Ensure dependency headers are generated before dependent protos are built. + # FIXME: CMake docs suggest OBJECT_DEPENDS isn't needed, but I can't get the + #recommended add_dependenci

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall updated this revision to Diff 300930. sammccall marked an inline comment as done. sammccall added a comment. Move FIXME to more specific place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90215/new/ https://reviews.llvm.org/D90215 Files

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 300931. hokein marked an inline comment as done. hokein added a comment. Herald added a subscriber: dexonsmith. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://revie

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx' must be a constant integer}} - vec_ctf(vui, index); //expected-error {{argument to '

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Your fix looks good for clang-format. I'm also not familiar with `DiagnosticsEngine`. It would be nice to follow-up with folks on that on either removing the defaulted ctor para

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG443ab4d2e012: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 443ab4d - [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

Author: Mikhail Maltsev Date: 2020-10-27T10:43:39Z New Revision: 443ab4d2e01246bf93cd410db945dc9ab6adf1b3 URL: https://github.com/llvm/llvm-project/commit/443ab4d2e01246bf93cd410db945dc9ab6adf1b3 DIFF: https://github.com/llvm/llvm-project/commit/443ab4d2e01246bf93cd410db945dc9ab6adf1b3.diff LO

[PATCH] D89851: [clangd] Separate final_result into a different message

kbobyrev updated this revision to Diff 300936. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang

[clang-tools-extra] d26dd74 - [clangd] Separate final_result into a different message

Author: Kirill Bobyrev Date: 2020-10-27T11:46:16+01:00 New Revision: d26dd743084a886382204ede5eeed146cd29fcd6 URL: https://github.com/llvm/llvm-project/commit/d26dd743084a886382204ede5eeed146cd29fcd6 DIFF: https://github.com/llvm/llvm-project/commit/d26dd743084a886382204ede5eeed146cd29fcd6.diff

[PATCH] D89851: [clangd] Separate final_result into a different message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd26dd743084a: [clangd] Separate final_result into a different message (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. @Hiralo, it looks like you uploaded wrong diff because your previous revision is shown as "base" version. Base revision should be clang-tidy sources without your changes. Please add Lit test for the new option, see https://llvm.org/docs/TestingGuide.html for mor

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein added a subscriber: hubert.reinterpretcast. hokein added a comment. @hubert.reinterpretcast, similar to D78350 , could you help to test this patch with your downstream clang? this patch is based on 2c2dc7c392a3f28d4dbec3018e3137d5d4f8c6c8

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky created this revision. aronsky added reviewers: aaron.ballman, steveire. aronsky created this object with visibility "All Users". Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. aronsky requested review of this revision. AST dumps in JSON format were missing a

[PATCH] D90221: Include attribute details when dumping AST in JSON

lebedev.ri added a comment. Are there tests missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90221/new/ https://reviews.llvm.org/D90221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D90221: Include attribute details when dumping AST in JSON

aronsky added a comment. In D90221#2356062 , @lebedev.ri wrote: > Are there tests missing? Quite possible. I followed the trail of the existing functions to figure out the difference between JSON and textual dumping, and tried replicating everything in

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:330 if (!Config.empty()) { if (llvm::ErrorOr ParsedConfig = parseConfiguration(Config)) { DmitryPolukhin wrote: > I think you can make this option m

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:330 if (!Config.empty()) { if (llvm::ErrorOr ParsedConfig = parseConfiguration(Config)) { Hiralo wrote: > DmitryPolukhin wrote: > > I think you can

[clang] 8503253 - [clang-format] Fix misformatted macro definitions after D86959

Author: Alex Richardson Date: 2020-10-27T12:16:46Z New Revision: 850325348ae82cd5e26ea9edfd04219d0fbe7828 URL: https://github.com/llvm/llvm-project/commit/850325348ae82cd5e26ea9edfd04219d0fbe7828 DIFF: https://github.com/llvm/llvm-project/commit/850325348ae82cd5e26ea9edfd04219d0fbe7828.diff LO

[PATCH] D88956: [clang-format] Fix misformatted macro definitions after D86959

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG850325348ae8: [clang-format] Fix misformatted macro definitions after D86959 (authored by arichardson). Changed prior to commit: https://reviews.l

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added a comment. In D88913#2353379 , @sepavloff wrote: > Generally the patch looks good. But the need to expect incorrect values in > tests is a concern. Maybe this is a consequence of storing exception behavior > in a separate field of CGFPOptionsRA

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h On line 89 the argument is called `DEPENDS` (also in the com

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:330 if (!Config.empty()) { if (llvm::ErrorOr ParsedConfig = parseConfiguration(Config)) { Hiralo wrote: > Hiralo wrote: > > DmitryPolukhin wrote: >

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a subscriber: klimek. aaron.ballman added a comment. In D89743#2348487 , @sammccall wrote: > In D89743#2342229 , @aaron.ballman > wrote: > >> My preference is to add support for `hasName()` as t

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

martong added a comment. > Now I'm going to make unittests for SValBuilder::evalCast. Let me ask you to > offer me some examples of casts to check. As many cases we can collect as > robust the test would be. E.g. This is not going to be easy. I guess we should cover both implicit and explicit

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman added a comment. In D90042#2350035 , @flx wrote: > I should note that I was only able to reproduce the false positive with the > actual implementation std::function and not our fake version here. Any reason not to lift enough of the actual

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 300965. trixirt added a comment. precheckin lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D83088: Introduce CfgTraits abstraction

rengolin added a comment. I have read all of the comments in this review and have looked at all the other pending reviews because of this and I still see strong disagreement on the design and implementation. Unfortunately, I can't contribute with the technical discussion because there's a lot

[clang] e562a40 - Fix for PR47544. Clang is crashing after generating the right

Author: Zahira Ammarguellat Date: 2020-10-27T05:57:39-07:00 New Revision: e562a40871da14cef6685efef09760bca2718269 URL: https://github.com/llvm/llvm-project/commit/e562a40871da14cef6685efef09760bca2718269 DIFF: https://github.com/llvm/llvm-project/commit/e562a40871da14cef6685efef09760bca2718269

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. The 10,000 problems are for all the extra semicolon problems. Those after switch are a small subset, chosen because is ok to automagically fix them. The checker is in the linuxkernel/ because it is being used to fix the linux kernel now. And to enforce it stays fixed.

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked 9 inline comments as done. DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames =

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:482 Styles.emplace_back(IdentifierNamingCheck::NamingStyle{ - std::move(CaseOptional), std::move(Prefix), std::move(Postfix)}); -else +

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

steakhal added a comment. In D90157#2356170 , @martong wrote: >> Now I'm going to make unittests for SValBuilder::evalCast. Let me ask you to >> offer me some examples of casts to check. As many cases we can collect as >> robust the test would be. E.g. >

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 300972. DiggerLin marked 3 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/

[clang] b19473c - [clang] RewriteObjCClassMetaData - remove superfluous null pointer check. NFCI.

Author: Simon Pilgrim Date: 2020-10-27T13:14:55Z New Revision: b19473cf590eca13d23a20191c820d0f9d835beb URL: https://github.com/llvm/llvm-project/commit/b19473cf590eca13d23a20191c820d0f9d835beb DIFF: https://github.com/llvm/llvm-project/commit/b19473cf590eca13d23a20191c820d0f9d835beb.diff LOG:

[clang] 2bc2e2e - [MallocChecker] Remove duplicate QCoreApplication::postEvent check. NFCI.

Author: Simon Pilgrim Date: 2020-10-27T13:14:54Z New Revision: 2bc2e2e9fe25c5568cfb8681e441fcc6a194daa4 URL: https://github.com/llvm/llvm-project/commit/2bc2e2e9fe25c5568cfb8681e441fcc6a194daa4 DIFF: https://github.com/llvm/llvm-project/commit/2bc2e2e9fe25c5568cfb8681e441fcc6a194daa4.diff LOG:

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2356180 , @aaron.ballman wrote: > In D90042#2350035 , @flx wrote: > >> I should note that I was only able to reproduce the false positive with the >> actual implementation std::funct

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 300975. jansvoboda11 added a comment. Formalize the "implied by" relationship with `DefaultAnyOf<[...]>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Basic/LangOptions.d

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij abandoned this revision. stuij added a comment. Abandoned because lack of reaction for such an unimportant issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88566/new/ https://reviews.llvm.org/D88566 __

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a subscriber: Anastasia. jansvoboda11 added a comment. Using the records with `DefaultAnyOf<[...]>` to catch errors seems to work well, thanks for the suggestion. (I was initially thinking about using the keypaths to avoid errors and reorder the options in the TableGen backen

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 300979. jansvoboda11 added a comment. Fix typo & whitespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

Eugene.Zelenko added a comment. I think CLang should do this job, since it has two related warnings already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 ___ c

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

aaron.ballman added a comment. In D90109#2352180 , @dsanders11 wrote: > Added a few inline comments for clarification. > > **Note**: I was not able to get a debug build and unit tests working on my > Windows set up, so this has only been tested manually.

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

sammccall added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h kbobyrev wrote: > On line 89 the argument is called `DEPEND

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

aaron.ballman added a comment. In D90180#2354931 , @njames93 wrote: > Is this not already handled by `-Wextra-semi`. If it isn't I feel like it > should be handled there rather than in clang-tidy Strong +1 -- this is already handled by `-Wextra-semi-stmt

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo updated this revision to Diff 300980. Hiralo added a comment. With updated patch now changes are only in ClangTidyMain.cpp. Thanks to @DmitryPolukhin for valuable suggestion :) Added '--config-file' option to specify custom config file. ClangTidyMain.cpp reads ConfigFile into string and th

[PATCH] D88609: Use uint64_t for branch weights instead of uint32_t

kiranchandramohan added a subscriber: thakis. kiranchandramohan added a comment. @thakis Can you revert the testcase fix in MLIR also which was necessary after this patch? https://reviews.llvm.org/rG0fc1aa22ee6ac337a5d51fa5666c9cd61da61b07 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 75a1790 - Fix use-after-scope introduced in 850325348ae82cd5e26ea9edfd04219d0fbe7828

Author: Alex Richardson Date: 2020-10-27T14:26:23Z New Revision: 75a1790f4bf052b0a615ed0270a7b4b1c4c88818 URL: https://github.com/llvm/llvm-project/commit/75a1790f4bf052b0a615ed0270a7b4b1c4c88818 DIFF: https://github.com/llvm/llvm-project/commit/75a1790f4bf052b0a615ed0270a7b4b1c4c88818.diff LO

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added a comment. In D54943#2352196 , @0x8000- wrote: > Would it be possible to split this review further, into "checking" and > "fixing" portions? I understand that fix-it portion is more difficult, and > sometimes results in multiple '

[PATCH] D90232: Respond to review items and renew D14484 for merge possiblity

catskul created this revision. catskul added a reviewer: clang-format. catskul added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. I'm trying to get D14484 past the finish

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao updated this revision to Diff 300985. hliao added a comment. Test case is enhanced to check that no kernel argument type is coerced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/

[PATCH] D90110: [clang-tidy] Use --use-color in run-clang-tidy.py

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This change LGTM, but please wait a few days in case @alexfh (or others) have concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. In D89980#2348339 , @tra wrote: > Are there any tests to illustrate what this change does to IR or generated > code? the existing test `kernel-args.cu` is enhanced by adding a pointer in that aggregate kernel argument. Previously,

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao updated this revision to Diff 300989. hliao added a comment. Revise the comment and point the safety issue by coercing the kernel argument from a generic pointer to a global one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https:

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm requested changes to this revision. arsenm added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:30 -} - -// HOST: define void @_Z22__device_stub__kernel2Ri(i32* nonnull align 4 dereferen

[PATCH] D87030: Adapt CastExpr::getSubExprAsWritten to ConstantExpr

sberg added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87030/new/ https://reviews.llvm.org/D87030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89481: [scan-build] Fix clang++ pathname again

sberg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89481/new/ https://reviews.llvm.org/D89481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:30 -} - -// HOST: define void @_Z22__device_stub__kernel2Ri(i32* nonnull align 4 dereferenceable(4) %x) arsenm wrote: > This test should not be deleted. I want to s

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:42 + +llvm::Optional toFoldingRange(LocInfo Begin, LocInfo End, +

[PATCH] D90238: Update to D31635

catskul created this revision. catskul added a reviewer: clang-format. catskul added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. catskul requested review of this revision. I'm trying to get D31635 past the finish

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1861 + + do [[unlikely]] { // The loop will always iterate once +... // The likelihood attribute affects the likelihood of the Mordante wrote: > aaron.ball

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Rationale: Children of a syntax tree had forward links only, because there was no need for reverse links. This need appeared when we started mutat

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

eduucaldas added a reviewer: gribozavr2. eduucaldas added a subscriber: sammccall. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:189 /// EXPECTS: Child->Role != Detached void prependChildLowLevel(Node *Child); friend class TreeBu

[clang] 5984097 - [AMDGPU] Add missing support for targets

Author: Tony Date: 2020-10-27T15:36:31Z New Revision: 5984097823891fc90438a3b859c513a0b63331cd URL: https://github.com/llvm/llvm-project/commit/5984097823891fc90438a3b859c513a0b63331cd DIFF: https://github.com/llvm/llvm-project/commit/5984097823891fc90438a3b859c513a0b63331cd.diff LOG: [AMDGPU]

[PATCH] D90212: [AMDGPU] Add missing support for targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG598409782389: [AMDGPU] Add missing support for targets (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. Yes, it is what I meant as a simpler solution. But please add Lit test even for such trivial option. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:337 + +Config.assign((*Text)->getBuffer()); + } I suggest

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 301008. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 301009. kbobyrev added a comment. Resolve merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp cla

[PATCH] D82035: [PowerPC] Add Sema checks for MMA types

bsaleil updated this revision to Diff 301010. bsaleil added reviewers: nemanjai, saghir, lei, rsmith. bsaleil added a comment. Herald added a subscriber: dexonsmith. Rebasing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82035/new/ https://re

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

sfertile added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao updated this revision to Diff 301012. hliao added a comment. Add `amdgpu-kernel-arg-pointer-type.cu` back and revise its checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 Files: clang/lib/Code

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad6bbacf091: [clangd] Start using SyntaxTrees for folding ranges feature (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 5ad6bba - [clangd] Start using SyntaxTrees for folding ranges feature

Author: Kirill Bobyrev Date: 2020-10-27T16:47:35+01:00 New Revision: 5ad6bbacf091c90d47730bf284f4893eb1afb1ee URL: https://github.com/llvm/llvm-project/commit/5ad6bbacf091c90d47730bf284f4893eb1afb1ee DIFF: https://github.com/llvm/llvm-project/commit/5ad6bbacf091c90d47730bf284f4893eb1afb1ee.diff

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames =

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

dmajor added a comment. After this commit our bots have a failure on the wasm target, could you please take a look? test.c: double a, b; c() { #pragma STDC FENV_ACCESS ON b == a; } Run `clang -cc1 -triple wasm32-unknown-wasi -emit-obj test.c` (clang needs to be build with `-DLLVM_

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas marked 8 inline comments as done. eduucaldas added a comment. I left some points unanswered, I'll answer them tomorrow :) Comment at: clang/include/clang/Tooling/Syntax/Tree.h:231 + /// `ElementAndDelimiter` acts as one. + template class ElementAndDelimiterIterato

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 301020. DiggerLin marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/includ

[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:189 /// EXPECTS: Child->Role != Detached void prependChildLowLevel(Node *Child); friend class TreeBuilder; eduucaldas wrote: > Should we provide an `appendChildLowLev

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas updated this revision to Diff 301024. eduucaldas marked 6 inline comments as done. eduucaldas added a comment. - `const` on `getElement` and similar. - `NotSentinel` -> `Element` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90161/new/ h

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I like how this is coming together. I have a few comments inline. Also, I wonder if there should be a test for the new OptParser behaviour in `llvm/unittests/Option/`. ===

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 -

RE: [PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

Thank you. I don't know the solution but I can remove the assert and create a bug report to have it resolved. > -Original Message- > From: dmajor via Phabricator > Sent: Tuesday, October 27, 2020 11:58 AM > To: Blower, Melanie I ; sepavl...@gmail.com; > rjmcc...@gmail.com; rich...@metaf

  1   2   3   >