[clang] f81f09b - [c++20] For P0732R2: Support string literal operator templates.

Author: Richard Smith Date: 2020-10-25T00:34:15-07:00 New Revision: f81f09ba8950a199af88e5a622155fb9801b11b7 URL: https://github.com/llvm/llvm-project/commit/f81f09ba8950a199af88e5a622155fb9801b11b7 DIFF: https://github.com/llvm/llvm-project/commit/f81f09ba8950a199af88e5a622155fb9801b11b7.diff

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev updated this revision to Diff 300528. kbobyrev added a comment. Rebase on top of master, use proto2 syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang-tools-extra/clangd/index/r

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes: https://github.com/clangd/c

[PATCH] D80499: Remove obsolete ignore*() matcher uses

steveire added a subscriber: alexfh. steveire added a comment. @alexfh This change is based on the behavior of AST Matchers being changed to ignore invisible/implicit AST nodes by default. As the default was not changed in the end, this patch would need to be updated to add `traverse(TK_IgnoreU

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/lib/Analysis/ThreadSafety.cpp:1275 +const ValueDecl *VD = LP->clangDecl(); +return VD->isDefinedOutsideFunctionOrMethod(); + } Hmm, I've not seen that function

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. Please can you point me where you've added the negative test for the false-positive issue that caused the revert last time? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 300535. kbobyrev added a comment. Use u8 string literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116 Files: clang-tools-extra/clangd/CodeComplete.h clang-tool

[clang] 2e204e2 - [clang] Enable support for #pragma STDC FENV_ACCESS

Author: Melanie Blower Date: 2020-10-25T06:46:25-07:00 New Revision: 2e204e23911b1f8bd1463535da40c6e48747a138 URL: https://github.com/llvm/llvm-project/commit/2e204e23911b1f8bd1463535da40c6e48747a138 DIFF: https://github.com/llvm/llvm-project/commit/2e204e23911b1f8bd1463535da40c6e48747a138.diff

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e204e23911b: [clang] Enable support for #pragma STDC FENV_ACCESS (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 576d436 - Correct LIT test failure detected on buildbot after mibintc committed rG2e204e23911b: [clang] Enable support for #pragma STDC FENV_ACCESS D87528

Author: Melanie Blower Date: 2020-10-25T08:10:34-07:00 New Revision: 576d436c828f84f18277e4675e6e5337d2b77fde URL: https://github.com/llvm/llvm-project/commit/576d436c828f84f18277e4675e6e5337d2b77fde DIFF: https://github.com/llvm/llvm-project/commit/576d436c828f84f18277e4675e6e5337d2b77fde.diff

[PATCH] D90121: Add a consumer to diagnostics engine

dmikis created this revision. dmikis added reviewers: djasper, bkramer, krasimir. dmikis added a project: clang-format. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. dmikis requested review of this revision. Otherwise problems like trying to format readonly file in-

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. aaronpuchert requested review of this revision. When an overloaded member function has a ref-qualifier, like: class X { voi

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. 4 tests seem to fail still, otherwise this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:4927 // Note that the function case is not possible here. -if (DeclType->isRValueReferenceType() && LValRefType) { - // FIXME: This is the wrong BadConversionSequence. The problem is bin

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1275 +const ValueDecl *VD = LP->clangDecl(); +return VD->isDefinedOutsideFunctionOrMethod(); + } aaron.ballman wrote: > Hmm, I've not seen that function used a whole lot

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

ArcsinX added a comment. I have face this problem long time ago. This happens only: - on non-English Windows (and could be fixed via system settings: Control Panel -> Clock,Language,and Region -> Region and Language -> Administrative ->Language for non-Unicode programs -> Change system locale -

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:87-89 + void test4() { +MutexLock lock(&mu); // expected-warning {{acquiring mutex 'mu' requires negative capability '!mu'}} + } aaronpuchert wrote: > @lebedev

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:60 +// Make sure all exiting blocks produce the same incoming value for the +// block. If there ar

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:87-89 + void test4() { +MutexLock lock(&mu); // expected-warning {{acquiring mutex 'mu' requires negative capability '!mu'}} + } lebedev.ri wrote: > aaronpuc

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thanks. Note that i didn't check that this doesn't cause any new false-positives Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:87-89 + void tes

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kadircet added a comment. I think we should update cmake rules to explicitly tell the compilers that the source code language is utf8. https://docs.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=vs-2019 seems to be the way for MSVC. I am not

[clang] 5250a03 - Thread safety analysis: Consider global variables in scope

Author: Aaron Puchert Date: 2020-10-25T19:32:26+01:00 New Revision: 5250a03a9959c2701a8338fe1a1ffa8bd93d6173 URL: https://github.com/llvm/llvm-project/commit/5250a03a9959c2701a8338fe1a1ffa8bd93d6173 DIFF: https://github.com/llvm/llvm-project/commit/5250a03a9959c2701a8338fe1a1ffa8bd93d6173.diff

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5250a03a9959: Thread safety analysis: Consider global variables in scope (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge created this revision. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added projects: clang, LLVM. nridge retitled this revision from "[clangd] Implement call hierarchy (incoming callers)" to "[clangd] Implement call hierarchy (incoming c

[clang] b296c64 - Thread safety analysis: Nullability improvements in TIL, NFCI

Author: Aaron Puchert Date: 2020-10-25T19:37:16+01:00 New Revision: b296c64e64a0bc600538c8bc67d4ccc2564e3c72 URL: https://github.com/llvm/llvm-project/commit/b296c64e64a0bc600538c8bc67d4ccc2564e3c72 DIFF: https://github.com/llvm/llvm-project/commit/b296c64e64a0bc600538c8bc67d4ccc2564e3c72.diff

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge added a comment. Note, testing this with vscode requires this vscode-clangd patch applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 _

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

steveire updated this revision to Diff 300550. steveire added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82278/new/ https://reviews.llvm.org/D82278 Files: clang-tools-extra/clang-tidy/bugprone/ThrowKeywordMissingCheck.cpp

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp:80 auto Matches = - match(expr(hasDescendant(typeLoc().bind("t"))), *E, *Result.Context); + match(traverse(TK_AsIs, expr(h

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

njames93 added a comment. Isn't `llvm::errs()` buffered, negating most of the benefit here. Also using std::string here is bad, its potentially going to allocate and reallocate memory each time it grows. It would be better off using an `llvm::SmallString` and looking at what could potentially be

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 300555. aeubanks added a comment. move map into PassInstrumentationCallbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/PassInstrume

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

danielmartin added a comment. Using explicit UTF-8 string literals is a possible solution, but it makes the code a bit less readable. Another possible solution is to save the source file using UTF-8 with BOM, but this is confusing outside the Microsoft world (and it's very easy to remove the BO

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

njames93 created this revision. njames93 added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 requested review of this revision. Rearrange the fields to reduce the size of the classes Repository: rG LLVM Github Monorepo https://reviews.

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 300559. atmnpatel added a comment. Added word back in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/T

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. Hi, @echristo. What's your opinion here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D90010: clang-tidy: Reduce number of stderr write calls

dblaikie added a comment. In D90010#2352556 , @njames93 wrote: > Isn't `llvm::errs()` buffered, negating most of the benefit here. +1 to this (the patch description doesn't explain any specific motivation either - whether it's performance (runtime? memor

[clang] 180548c - [X86] VEX/EVEX prefix doesn't work for inline assembly.

Author: Liu, Chen3 Date: 2020-10-26T08:37:45+08:00 New Revision: 180548c5c7848f82ceac5d6a3528a8cb14c20fed URL: https://github.com/llvm/llvm-project/commit/180548c5c7848f82ceac5d6a3528a8cb14c20fed DIFF: https://github.com/llvm/llvm-project/commit/180548c5c7848f82ceac5d6a3528a8cb14c20fed.diff LO

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG180548c5c784: [X86] VEX/EVEX prefix doesn't work for inline assembly. (authored by LiuChen3). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90129: Source location for -Wignored-qualifiers on lambda trailing return type

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert requested review of this revision. We don't have a source location for trailing return types at the moment, and the current f

[PATCH] D90129: Source location for -Wignored-qualifiers on lambda trailing return type

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:3092-3094 +SourceLocation Loc = D.getIdentifierLoc(); +if (Loc.isInvalid()) + Loc = FTI.getRParenLoc(); I'm open to always using the `RParenLoc`. Repository: rG LLVM Gith

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 300575. aeubanks added a comment. rebase add assert for O0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Code

[clang-tools-extra] 15f6bad - [clangd] Add dependency on remote index service proto

Author: Kirill Bobyrev Date: 2020-10-26T07:08:49+01:00 New Revision: 15f6bad6d74a993e366c8fc93a9c91f213ac6bc3 URL: https://github.com/llvm/llvm-project/commit/15f6bad6d74a993e366c8fc93a9c91f213ac6bc3 DIFF: https://github.com/llvm/llvm-project/commit/15f6bad6d74a993e366c8fc93a9c91f213ac6bc3.diff

[PATCH] D90133: clang-format: Allow fallback-style to take formatting arguments

Chizi123 created this revision. Chizi123 added reviewers: llvm-commits, cfe-commits, djasper, rsmith, klimek. Herald added a project: clang. Chizi123 requested review of this revision. Currently, -style is capable of accepting configuration options in its argument, while -fallback-style must be a