[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

jyknight added a comment. In D71726#2207700 , @yaxunl wrote: > clang does not always emit atomic instructions for atomic builtins. Clang may > emit lib calls for atomic builtins. Basically clang checks target info about > max atomic inline width and if t

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

iajbar added a comment. Clang crashes when calling getLLVMLinkageVarDefinition() in EmitAliasDefinition() when compiling this testcase: enum a_type { a , b, c}; typedef enum a_type b_type; void foo(b_type x, enum a_type y){} void bar(b_type x, enum b_type y) __attribute__ ((alias ("foo"))); Decl

[clang] 05bef88 - [AIX] Let alloca return 16 bytes alignment

Author: Xiangling Liao Date: 2020-10-23T14:41:32-04:00 New Revision: 05bef88eb3ecb8519a871ca9aa53caeca5add555 URL: https://github.com/llvm/llvm-project/commit/05bef88eb3ecb8519a871ca9aa53caeca5add555 DIFF: https://github.com/llvm/llvm-project/commit/05bef88eb3ecb8519a871ca9aa53caeca5add555.diff

[PATCH] D89910: [AIX] Let alloca return 16 bytes alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89910/new/ https://reviews

[clang] b7926ce - [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

Author: Nick Desaulniers Date: 2020-10-23T11:55:39-07:00 New Revision: b7926ce6d7a83cdf70c68d82bc3389c04009b841 URL: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841 DIFF: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841.di

[PATCH] D89922: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf52a85ddc9b: SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7926ce6d7a8: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch (authored by nickdesaulniers). Repository: rG LLVM Github Mono

[clang] cf52a85 - SourceManager: Simplify by inlining what remains of ComputeLineNumbers, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T14:56:41-04:00 New Revision: cf52a85ddc9be165daca3d32521747c898f4ffd1 URL: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4ffd1 DIFF: https://github.com/llvm/llvm-project/commit/cf52a85ddc9be165daca3d32521747c898f4

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300371. tianshilei1992 added a comment. Removed useless code and fixed some cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: clang/lib/CodeGen/CGSt

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

rnk added a comment. It seems like there are related test failures according to the Phabricator/Jenkins automation. Is that a true positive? Please confirm either way before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https:

[PATCH] D90067: SourceManager: Return non-const references in getOrCreateContentCache and related, NFC

dexonsmith created this revision. dexonsmith added a reviewer: JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Update a few APIs to return non-const references instead of pointers, and remove associated `const_cast`s and non-null assertions. https

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith updated this revision to Diff 300377. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89580, which implements @JDevlieghere's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89580/new/ https://reviews.llvm.org/D89580 Files: clang/include/

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300380. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes added a comment. In D89608#2336596 , @gribozavr2 wrote: > Any chance of adding a test? Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 __

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added a comment. > Yes, there are no generically available libcalls for atomic float math -- but > that's okay -- let LLVM handle transform into a cmpxchg loop when required. I suspect Yaxun's target cannot provide libcalls at all, which is why he wants to diagnose up-front. But I agr

[PATCH] D90063: [AIX] Also error on -G for link-only step

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-err-options.c:14-15 + // RUN: %clang -target powerpc64-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \ // RUN: FileCheck --check-prefix=CHECK64 %s +// RUN: %clang -target powerpc64-ibm-aix-xcof

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

DiggerLin added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

DiggerLin updated this revision to Diff 300383. DiggerLin added a comment. Herald added a subscriber: dexonsmith. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop ---

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

nickdesaulniers created this revision. nickdesaulniers added reviewers: aaron.ballman, iajbar. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Via bugreport: https://reviews.llvm.org/D66492#2350947 Repository: rG LLVM Gi

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L updated this revision to Diff 300391. Xiangling_L added a comment. Fixed the duplication in the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90063/new/ https://reviews.llvm.org/D90063 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp

[clang] 2b7dfdd - Fix typo in diagnostic name.

Author: Richard Smith Date: 2020-10-23T13:21:21-07:00 New Revision: 2b7dfdd319c0e6e3a8934bcf4019f402d63f7539 URL: https://github.com/llvm/llvm-project/commit/2b7dfdd319c0e6e3a8934bcf4019f402d63f7539 DIFF: https://github.com/llvm/llvm-project/commit/2b7dfdd319c0e6e3a8934bcf4019f402d63f7539.diff

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4643 + D->getType().isConstQualified()); +else if (isa(GD.getDecl())) + LT = getFunctionLinkage(GD); I'd suggest making this just 'els

[PATCH] D83088: Introduce CfgTraits abstraction

mehdi_amini added a comment. In D83088#2350287 , @nhaehnle wrote: > Hi Mehdi, this is not an appropriate place for this discussion. Yes, we have > a general rule that patches can be reverted if they're obviously broken (e.g. > build bot problems) or clea

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane updated this revision to Diff 300396. erichkeane added a comment. Alright, I have the multi-emit dealt with, and the problems that come with that solved. This doesn't do the MSVC-emit-for-all-CCs thing, but I intend to do that in a separate patch with the same infrastructure. CHANG

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes updated this revision to Diff 300402. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 Files: clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp clang-tools-extra/unittests/clang-tidy/Inc

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

bsaleil updated this revision to Diff 300408. bsaleil added a comment. Herald added a subscriber: dexonsmith. Rebasing the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81508/new/ https://reviews.llvm.org/D81508 Files: clang/include/clang/

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 300410. leonardchan retitled this revision from "[clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation" to "[clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs". leonardchan edited the s

[clang] cb9b984 - PR47954 / DR2126: permit temporary objects that are lifetime-extended by

Author: Richard Smith Date: 2020-10-23T14:29:18-07:00 New Revision: cb9b9842d31d6082c6a2259a64eb5d47bd680d32 URL: https://github.com/llvm/llvm-project/commit/cb9b9842d31d6082c6a2259a64eb5d47bd680d32 DIFF: https://github.com/llvm/llvm-project/commit/cb9b9842d31d6082c6a2259a64eb5d47bd680d32.diff

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e1a56de153: [CodeGen] Emit destructor calls to destruct non-trivial C struct (authored by ahatanak, committed by --local ).

[clang] 71e1a56 - [CodeGen] Emit destructor calls to destruct non-trivial C struct

Author: Akira Hatanaka Date: 2020-10-23T14:46:17-07:00 New Revision: 71e1a56de153536b9ff655fe740ccbf3f6b1faf0 URL: https://github.com/llvm/llvm-project/commit/71e1a56de153536b9ff655fe740ccbf3f6b1faf0 DIFF: https://github.com/llvm/llvm-project/commit/71e1a56de153536b9ff655fe740ccbf3f6b1faf0.diff

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 300421. DiggerLin added a comment. delete asm test case from clang/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith created this revision. dexonsmith added reviewers: dblaikie, aprantl. Herald added a reviewer: bollu. Herald added subscribers: ributzka, hiraditya, kristof.beyls. Herald added a project: LLVM. dexonsmith requested review of this revision. `TempMDNode` includes a bunch of machinery for

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith added a comment. https://github.com/llvm/llvm-project/blob/master/llvm/lib/IR/Metadata.cpp#L716 is where the auto-detection of self-references is: // Drop uniquing for self-reference cycles and deleted constants. if (New == this || (!New && Old && isa(Old))) { if (!isResolved(

[PATCH] D90079: CGLoopInfo: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

dexonsmith added a comment. BTW, this is a long-delayed follow-up to 5e5b85098dbeaea2cfa5d01695b5d2982634d7dd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90079/new/ https://reviews.llvm.org/D90079 ___ cfe-commits mailing list cfe-commits@

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang marked an inline comment as done. akhuang added a comment. Whoops, forgot to check the tests. Apparently `mapEncodedInteger` asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] ccca93b - Don't allow structured binding declarations to decompose a

Author: Richard Smith Date: 2020-10-23T16:28:25-07:00 New Revision: ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1 URL: https://github.com/llvm/llvm-project/commit/ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1 DIFF: https://github.com/llvm/llvm-project/commit/ccca93b5a2cb284dcdfecd34db1ca14632d6a1c1.diff

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File) // FIXME: Use correctly named FileEntryRef. +Delegate->FileSkipp

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 300438. akhuang added a comment. Fix test failures; remove assert for signed APSInts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org/D89072 Files: clang/lib/CodeGen/CGDebug

[PATCH] D89844: [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300443. tianshilei1992 added a comment. Fixed the issue using a way that no need to change test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: cl

[PATCH] D89521: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG81ac81f8644a: FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 81ac81f - FileManager: Reorder declarations of FileEntry and FileEntryRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T20:47:15-04:00 New Revision: 81ac81f8644a7c6ed19bea95385794f7870d0fda URL: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d0fda DIFF: https://github.com/llvm/llvm-project/commit/81ac81f8644a7c6ed19bea95385794f7870d

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith added a comment. Thanks for the review! @JDevlieghere, let me know if the updated patch looks good to you too (also the prep commit). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89580/new/ https://reviews.llvm.org/D89580 ___ cfe

[clang-tools-extra] 434f377 - clangd: Stop calling FileEntryRef::FileEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-10-23T21:28:09-04:00 New Revision: 434f3774f629f5896614e9efb4eda82d813402ed URL: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d813402ed DIFF: https://github.com/llvm/llvm-project/commit/434f3774f629f5896614e9efb4eda82d8134

[PATCH] D89514: clangd: Stop calling FileEntryRef::FileEntryRef

dexonsmith marked an inline comment as done. dexonsmith added a comment. Committed in 434f3774f629f5896614e9efb4eda82d813402ed . Comment at: clang-tools-extra/clangd/ParsedAST.cpp:222 if (File)

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. I missed adding to llvm/lib/Bitcode/Reader/BitcodeReader.cpp, so LTO is broken with this fn attribute...todo...fix diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index f8069b93103f..a99d6baa8d9d 100644 --

[clang] 74910cb - HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T22:10:50-04:00 New Revision: 74910cbbd8d1df824ab1d5e742c50641d0fee907 URL: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fee907 DIFF: https://github.com/llvm/llvm-project/commit/74910cbbd8d1df824ab1d5e742c50641d0fe

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 updated this revision to Diff 300451. tianshilei1992 added a comment. Reverted changes for target data. It will be in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844 Files: c

<    1   2