[PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

dexonsmith abandoned this revision. dexonsmith added subscribers: ldionne, EricWF. dexonsmith added a comment. Herald added a subscriber: ributzka. In D17053#632700 , @EricWF wrote: > Maybe if we want to improve the failure mode we can add a > `_LIBCPP_ASS

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315378 , @ye-luo wrote: > FindCUDA has been deprecated. > Please explore the following feature without directly calling FindCUDA. > https://gitlab.kitware.com/cmake/cmake/-/merge_requests/1856 Finding architectures usin

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. The link I posted indicated that independent feature is merged since 3.12. Better to avoid deprecated stuff when introducing new cmake lines even though some existing lines may rely on deprecated cmake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. 3.18 introduces CMAKE_CUDA_ARCHITECTURES. Does 3.18 supports detection? If we know a new way works since 3.18, I think putting both with if-else makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315402 , @ye-luo wrote: > The link I posted indicated that independent feature is merged since 3.12. > Better to avoid deprecated stuff when introducing new cmake lines even though > some existing lines may still rely

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. I just realized that this patch affects clang and libomptarget. I cannot comment on clang. Regarding libomptarget, Could you explain why the detection is not put together with other cuda stuff in `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake` Repo

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

scott.linder updated this revision to Diff 296558. scott.linder added a comment. Don't hardcode x86_64-specific offsets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754 Files: clang/test/CodeGen/debug-info

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315451 , @ye-luo wrote: > I just realized that this patch affects clang and libomptarget. > I cannot comment on clang. Regarding libomptarget, Could you explain why the > detection is not put together with other cuda st

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315513 , @jhuber6 wrote: > In D88929#2315451 , @ye-luo wrote: > >> I just realized that this patch affects clang and libomptarget. >> I cannot comment on clang. Regarding libomptar

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added a comment. In D88929#2315519 , @ye-luo wrote: > Probably not messing with `enable_language(CUDA)` at the moment, just add > `cuda_select_nvcc_arch_flags(CUDA_ARCH_FLAGS)` to > `openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315538 , @jhuber6 wrote: > In D88929#2315519 , @ye-luo wrote: > >> Probably not messing with `enable_language(CUDA)` at the moment, just add >> `cuda_select_nvcc_arch_flags(CUDA_A

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1169 +createBranchRegion(S->getCond(), BodyCount, + subtractCounters(CondCount, BodyCount)); } If `theWhileStmt->getCond()` is-a BinaryOperator, it would

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. aeubanks requested review of this revision. Move it as an EP callback (-O[123]) or in addSanitizersAtO0. This makes it not run in ThinLTO pre-link (like the other sanitizers), so don'

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

JonChesterfield added a comment. An alternative approach is to build the deviceRTL for multiple cuda versions and then pick whichever one is the best fit when compiling application code. That has advantages when building the deviceRTL libraries on a different machine to the one that intends to

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added a comment. In D88929#2315640 , @JonChesterfield wrote: > An alternative approach is to build the deviceRTL for multiple cuda versions > and then pick whichever one is the best fit when compiling application code. > That has advantages when

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

shafik added a comment. `ASTImporter` changes looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66782/new/ https://reviews.llvm.org/D66782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 updated this revision to Diff 296577. jhuber6 added a comment. Removing redundant call to `find_package`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 Files: clang/CMakeLists.txt openmp/libom

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo requested changes to this revision. ye-luo added inline comments. This revision now requires changes to proceed. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif()

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif() ye-luo wrote: > 1. Doesn't work right now. Missing comma ",${CMAKE_MATCH_1}"

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:92 foreach(sm ${nvptx_sm_list}) set(CUDA_ARCH ${CUDA_ARCH} -gencode arch=compute_${sm},code=sm_${sm}) endforeach() my point 2 refers to here CUDA_ARCH which g

[clang] 5a3f6bf - Reapply "[OpenMP][FIX] Verify compatible types for declare variant calls" D88384

Author: Johannes Doerfert Date: 2020-10-07T00:06:51-05:00 New Revision: 5a3f6bfe8a71b94728597aee12a4c36949d5f6af URL: https://github.com/llvm/llvm-project/commit/5a3f6bfe8a71b94728597aee12a4c36949d5f6af DIFF: https://github.com/llvm/llvm-project/commit/5a3f6bfe8a71b94728597aee12a4c36949d5f6af.d

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert abandoned this revision. jdoerfert added a comment. Changing the assume to a proper exit did the trick for the tests. I recommited D88384 with that minor modification. Apologies for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

ye-luo added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt:80 + else() +list(APPEND compute_capabilities ${CMAKE_MATCH_1}) + endif() jhuber6 wrote: > ye-luo wrote: > > 1. Doesn't work right now. Missing comma "

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2090 +CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + PhysRegOutputs.insert(GCCReg); +} Can we get rid of the count call above and just use

<    1   2