[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Very nice, thank you! A few nits about comments and asserts. Comment at: clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp:112 - // If there aren't any enu

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2299938 , @rsmith wrote: > We've hit a fairly subtle miscompile caused by this patch. > > glibc's setjmp.h looks like this (irrelevant parts removed): > > struct __jmp_buf_tag { /*...*/ }; > extern int __sigsetjmp(stru

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/543 Repository: rG LLVM G

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek added a comment. In D83296#2299062 , @nridge wrote: > What does this change mean for users of clang-format -- better formatting of > complicated (e.g. multi-line) macro invocations? In addition to what Sam said, this also attempts to be an improve

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added a comment. Being permissive about recognizing builtins when the expected signature requires a type that lookup can't find seems completely reasonable. We don't really want to force library functions to take the custom-typechecking path just because we want to infer an attribute

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 294901. hokein marked 2 inline comments as done. hokein added a comment. address comments: - reuse the RecoveryAST to control the early typo-correction; - uses the fixed result type for some operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:153 COMPATIBLE_LANGOPT(RecoveryASTType, 1, 0, "Preserve the type in recovery expressions") +COMPATIBLE_LANGOPT(CDependence, 1, 0, "Build dependent AST nodes in C for better error recovery") -

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:572 + // - backward: 2^(N-1) lines. + unsigned WordGain = 1U << Word.Text.size(); + // Line number for SM.translat

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:153 COMPATIBLE_LANGOPT(RecoveryASTType, 1, 0, "Preserve the type in recovery expressions") +COMPATIBLE_LANGOPT(CDependence, 1, 0, "Build dependent AST nodes in C for better error recovery")

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

Hi! This issue must be fixed by: https://reviews.llvm.org/rGf91b9c0f9858 Do you have recent changes from the trunk? Thanks, --Serge On Tue, Sep 29, 2020 at 4:22 AM Leonard Chan via Phabricator < revi...@reviews.llvm.org> wrote: > leonardchan added a comment. > > Hi! It looks like this is causi

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added a comment. In D87528#2299497 , @mibintc wrote: > In D87528#2297647 , @sepavloff wrote: > >> In D87528#2295015 , @mibintc wrote: >> >>> I tried using the 0924

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:153 COMPATIBLE_LANGOPT(RecoveryASTType, 1, 0, "Preserve the type in recovery expressions") +COMPATIBLE_LANGOPT(CDependence, 1, 0, "Build dependent AST nodes in C for better error recovery") -

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 294903. hokein marked an inline comment as done. hokein added a comment. add isDependenceAllowed function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files: clang

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas marked 3 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:2932 |-'void' - |-SimpleDeclarator Declarator - | |-'foo' - | `-ParametersAndQualifiers - | |-'(' OpenParen - | `-')' CloseParen

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas updated this revision to Diff 294905. eduucaldas marked an inline comment as done. eduucaldas added a comment. Improve comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88403/new/ https://reviews.llvm.org/D88403 Files: clang/inclu

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In preparation for making movin

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

Naghasan accepted this revision. Naghasan added a comment. This revision is now accepted and ready to land. Change make sense to me (same rational as CUDA or OpenCL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87282/new/ https://reviews.llvm.org

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:39 public: - /// If \p CompileCommandsDir has a value, compile_commands.json will be - /// loaded only from \p CompileCommandsDir. Otherwise, clangd will look - /// for compile_commands.js

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall updated this revision to Diff 294907. sammccall added a comment. Drop redundant 'opts' from member names of per-feature opts structs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88470/new/ https://reviews.llvm.org/D88470 Files: clang-

[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:128 const auto ValueFilter = [](const NamedDecl *D) { return isa(D); }; +const auto TypeFilter = [](const NamedDecl *D) { return !isa(D); }; why not using `isa(D)`? ===

[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Extend the TargetDecl API to fix the workaround in https://reviews.llvm.or

[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:112 + /// Underlying declarations for renaming alias (typedef decl, type alias decl) + AliasUnderlying, + /// Underlying declarations for non-renaming alias, decltype, etc. The pr

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 294924. ArcsinX added a comment. Fix possible UB at bitwise shift. WordGain => MaxDistance. Fix LineMin and LineMax values. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

kadircet added a comment. thanks! this mostly looks good, as discussed offline I believe having an infra that we can improve over time is better than not having anything until we've got the "perfect" solution. i just got a couple of questions about some pieces, and some nits. ===

[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

sammccall added a comment. We manage to get rid of a little code here, but we add complexity to an important API, and make... one test better and a few tests worse. I'd like to get rid of the wart in the code, but the tradeoff doesn't seem completely compelling... going to think about the API he

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

bader updated this revision to Diff 294931. bader added a comment. Applied Ronan's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87282/new/ https://reviews.llvm.org/D87282 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, baloghadamsoftware, xazax.hun. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a reviewer: Szelethus. Herald ad

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

ebevhan accepted this revision. ebevhan added a comment. This revision is now accepted and ready to land. LGTM, but @aaron.ballman should probably give his two cents as well for completion's sake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

steakhal added a comment. In D77062#2298663 , @ASDenysPetrov wrote: > @steakhal > You told that you suppose a potential fix. It would be nice, if you share the > patch to review. I mean, I already told you my suggestion, there was no concrete fix in my

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

aaron.ballman added a comment. While I agree that there's an issue here that needs to be solved, I don't think this patch will be merged as-is -- there are technical issues brought up by @alexfh that have not been addressed, and I share the opinion that we should extend existing suppression mec

[clang] 9263931 - [SYCL] Assume SYCL device functions are convergent

Author: Alexey Bader Date: 2020-09-29T15:23:50+03:00 New Revision: 9263931fcccdc99000c1de668bea330711333729 URL: https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729 DIFF: https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729.diff

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

This revision was automatically updated to reflect the committed changes. bader marked an inline comment as done. Closed by commit rG9263931fcccd: [SYCL] Assume SYCL device functions are convergent (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

grokos added inline comments. Comment at: openmp/libomptarget/include/Ident.h:48-51 +auto removePath = [](const std::string &path) { +std::size_t pos = path.rfind('/'); +return path.substr(pos + 1); +}; jhuber6 wrote: > This will probably

[PATCH] D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool

njames93 added a comment. Just a follow up on this point, dependencies are a little messed up here. Running any of the check-clang-extra<...> results in all clang-tools-extra targets being built. Not ideal if you just want to test a small change to one tools and potentially having to rebuild al

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

aaron.ballman updated this revision to Diff 294947. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/ https://reviews.llvm.org/D88445 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clan

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

aaron.ballman updated this revision to Diff 294951. aaron.ballman added a comment. Missed a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/ https://reviews.llvm.org/D88445 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Basic/Diagnos

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo updated this revision to Diff 294959. tdeo added a comment. - Improve comments - In apply(), assert on the conditions we established in prepare() instead of proceeding. - Remove redundant tests and add new ones for value-dependent and GNU range cases. CHANGES SINCE LAST ACTION https://r

[PATCH] D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool

whisperity added a comment. In D84176#2300488 , @njames93 wrote: > Is this an artefact of how `check-clang-tools` also depends on all > clang-tools-extra targets. Yes, this was not changed in this patch. Fixing that will require a lot more CMake magic w

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo marked 10 inline comments as done. tdeo added a comment. Thanks for the review! Please land this if there are no more issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88434/new/ https://reviews.llvm.org/D88434 ___ cfe-commits mailin

[libunwind] f34ae1b - [AArch64] Add v8.5 Branch Target Identification support.

Author: Daniel Kiss Date: 2020-09-29T15:51:01+02:00 New Revision: f34ae1b9de68152de037fd3e394d196b997c4296 URL: https://github.com/llvm/llvm-project/commit/f34ae1b9de68152de037fd3e394d196b997c4296 DIFF: https://github.com/llvm/llvm-project/commit/f34ae1b9de68152de037fd3e394d196b997c4296.diff L

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

sammccall accepted this revision. sammccall added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88434/new/ https://reviews.llvm.org/D88434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl &Arg) dblaikie wrote: > BRevzin wrote: > > dblaikie wrote: > > > What tripped over/required this SFINAE? >

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

martong added a comment. > In this example, it cast to the `unsigned char` (which is the type of the > stored value of `**b`, stored at `#1`) instead of the static type of the > access (the type of `**b` is `char`at `#2`). Possible typo in the summary. At `#2` the type should be `char *` shoul

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. I'm going to land this as-is, based on Bevin's LGTM and my own confidence that the 10 lines I added are correct (enough). @aaron.ballman , please reopen this review if you have additional comments or concerns. Thanks. Repository: rG LLVM Github Monorepo

[clang] d9ee935 - [Sema] Address-space sensitive check for unbounded arrays (v2)

Author: Chris Hamilton Date: 2020-09-29T16:14:48+02:00 New Revision: d9ee935679e7164d1c47e351bbbcf5c25742b59c URL: https://github.com/llvm/llvm-project/commit/d9ee935679e7164d1c47e351bbbcf5c25742b59c DIFF: https://github.com/llvm/llvm-project/commit/d9ee935679e7164d1c47e351bbbcf5c25742b59c.diff

[PATCH] D78938: Make LLVM build in C++20 mode

lebedev.ri added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171 - -inline bool operator!=(const DWARFExpression::iterator &LHS, - const DWARFExpression::iterator &RHS) { - return !(LHS == RHS); -} B

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9ee935679e7: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D78938: Make LLVM build in C++20 mode

BRevzin added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171 - -inline bool operator!=(const DWARFExpression::iterator &LHS, - const DWARFExpression::iterator &RHS) { - return !(LHS == RHS); -} lebe

[PATCH] D88260: [NFC][FE] Replace TypeSize with StorageUnitSize

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1749-1750 -// Otherwise, allocate just the number of bytes required to store -// the bitfield. + //

[PATCH] D88489: [clangd] Mark code action as "preferred" if it's the sole quickfix action

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo ht

[clang-tools-extra] 4fb303f - [clangd] Improve PopulateSwitch tweak to work on non-empty switches

Author: Tadeo Kondrak Date: 2020-09-29T16:37:51+02:00 New Revision: 4fb303f340e2c55783f9b0f3ed33fa2c36360acf URL: https://github.com/llvm/llvm-project/commit/4fb303f340e2c55783f9b0f3ed33fa2c36360acf DIFF: https://github.com/llvm/llvm-project/commit/4fb303f340e2c55783f9b0f3ed33fa2c36360acf.diff

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fb303f340e2: [clangd] Improve PopulateSwitch tweak to work on non-empty switches (authored by tdeo, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert created this revision. jdoerfert added a reviewer: aaron.ballman. Herald added a subscriber: bollu. Herald added a project: clang. jdoerfert requested review of this revision. Add and pass AllowCXX not only in mergeFunctionTypes but all merge*Type methods. Use it to determine if referenc

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

ayrivera added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", &os)) aganea wrote: > ayrivera wrote: > > MaskRay

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 295000. ellis added a comment. [objc] Fix memory leak in CGObjCMac.cpp CGObjCMac.cpp was leaking a MangleContext everytime it mangled an ObjC method. We now have an instance variable that allocates and deallocates the context. Repository: rG LLVM Github Mo

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. Oops, I meant to create a new commit rather than amend to this one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. MSAN build times out for generated DecisionF

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:164 +LLVM_NO_SANITIZE("memory") float Evaluate(const %s&); Please add a comment

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:61 + + return NeedsExtraBitToPreserveSigness ? Signed : ExtendedSigned; +} Should not the `ExtendedSigned` be in the true branch? Comment at:

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 updated this revision to Diff 295005. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88495/new/ https://reviews.llvm.org/D88495 Files: clang-tools-extra/clangd/quality/CompletionModelCodege

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis created this revision. ellis added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. ellis requested review of this revision. A memory leak was introduced in https://reviews.llvm.org/D88329 CGObjCMac.cpp was leaking a MangleContext everytime it man

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. https://reviews.llvm.org/D88497 will fix the leak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing list cfe-commits@

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl &Arg) dblaikie wrote: > Quuxplusone wrote: > > BRevzin wrote: > > > dblaikie wrote: > > > > BRevzin wrote:

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9f63d22fafb: [clangd] Disable msan instrumentation for generated Evaluate(). (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88495/ne

[clang-tools-extra] a9f63d2 - [clangd] Disable msan instrumentation for generated Evaluate().

Author: Utkarsh Saxena Date: 2020-09-29T17:44:10+02:00 New Revision: a9f63d22fafb0d7de768efc6b7447f8e7f6bb220 URL: https://github.com/llvm/llvm-project/commit/a9f63d22fafb0d7de768efc6b7447f8e7f6bb220 DIFF: https://github.com/llvm/llvm-project/commit/a9f63d22fafb0d7de768efc6b7447f8e7f6bb220.diff

[clang] 1192747 - NFC, add a missing stdlib include for the use of abort

Author: Alex Lorenz Date: 2020-09-29T08:50:51-07:00 New Revision: 119274748bce6d1248aa57cb55d79bfeae8a2f8e URL: https://github.com/llvm/llvm-project/commit/119274748bce6d1248aa57cb55d79bfeae8a2f8e DIFF: https://github.com/llvm/llvm-project/commit/119274748bce6d1248aa57cb55d79bfeae8a2f8e.diff L

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc. Herald added a project: clang. sepavloff requested review of this revision. Previously initializers were evaluated using rounding mode currently specified by Sema. If at the same time FP exception behavior was s

[PATCH] D88462: FP math settings for static duration initialization - work in progress

sepavloff added a comment. Please look at D88498 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88462/new/ https://reviews.llvm.org/D88462 ___ cfe-commits mailing list c

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

steakhal added a comment. In D88477#2300687 , @martong wrote: >> In this example, it cast to the `unsigned char` (which is the type of the >> stored value of `**b`, stored at `#1`) instead of the static type of the >> access (the type of `**b` is `char`

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + getLangOpts().CPlusPlus17 || getLangOpts().C2x) { +MustProgress = true; Also in C? And C2x in t

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

steakhal added a comment. Thank you for your time @balazske! Your catches were really valuable. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:61 + + return NeedsExtraBitToPreserveSigness ? Signed : ExtendedSigned; +} balazske wrote: > S

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88498/new/ https://reviews.llvm.org/D88498 ___

[PATCH] D88462: FP math settings for static duration initialization - work in progress

mibintc abandoned this revision. mibintc added a comment. refer to https://reviews.llvm.org/D88498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88462/new/ https://reviews.llvm.org/D88462 ___ cfe-commits

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, DiggerLin. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since libc++ has dependencies on libm. Repository: rG LLVM Github Monorepo https://re

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, oops, I should've caught this in review. I assume you still need a commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ htt

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis added a comment. Yes please commit for me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#2274568 , @balazske wrote: > I am not sure if this checker is worth to further development. A part of the > found bugs can be detected with other checkers too, specially if the > preconditions of many standard functio

[PATCH] D88265: Fix comma with half vectors.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/test/Sema/fp16vec-sema.c:29 sv0 = hv0 >= hv1; + hv0, 1; // expected-warning 2 {{expression result unused}} sv0 = hv0 || hv1; // expected-error{{logical expression with vector types 'h

[clang-tools-extra] d8ba6b4 - [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

Author: Aleksandr Platonov Date: 2020-09-29T19:54:55+03:00 New Revision: d8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe URL: https://github.com/llvm/llvm-project/commit/d8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe DIFF: https://github.com/llvm/llvm-project/commit/d8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe.

[PATCH] D88265: Fix comma with half vectors.

arames updated this revision to Diff 295025. arames marked an inline comment as done. arames added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88265/new/ https://reviews.llvm.org/D88265 Files: clang/lib/Se

Re: [PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

Thanks for looking into it. We have that commit but it still seems to be failing for us with the same error. On Tue, Sep 29, 2020 at 12:58 AM Serge Pavlov wrote: > Hi! > > This issue must be fixed by: https://reviews.llvm.org/rGf91b9c0f9858 > Do you have recent changes from the trunk? > > Thanks

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

rjmccall added a comment. Commented in that review, but that patch has the wrong fix: it's based on the targets LLVM is configured with rather than the current test target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.l

[PATCH] D88498: [FPEnv] Evaluate initializers in constant rounding mode

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Parse/ParseDecl.cpp:2290 + // rounding mode. + if (VD->isFileVarDecl() || VD->isConstexpr() || + (!getLangO

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a comment. Richard and I had a long conversation about this further up-thread, if you missed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/new/ https://reviews.llvm.org/D87528 ___ cfe-commits mailing list cfe-commits

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX closed this revision. ArcsinX added a comment. Don't know why this didn't close automatically Commit: https://reviews.llvm.org/rGd8ba6b4ab3eceb6bbcdf4371d4ffaab9d1a5cebe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://revie

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295032. jhuber6 added a reviewer: erichkeane. jhuber6 added a comment. Adding test cases for incompatible architecture messages. Checking the architecture is done by checking all combinations of architectures. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

erichkeane resigned from this revision. erichkeane added a comment. I'm not really a good person to review this, OMP isn't nearly my expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 __

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff added a comment. In D87822#2301194 , @leonardchan wrote: > Thanks for looking into it. We have that commit but it still seems to be > failing for us with the same error. In D88498 this test is removed because us

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

This revision was automatically updated to reflect the committed changes. Closed by commit rG3681be876fea: Add -fprofile-update={atomic,prefer-atomic,single} (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D87737?vs=294781&id=295042#toc Repository: rG LLVM Github Mon

[clang] 3681be8 - Add -fprofile-update={atomic,prefer-atomic,single}

Author: Fangrui Song Date: 2020-09-29T10:43:23-07:00 New Revision: 3681be876fea9b270c7a1d2dc41679a399610e06 URL: https://github.com/llvm/llvm-project/commit/3681be876fea9b270c7a1d2dc41679a399610e06 DIFF: https://github.com/llvm/llvm-project/commit/3681be876fea9b270c7a1d2dc41679a399610e06.diff

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:929 - /// \param[out] NameOut - The return value. - void GetNameForMethod(const ObjCMethodDecl *OMD, -const ObjCContainerDecl *CD, Note that the removed method is

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas updated this revision to Diff 295053. eduucaldas added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88403/new/ https://reviews.llvm.org/D88403 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tool

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

ellis updated this revision to Diff 295055. ellis added a subscriber: vsapsai. ellis added a comment. Herald added a reviewer: JDevlieghere. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix a comment to reference the correct method. Thanks to @vsapsai for pointing this o

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88445/new/ https://reviews.llvm.org/D88445 ___ cfe-commits mailing list cfe-commits@

[PATCH] D77598: Integral template argument suffix and cast printing

rnk added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rsmith wrote: > reikdas wrote: > > rsmith wr

[PATCH] D88507: [clangd][remote] Make sure relative paths are absolute with respect to posix style

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Relative paths received from the server are

[clang-tools-extra] 962a247 - [clangd] Fix assertion in remote-index marshalling

Author: Kadir Cetinkaya Date: 2020-09-29T20:40:19+02:00 New Revision: 962a247aebba39bc8f2d6aa901ed512f5c09dc72 URL: https://github.com/llvm/llvm-project/commit/962a247aebba39bc8f2d6aa901ed512f5c09dc72 DIFF: https://github.com/llvm/llvm-project/commit/962a247aebba39bc8f2d6aa901ed512f5c09dc72.dif

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

JDevlieghere added a comment. Thanks for updating the comment in dsymutil! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list cfe-commit

[PATCH] D88500: [AIX][Clang][Driver] Link libm along with libc++

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:165 +// Since libc++ has dependencies on libm, if we have one then add the other. +if (getToolChain().ShouldLinkCXXStdlib(Args)) Is that right? My check of t

[clang] 15fbae8 - Use "default member initializer" instead of "in-class initializer" for diagnostics.

Author: Aaron Ballman Date: 2020-09-29T15:04:23-04:00 New Revision: 15fbae8ac303d8601ea95418d4818cb50d0765e1 URL: https://github.com/llvm/llvm-project/commit/15fbae8ac303d8601ea95418d4818cb50d0765e1 DIFF: https://github.com/llvm/llvm-project/commit/15fbae8ac303d8601ea95418d4818cb50d0765e1.diff

  1   2   >